appsignal 3.4.16-java → 3.5.1-java

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9f4bbbebf35d65f97a75c99730464bb19e90387b1c84558c2d2bcaa195d15986
-  data.tar.gz: 9e88ecb0449d0ce64b0e9bbe325834542f08016f31519005a65f077dd34c7979
+  metadata.gz: fe4aa04040848caadc77c47f984ee7969f08a5c36a5bd598e89e5807cb48124e
+  data.tar.gz: b3155c076dc8f322907d1c1d6dc49a7a8b03824272f0d7fb878d5b230fa3a25b
 SHA512:
-  metadata.gz: 296a3681f8ad3d2eddb404e90448afe88d9dc71825f0aa66ad2f5de0418bca9500020ccf8199489a3aee87d935fc54c7cc29d3cc869dcce16bd1d3ffcbb795df
-  data.tar.gz: 84f42f07b0ca6611326d8f3fd868221432bd81323837d2586be7b4245559ec94881275a3cf2c4b6899881098bffca72e1a82974bdc8b8e7448b4e04b71fbc781
+  metadata.gz: 7dd1e584fc1caa6a77d719186321a27e576d57d2f534db938a7e9157a520345f58054860ad0095381c4c41710e6d709bf587a1d9685398c81b82cff0255e82e9
+  data.tar.gz: 46b9a9f88c2e8d121ad43f403f41a56712e38f624e75ca899185c76a8244b970bee16637ed59b4b7b0441c0417138a08578db8c0eca3ac1b5e1e65d336b9a499

data/CHANGELOG.md

@@ -1,5 +1,18 @@
 # AppSignal for Ruby gem Changelog
 
+## 3.5.1
+
+### Fixed
+
+- [2e93182b](https://github.com/appsignal/appsignal-ruby/commit/2e93182b6ae83b16fe9885558cd8f0bfce6a9a5f) patch - Fix an error in the diagnose report when reading a file's contents results in an "Invalid seek" error. This could happen when the log path is configured to `/dev/stdout`, which is not supported.
+- [ae0b779b](https://github.com/appsignal/appsignal-ruby/commit/ae0b779b3ec00cc46291bc0373d748d720231e74) patch - Fix logger compatibility with Ruby 3.3
+
+## 3.5.0
+
+### Added
+
+- [cee1676f](https://github.com/appsignal/appsignal-ruby/commit/cee1676fc5539e380c58e8a824b5c59c3c927119) minor - Nested errors are now supported. The error causes are stored as sample data on the transaction so they can be displayed in the UI.
+
 ## 3.4.16
 
 ### Changed

data/lib/appsignal/cli/diagnose/paths.rb

@@ -71,10 +71,14 @@ module Appsignal
               :group => Utils.group_for_gid(path_gid)
             }
             if info[:type] == "file"
-              info[:content] = Utils.read_file_content(
-                path,
-                BYTES_TO_READ_FOR_FILES
-              ).split("\n")
+              begin
+                info[:content] = Utils.read_file_content(
+                  path,
+                  BYTES_TO_READ_FOR_FILES
+                ).split("\n")
+              rescue => error
+                info[:read_error] = "#{error.class}: #{error.message}"
+              end
             end
           end
         end

data/lib/appsignal/cli/diagnose.rb

@@ -631,6 +631,11 @@ module Appsignal
           else
             print_empty_line
           end
+
+          return unless path.key?(:read_error)
+
+          puts "    Read error: #{path[:read_error]}"
+          print_empty_line
         end
 
         def print_empty_line

data/lib/appsignal/logger.rb

@@ -25,6 +25,8 @@ module Appsignal
     def initialize(group, level: INFO, format: PLAINTEXT)
       raise TypeError, "group must be a string" unless group.is_a? String
 
+      super(group, :level => level)
+
       @group = group
       @level = level
       @format = format

data/lib/appsignal/transaction.rb

@@ -12,6 +12,7 @@ module Appsignal
     ALLOWED_TAG_KEY_TYPES = [Symbol, String].freeze
     ALLOWED_TAG_VALUE_TYPES = [Symbol, String, Integer].freeze
     BREADCRUMB_LIMIT = 20
+    ERROR_CAUSES_LIMIT = 10
 
     class << self
       def create(id, namespace, request, options = {})
@@ -374,6 +375,41 @@ module Appsignal
         cleaned_error_message(error),
         backtrace ? Appsignal::Utils::Data.generate(backtrace) : Appsignal::Extension.data_array_new
       )
+
+      root_cause_missing = false
+
+      causes = []
+      while error
+        error = error.cause
+
+        break unless error
+
+        if causes.length >= ERROR_CAUSES_LIMIT
+          Appsignal.logger.debug "Appsignal::Transaction#set_error: Error has more " \
+            "than #{ERROR_CAUSES_LIMIT} error causes. Only the first #{ERROR_CAUSES_LIMIT} " \
+            "will be reported."
+          root_cause_missing = true
+          break
+        end
+
+        causes << error
+      end
+
+      return if causes.empty?
+
+      causes_sample_data = causes.map do |e|
+        {
+          :name => e.class.name,
+          :message => cleaned_error_message(e)
+        }
+      end
+
+      causes_sample_data.last[:is_root_cause] = false if root_cause_missing
+
+      set_sample_data(
+        "error_causes",
+        causes_sample_data
+      )
     end
     alias_method :add_exception, :set_error
 

data/lib/appsignal/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Appsignal
-  VERSION = "3.4.16"
+  VERSION = "3.5.1"
 end

data/spec/lib/appsignal/cli/diagnose/utils_spec.rb

@@ -71,5 +71,16 @@ describe Appsignal::CLI::Diagnose::Utils do
         is_expected.to eq(file_contents)
       end
     end
+
+    context "when reading the file raises an illegal seek error" do
+      let(:file_contents) { "line 1\n" }
+      before do
+        expect(File).to receive(:binread).and_raise(Errno::ESPIPE)
+      end
+
+      it "returns the error as the content" do
+        expect { subject }.to raise_error(Errno::ESPIPE)
+      end
+    end
   end
 end

data/spec/lib/appsignal/cli/diagnose_spec.rb

@@ -1424,6 +1424,26 @@ describe Appsignal::CLI::Diagnose, :api_stub => true, :send_report => :yes_cli_i
             )
           end
         end
+
+        context "when reading the file returns a illegal seek error" do
+          before do
+            File.write(file_path, "Some content")
+            allow(File).to receive(:binread).and_call_original
+            expect(File).to receive(:binread).with(file_path, anything,
+              anything).and_raise(Errno::ESPIPE)
+            run
+          end
+
+          it "outputs file does not exists" do
+            expect(output).to include %(Read error: Errno::ESPIPE: Illegal seek)
+          end
+
+          it "transmits file data in report" do
+            expect(received_report["paths"][filename]).to include(
+              "read_error" => "Errno::ESPIPE: Illegal seek"
+            )
+          end
+        end
       end
 
       describe "mkmf.log" do

data/spec/lib/appsignal/transaction_spec.rb

@@ -788,6 +788,99 @@ describe Appsignal::Transaction do
         end
       end
 
+      context "when the error has no causes" do
+        it "should not send the causes information as sample data" do
+          expect(transaction.ext).to_not receive(:set_sample_data)
+
+          transaction.set_error(error)
+        end
+      end
+
+      context "when the error has multiple causes" do
+        let(:error) do
+          e = ExampleStandardError.new("test message")
+          e2 = RuntimeError.new("cause message")
+          e3 = StandardError.new("cause message 2")
+          allow(e).to receive(:backtrace).and_return(["line 1"])
+          allow(e).to receive(:cause).and_return(e2)
+          allow(e2).to receive(:cause).and_return(e3)
+          e
+        end
+
+        it "sends the causes information as sample data" do
+          expect(transaction.ext).to receive(:set_error).with(
+            "ExampleStandardError",
+            "test message",
+            Appsignal::Utils::Data.generate(["line 1"])
+          )
+
+          expect(transaction.ext).to receive(:set_sample_data).with(
+            "error_causes",
+            Appsignal::Utils::Data.generate(
+              [
+                {
+                  :name => "RuntimeError",
+                  :message => "cause message"
+                },
+                {
+                  :name => "StandardError",
+                  :message => "cause message 2"
+                }
+              ]
+            )
+          )
+
+          expect(Appsignal.logger).to_not receive(:debug)
+
+          transaction.set_error(error)
+        end
+      end
+
+      context "when the error has too many causes" do
+        let(:error) do
+          e = ExampleStandardError.new("root cause error")
+
+          11.times do |i|
+            next_e = ExampleStandardError.new("wrapper error #{i}")
+            allow(next_e).to receive(:cause).and_return(e)
+            e = next_e
+          end
+
+          allow(e).to receive(:backtrace).and_return(["line 1"])
+          e
+        end
+
+        it "sends only the first causes as sample data" do
+          expect(transaction.ext).to receive(:set_error).with(
+            "ExampleStandardError",
+            "wrapper error 10",
+            Appsignal::Utils::Data.generate(["line 1"])
+          )
+
+          expected_error_causes = Array.new(10) do |i|
+            {
+              :name => "ExampleStandardError",
+              :message => "wrapper error #{9 - i}"
+            }
+          end
+
+          expected_error_causes.last[:is_root_cause] = false
+
+          expect(transaction.ext).to receive(:set_sample_data).with(
+            "error_causes",
+            Appsignal::Utils::Data.generate(expected_error_causes)
+          )
+
+          expect(Appsignal.logger).to receive(:debug).with(
+            "Appsignal::Transaction#set_error: Error has more " \
+              "than 10 error causes. Only the first 10 " \
+              "will be reported."
+          )
+
+          transaction.set_error(error)
+        end
+      end
+
       context "when error message is nil" do
         let(:error) do
           e = ExampleStandardError.new

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appsignal
 version: !ruby/object:Gem::Version
-  version: 3.4.16
+  version: 3.5.1
 platform: java
 authors:
 - Robert Beekman
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-12-01 00:00:00.000000000 Z
+date: 2023-12-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -460,7 +460,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.4.11
 signing_key:
 specification_version: 4
 summary: Logs performance and exception data from your app to appsignal.com