appsignal 3.4.0 → 3.4.1

data/spec/lib/appsignal/cli/install_spec.rb

@@ -99,7 +99,7 @@ describe Appsignal::CLI::Install do
 
   shared_examples "push_api_key validation" do
     context "without key" do
-      let(:push_api_key) {}
+      let(:push_api_key) { nil }
 
       it "does not install" do
         run
@@ -178,7 +178,7 @@ describe Appsignal::CLI::Install do
 
     context "with Capfile" do
       context "when already installed" do
-        before { File.open(capfile, "w") { |f| f.write("require 'appsignal/capistrano'") } }
+        before { File.write(capfile, "require 'appsignal/capistrano'") }
 
         it "does not add another require to Capfile" do
           run
@@ -432,9 +432,7 @@ describe Appsignal::CLI::Install do
 
       context "when failed to load the Rails application.rb file" do
         before do
-          File.open(File.join(config_dir, "application.rb"), "w") do |file|
-            file.write("I am invalid code")
-          end
+          File.write(File.join(config_dir, "application.rb"), "I am invalid code")
         end
 
         it "prompts the user to fill in an app name" do
@@ -726,7 +724,8 @@ describe Appsignal::CLI::Install do
     end
   end
 
-  if !rails_present? && !sinatra_present? && !padrino_present? && !grape_present? && !hanami2_present?
+  if !rails_present? && !sinatra_present? && !padrino_present? && !grape_present? &&
+      !hanami2_present?
     context "with unknown framework" do
       let(:push_api_key) { "my_key" }
 

data/spec/lib/appsignal/cli_spec.rb

@@ -40,7 +40,7 @@ describe Appsignal::CLI do
       end
     end.to raise_error(SystemExit)
 
-    expect(output).to include "Command 'nonsense' does not exist, run "\
+    expect(output).to include "Command 'nonsense' does not exist, run " \
       "appsignal -h to see the help"
   end
 

data/spec/lib/appsignal/config_spec.rb

@@ -162,6 +162,7 @@ describe Appsignal::Config do
         :enable_minutely_probes         => true,
         :enable_statsd                  => true,
         :enable_nginx_metrics           => false,
+        :enable_rails_error_reporter    => true,
         :endpoint                       => "https://push.appsignal.com",
         :files_world_accessible         => true,
         :filter_parameters              => [],
@@ -263,7 +264,8 @@ describe Appsignal::Config do
 
     context "with an overriden config file" do
       let(:config) do
-        project_fixture_config("production", {}, Appsignal.logger, File.join(project_fixture_path, "config", "appsignal.yml"))
+        project_fixture_config("production", {}, Appsignal.logger,
+          File.join(project_fixture_path, "config", "appsignal.yml"))
       end
 
       it "is valid and active" do
@@ -273,7 +275,8 @@ describe Appsignal::Config do
 
       context "with an invalid overriden config file" do
         let(:config) do
-          project_fixture_config("production", {}, Appsignal.logger, File.join(project_fixture_path, "config", "missing.yml"))
+          project_fixture_config("production", {}, Appsignal.logger,
+            File.join(project_fixture_path, "config", "missing.yml"))
         end
 
         it "is not valid" do
@@ -612,36 +615,39 @@ describe Appsignal::Config do
     end
 
     it "writes the current config to environment variables" do
-      expect(ENV["_APPSIGNAL_ACTIVE"]).to                       eq "true"
-      expect(ENV["_APPSIGNAL_APP_PATH"]).to                     end_with("spec/support/fixtures/projects/valid")
-      expect(ENV["_APPSIGNAL_AGENT_PATH"]).to                   end_with("/ext")
-      expect(ENV["_APPSIGNAL_DEBUG_LOGGING"]).to                eq "false"
-      expect(ENV["_APPSIGNAL_LOG"]).to                          eq "stdout"
-      expect(ENV["_APPSIGNAL_LOG_FILE_PATH"]).to                end_with("/tmp/appsignal.log")
-      expect(ENV["_APPSIGNAL_LOGGING_ENDPOINT"]).to             eq "http://localhost:123"
-      expect(ENV["_APPSIGNAL_PUSH_API_ENDPOINT"]).to            eq "https://push.appsignal.com"
-      expect(ENV["_APPSIGNAL_PUSH_API_KEY"]).to                 eq "abc"
-      expect(ENV["_APPSIGNAL_APP_NAME"]).to                     eq "TestApp"
-      expect(ENV["_APPSIGNAL_ENVIRONMENT"]).to                  eq "production"
-      expect(ENV["_APPSIGNAL_LANGUAGE_INTEGRATION_VERSION"]).to eq "ruby-#{Appsignal::VERSION}"
-      expect(ENV["_APPSIGNAL_HTTP_PROXY"]).to                   eq "http://localhost"
-      expect(ENV["_APPSIGNAL_IGNORE_ACTIONS"]).to               eq "action1,action2"
-      expect(ENV["_APPSIGNAL_IGNORE_ERRORS"]).to                eq "ExampleStandardError,AnotherError"
-      expect(ENV["_APPSIGNAL_IGNORE_NAMESPACES"]).to            eq "admin,private_namespace"
-      expect(ENV["_APPSIGNAL_RUNNING_IN_CONTAINER"]).to         eq "false"
-      expect(ENV["_APPSIGNAL_ENABLE_HOST_METRICS"]).to          eq "true"
-      expect(ENV["_APPSIGNAL_HOSTNAME"]).to                     eq ""
-      expect(ENV["_APPSIGNAL_PROCESS_NAME"]).to                 include "rspec"
-      expect(ENV["_APPSIGNAL_CA_FILE_PATH"]).to                 eq File.join(resources_dir, "cacert.pem")
-      expect(ENV["_APPSIGNAL_DNS_SERVERS"]).to                  eq "8.8.8.8,8.8.4.4"
-      expect(ENV["_APPSIGNAL_FILES_WORLD_ACCESSIBLE"]).to       eq "true"
-      expect(ENV["_APPSIGNAL_TRANSACTION_DEBUG_MODE"]).to       eq "true"
-      expect(ENV["_APPSIGNAL_SEND_ENVIRONMENT_METADATA"]).to    eq "false"
-      expect(ENV["_APPSIGNAL_FILTER_PARAMETERS"]).to            eq "password,confirm_password"
-      expect(ENV["_APPSIGNAL_FILTER_SESSION_DATA"]).to          eq "key1,key2"
-      expect(ENV["_APP_REVISION"]).to                           eq "v2.5.1"
-      expect(ENV).to_not                                        have_key("_APPSIGNAL_WORKING_DIR_PATH")
-      expect(ENV).to_not                                        have_key("_APPSIGNAL_WORKING_DIRECTORY_PATH")
+      expect(ENV.fetch("_APPSIGNAL_ACTIVE", nil)).to eq "true"
+      expect(ENV.fetch("_APPSIGNAL_APP_PATH", nil))
+        .to end_with("spec/support/fixtures/projects/valid")
+      expect(ENV.fetch("_APPSIGNAL_AGENT_PATH", nil)).to end_with("/ext")
+      expect(ENV.fetch("_APPSIGNAL_DEBUG_LOGGING", nil)).to eq "false"
+      expect(ENV.fetch("_APPSIGNAL_LOG", nil)).to eq "stdout"
+      expect(ENV.fetch("_APPSIGNAL_LOG_FILE_PATH", nil)).to end_with("/tmp/appsignal.log")
+      expect(ENV.fetch("_APPSIGNAL_LOGGING_ENDPOINT", nil)).to eq "http://localhost:123"
+      expect(ENV.fetch("_APPSIGNAL_PUSH_API_ENDPOINT", nil)).to eq "https://push.appsignal.com"
+      expect(ENV.fetch("_APPSIGNAL_PUSH_API_KEY", nil)).to eq "abc"
+      expect(ENV.fetch("_APPSIGNAL_APP_NAME", nil)).to eq "TestApp"
+      expect(ENV.fetch("_APPSIGNAL_ENVIRONMENT", nil)).to eq "production"
+      expect(ENV.fetch("_APPSIGNAL_LANGUAGE_INTEGRATION_VERSION", nil))
+        .to eq "ruby-#{Appsignal::VERSION}"
+      expect(ENV.fetch("_APPSIGNAL_HTTP_PROXY", nil)).to eq "http://localhost"
+      expect(ENV.fetch("_APPSIGNAL_IGNORE_ACTIONS", nil)).to eq "action1,action2"
+      expect(ENV.fetch("_APPSIGNAL_IGNORE_ERRORS", nil)).to eq "ExampleStandardError,AnotherError"
+      expect(ENV.fetch("_APPSIGNAL_IGNORE_NAMESPACES", nil)).to eq "admin,private_namespace"
+      expect(ENV.fetch("_APPSIGNAL_RUNNING_IN_CONTAINER", nil)).to eq "false"
+      expect(ENV.fetch("_APPSIGNAL_ENABLE_HOST_METRICS", nil)).to eq "true"
+      expect(ENV.fetch("_APPSIGNAL_HOSTNAME", nil)).to eq ""
+      expect(ENV.fetch("_APPSIGNAL_PROCESS_NAME", nil)).to include "rspec"
+      expect(ENV.fetch("_APPSIGNAL_CA_FILE_PATH", nil))
+        .to eq File.join(resources_dir, "cacert.pem")
+      expect(ENV.fetch("_APPSIGNAL_DNS_SERVERS", nil)).to eq "8.8.8.8,8.8.4.4"
+      expect(ENV.fetch("_APPSIGNAL_FILES_WORLD_ACCESSIBLE", nil)).to eq "true"
+      expect(ENV.fetch("_APPSIGNAL_TRANSACTION_DEBUG_MODE", nil)).to eq "true"
+      expect(ENV.fetch("_APPSIGNAL_SEND_ENVIRONMENT_METADATA", nil)).to eq "false"
+      expect(ENV.fetch("_APPSIGNAL_FILTER_PARAMETERS", nil)).to eq "password,confirm_password"
+      expect(ENV.fetch("_APPSIGNAL_FILTER_SESSION_DATA", nil)).to eq "key1,key2"
+      expect(ENV.fetch("_APP_REVISION", nil)).to eq "v2.5.1"
+      expect(ENV).to_not have_key("_APPSIGNAL_WORKING_DIR_PATH")
+      expect(ENV).to_not have_key("_APPSIGNAL_WORKING_DIRECTORY_PATH")
     end
 
     context "with :hostname" do
@@ -651,7 +657,7 @@ describe Appsignal::Config do
       end
 
       it "sets the modified :hostname" do
-        expect(ENV["_APPSIGNAL_HOSTNAME"]).to eq "Alices-MBP.example.com"
+        expect(ENV.fetch("_APPSIGNAL_HOSTNAME", nil)).to eq "Alices-MBP.example.com"
       end
     end
 
@@ -662,7 +668,7 @@ describe Appsignal::Config do
       end
 
       it "sets the modified :working_dir_path" do
-        expect(ENV["_APPSIGNAL_WORKING_DIR_PATH"]).to eq "/tmp/appsignal2"
+        expect(ENV.fetch("_APPSIGNAL_WORKING_DIR_PATH", nil)).to eq "/tmp/appsignal2"
       end
     end
 
@@ -673,7 +679,7 @@ describe Appsignal::Config do
       end
 
       it "sets the modified :working_directory_path" do
-        expect(ENV["_APPSIGNAL_WORKING_DIRECTORY_PATH"]).to eq "/tmp/appsignal2"
+        expect(ENV.fetch("_APPSIGNAL_WORKING_DIRECTORY_PATH", nil)).to eq "/tmp/appsignal2"
       end
     end
   end
@@ -713,7 +719,7 @@ describe Appsignal::Config do
 
         it "prints a warning" do
           subject
-          expect(output).to include "appsignal: Unable to log to '#{log_path}'. "\
+          expect(output).to include "appsignal: Unable to log to '#{log_path}'. " \
             "Logging to '#{system_tmp_dir}' instead."
         end
       end
@@ -727,7 +733,7 @@ describe Appsignal::Config do
 
         it "prints a warning" do
           subject
-          expect(output).to include "appsignal: Unable to log to '#{log_path}' "\
+          expect(output).to include "appsignal: Unable to log to '#{log_path}' " \
             "or the '#{system_tmp_dir}' fallback."
         end
       end

data/spec/lib/appsignal/event_formatter/action_view/render_formatter_spec.rb

@@ -9,8 +9,10 @@ describe Appsignal::EventFormatter::ActionView::RenderFormatter do
       before { allow(Rails.root).to receive(:to_s).and_return("/var/www/app/20130101") }
 
       it "registers render_partial.action_view and render_template.action_view" do
-        expect(Appsignal::EventFormatter.registered?("render_partial.action_view", klass)).to be_truthy
-        expect(Appsignal::EventFormatter.registered?("render_template.action_view", klass)).to be_truthy
+        expect(Appsignal::EventFormatter.registered?("render_partial.action_view",
+          klass)).to be_truthy
+        expect(Appsignal::EventFormatter.registered?("render_template.action_view",
+          klass)).to be_truthy
       end
 
       describe "#root_path" do
@@ -31,7 +33,9 @@ describe Appsignal::EventFormatter::ActionView::RenderFormatter do
         end
 
         context "with a frozen identifier" do
-          let(:payload) { { :identifier => "/var/www/app/20130101/app/views/home/index/html.erb".freeze } }
+          let(:payload) do
+            { :identifier => "/var/www/app/20130101/app/views/home/index/html.erb".freeze }
+          end
 
           it { is_expected.to eq ["app/views/home/index/html.erb", nil] }
         end
@@ -46,8 +50,10 @@ describe Appsignal::EventFormatter::ActionView::RenderFormatter do
   else
     context "when not in a Rails app" do
       it "does not register the event formatter" do
-        expect(Appsignal::EventFormatter.registered?("render_partial.action_view", klass)).to be_falsy
-        expect(Appsignal::EventFormatter.registered?("render_template.action_view", klass)).to be_falsy
+        expect(Appsignal::EventFormatter.registered?("render_partial.action_view",
+          klass)).to be_falsy
+        expect(Appsignal::EventFormatter.registered?("render_template.action_view",
+          klass)).to be_falsy
       end
     end
   end

data/spec/lib/appsignal/event_formatter/elastic_search/search_formatter_spec.rb

@@ -11,8 +11,8 @@ describe Appsignal::EventFormatter::ElasticSearch::SearchFormatter do
   describe "#format" do
     let(:payload) do
       {
-        :name   => "Search",
-        :klass  => "User",
+        :name => "Search",
+        :klass => "User",
         :search => { :index => "users", :type => "user", :q => "John Doe" }
       }
     end
@@ -29,8 +29,8 @@ describe Appsignal::EventFormatter::ElasticSearch::SearchFormatter do
     let(:search) do
       {
         :index => "users",
-        :type  => "user",
-        :q     => "John Doe",
+        :type => "user",
+        :q => "John Doe",
         :other => "Other"
       }
     end

data/spec/lib/appsignal/event_formatter/mongo_ruby_driver/query_formatter_spec.rb

@@ -5,7 +5,7 @@ describe Appsignal::EventFormatter::MongoRubyDriver::QueryFormatter do
     let(:strategy) { :find }
     let(:command) do
       {
-        "find"   => "users",
+        "find" => "users",
         "filter" => { "_id" => 1 }
       }
     end
@@ -13,11 +13,8 @@ describe Appsignal::EventFormatter::MongoRubyDriver::QueryFormatter do
     it "should apply a strategy for each key" do
       # TODO: additional curly brackets required for issue
       # https://github.com/rspec/rspec-mocks/issues/1460
-      # rubocop:disable Style/BracesAroundHashParameters
       expect(formatter).to receive(:apply_strategy)
         .with(:sanitize_document, { "_id" => 1 })
-      # rubocop:enable Style/BracesAroundHashParameters
-
       expect(formatter).to receive(:apply_strategy)
         .with(:allow, "users")
 

data/spec/lib/appsignal/event_formatter_spec.rb

@@ -2,6 +2,7 @@ class MockFormatter < Appsignal::EventFormatter
   attr_reader :body
 
   def initialize
+    super
     @body = "some value"
   end
 
@@ -28,6 +29,7 @@ end
 
 class MockDependentFormatter < Appsignal::EventFormatter
   def initialize
+    super
     raise "There is an error"
   end
 
@@ -60,7 +62,7 @@ describe Appsignal::EventFormatter do
           klass.register("mock.twice", MockFormatter)
         end
         expect(klass.registered?("mock.twice")).to be_truthy
-        expect(logs).to contains_log :warn, \
+        expect(logs).to contains_log :warn,
           "Formatter for 'mock.twice' already registered, not registering 'MockFormatter'"
       end
     end
@@ -71,9 +73,9 @@ describe Appsignal::EventFormatter do
           described_class.register "mock.dependent", MockDependentFormatter
         end
         expect(klass.registered?("mock.dependent")).to be_falsy
-        expect(logs).to contains_log :error, \
+        expect(logs).to contains_log :error,
           "'There is an error' " \
-          "when initializing mock.dependent event formatter"
+            "when initializing mock.dependent event formatter"
       end
     end
 
@@ -84,9 +86,9 @@ describe Appsignal::EventFormatter do
             described_class.register "mock.missing", MissingFormatMockFormatter
           end
           expect(klass.registered?("mock.missing")).to be_falsy
-          expect(logs).to contains_log :error, \
+          expect(logs).to contains_log :error,
             "'MissingFormatMockFormatter does not have a format(payload) " \
-            "method' when initializing mock.missing event formatter"
+              "method' when initializing mock.missing event formatter"
         end
       end
 
@@ -96,9 +98,9 @@ describe Appsignal::EventFormatter do
             described_class.register "mock.incorrect", IncorrectFormatMockFormatter
           end
           expect(klass.registered?("mock.incorrect")).to be_falsy
-          expect(logs).to contains_log :error, \
+          expect(logs).to contains_log :error,
             "'IncorrectFormatMockFormatter does not have a format(payload) " \
-            "method' when initializing mock.incorrect event formatter"
+              "method' when initializing mock.incorrect event formatter"
         end
       end
 
@@ -108,9 +110,9 @@ describe Appsignal::EventFormatter do
             described_class.register "mock.incorrect", IncorrectFormatMock2Formatter
           end
           expect(klass.registered?("mock.incorrect")).to be_falsy
-          expect(logs).to contains_log :error, \
+          expect(logs).to contains_log :error,
             "'IncorrectFormatMock2Formatter does not have a format(payload) " \
-            "method' when initializing mock.incorrect event formatter"
+              "method' when initializing mock.incorrect event formatter"
         end
       end
     end

data/spec/lib/appsignal/hooks/action_cable_spec.rb

@@ -52,8 +52,11 @@ describe Appsignal::Hooks::ActionCableHook do
           expect(Appsignal.active?).to be_truthy
           transaction
 
-          expect(Appsignal::Transaction).to receive(:create)
-            .with(transaction_id, Appsignal::Transaction::ACTION_CABLE, kind_of(ActionDispatch::Request))
+          expect(Appsignal::Transaction).to receive(:create).with(
+            transaction_id,
+            Appsignal::Transaction::ACTION_CABLE,
+            kind_of(ActionDispatch::Request)
+          )
             .and_return(transaction)
           allow(Appsignal::Transaction).to receive(:current).and_return(transaction)
 

data/spec/lib/appsignal/hooks/action_mailer_spec.rb

@@ -8,7 +8,8 @@ describe Appsignal::Hooks::ActionMailerHook do
         default :from => "test@example.com"
 
         def welcome
-          mail(:to => "test@example.com", :subject => "ActionMailer test", :content_type => "text/html") do |format|
+          mail(:to => "test@example.com", :subject => "ActionMailer test",
+            :content_type => "text/html") do |format|
             format.html { render :html => "This is a test" }
           end
         end

data/spec/lib/appsignal/hooks/active_support_notifications/instrument_shared_examples.rb

@@ -48,7 +48,7 @@ shared_examples "activesupport instrument override" do
   end
 
   it "converts non-string names to strings" do
-    as.instrument(:not_a_string) {}
+    as.instrument(:not_a_string) {} # rubocop:disable Lint/EmptyBlock
     expect(transaction.to_h["events"]).to match([
       {
         "allocation_count" => kind_of(Integer),

data/spec/lib/appsignal/hooks/active_support_notifications/start_finish_shared_examples.rb

@@ -1,7 +1,7 @@
 shared_examples "activesupport start finish override" do
   let(:instrumenter) { as.instrumenter }
 
-  it "instruments an ActiveSupport::Notifications.start/finish event with payload on start ignores payload" do
+  it "instruments start/finish events with payload on start ignores payload" do
     instrumenter.start("sql.active_record", :sql => "SQL")
     instrumenter.finish("sql.active_record", {})
 

data/spec/lib/appsignal/hooks/activejob_spec.rb

@@ -167,7 +167,8 @@ if DependencyHelper.active_job_present?
           expect(Appsignal).to receive(:increment_counter)
             .with("active_job_queue_job_count", 1, tags.merge(:status => :processed))
           expect(Appsignal).to receive(:increment_counter)
-            .with("active_job_queue_priority_job_count", 1, tags.merge(:priority => 10, :status => :processed))
+            .with("active_job_queue_priority_job_count", 1, tags.merge(:priority => 10,
+              :status => :processed))
 
           perform_job(ActiveJobPriorityTestJob)
 
@@ -243,9 +244,11 @@ if DependencyHelper.active_job_present?
             expect(Appsignal).to receive(:increment_counter)
               .with("active_job_queue_job_count", 1, tags.merge(:status => :failed))
             expect(Appsignal).to receive(:increment_counter)
-              .with("active_job_queue_priority_job_count", 1, tags.merge(:priority => 10, :status => :processed))
+              .with("active_job_queue_priority_job_count", 1, tags.merge(:priority => 10,
+                :status => :processed))
             expect(Appsignal).to receive(:increment_counter)
-              .with("active_job_queue_priority_job_count", 1, tags.merge(:priority => 10, :status => :failed))
+              .with("active_job_queue_priority_job_count", 1, tags.merge(:priority => 10,
+                :status => :failed))
 
             expect do
               perform_job(ActiveJobErrorPriorityTestJob)
@@ -323,7 +326,8 @@ if DependencyHelper.active_job_present?
       end
     end
 
-    context "with provider_job_id", :skip => DependencyHelper.rails_version < Gem::Version.new("5.0.0") do
+    context "with provider_job_id",
+      :skip => DependencyHelper.rails_version < Gem::Version.new("5.0.0") do
       before do
         module ActiveJob
           module QueueAdapters
@@ -363,7 +367,8 @@ if DependencyHelper.active_job_present?
       end
     end
 
-    context "with enqueued_at", :skip => DependencyHelper.rails_version < Gem::Version.new("6.0.0") do
+    context "with enqueued_at",
+      :skip => DependencyHelper.rails_version < Gem::Version.new("6.0.0") do
       before do
         module ActiveJob
           module QueueAdapters
@@ -425,7 +430,8 @@ if DependencyHelper.active_job_present?
           expect(transaction_hash).to include(
             "action" => "ActionMailerTestJob#welcome",
             "sample_data" => hash_including(
-              "params" => ["ActionMailerTestJob", "welcome", "deliver_now"] + active_job_args_wrapper,
+              "params" => ["ActionMailerTestJob", "welcome",
+                           "deliver_now"] + active_job_args_wrapper,
               "tags" => {
                 "active_job_id" => kind_of(String),
                 "queue" => "mailers"
@@ -444,7 +450,8 @@ if DependencyHelper.active_job_present?
           expect(transaction_hash).to include(
             "action" => "ActionMailerTestJob#welcome",
             "sample_data" => hash_including(
-              "params" => ["ActionMailerTestJob", "welcome", "deliver_now"] + active_job_args_wrapper(:args => method_expected_args),
+              "params" => ["ActionMailerTestJob", "welcome",
+                           "deliver_now"] + active_job_args_wrapper(:args => method_expected_args),
               "tags" => {
                 "active_job_id" => kind_of(String),
                 "queue" => "mailers"
@@ -464,7 +471,11 @@ if DependencyHelper.active_job_present?
             expect(transaction_hash).to include(
               "action" => "ActionMailerTestJob#welcome",
               "sample_data" => hash_including(
-                "params" => ["ActionMailerTestJob", "welcome", "deliver_now"] + active_job_args_wrapper(:params => parameterized_expected_args),
+                "params" => [
+                  "ActionMailerTestJob",
+                  "welcome",
+                  "deliver_now"
+                ] + active_job_args_wrapper(:params => parameterized_expected_args),
                 "tags" => {
                   "active_job_id" => kind_of(String),
                   "queue" => "mailers"
@@ -571,10 +582,8 @@ if DependencyHelper.active_job_present?
       end
     end
 
-    def perform_active_job
-      Timecop.freeze(time) do
-        yield
-      end
+    def perform_active_job(&block)
+      Timecop.freeze(time, &block)
     end
 
     def perform_job(job_class, args = nil)

data/spec/lib/appsignal/hooks/data_mapper_spec.rb

@@ -3,6 +3,7 @@ describe Appsignal::Hooks::DataMapperHook do
     before :context do
       module DataMapper
       end
+
       module DataObjects
         class Connection
         end

data/spec/lib/appsignal/hooks/delayed_job_spec.rb

@@ -39,13 +39,13 @@ describe Appsignal::Hooks::DelayedJobHook do
       let(:payload_object) { double(:args => args) }
       let(:job_data) do
         {
-          :id             => 123,
-          :name           => "TestClass#perform",
-          :priority       => 1,
-          :attempts       => 1,
-          :queue          => "default",
-          :created_at     => created_at,
-          :run_at         => run_at,
+          :id => 123,
+          :name => "TestClass#perform",
+          :priority => 1,
+          :attempts => 1,
+          :queue => "default",
+          :created_at => created_at,
+          :run_at => run_at,
           :payload_object => payload_object
         }
       end
@@ -76,8 +76,8 @@ describe Appsignal::Hooks::DelayedJobHook do
             "metadata" => {
               "priority" => 1,
               "attempts" => 1,
-              "queue"    => "default",
-              "id"       => "123"
+              "queue" => "default",
+              "id" => "123"
             },
             "params" => ["argument"]
           )
@@ -204,7 +204,7 @@ describe Appsignal::Hooks::DelayedJobHook do
               end
             end
 
-            context "with payload_object being acting like a Hash and returning a non-String value" do
+            context "with payload_object acting like a Hash and returning a non-String value" do
               class ClassActingAsHash
                 def self.[](_key)
                   Object.new
@@ -279,8 +279,8 @@ describe Appsignal::Hooks::DelayedJobHook do
                 "metadata" => {
                   "priority" => 1,
                   "attempts" => 1,
-                  "queue"    => "default",
-                  "id"       => "123"
+                  "queue" => "default",
+                  "id" => "123"
                 },
                 "params" => ["activejob_argument"]
               )

data/spec/lib/appsignal/hooks/excon_spec.rb

@@ -38,7 +38,7 @@ describe Appsignal::Hooks::ExconHook do
           :method => :get,
           :scheme => "http"
         }
-        Excon.defaults[:instrumentor].instrument("excon.request", data) {}
+        Excon.defaults[:instrumentor].instrument("excon.request", data) {} # rubocop:disable Lint/EmptyBlock
 
         expect(transaction.to_h["events"]).to include(
           hash_including(
@@ -51,7 +51,7 @@ describe Appsignal::Hooks::ExconHook do
 
       it "instruments a http response" do
         data = { :host => "www.google.com" }
-        Excon.defaults[:instrumentor].instrument("excon.response", data) {}
+        Excon.defaults[:instrumentor].instrument("excon.response", data) {} # rubocop:disable Lint/EmptyBlock
 
         expect(transaction.to_h["events"]).to include(
           hash_including(

data/spec/lib/appsignal/hooks/mongo_ruby_driver_spec.rb

@@ -3,7 +3,9 @@ describe Appsignal::Hooks::MongoRubyDriverHook do
 
   context "with mongo ruby driver" do
     let(:subscriber) { Appsignal::Hooks::MongoMonitorSubscriber.new }
-    before { allow(Appsignal::Hooks::MongoMonitorSubscriber).to receive(:new).and_return(subscriber) }
+    before do
+      allow(Appsignal::Hooks::MongoMonitorSubscriber).to receive(:new).and_return(subscriber)
+    end
 
     before(:context) do
       module Mongo

data/spec/lib/appsignal/hooks/shoryuken_spec.rb

@@ -146,7 +146,9 @@ describe Appsignal::Hooks::ShoryukenMiddleware do
       [
         double(
           :message_id => "msg2",
-          :attributes => { "SentTimestamp" => (Time.parse("1976-11-18 01:00:00UTC").to_i * 1000).to_s }
+          :attributes => {
+            "SentTimestamp" => (Time.parse("1976-11-18 01:00:00UTC").to_i * 1000).to_s
+          }
         ),
         double(
           :message_id => "msg1",
@@ -165,7 +167,7 @@ describe Appsignal::Hooks::ShoryukenMiddleware do
     it "creates a transaction for the batch" do
       allow_any_instance_of(Appsignal::Transaction).to receive(:set_queue_start).and_call_original
       expect do
-        perform_job {}
+        perform_job {} # rubocop:disable Lint/EmptyBlock
       end.to change { created_transactions.length }.by(1)
 
       transaction = last_transaction

data/spec/lib/appsignal/hooks/sidekiq_spec.rb

@@ -21,7 +21,8 @@ describe Appsignal::Hooks::SidekiqHook do
       alias exists? include?
 
       unless method_defined? :prepend
-        def prepend(middleware) # For Ruby < 2.5
+        # For Ruby < 2.5
+        def prepend(middleware)
           insert(0, middleware)
         end
       end

data/spec/lib/appsignal/hooks_spec.rb

@@ -67,13 +67,14 @@ describe Appsignal::Hooks do
     expect(Appsignal::Hooks.hooks[:mock_error_hook]).to be_instance_of(MockErrorHook)
     expect(Appsignal::Hooks.hooks[:mock_error_hook].installed?).to be_falsy
 
-    expect(Appsignal.logger).to receive(:error).with("Error while installing mock_error_hook hook: error").once
+    expect(Appsignal.logger).to receive(:error)
+      .with("Error while installing mock_error_hook hook: error").once
     expect(Appsignal.logger).to receive(:debug).ordered do |message|
       expect(message).to eq("Installing mock_error_hook hook")
     end
     expect(Appsignal.logger).to receive(:debug).ordered do |message|
       # Start of the error backtrace as debug log
-      expect(message).to start_with(File.expand_path("../../../../", __FILE__))
+      expect(message).to start_with(File.expand_path("../../..", __dir__))
     end
 
     Appsignal::Hooks.load_hooks
@@ -104,8 +105,8 @@ describe Appsignal::Hooks do
 
         deprecation_message =
           "The constant Appsignal::Hooks::SidekiqPlugin has been deprecated. " \
-          "Please update the constant name to Appsignal::Integrations::SidekiqMiddleware " \
-          "in the following file to remove this message.\n#{__FILE__}:"
+            "Please update the constant name to Appsignal::Integrations::SidekiqMiddleware " \
+            "in the following file to remove this message.\n#{__FILE__}:"
         expect(stderr).to include "appsignal WARNING: #{deprecation_message}"
         expect(log).to contains_log :warn, deprecation_message
       end