appsignal 3.4.0-java → 3.4.2-java

data/spec/lib/appsignal/probes/gvl_spec.rb

@@ -4,36 +4,84 @@ describe Appsignal::Probes::GvlProbe do
 
   let(:hostname) { "some-host" }
 
+  def gauges_for(metric)
+    gauges = appsignal_mock.gauges.select do |gauge|
+      gauge[0] == metric
+    end
+
+    gauges.map do |gauge|
+      gauge.drop(1)
+    end
+  end
+
   after(:each) { FakeGVLTools.reset }
 
-  context "with global timer enabled" do
-    before(:each) { FakeGVLTools::GlobalTimer.enabled = true }
+  it "gauges the global timer delta" do
+    FakeGVLTools::GlobalTimer.monotonic_time = 100_000_000
+    probe.call
+
+    expect(gauges_for("gvl_global_timer")).to be_empty
+
+    FakeGVLTools::GlobalTimer.monotonic_time = 300_000_000
+    probe.call
 
-    it "gauges the global timer delta" do
-      FakeGVLTools::GlobalTimer.monotonic_time = 100_000_000
+    expect(gauges_for("gvl_global_timer")).to eq [
+      [200, { :hostname => hostname }]
+    ]
+  end
+
+  context "when the delta is negative" do
+    it "does not gauge the global timer delta" do
+      FakeGVLTools::GlobalTimer.monotonic_time = 300_000_000
       probe.call
 
-      expect(appsignal_mock.gauges).to be_empty
+      expect(gauges_for("gvl_global_timer")).to be_empty
+
+      FakeGVLTools::GlobalTimer.monotonic_time = 0
+      probe.call
+
+      expect(gauges_for("gvl_global_timer")).to be_empty
+    end
+  end
 
+  context "when the delta is zero" do
+    it "does not gauge the global timer delta" do
       FakeGVLTools::GlobalTimer.monotonic_time = 300_000_000
       probe.call
 
-      expect(appsignal_mock.gauges).to eq [
-        ["gvl_global_timer", 200, { :hostname => hostname }]
-      ]
+      expect(gauges_for("gvl_global_timer")).to be_empty
+
+      probe.call
+
+      expect(gauges_for("gvl_global_timer")).to be_empty
     end
   end
 
-  context "with waiting threads enabled" do
-    before(:each) { FakeGVLTools::WaitingThreads.enabled = true }
+  context "when the waiting threads count is enabled" do
+    before(:each) do
+      FakeGVLTools::WaitingThreads.enabled = true
+    end
 
     it "gauges the waiting threads count" do
       FakeGVLTools::WaitingThreads.count = 3
       probe.call
 
-      expect(appsignal_mock.gauges).to eq [
-        ["gvl_waiting_threads", 3, { :hostname => hostname }]
+      expect(gauges_for("gvl_waiting_threads")).to eq [
+        [3, { :hostname => hostname }]
       ]
     end
   end
+
+  context "when the waiting threads count is disabled" do
+    before(:each) do
+      FakeGVLTools::WaitingThreads.enabled = false
+    end
+
+    it "does not gauge the waiting threads count" do
+      FakeGVLTools::WaitingThreads.count = 3
+      probe.call
+
+      expect(gauges_for("gvl_waiting_threads")).to be_empty
+    end
+  end
 end

data/spec/lib/appsignal/probes/mri_spec.rb

@@ -1,10 +1,12 @@
 describe Appsignal::Probes::MriProbe do
   let(:appsignal_mock) { AppsignalMock.new(:hostname => hostname) }
   let(:gc_profiler_mock) { instance_double("Appsignal::GarbageCollectionProfiler") }
-  let(:probe) { described_class.new(:appsignal => appsignal_mock, :gc_profiler => gc_profiler_mock) }
+  let(:probe) do
+    described_class.new(:appsignal => appsignal_mock, :gc_profiler => gc_profiler_mock)
+  end
 
   describe ".dependencies_present?" do
-    if DependencyHelper.running_jruby? || DependencyHelper.running_ruby_2_0?
+    if DependencyHelper.running_jruby?
       it "should not be present" do
         expect(described_class.dependencies_present?).to be_falsy
       end
@@ -15,7 +17,7 @@ describe Appsignal::Probes::MriProbe do
     end
   end
 
-  unless DependencyHelper.running_jruby? || DependencyHelper.running_ruby_2_0?
+  unless DependencyHelper.running_jruby?
     describe "#call" do
       let(:hostname) { nil }
       before do
@@ -126,7 +128,8 @@ describe Appsignal::Probes::MriProbe do
 
         it "reports custom hostname tag value" do
           probe.call
-          expect_gauge_value("heap_slots", :tags => { :metric => :heap_live, :hostname => hostname })
+          expect_gauge_value("heap_slots",
+            :tags => { :metric => :heap_live, :hostname => hostname })
         end
       end
     end

data/spec/lib/appsignal/rack/generic_instrumentation_spec.rb

@@ -42,7 +42,8 @@ describe Appsignal::Rack::GenericInstrumentation do
         kind_of(String),
         Appsignal::Transaction::HTTP_REQUEST,
         kind_of(Rack::Request)
-      ).and_return(double(:set_action_if_nil => nil, :set_http_or_background_queue_start => nil, :set_metadata => nil))
+      ).and_return(double(:set_action_if_nil => nil, :set_http_or_background_queue_start => nil,
+        :set_metadata => nil))
     end
 
     it "should call the app" do

data/spec/lib/appsignal/rack/rails_instrumentation_spec.rb

@@ -113,7 +113,8 @@ if DependencyHelper.rails_present?
 
           transaction_hash = last_transaction.to_h
           expect(transaction_hash["metadata"]).to_not have_key("method")
-          expect(log_contents(log)).to contains_log(:error, "Unable to report HTTP request method: '")
+          expect(log_contents(log)).to contains_log(:error,
+            "Unable to report HTTP request method: '")
         end
       end
 

data/spec/lib/appsignal/rack/sinatra_instrumentation_spec.rb

@@ -110,7 +110,8 @@ if DependencyHelper.sinatra_present?
           Appsignal::Transaction::HTTP_REQUEST,
           kind_of(Sinatra::Request),
           kind_of(Hash)
-        ).and_return(double(:set_action_if_nil => nil, :set_http_or_background_queue_start => nil, :set_metadata => nil))
+        ).and_return(double(:set_action_if_nil => nil, :set_http_or_background_queue_start => nil,
+          :set_metadata => nil))
       end
 
       it "should call the app" do
@@ -158,7 +159,8 @@ if DependencyHelper.sinatra_present?
 
       describe "action name" do
         it "should set the action" do
-          expect_any_instance_of(Appsignal::Transaction).to receive(:set_action_if_nil).with("GET /")
+          expect_any_instance_of(Appsignal::Transaction)
+            .to receive(:set_action_if_nil).with("GET /")
         end
 
         context "without 'sinatra.route' env" do
@@ -173,14 +175,16 @@ if DependencyHelper.sinatra_present?
           before { env["SCRIPT_NAME"] = "/api" }
 
           it "should call set_action with an application prefix path" do
-            expect_any_instance_of(Appsignal::Transaction).to receive(:set_action_if_nil).with("GET /api/")
+            expect_any_instance_of(Appsignal::Transaction)
+              .to receive(:set_action_if_nil).with("GET /api/")
           end
 
           context "without 'sinatra.route' env" do
             let(:env) { { :path => "/", :method => "GET" } }
 
             it "returns nil" do
-              expect_any_instance_of(Appsignal::Transaction).to receive(:set_action_if_nil).with(nil)
+              expect_any_instance_of(Appsignal::Transaction)
+                .to receive(:set_action_if_nil).with(nil)
             end
           end
         end
@@ -191,7 +195,8 @@ if DependencyHelper.sinatra_present?
       end
 
       it "should set the queue start" do
-        expect_any_instance_of(Appsignal::Transaction).to receive(:set_http_or_background_queue_start)
+        expect_any_instance_of(Appsignal::Transaction)
+          .to receive(:set_http_or_background_queue_start)
       end
 
       context "with overridden request class and params method" do

data/spec/lib/appsignal/rack/streaming_listener_spec.rb

@@ -4,10 +4,10 @@ describe Appsignal::Rack::StreamingListener do
   let(:headers) { {} }
   let(:env) do
     {
-      "rack.input"     => StringIO.new,
+      "rack.input" => StringIO.new,
       "REQUEST_METHOD" => "GET",
-      "PATH_INFO"      => "/homepage",
-      "QUERY_STRING"   => "param=something"
+      "PATH_INFO" => "/homepage",
+      "QUERY_STRING" => "param=something"
     }
   end
   let(:app)      { double(:call => [200, headers, "body"]) }
@@ -114,8 +114,10 @@ end
 
 describe Appsignal::StreamWrapper do
   let(:stream)      { double }
-  let(:transaction) { Appsignal::Transaction.create(SecureRandom.uuid, Appsignal::Transaction::HTTP_REQUEST, {}) }
-  let(:wrapper)     { Appsignal::StreamWrapper.new(stream, transaction) }
+  let(:transaction) do
+    Appsignal::Transaction.create(SecureRandom.uuid, Appsignal::Transaction::HTTP_REQUEST, {})
+  end
+  let(:wrapper) { Appsignal::StreamWrapper.new(stream, transaction) }
 
   describe "#each" do
     it "calls the original stream" do

data/spec/lib/appsignal/transaction_spec.rb

@@ -66,8 +66,8 @@ describe Appsignal::Transaction do
           create_transaction("2")
           expect(log_contents(log)).to contains_log :warn,
             "Trying to start new transaction with id '2', but a " \
-            "transaction with id '#{transaction_id}' is already " \
-            "running. Using transaction '#{transaction_id}'."
+              "transaction with id '#{transaction_id}' is already " \
+              "running. Using transaction '#{transaction_id}'."
         end
 
         context "with option :force => true" do
@@ -741,7 +741,7 @@ describe Appsignal::Transaction do
         it "does not add the error" do
           expect(Appsignal.logger).to receive(:error).with(
             "Appsignal::Transaction#set_error: Cannot set error. " \
-            "The given value is not an exception: #{error.inspect}"
+              "The given value is not an exception: #{error.inspect}"
           )
           expect(transaction.ext).to_not receive(:set_error)
 
@@ -1083,7 +1083,9 @@ describe Appsignal::Transaction do
 
       context "with an array" do
         let(:request) do
-          Appsignal::Transaction::GenericRequest.new(background_env_with_data(:params => %w[arg1 arg2]))
+          Appsignal::Transaction::GenericRequest.new(
+            background_env_with_data(:params => %w[arg1 arg2])
+          )
         end
 
         it { is_expected.to eq %w[arg1 arg2] }
@@ -1099,8 +1101,9 @@ describe Appsignal::Transaction do
       context "with env" do
         context "with sanitization" do
           let(:request) do
-            Appsignal::Transaction::GenericRequest.new \
+            Appsignal::Transaction::GenericRequest.new(
               http_request_env_with_data(:params => { :foo => :bar })
+            )
           end
 
           it "should call the params sanitizer" do
@@ -1110,8 +1113,9 @@ describe Appsignal::Transaction do
 
         context "with AppSignal filtering" do
           let(:request) do
-            Appsignal::Transaction::GenericRequest.new \
+            Appsignal::Transaction::GenericRequest.new(
               http_request_env_with_data(:params => { :foo => :bar, :baz => :bat })
+            )
           end
           before { Appsignal.config.config_hash[:filter_parameters] = %w[foo] }
           after { Appsignal.config.config_hash[:filter_parameters] = [] }
@@ -1233,7 +1237,8 @@ describe Appsignal::Transaction do
                   true
                 end
               end.new
-              ActionDispatch::Request::Session.create(store, ActionDispatch::Request.new("rack.input" => StringIO.new), {})
+              ActionDispatch::Request::Session.create(store,
+                ActionDispatch::Request.new("rack.input" => StringIO.new), {})
             end
             before do
               expect(transaction).to respond_to(:request)
@@ -1334,12 +1339,14 @@ describe Appsignal::Transaction do
 
       let(:error) do
         PG::UniqueViolation.new(
-          "ERROR: duplicate key value violates unique constraint \"index_users_on_email\" DETAIL: Key (email)=(test@test.com) already exists."
+          "ERROR: duplicate key value violates unique constraint " \
+            "\"index_users_on_email\" DETAIL: Key (email)=(test@test.com) already exists."
         )
       end
 
       it "returns a sanizited error message" do
-        expect(subject).to eq "ERROR: duplicate key value violates unique constraint \"index_users_on_email\" DETAIL: Key (email)=(?) already exists."
+        expect(subject).to eq "ERROR: duplicate key value violates unique constraint " \
+          "\"index_users_on_email\" DETAIL: Key (email)=(?) already exists."
       end
     end
 
@@ -1350,15 +1357,15 @@ describe Appsignal::Transaction do
 
       let(:error) do
         ActiveRecord::RecordNotUnique.new(
-          "PG::UniqueViolation: ERROR: duplicate key value violates unique constraint \"example_constraint\"\n" \
-          "DETAIL: Key (email)=(foo@example.com) already exists."
+          "PG::UniqueViolation: ERROR: duplicate key value violates unique constraint " \
+            "\"example_constraint\"\nDETAIL: Key (email)=(foo@example.com) already exists."
         )
       end
 
       it "returns a sanizited error message" do
         expect(subject).to eq \
-          "PG::UniqueViolation: ERROR: duplicate key value violates unique constraint \"example_constraint\"\n" \
-          "DETAIL: Key (email)=(?) already exists."
+          "PG::UniqueViolation: ERROR: duplicate key value violates unique constraint " \
+            "\"example_constraint\"\nDETAIL: Key (email)=(?) already exists."
       end
     end
   end

data/spec/lib/appsignal/utils/data_spec.rb

@@ -47,6 +47,7 @@ describe Appsignal::Utils::Data do
 
         describe "#to_s" do
           it "returns a serialized hash" do
+            # rubocop:disable Style/StringConcatenation
             expect(subject.to_s).to eq %({"":"test",) +
               %("1":true,) +
               %("bar":null,) +
@@ -59,6 +60,7 @@ describe Appsignal::Utils::Data do
               %("int63":"bigint:#{1 << 63}",) +
               %("int64":"bigint:#{1 << 64}",) +
               %("the":"payload"})
+            # rubocop:enable Style/StringConcatenation
           end
         end
       end
@@ -73,6 +75,7 @@ describe Appsignal::Utils::Data do
 
         describe "#to_s" do
           it "returns a serialized array" do
+            # rubocop:disable Style/StringConcatenation, Style/RedundantStringEscape
             expect(subject.to_s).to eq %([null,) +
               %(true,) +
               %(false,) +
@@ -84,6 +87,7 @@ describe Appsignal::Utils::Data do
               %("bigint:#{1 << 63}",) +
               %("bigint:#{1 << 64}",) +
               %({\"arr\":[1,2,\"three\"],\"foo\":\"bʊr\"}])
+            # rubocop:enable Style/StringConcatenation, Style/RedundantStringEscape
           end
         end
       end
@@ -105,7 +109,12 @@ describe Appsignal::Utils::Data do
 
         describe "#to_s" do
           it "returns a JSON representation in a String" do
-            expect(subject.to_s).to eq %({"field_four":{"one":"aa�"},"field_one":"aa","field_three":["one","aa�"],"field_two":"aa�"})
+            # rubocop:disable Style/StringConcatenation
+            expect(subject.to_s).to eq %({"field_four":{"one":"aa�"},) +
+              %("field_one":"aa",) +
+              %("field_three":["one","aa�"],) +
+              %("field_two":"aa�"})
+            # rubocop:enable Style/StringConcatenation
           end
         end
       end

data/spec/lib/appsignal/utils/hash_sanitizer_spec.rb

@@ -2,23 +2,23 @@ describe Appsignal::Utils::HashSanitizer do
   let(:file) { uploaded_file }
   let(:params) do
     {
-      :text       => "string",
-      "string"    => "string key value",
-      :file       => file,
-      :float      => 0.0,
-      :bool_true  => true,
+      :text => "string",
+      "string" => "string key value",
+      :file => file,
+      :float => 0.0,
+      :bool_true => true,
       :bool_false => false,
-      :nil        => nil,
-      :int        => 1, # Fixnum
-      :int64      => 1 << 64, # Bignum
-      :hash       => {
-        :nested_text  => "string",
+      :nil => nil,
+      :int => 1, # Fixnum
+      :int64 => 1 << 64, # Bignum
+      :hash => {
+        :nested_text => "string",
         :nested_array => [
           "something",
           "else",
           file,
           {
-            :key  => "value",
+            :key => "value",
             :file => file
           }
         ]

data/spec/lib/appsignal/utils/json_spec.rb

@@ -15,7 +15,8 @@ describe Appsignal::Utils::JSON do
       end
 
       it "returns a JSON string" do
-        is_expected.to eq %({"the":"payload","1":true,"":"test","foo":[1,2,"three"],"bar":null,"baz":{"foo":"bar"}})
+        is_expected.to eq %({"the":"payload","1":true,"":"test",) +
+          %("foo":[1,2,"three"],"bar":null,"baz":{"foo":"bar"}})
       end
     end
 
@@ -35,7 +36,8 @@ describe Appsignal::Utils::JSON do
       end
 
       it "returns a JSON string with invalid UTF-8 content" do
-        is_expected.to eq %({"field_one":"aa","field_two":"aa�","field_three":["one","aa�"],"field_four":{"one":"aa�"}})
+        is_expected.to eq %({"field_one":"aa","field_two":"aa�",) +
+          %("field_three":["one","aa�"],"field_four":{"one":"aa�"}})
       end
     end
   end

data/spec/lib/appsignal_spec.rb

@@ -22,12 +22,10 @@ describe Appsignal do
   describe ".start" do
     context "with no config set beforehand" do
       it "should do nothing when config is not set and there is no valid config in the env" do
-        expect(Appsignal.logger).to receive(:error).with(
-          "Push API key not set after loading config"
-        ).once
-        expect(Appsignal.logger).to receive(:error).with(
-          "Not starting, no valid config for this environment"
-        ).once
+        expect(Appsignal.logger).to receive(:error)
+          .with("Push API key not set after loading config").once
+        expect(Appsignal.logger).to receive(:error)
+          .with("Not starting, no valid config for this environment").once
         expect(Appsignal::Extension).to_not receive(:start)
         Appsignal.start
       end
@@ -249,7 +247,7 @@ describe Appsignal do
         end
 
         it "logs an error" do
-          Appsignal.monitor_transaction("unknown.sidekiq") {}
+          Appsignal.monitor_transaction("unknown.sidekiq") {} # rubocop:disable Lint/EmptyBlock
           expect(log).to contains_log(
             :error,
             "Unrecognized name 'unknown.sidekiq': names must start with either 'perform_job' " \
@@ -317,9 +315,8 @@ describe Appsignal do
     describe ".monitor_transaction" do
       context "with a successful call" do
         it "should instrument and complete for a background job" do
-          expect(Appsignal).to receive(:instrument).with(
-            "perform_job.something"
-          ).and_yield
+          expect(Appsignal).to receive(:instrument)
+            .with("perform_job.something").and_yield
           expect(Appsignal::Transaction).to receive(:complete_current!)
           object = double
           expect(object).to receive(:some_method).and_return(1)
@@ -336,9 +333,8 @@ describe Appsignal do
         end
 
         it "should instrument and complete for a http request" do
-          expect(Appsignal).to receive(:instrument).with(
-            "process_action.something"
-          ).and_yield
+          expect(Appsignal).to receive(:instrument)
+            .with("process_action.something").and_yield
           expect(Appsignal::Transaction).to receive(:complete_current!)
           object = double
           expect(object).to receive(:some_method)
@@ -378,7 +374,7 @@ describe Appsignal do
         end
 
         it "logs an error" do
-          Appsignal.monitor_transaction("unknown.sidekiq") {}
+          Appsignal.monitor_transaction("unknown.sidekiq") {} # rubocop:disable Lint/EmptyBlock
           expect(log).to contains_log(
             :error,
             "Unrecognized name 'unknown.sidekiq': names must start with either 'perform_job' " \
@@ -529,7 +525,8 @@ describe Appsignal do
 
       describe ".set_gauge" do
         it "should call set_gauge on the extension with a string key and float" do
-          expect(Appsignal::Extension).to receive(:set_gauge).with("key", 0.1, Appsignal::Extension.data_map_new)
+          expect(Appsignal::Extension).to receive(:set_gauge)
+            .with("key", 0.1, Appsignal::Extension.data_map_new)
           Appsignal.set_gauge("key", 0.1)
         end
 
@@ -540,12 +537,14 @@ describe Appsignal do
         end
 
         it "should call set_gauge on the extension with a symbol key and int" do
-          expect(Appsignal::Extension).to receive(:set_gauge).with("key", 1.0, Appsignal::Extension.data_map_new)
+          expect(Appsignal::Extension).to receive(:set_gauge)
+            .with("key", 1.0, Appsignal::Extension.data_map_new)
           Appsignal.set_gauge(:key, 1)
         end
 
         it "should not raise an exception when out of range" do
-          expect(Appsignal::Extension).to receive(:set_gauge).with("key", 10, Appsignal::Extension.data_map_new).and_raise(RangeError)
+          expect(Appsignal::Extension).to receive(:set_gauge).with("key", 10,
+            Appsignal::Extension.data_map_new).and_raise(RangeError)
           expect(Appsignal.logger).to receive(:warn).with("Gauge value 10 for key 'key' is too big")
           expect do
             Appsignal.set_gauge("key", 10)
@@ -565,8 +564,10 @@ describe Appsignal do
         end
 
         it "should not raise an exception when out of range" do
-          expect(Appsignal::Extension).to receive(:set_host_gauge).with("key", 10).and_raise(RangeError)
-          expect(Appsignal.logger).to receive(:warn).with("Host gauge value 10 for key 'key' is too big")
+          expect(Appsignal::Extension).to receive(:set_host_gauge).with("key",
+            10).and_raise(RangeError)
+          expect(Appsignal.logger).to receive(:warn)
+            .with("Host gauge value 10 for key 'key' is too big")
           expect do
             Appsignal.set_host_gauge("key", 10)
           end.to_not raise_error
@@ -585,8 +586,10 @@ describe Appsignal do
         end
 
         it "should not raise an exception when out of range" do
-          expect(Appsignal::Extension).to receive(:set_process_gauge).with("key", 10).and_raise(RangeError)
-          expect(Appsignal.logger).to receive(:warn).with("Process gauge value 10 for key 'key' is too big")
+          expect(Appsignal::Extension).to receive(:set_process_gauge).with("key",
+            10).and_raise(RangeError)
+          expect(Appsignal.logger).to receive(:warn)
+            .with("Process gauge value 10 for key 'key' is too big")
           expect do
             Appsignal.set_process_gauge("key", 10)
           end.to_not raise_error
@@ -595,7 +598,8 @@ describe Appsignal do
 
       describe ".increment_counter" do
         it "should call increment_counter on the extension with a string key" do
-          expect(Appsignal::Extension).to receive(:increment_counter).with("key", 1, Appsignal::Extension.data_map_new)
+          expect(Appsignal::Extension).to receive(:increment_counter)
+            .with("key", 1, Appsignal::Extension.data_map_new)
           Appsignal.increment_counter("key")
         end
 
@@ -606,18 +610,22 @@ describe Appsignal do
         end
 
         it "should call increment_counter on the extension with a symbol key" do
-          expect(Appsignal::Extension).to receive(:increment_counter).with("key", 1, Appsignal::Extension.data_map_new)
+          expect(Appsignal::Extension).to receive(:increment_counter)
+            .with("key", 1, Appsignal::Extension.data_map_new)
           Appsignal.increment_counter(:key)
         end
 
         it "should call increment_counter on the extension with a count" do
-          expect(Appsignal::Extension).to receive(:increment_counter).with("key", 5, Appsignal::Extension.data_map_new)
+          expect(Appsignal::Extension).to receive(:increment_counter)
+            .with("key", 5, Appsignal::Extension.data_map_new)
           Appsignal.increment_counter("key", 5)
         end
 
         it "should not raise an exception when out of range" do
-          expect(Appsignal::Extension).to receive(:increment_counter).with("key", 10, Appsignal::Extension.data_map_new).and_raise(RangeError)
-          expect(Appsignal.logger).to receive(:warn).with("Counter value 10 for key 'key' is too big")
+          expect(Appsignal::Extension).to receive(:increment_counter)
+            .with("key", 10, Appsignal::Extension.data_map_new).and_raise(RangeError)
+          expect(Appsignal.logger).to receive(:warn)
+            .with("Counter value 10 for key 'key' is too big")
           expect do
             Appsignal.increment_counter("key", 10)
           end.to_not raise_error
@@ -626,7 +634,8 @@ describe Appsignal do
 
       describe ".add_distribution_value" do
         it "should call add_distribution_value on the extension with a string key and float" do
-          expect(Appsignal::Extension).to receive(:add_distribution_value).with("key", 0.1, Appsignal::Extension.data_map_new)
+          expect(Appsignal::Extension).to receive(:add_distribution_value)
+            .with("key", 0.1, Appsignal::Extension.data_map_new)
           Appsignal.add_distribution_value("key", 0.1)
         end
 
@@ -637,13 +646,16 @@ describe Appsignal do
         end
 
         it "should call add_distribution_value on the extension with a symbol key and int" do
-          expect(Appsignal::Extension).to receive(:add_distribution_value).with("key", 1.0, Appsignal::Extension.data_map_new)
+          expect(Appsignal::Extension).to receive(:add_distribution_value)
+            .with("key", 1.0, Appsignal::Extension.data_map_new)
           Appsignal.add_distribution_value(:key, 1)
         end
 
         it "should not raise an exception when out of range" do
-          expect(Appsignal::Extension).to receive(:add_distribution_value).with("key", 10, Appsignal::Extension.data_map_new).and_raise(RangeError)
-          expect(Appsignal.logger).to receive(:warn).with("Distribution value 10 for key 'key' is too big")
+          expect(Appsignal::Extension).to receive(:add_distribution_value)
+            .with("key", 10, Appsignal::Extension.data_map_new).and_raise(RangeError)
+          expect(Appsignal.logger).to receive(:warn)
+            .with("Distribution value 10 for key 'key' is too big")
           expect do
             Appsignal.add_distribution_value("key", 10)
           end.to_not raise_error
@@ -1053,14 +1065,16 @@ describe Appsignal do
       it_behaves_like "instrument helper" do
         let(:instrumenter) { Appsignal }
         before do
-          expect(Appsignal::Transaction).to receive(:current).at_least(:once).and_return(transaction)
+          expect(Appsignal::Transaction).to receive(:current).at_least(:once)
+            .and_return(transaction)
         end
       end
     end
 
     describe ".instrument_sql" do
       before do
-        expect(Appsignal::Transaction).to receive(:current).at_least(:once).and_return(transaction)
+        expect(Appsignal::Transaction).to receive(:current).at_least(:once)
+          .and_return(transaction)
       end
 
       it "creates an SQL event on the transaction" do
@@ -1119,7 +1133,7 @@ describe Appsignal do
 
     context "when the log path is writable" do
       context "when the log file is writable" do
-        let(:log_file_contents) { File.open(log_file).read }
+        let(:log_file_contents) { File.read(log_file) }
 
         before do
           capture_stdout(out_stream) do
@@ -1198,8 +1212,8 @@ describe Appsignal do
 
       it "outputs a warning" do
         expect(output).to include \
-          "appsignal: Unable to log to '#{log_path}' "\
-          "or the '#{Appsignal::Config.system_tmp_dir}' fallback."
+          "appsignal: Unable to log to '#{log_path}' " \
+            "or the '#{Appsignal::Config.system_tmp_dir}' fallback."
       end
     end