appsignal 3.0.0.beta.1 → 3.0.3

data/spec/lib/puma/appsignal_spec.rb

@@ -23,6 +23,27 @@ RSpec.describe "Puma plugin" do
       def self.stats
       end
 
+      def self.run
+        # Capture threads running before application is preloaded
+        before = Thread.list.reject { |t| t.thread_variable_get(:fork_safe) }
+
+        # An abbreviated version of what happens in Puma::Cluster#run
+        launcher = MockPumaLauncher.new
+        plugin = Plugin.plugin.new
+        plugin.start(launcher)
+        launcher.events.on_booted.call
+
+        # Wait for minutely probe thread to finish starting
+        sleep 0.005
+
+        # Capture any new threads running after application is preloaded.
+        # Any threads created during the preloading phase will not be
+        # carried over into the forked workers. Puma warns about these
+        # but the minutely probe thread should only exist in the main process.
+        after = Thread.list.reject { |t| t.thread_variable_get(:fork_safe) }
+        $stdout.puts "! WARNING: Detected #{after.size - before.size} Thread(s) started in app boot" if after.size > before.size
+      end
+
       class Plugin
         class << self
           attr_reader :plugin
@@ -68,6 +89,13 @@ RSpec.describe "Puma plugin" do
     wait_for("enough probe calls") { probe.calls >= 2 }
   end
 
+  it "marks the PumaProbe thread as fork-safe" do
+    out_stream = std_stream
+    capture_stdout(out_stream) { Puma.run }
+
+    expect(out_stream.read).not_to include("WARNING: Detected 1 Thread")
+  end
+
   context "without Puma.stats" do
     before { Puma.singleton_class.send(:remove_method, :stats) }
 

data/spec/spec_helper.rb

@@ -117,6 +117,28 @@ RSpec.configure do |config|
     allow(Appsignal::Config).to receive(:system_tmp_dir).and_return(spec_system_tmp_dir)
   end
 
+  # These tests are not run by default. They require a failed extension
+  # installation. See the `rake test:failure` task. If a test with this tag was
+  # run, run `rake extension:install` again to fix the extension installation
+  # before running other tests.
+  config.before :extension_installation_failure => true do
+    next unless Appsignal.extension_loaded?
+
+    raise "Extension is loaded, please run the following task and rerun the test." \
+      "\n\n    rake test:prepare_failure"
+  end
+
+  # Check to see if the extension is loaded before running the specs. If the
+  # extension is not loaded it can result in unexpected behavior.
+  config.before do |example|
+    next if Appsignal.extension_loaded?
+    next if example.metadata[:extension_installation_failure]
+
+    puts "\nWARNING: The AppSignal extension is not loaded, please run the "\
+      "following task and rerun the test." \
+      "\n\n    rake extension:install\n"
+  end
+
   config.after do
     Appsignal::Testing.clear!
     clear_current_transaction!

data/spec/support/testing.rb

@@ -1,16 +1,26 @@
 module Appsignal
   class << self
+    attr_writer :testing
     remove_method :testing?
 
     # @api private
     def testing?
-      true
+      @testing = true unless defined?(@testing)
+      @testing
     end
   end
 
   # @api private
   module Testing
     class << self
+      def without_testing
+        original_testing = Appsignal.testing?
+        Appsignal.testing = false
+        yield
+      ensure
+        Appsignal.testing = original_testing
+      end
+
       def transactions
         @transactions ||= []
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appsignal
 version: !ruby/object:Gem::Version
-  version: 3.0.0.beta.1
+  version: 3.0.3
 platform: ruby
 authors:
 - Robert Beekman
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-01-28 00:00:00.000000000 Z
+date: 2021-04-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -165,8 +165,6 @@ files:
 - gemfiles/que.gemfile
 - gemfiles/que_beta.gemfile
 - gemfiles/rails-3.2.gemfile
-- gemfiles/rails-4.0.gemfile
-- gemfiles/rails-4.1.gemfile
 - gemfiles/rails-4.2.gemfile
 - gemfiles/rails-5.0.gemfile
 - gemfiles/rails-5.1.gemfile
@@ -241,6 +239,7 @@ files:
 - lib/appsignal/integrations/rake.rb
 - lib/appsignal/integrations/redis.rb
 - lib/appsignal/integrations/resque.rb
+- lib/appsignal/integrations/sidekiq.rb
 - lib/appsignal/integrations/sinatra.rb
 - lib/appsignal/integrations/unicorn.rb
 - lib/appsignal/integrations/webmachine.rb
@@ -326,6 +325,7 @@ files:
 - spec/lib/appsignal/integrations/padrino_spec.rb
 - spec/lib/appsignal/integrations/que_spec.rb
 - spec/lib/appsignal/integrations/railtie_spec.rb
+- spec/lib/appsignal/integrations/sidekiq_spec.rb
 - spec/lib/appsignal/integrations/sinatra_spec.rb
 - spec/lib/appsignal/integrations/webmachine_spec.rb
 - spec/lib/appsignal/logger_spec.rb
@@ -404,14 +404,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '1.9'
+      version: '2.0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
-rubygems_version: 3.2.6
+rubygems_version: 3.2.16
 signing_key:
 specification_version: 4
 summary: Logs performance and exception data from your app to appsignal.com
@@ -473,6 +473,7 @@ test_files:
 - spec/lib/appsignal/integrations/padrino_spec.rb
 - spec/lib/appsignal/integrations/que_spec.rb
 - spec/lib/appsignal/integrations/railtie_spec.rb
+- spec/lib/appsignal/integrations/sidekiq_spec.rb
 - spec/lib/appsignal/integrations/sinatra_spec.rb
 - spec/lib/appsignal/integrations/webmachine_spec.rb
 - spec/lib/appsignal/logger_spec.rb

data/gemfiles/rails-4.0.gemfile

@@ -1,6 +0,0 @@
-source 'https://rubygems.org'
-
-gem 'rails', '~> 4.0.0'
-gem 'mime-types', '~> 2.6'
-
-gemspec :path => '../'

data/gemfiles/rails-4.1.gemfile

@@ -1,6 +0,0 @@
-source 'https://rubygems.org'
-
-gem 'rails', '~> 4.1.0'
-gem 'mime-types', '~> 2.6'
-
-gemspec :path => '../'