appsignal 2.9.5-java → 2.9.6-java

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: effa13f4712da9135dbc3c18772b32247582744e1cf88ac17c9ef42606f7e48a
-  data.tar.gz: 462d6bcfa88907d7e22b1d9f462c07cbc6b730d4b71e9dfc56d4ae67906223cd
+  metadata.gz: 92a3e8d10cd1fdf02f0ba5fc2083cc3524a3f3b3882e1e1686df719ca1280473
+  data.tar.gz: 8a92cc47146720f2ba0bd8be84190577b9717c8f6d0ee39cfe28727efb59de9d
 SHA512:
-  metadata.gz: ba076205d8671f8fdaf2c9581ec23a0ff4c08f4b2b9bf26afe81e2481ede99cb17ae5b95b83db344fbc61df13f58213ad11c0b99aee4f5731be5155e5faa356c
-  data.tar.gz: 00b290c9140898b039d2d66e43386ed23d8248d27675f43178c489356e96cf6911d5d585c9432898d4685f0772f4556f28bcbe0a44418480ccb51859a3c62cf5
+  metadata.gz: f20caec585b2f0eb8c705cfd3d6c9ac26e44840a42d960f642d6b268f374f1ebd16f672c2d5d54343e65b4ec43b0e525416662fda735168d6297f50484460e2a
+  data.tar.gz: fc1859e2c96b8a36fc4aef021f5702e1082d54866817a1f234b0f080f843f7cfa7df5abd923fa1fbe60507522b0a600f165a7d7e0bc9297921f596378590a818

data/.travis.yml

@@ -11,15 +11,16 @@ branches:
 language: ruby
 cache:
   directories:
-  - vendor/bundle
+  - "$TRAVIS_BUILD_DIR/vendor/cache"
 env:
   global:
+  - BUNDLE_PATH=$TRAVIS_BUILD_DIR/vendor/cache
   - RUNNING_IN_CI=true
   - RAILS_ENV=test
   - JRUBY_OPTS=''
 before_install:
 - "./support/install_deps"
-install: "./support/bundler_wrapper install --jobs=3 --retry=3"
+install: "./support/bundler_wrapper install --jobs=3 --retry=3 --path=${BUNDLE_PATH:-$TRAVIS_BUILD_DIR/vendor/cache}"
 before_script:
 - "./support/bundler_wrapper exec rake extension:install"
 script: "./support/bundler_wrapper exec rake test"

data/CHANGELOG.md

@@ -1,6 +1,13 @@
 # Changelog
 
+## 2.9.6
+- Print link to diagnose docs on unsuccessful demo command. PR #512
+- Add support for minutely probe `.dependencies_present?` check. PR #523
+- Do not activate Sidekiq minutely probe on unsupported Redis gem versions.
+  PR #523.
+
 ## 2.9.5
+- Improve logging in minutely probes. PR #508
 - Delay the first minutely probe for a bit, since it might take some
   time for dependencies to initialize. PR #511
 

data/README.md

@@ -267,6 +267,8 @@ we send a package to so far on our [Stroopwafles page][waffles-page].
 AppSignal. They will help you get set up, tweak your code and make sure you get
 the most out of using AppSignal.
 
+Also see our [SUPPORT.md file](SUPPORT.md).
+
 [appsignal]: https://appsignal.com
 [appsignal-sign-up]: https://appsignal.com/users/sign_up
 [contact]: mailto:support@appsignal.com

data/Rakefile

@@ -214,7 +214,7 @@ namespace :publish do
     Dir.chdir("#{File.dirname(__FILE__)}/pkg") do
       Dir["*.gem"].each do |gem_package|
         puts "## Publishing gem package: #{gem_package}"
-        puts `gem push #{gem_package}`
+        system "gem push #{gem_package}"
       end
     end
   end

data/SUPPORT.md

@@ -0,0 +1,16 @@
+# Support
+
+[Contact us][contact] and speak directly with the engineers working on
+AppSignal. They will help you get set up, tweak your code and make sure you get
+the most out of using AppSignal. You can also find our documentation at
+[docs.appsignal.com](https://docs.appsignal.com/).
+
+We do not recommend creating an issue on the Ruby gem's GitHub project if it
+concerns your private app data. During the support process we'll need the
+AppSignal logs and other resources that contain your app's private data,
+something for which the public GitHub issue tracker is not suited.
+
+Please contact us on our website [appsignal.com](https://appsignal.com/) or via
+email at [support@appsignal.com][contact].
+
+[contact]: mailto:support@appsignal.com

data/build_matrix.yml

@@ -9,17 +9,18 @@ travis: # Default `.travis.yml` contents
   language: ruby
   cache:
     directories:
-      - vendor/bundle
+      - "$TRAVIS_BUILD_DIR/vendor/cache"
 
   env:
     global:
+      - "BUNDLE_PATH=$TRAVIS_BUILD_DIR/vendor/cache"
       - "RUNNING_IN_CI=true"
       - "RAILS_ENV=test"
       - "JRUBY_OPTS=''" # Workaround https://github.com/travis-ci/travis-ci/issues/6471
 
   before_install:
     - "./support/install_deps"
-  install: "./support/bundler_wrapper install --jobs=3 --retry=3"
+  install: "./support/bundler_wrapper install --jobs=3 --retry=3 --path=${BUNDLE_PATH:-$TRAVIS_BUILD_DIR/vendor/cache}"
   before_script:
     - "./support/bundler_wrapper exec rake extension:install"
   script: "./support/bundler_wrapper exec rake test"

data/lib/appsignal/cli/demo.rb

@@ -54,8 +54,11 @@ module Appsignal
             puts "Demonstration sample data sent!"
             puts "It may take about a minute for the data to appear on https://appsignal.com/accounts"
           else
-            puts "Error: Unable to start the AppSignal agent and send data to AppSignal.com"
-            puts "Please use `appsignal diagnose` to debug your configuration."
+            puts "\nError: Unable to start the AppSignal agent and send data to AppSignal.com."
+            puts "Please use the diagnose command (https://docs.appsignal.com/ruby/command-line/diagnose.html) to debug your configuration:"
+            puts
+            puts "    bundle exec appsignal diagnose --environment=production"
+            puts
             exit 1
           end
         end

data/lib/appsignal/hooks/sidekiq.rb

@@ -25,6 +25,10 @@ module Appsignal
     class SidekiqProbe
       attr_reader :config
 
+      def self.dependencies_present?
+        Gem::Version.new(Redis::VERSION) >= Gem::Version.new("3.3.5")
+      end
+
       def initialize(config = {})
         @config = config
         @cache = {}

data/lib/appsignal/minutely.rb

@@ -140,13 +140,13 @@ module Appsignal
           sleep initial_wait_time
           loop do
             logger = Appsignal.logger
-            logger.debug("Gathering minutely metrics with #{probes.count} probes")
+            logger.debug("Gathering minutely metrics with #{probe_instances.count} probes")
             probe_instances.each do |name, probe|
               begin
                 logger.debug("Gathering minutely metrics with '#{name}' probe")
                 probe.call
               rescue => ex
-                logger.error "Error in minutely probe '#{name}': #{ex}\n"
+                logger.error "Error in minutely probe '#{name}': #{ex}"
                 logger.debug ex.backtrace.join("\n")
               end
             end
@@ -176,11 +176,27 @@ module Appsignal
 
       def initialize_probes
         probes.each do |name, probe|
-          instance = probe.respond_to?(:new) ? probe.new : probe
+          if probe.respond_to? :new
+            instance = probe.new
+            klass = probe
+          else
+            instance = probe
+            klass = instance.class
+          end
+          unless dependencies_present?(klass)
+            Appsignal.logger.debug "Skipping '#{name}' probe, " \
+              "#{klass}.dependency_present? returned falsy"
+            next
+          end
           probe_instances[name] = instance
         end
       end
 
+      def dependencies_present?(probe)
+        return true unless probe.respond_to? :dependencies_present?
+        probe.dependencies_present?
+      end
+
       def probe_instances
         @@probe_instances ||= {}
       end

data/lib/appsignal/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Appsignal
-  VERSION = "2.9.5".freeze
+  VERSION = "2.9.6".freeze
 end

data/spec/lib/appsignal/config_spec.rb

@@ -479,7 +479,7 @@ describe Appsignal::Config do
 
     it "writes the current config to environment variables" do
       expect(ENV["_APPSIGNAL_ACTIVE"]).to                       eq "true"
-      expect(ENV["_APPSIGNAL_APP_PATH"]).to                     end_with("spec/support/project_fixture")
+      expect(ENV["_APPSIGNAL_APP_PATH"]).to                     end_with("spec/support/fixtures/projects/valid")
       expect(ENV["_APPSIGNAL_AGENT_PATH"]).to                   end_with("/ext")
       expect(ENV["_APPSIGNAL_DEBUG_LOGGING"]).to                eq "false"
       expect(ENV["_APPSIGNAL_LOG"]).to                          eq "stdout"

data/spec/lib/appsignal/hooks/active_support_notifications_spec.rb

@@ -30,6 +30,20 @@ describe Appsignal::Hooks::ActiveSupportNotificationsHook do
       expect(return_value).to eq "value"
     end
 
+    it "instruments an ActiveSupport::Notifications.instrument event with no registered formatter" do
+      expect(Appsignal::Transaction.current).to receive(:start_event)
+        .at_least(:once)
+      expect(Appsignal::Transaction.current).to receive(:finish_event)
+        .at_least(:once)
+        .with("no-registered.formatter", nil, nil, nil)
+
+      return_value = as.instrument("no-registered.formatter", :key => "something") do
+        "value"
+      end
+
+      expect(return_value).to eq "value"
+    end
+
     it "should convert non-string names to strings" do
       expect(Appsignal::Transaction.current).to receive(:start_event)
         .at_least(:once)

data/spec/lib/appsignal/hooks/sidekiq_spec.rb

@@ -665,6 +665,30 @@ describe Appsignal::Hooks::SidekiqProbe do
     end
     after { Object.send(:remove_const, "Sidekiq") }
 
+    describe ".dependencies_present?" do
+      before do
+        class Redis; end
+        Redis.const_set(:VERSION, version)
+      end
+      after { Object.send(:remove_const, "Redis") }
+
+      context "when Redis version is < 3.3.5" do
+        let(:version) { "3.3.4" }
+
+        it "does not start probe" do
+          expect(described_class.dependencies_present?).to be_falsy
+        end
+      end
+
+      context "when Redis version is >= 3.3.5" do
+        let(:version) { "3.3.5" }
+
+        it "does not start probe" do
+          expect(described_class.dependencies_present?).to be_truthy
+        end
+      end
+    end
+
     it "loads Sidekiq::API" do
       expect(defined?(Sidekiq::API)).to be_falsy
       probe

data/spec/lib/appsignal/minutely_spec.rb

@@ -19,6 +19,18 @@ describe Appsignal::Minutely do
       end
     end
 
+    class ProbeWithoutDependency < Probe
+      def self.dependencies_present?
+        true
+      end
+    end
+
+    class ProbeWithMissingDependency < Probe
+      def self.dependencies_present?
+        false
+      end
+    end
+
     class BrokenProbe < Probe
       def call
         super
@@ -31,14 +43,8 @@ describe Appsignal::Minutely do
     before do
       Appsignal.logger = test_logger(log_stream)
       # Speed up test time
-      expect(Appsignal::Minutely).to receive(:initial_wait_time)
-        .ordered
-        .once
-        .and_return(0.001)
-      expect(Appsignal::Minutely).to receive(:wait_time)
-        .ordered
-        .at_least(:once)
-        .and_return(0.001)
+      allow(Appsignal::Minutely).to receive(:initial_wait_time).and_return(0.001)
+      allow(Appsignal::Minutely).to receive(:wait_time).and_return(0.001)
     end
 
     context "with an instance of a class" do
@@ -51,6 +57,24 @@ describe Appsignal::Minutely do
         expect(log).to contains_log(:debug, "Gathering minutely metrics with 1 probe")
         expect(log).to contains_log(:debug, "Gathering minutely metrics with 'my_probe' probe")
       end
+
+      context "when dependency requirement is not met" do
+        it "does not initialize the probe" do
+          # Working probe which we can use to wait for X ticks
+          working_probe = ProbeWithoutDependency.new
+          Appsignal::Minutely.probes.register :probe_without_dep, working_probe
+
+          probe = ProbeWithMissingDependency.new
+          Appsignal::Minutely.probes.register :probe_with_missing_dep, probe
+          Appsignal::Minutely.start
+
+          wait_for("enough probe calls") { working_probe.calls >= 2 }
+          # Only counts initialized probes
+          expect(log).to contains_log(:debug, "Gathering minutely metrics with 1 probe")
+          expect(log).to contains_log :debug, "Skipping 'probe_with_missing_dep' probe, " \
+            "ProbeWithMissingDependency.dependency_present? returned falsy"
+        end
+      end
     end
 
     context "with probe class" do
@@ -65,6 +89,26 @@ describe Appsignal::Minutely do
         expect(log).to contains_log(:debug, "Gathering minutely metrics with 1 probe")
         expect(log).to contains_log(:debug, "Gathering minutely metrics with 'my_probe' probe")
       end
+
+      context "when dependency requirement is not met" do
+        it "does not initialize the probe" do
+          # Working probe which we can use to wait for X ticks
+          working_probe = ProbeWithoutDependency
+          working_probe_instance = working_probe.new
+          expect(working_probe).to receive(:new).and_return(working_probe_instance)
+          Appsignal::Minutely.probes.register :probe_without_dep, working_probe
+
+          probe = ProbeWithMissingDependency
+          Appsignal::Minutely.probes.register :probe_with_missing_dep, probe
+          Appsignal::Minutely.start
+
+          wait_for("enough probe calls") { working_probe_instance.calls >= 2 }
+          # Only counts initialized probes
+          expect(log).to contains_log(:debug, "Gathering minutely metrics with 1 probe")
+          expect(log).to contains_log :debug, "Skipping 'probe_with_missing_dep' probe, " \
+            "ProbeWithMissingDependency.dependency_present? returned falsy"
+        end
+      end
     end
 
     context "with a lambda" do
@@ -101,9 +145,6 @@ describe Appsignal::Minutely do
     end
 
     it "ensures only one minutely probes thread is active at a time" do
-      # Starting twice in this spec, so expecting it more than once
-      expect(Appsignal::Minutely).to receive(:initial_wait_time).at_least(:once).and_return(0.001)
-
       alive_thread_counter = proc { Thread.list.reject { |t| t.status == "dead" }.length }
       probe = Probe.new
       Appsignal::Minutely.probes.register :my_probe, probe
@@ -112,8 +153,13 @@ describe Appsignal::Minutely do
       end.to change { alive_thread_counter.call }.by(1)
 
       wait_for("enough probe calls") { probe.calls >= 2 }
+      expect(Appsignal::Minutely).to have_received(:initial_wait_time).once
+      expect(Appsignal::Minutely).to have_received(:wait_time).at_least(:once)
       expect(log).to contains_log(:debug, "Gathering minutely metrics with 1 probe")
       expect(log).to contains_log(:debug, "Gathering minutely metrics with 'my_probe' probe")
+
+      # Starting twice in this spec, so expecting it more than once
+      expect(Appsignal::Minutely).to have_received(:initial_wait_time).once
       expect do
         # Fetch old thread
         thread = Appsignal::Minutely.class_variable_get(:@@thread)

data/spec/support/helpers/config_helpers.rb

@@ -1,7 +1,7 @@
 module ConfigHelpers
   def project_fixture_path
     File.expand_path(
-      File.join(File.dirname(__FILE__), "../project_fixture")
+      File.join(File.dirname(__FILE__), "../fixtures/projects/valid")
     )
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appsignal
 version: !ruby/object:Gem::Version
-  version: 2.9.5
+  version: 2.9.6
 platform: java
 authors:
 - Robert Beekman
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-10 00:00:00.000000000 Z
+date: 2019-04-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -158,6 +158,7 @@ files:
 - LICENSE
 - README.md
 - Rakefile
+- SUPPORT.md
 - appsignal.gemspec
 - benchmark.rake
 - bin/appsignal
@@ -338,12 +339,13 @@ files:
 - spec/lib/appsignal/utils/query_params_sanitizer_spec.rb
 - spec/lib/appsignal_spec.rb
 - spec/spec_helper.rb
-- spec/support/fixtures/containers/cgroups/docker
-- spec/support/fixtures/containers/cgroups/docker_systemd
-- spec/support/fixtures/containers/cgroups/lxc
-- spec/support/fixtures/containers/cgroups/no_permission
-- spec/support/fixtures/containers/cgroups/none
 - spec/support/fixtures/generated_config.yml
+- spec/support/fixtures/projects/valid/config/application.rb
+- spec/support/fixtures/projects/valid/config/appsignal.yml
+- spec/support/fixtures/projects/valid/config/environments/development.rb
+- spec/support/fixtures/projects/valid/config/environments/production.rb
+- spec/support/fixtures/projects/valid/config/environments/test.rb
+- spec/support/fixtures/projects/valid/log/.gitkeep
 - spec/support/fixtures/uploaded_file.txt
 - spec/support/helpers/api_request_helper.rb
 - spec/support/helpers/cli_helpers.rb
@@ -361,12 +363,6 @@ files:
 - spec/support/matchers/contains_log.rb
 - spec/support/mocks/fake_gc_profiler.rb
 - spec/support/mocks/mock_extension.rb
-- spec/support/project_fixture/config/application.rb
-- spec/support/project_fixture/config/appsignal.yml
-- spec/support/project_fixture/config/environments/development.rb
-- spec/support/project_fixture/config/environments/production.rb
-- spec/support/project_fixture/config/environments/test.rb
-- spec/support/project_fixture/log/.gitkeep
 - spec/support/rails/my_app.rb
 - spec/support/shared_examples/instrument.rb
 - spec/support/stubs/delayed_job.rb
@@ -393,8 +389,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.2
 signing_key: 
 specification_version: 4
 summary: Logs performance and exception data from your app to appsignal.com
@@ -470,12 +465,13 @@ test_files:
 - spec/lib/appsignal/utils/query_params_sanitizer_spec.rb
 - spec/lib/appsignal_spec.rb
 - spec/spec_helper.rb
-- spec/support/fixtures/containers/cgroups/docker
-- spec/support/fixtures/containers/cgroups/docker_systemd
-- spec/support/fixtures/containers/cgroups/lxc
-- spec/support/fixtures/containers/cgroups/no_permission
-- spec/support/fixtures/containers/cgroups/none
 - spec/support/fixtures/generated_config.yml
+- spec/support/fixtures/projects/valid/config/application.rb
+- spec/support/fixtures/projects/valid/config/appsignal.yml
+- spec/support/fixtures/projects/valid/config/environments/development.rb
+- spec/support/fixtures/projects/valid/config/environments/production.rb
+- spec/support/fixtures/projects/valid/config/environments/test.rb
+- spec/support/fixtures/projects/valid/log/.gitkeep
 - spec/support/fixtures/uploaded_file.txt
 - spec/support/helpers/api_request_helper.rb
 - spec/support/helpers/cli_helpers.rb
@@ -493,12 +489,6 @@ test_files:
 - spec/support/matchers/contains_log.rb
 - spec/support/mocks/fake_gc_profiler.rb
 - spec/support/mocks/mock_extension.rb
-- spec/support/project_fixture/config/application.rb
-- spec/support/project_fixture/config/appsignal.yml
-- spec/support/project_fixture/config/environments/development.rb
-- spec/support/project_fixture/config/environments/production.rb
-- spec/support/project_fixture/config/environments/test.rb
-- spec/support/project_fixture/log/.gitkeep
 - spec/support/rails/my_app.rb
 - spec/support/shared_examples/instrument.rb
 - spec/support/stubs/delayed_job.rb

data/spec/support/fixtures/containers/cgroups/docker

@@ -1,14 +0,0 @@
-14:name=systemd:/docker/0c703b75cdeaad7c933aa68b4678cc5c37a12d5ef5d7cb52c9cefe684d98e575
-13:pids:/docker/0c703b75cdeaad7c933aa68b4678cc5c37a12d5ef5d7cb52c9cefe684d98e575
-12:hugetlb:/docker/0c703b75cdeaad7c933aa68b4678cc5c37a12d5ef5d7cb52c9cefe684d98e575
-11:net_prio:/docker/0c703b75cdeaad7c933aa68b4678cc5c37a12d5ef5d7cb52c9cefe684d98e575
-10:perf_event:/docker/0c703b75cdeaad7c933aa68b4678cc5c37a12d5ef5d7cb52c9cefe684d98e575
-9:net_cls:/docker/0c703b75cdeaad7c933aa68b4678cc5c37a12d5ef5d7cb52c9cefe684d98e575
-8:freezer:/docker/0c703b75cdeaad7c933aa68b4678cc5c37a12d5ef5d7cb52c9cefe684d98e575
-7:devices:/docker/0c703b75cdeaad7c933aa68b4678cc5c37a12d5ef5d7cb52c9cefe684d98e575
-6:memory:/docker/0c703b75cdeaad7c933aa68b4678cc5c37a12d5ef5d7cb52c9cefe684d98e575
-5:blkio:/docker/0c703b75cdeaad7c933aa68b4678cc5c37a12d5ef5d7cb52c9cefe684d98e575
-4:cpuacct:/docker/0c703b75cdeaad7c933aa68b4678cc5c37a12d5ef5d7cb52c9cefe684d98e575
-3:cpu:/docker/0c703b75cdeaad7c933aa68b4678cc5c37a12d5ef5d7cb52c9cefe684d98e575
-2:cpuset:/docker/0c703b75cdeaad7c933aa68b4678cc5c37a12d5ef5d7cb52c9cefe684d98e575
-1:name=openrc:/docker

data/spec/support/fixtures/containers/cgroups/docker_systemd

@@ -1,8 +0,0 @@
-8:net_cls:/system.slice/docker-09f1c4d420025670a3633edbc9b31450f1d6b2ff87b5912a10c320ad398c7215.scope
-7:freezer:/system.slice/docker-09f1c4d420025670a3633edbc9b31450f1d6b2ff87b5912a10c320ad398c7215.scope
-6:devices:/system.slice/docker-09f1c4d420025670a3633edbc9b31450f1d6b2ff87b5912a10c320ad398c7215.scope
-5:memory:/system.slice/docker-09f1c4d420025670a3633edbc9b31450f1d6b2ff87b5912a10c320ad398c7215.scope
-4:blkio:/system.slice/docker-09f1c4d420025670a3633edbc9b31450f1d6b2ff87b5912a10c320ad398c7215.scope
-3:cpu,cpuacct:/system.slice/docker-09f1c4d420025670a3633edbc9b31450f1d6b2ff87b5912a10c320ad398c7215.scope
-2:cpuset:/system.slice/docker-09f1c4d420025670a3633edbc9b31450f1d6b2ff87b5912a10c320ad398c7215.scope
-1:name=openrc:/system.slice/docker-09f1c4d420025670a3633edbc9b31450f1d6b2ff87b5912a10c320ad398c7215.scope

data/spec/support/fixtures/containers/cgroups/lxc

@@ -1,10 +0,0 @@
-11:name=systemd:/lxc/1a2e485e-3947-4bb6-8c24-8774f0859648
-10:hugetlb:/lxc/1a2e485e-3947-4bb6-8c24-8774f0859648
-9:perf_event:/lxc/1a2e485e-3947-4bb6-8c24-8774f0859648
-8:blkio:/lxc/1a2e485e-3947-4bb6-8c24-8774f0859648
-7:freezer:/lxc/1a2e485e-3947-4bb6-8c24-8774f0859648
-6:devices:/lxc/1a2e485e-3947-4bb6-8c24-8774f0859648
-5:memory:/lxc/1a2e485e-3947-4bb6-8c24-8774f0859648
-4:cpuacct:/lxc/1a2e485e-3947-4bb6-8c24-8774f0859648
-3:cpu:/lxc/1a2e485e-3947-4bb6-8c24-8774f0859648
-2:cpuset:/lxc/1a2e485e-3947-4bb6-8c24-8774f0859648

data/spec/support/fixtures/containers/cgroups/none

@@ -1 +0,0 @@
-2:name=systemd:/user/0.user/1.session