appsignal 2.8.4.beta.1-java → 2.8.4-java

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 89bf9c6f5a93f01db3a5b50e68b02492dfb36b6ee5af1b9188c5dc8af98ca2a4
-  data.tar.gz: bb171143986af96d4f40f29961abfa8812e80297f37ec5a79de9940a2db24249
+  metadata.gz: a6c51056cc45697339edad0c7229bea1d7097fc4e7c339197fcd4a41c65b9ba2
+  data.tar.gz: fb18f33d2c554adeea7181b36e0eb9dc3556a7d165e67b7a3e827586c42ca845
 SHA512:
-  metadata.gz: bfdd988fe0b33d6aea24d2758bf4cd269292277fe3d00373360f870a1af1b53ed26a7fddaac6260f29caa016e7b43e8fab5ac7ded847a5188d168b055c9637a2
-  data.tar.gz: 7c0ce94dcd2b9948d0def579bfc89651496e439b1d62b962867b2805430bc8a036f37d648d1fb19305b99910cd43f59745bff0b53327f11e12e3b6dd419a10ed
+  metadata.gz: fe31ea0e9ce501ab473a0813d81c1d5191ddbc5fc99265633393a497d8a89aa7cf6e19778fa0ceda621c5eac0fbedc12176caf6f80eb3879638a60419075bfda
+  data.tar.gz: 3e1c72e0b453e4aa2d758efa511aff1735039dd442121f00dba87ef52b04912c031400dc6acd52e35920c55244f05dd41afd118953e4b14958d0381a198888da

data/CHANGELOG.md

@@ -1,5 +1,7 @@
 # 2.8.4
-- Log memory usage of agent if high
+- Log memory usage of agent if high.
+  Commit 46cf3770e13eff9f5fccbf8a4525a8dbfd8eeaad
+- Fix `Appsignal::Transaction.pause!`. PR #482
 
 # 2.8.3
 - Fix multi user permission issue for agent directories and files.

data/lib/appsignal.rb

@@ -752,7 +752,7 @@ module Appsignal
     end
     deprecate :is_ignored_action?, :none, 2017, 3
 
-    # Convenience method for skipping instrumentations around a block of code.
+    # Convenience method for skipping instrumentation around a block of code.
     #
     # @example
     #   Appsignal.without_instrumentation do

data/lib/appsignal/transaction.rb

@@ -277,10 +277,12 @@ module Appsignal
     alias_method :add_exception, :set_error
 
     def start_event
+      return if paused?
       @ext.start_event(self.class.garbage_collection_profiler.total_time)
     end
 
     def finish_event(name, title, body, body_format = Appsignal::EventFormatter::DEFAULT)
+      return if paused?
       @ext.finish_event(
         name,
         title || BLANK,
@@ -291,6 +293,7 @@ module Appsignal
     end
 
     def record_event(name, title, body, duration, body_format = Appsignal::EventFormatter::DEFAULT)
+      return if paused?
       @ext.record_event(
         name,
         title || BLANK,

data/lib/appsignal/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Appsignal
-  VERSION = "2.8.4.beta.1".freeze
+  VERSION = "2.8.4".freeze
 end

data/spec/lib/appsignal/transaction_spec.rb

@@ -214,7 +214,7 @@ describe Appsignal::Transaction do
 
   context "pausing" do
     describe "#pause!" do
-      it "should change the pause flag to true" do
+      it "changes the pause flag to true" do
         expect do
           transaction.pause!
         end.to change(transaction, :paused).from(false).to(true)
@@ -224,7 +224,7 @@ describe Appsignal::Transaction do
     describe "#resume!" do
       before { transaction.pause! }
 
-      it "should change the pause flag to false" do
+      it "changes the pause flag to false" do
         expect do
           transaction.resume!
         end.to change(transaction, :paused).from(true).to(false)
@@ -232,14 +232,16 @@ describe Appsignal::Transaction do
     end
 
     describe "#paused?" do
-      it "should return the pause state" do
-        expect(transaction.paused?).to be_falsy
+      context "when not paused" do
+        it "return false" do
+          expect(transaction.paused?).to be_falsy
+        end
       end
 
       context "when paused" do
         before { transaction.pause! }
 
-        it "should return the pause state" do
+        it "returns true" do
           expect(transaction.paused?).to be_truthy
         end
       end
@@ -690,11 +692,20 @@ describe Appsignal::Transaction do
     end
 
     describe "#start_event" do
-      it "should start the event in the extension" do
+      it "starts the event in the extension" do
         expect(transaction.ext).to receive(:start_event).with(0).and_call_original
 
         transaction.start_event
       end
+
+      context "when transaction is paused" do
+        it "does not start the event" do
+          transaction.pause!
+          expect(transaction.ext).to_not receive(:start_event)
+
+          transaction.start_event
+        end
+      end
     end
 
     describe "#finish_event" do
@@ -737,6 +748,15 @@ describe Appsignal::Transaction do
           nil
         )
       end
+
+      context "when transaction is paused" do
+        it "does not finish the event" do
+          transaction.pause!
+          expect(transaction.ext).to_not receive(:finish_event)
+
+          transaction.start_event
+        end
+      end
     end
 
     describe "#record_event" do
@@ -783,6 +803,21 @@ describe Appsignal::Transaction do
           nil
         )
       end
+
+      context "when transaction is paused" do
+        it "does not record the event" do
+          transaction.pause!
+          expect(transaction.ext).to_not receive(:record_event)
+
+          transaction.record_event(
+            "name",
+            nil,
+            nil,
+            1000,
+            nil
+          )
+        end
+      end
     end
 
     describe "#instrument" do

data/spec/lib/appsignal_spec.rb

@@ -831,25 +831,25 @@ describe Appsignal do
     end
 
     describe ".without_instrumentation" do
-      let(:transaction) { double }
+      let(:transaction) { http_request_transaction }
       before { allow(Appsignal::Transaction).to receive(:current).and_return(transaction) }
 
-      it "should pause and unpause the transaction around the block" do
-        expect(transaction).to receive(:pause!)
-        expect(transaction).to receive(:resume!)
+      it "does not record events on the transaction" do
+        expect(transaction).to receive(:pause!).and_call_original
+        expect(transaction).to receive(:resume!).and_call_original
+        Appsignal.instrument("register.this.event") { :do_nothing }
+        Appsignal.without_instrumentation do
+          Appsignal.instrument("dont.register.this.event") { :do_nothing }
+        end
+        expect(transaction.to_h["events"].map { |e| e["name"] })
+          .to match_array("register.this.event")
       end
 
       context "without transaction" do
         let(:transaction) { nil }
 
         it "should not crash" do
-          # just execute the after block
-        end
-      end
-
-      after do
-        Appsignal.without_instrumentation do
-          # nothing
+          Appsignal.without_instrumentation { :do_nothing }
         end
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appsignal
 version: !ruby/object:Gem::Version
-  version: 2.8.4.beta.1
+  version: 2.8.4
 platform: java
 authors:
 - Robert Beekman
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-22 00:00:00.000000000 Z
+date: 2019-02-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -384,12 +384,11 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '1.9'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.2
 signing_key: 
 specification_version: 4
 summary: Logs performance and exception data from your app to appsignal.com