appsignal 2.7.0 → 2.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d828cca6d5a9ec2b478a06c63a55a036f546d9ff0b725353ef43c377b012bf62
-  data.tar.gz: 7d0f98c13409d78b7a5c0888c5d0e6ae9d56fd384f47d55c7a731c8a071d4b76
+  metadata.gz: 958814ee490ee3e9939d056c6733eb198613a1411e55b21d66d530ed9168c8ef
+  data.tar.gz: 4d1043dbf6f6ce145378068b00e71f9d7041017a32631e2e6ab061e38bfa5e89
 SHA512:
-  metadata.gz: caaca0b6b43feefd2c340071599fb68c6a583d7f47cdbf8d0307772e59306b0d88b6b08c5fccf1f407661794c787b71711f45a2d53e4f936f3c7f7a22861069f
-  data.tar.gz: 7093e7a762e3b34998ae9ab1476c75bbb5696ddbc50e33696db4c63477fdb489ee87b5a074b8558e8a11bbce7649e6d09ddeca26b7c92c515ad84c9b52cf2594
+  metadata.gz: 1b96e28295754d5fad3010b714fc7d594ec732ab0b15d22f61db5320ee9563dd9155ff7e4bd7fa1ea632933ba90e11f1a665f3d353102be2e35a2f549152e46e
+  data.tar.gz: 042da1fbb9c27a823638d78e38d231bd9f34dd59621c17b7ac029fdcf6df24335f4b07614adecea8e77224e9499486325c609054e0e139389905d793cebe1802

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+# 2.7.1
+- Improve error log on unsupported architecture and build combination on
+  install. PR #426
+- Improve performance when garbage collection profiling is disabled. PR #429
+
 # 2.7.0
 - Detect Kubernetes containers as containers for `running_in_container`
   config option. Commit 60822aac24ccc394df073091c64f05096455942d.

data/ext/Rakefile

@@ -15,6 +15,7 @@ task :default do
         ) &&
         File.exist?(ext_path("appsignal.h"))
       archive = download_archive(arch_config, "dynamic")
+      next unless archive
       next unless verify_archive(archive, arch_config, "dynamic")
       unarchive(archive)
     end

data/ext/base.rb

@@ -36,7 +36,7 @@ def write_agent_architecture
 end
 
 def check_architecture
-  if AGENT_CONFIG["triples"].keys.include?(ARCH)
+  if AGENT_CONFIG["triples"].key?(ARCH)
     true
   else
     installation_failed(
@@ -48,8 +48,18 @@ def check_architecture
 end
 
 def download_archive(arch_config, type)
-  logger.info "Downloading agent release from #{arch_config[type]["download_url"]}"
-  open(arch_config[type]["download_url"], :ssl_ca_cert => CA_CERT_PATH)
+  if arch_config.key?(type)
+    logger.info "Downloading agent release from #{arch_config[type]["download_url"]}"
+    open(arch_config[type]["download_url"], :ssl_ca_cert => CA_CERT_PATH)
+  else
+    installation_failed(
+      "AppSignal currently does not support your system. " \
+      "Expected config for architecture '#{ARCH}' and package type '#{type}', but none found. " \
+      "For a full list of supported systems visit: " \
+      "https://docs.appsignal.com/support/operating-systems.html"
+    )
+    false
+  end
 end
 
 def verify_archive(archive, arch_config, type)

data/ext/extconf.rb

@@ -11,6 +11,7 @@ def install
       File.exist?(ext_path("libappsignal.a")) &&
       File.exist?(ext_path("appsignal.h"))
     archive = download_archive(arch_config, "static")
+    return unless archive
     return unless verify_archive(archive, arch_config, "static")
     unarchive(archive)
   end

data/lib/appsignal/garbage_collection_profiler.rb

@@ -47,4 +47,15 @@ module Appsignal
       self.class.lock
     end
   end
+
+  # {Appsignal::NilGarbageCollectionProfiler} is a dummy profiler
+  # that always returns 0 as the total time.
+  # Used when we don't want any profile information
+  #
+  # @api private
+  class NilGarbageCollectionProfiler
+    def total_time
+      0
+    end
+  end
 end

data/lib/appsignal/transaction.rb

@@ -53,7 +53,8 @@ module Appsignal
       end
 
       def garbage_collection_profiler
-        @garbage_collection_profiler ||= Appsignal::GarbageCollectionProfiler.new
+        @garbage_collection_profiler ||=
+          Appsignal.config[:enable_gc_instrumentation] ? Appsignal::GarbageCollectionProfiler.new : NilGarbageCollectionProfiler.new
       end
     end
 

data/lib/appsignal/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Appsignal
-  VERSION = "2.7.0".freeze
+  VERSION = "2.7.1".freeze
 end

data/spec/lib/appsignal/garbage_collection_profiler_spec.rb

@@ -64,3 +64,13 @@ describe Appsignal::GarbageCollectionProfiler do
     end
   end
 end
+
+describe Appsignal::NilGarbageCollectionProfiler do
+  let(:profiler) { described_class.new }
+
+  describe "#total_time" do
+    it "has a total time of 0" do
+      expect(profiler.total_time).to eq(0)
+    end
+  end
+end

data/spec/lib/appsignal/transaction_spec.rb

@@ -672,6 +672,23 @@ describe Appsignal::Transaction do
       end
     end
 
+    describe "#garbage_collection_profiler" do
+      before { Appsignal::Transaction.instance_variable_set(:@garbage_collection_profiler, nil) }
+
+      it "returns the NilGarbageCollectionProfiler" do
+        expect(Appsignal::Transaction.garbage_collection_profiler).to be_a(Appsignal::NilGarbageCollectionProfiler)
+      end
+
+      context "when gc profiling is enabled" do
+        before { Appsignal.config.config_hash[:enable_gc_instrumentation] = true }
+        after { Appsignal.config.config_hash[:enable_gc_instrumentation] = false }
+
+        it "returns the GarbageCollectionProfiler" do
+          expect(Appsignal::Transaction.garbage_collection_profiler).to be_a(Appsignal::GarbageCollectionProfiler)
+        end
+      end
+    end
+
     describe "#start_event" do
       it "should start the event in the extension" do
         expect(transaction.ext).to receive(:start_event).with(0).and_call_original

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appsignal
 version: !ruby/object:Gem::Version
-  version: 2.7.0
+  version: 2.7.1
 platform: ruby
 authors:
 - Robert Beekman
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-13 00:00:00.000000000 Z
+date: 2018-09-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack