appsignal 2.7.0-java → 2.7.1-java

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6f7cd87796a7e264300c42c7bce8dee4b54a0d937df0cf939ca9945328d40183
-  data.tar.gz: 2de0ac030e5b42cc1d35df40b6e5910cdae4d6a5ccec64623b9413be8c1cf297
+  metadata.gz: fe59e0d41b1d389e33496fa1b7a0a34ab4d04f72e51a8f3a9c7afd827f1b52e8
+  data.tar.gz: 56db5cf916b132f78fb6d8ab1129a7b8d848dc3c9d420ac8b64d742c3420f0ba
 SHA512:
-  metadata.gz: 1c21d42b16b7121dc1287b930d0b507f46649ea89a93fdd0f922461185e3ebee647bb8ac699ada51ea03ade8c447004f68136b2b28723111a113a3005c6decda
-  data.tar.gz: 21a6a51677154b21867d215125845fea74b34a41c4b4a9f7240fa49211ffc9e4e1a569f9c3bf50a2dacce23301eca175938c867d8893481f57747285c9733edf
+  metadata.gz: 8aa281176c5797e7e916e19d8c07441d1b3e999d1cf2fff002eca5c747a5df90797f1a19fc3f3bc0b0f6d289f88c2ef89eebe2e4668888bf9087594b0b3a77d9
+  data.tar.gz: d420fad888ef6a017bb4424e346cda807a5a7d0ce780b93e57e362c4b2853eb3174655cf4b8d130649ba6969628836238f47880b0188e6151659fe5143cb9ea5

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+# 2.7.1
+- Improve error log on unsupported architecture and build combination on
+  install. PR #426
+- Improve performance when garbage collection profiling is disabled. PR #429
+
 # 2.7.0
 - Detect Kubernetes containers as containers for `running_in_container`
   config option. Commit 60822aac24ccc394df073091c64f05096455942d.

data/ext/Rakefile

@@ -15,6 +15,7 @@ task :default do
         ) &&
         File.exist?(ext_path("appsignal.h"))
       archive = download_archive(arch_config, "dynamic")
+      next unless archive
       next unless verify_archive(archive, arch_config, "dynamic")
       unarchive(archive)
     end

data/ext/base.rb

@@ -36,7 +36,7 @@ def write_agent_architecture
 end
 
 def check_architecture
-  if AGENT_CONFIG["triples"].keys.include?(ARCH)
+  if AGENT_CONFIG["triples"].key?(ARCH)
     true
   else
     installation_failed(
@@ -48,8 +48,18 @@ def check_architecture
 end
 
 def download_archive(arch_config, type)
-  logger.info "Downloading agent release from #{arch_config[type]["download_url"]}"
-  open(arch_config[type]["download_url"], :ssl_ca_cert => CA_CERT_PATH)
+  if arch_config.key?(type)
+    logger.info "Downloading agent release from #{arch_config[type]["download_url"]}"
+    open(arch_config[type]["download_url"], :ssl_ca_cert => CA_CERT_PATH)
+  else
+    installation_failed(
+      "AppSignal currently does not support your system. " \
+      "Expected config for architecture '#{ARCH}' and package type '#{type}', but none found. " \
+      "For a full list of supported systems visit: " \
+      "https://docs.appsignal.com/support/operating-systems.html"
+    )
+    false
+  end
 end
 
 def verify_archive(archive, arch_config, type)

data/ext/extconf.rb

@@ -11,6 +11,7 @@ def install
       File.exist?(ext_path("libappsignal.a")) &&
       File.exist?(ext_path("appsignal.h"))
     archive = download_archive(arch_config, "static")
+    return unless archive
     return unless verify_archive(archive, arch_config, "static")
     unarchive(archive)
   end

data/lib/appsignal/garbage_collection_profiler.rb

@@ -47,4 +47,15 @@ module Appsignal
       self.class.lock
     end
   end
+
+  # {Appsignal::NilGarbageCollectionProfiler} is a dummy profiler
+  # that always returns 0 as the total time.
+  # Used when we don't want any profile information
+  #
+  # @api private
+  class NilGarbageCollectionProfiler
+    def total_time
+      0
+    end
+  end
 end

data/lib/appsignal/transaction.rb

@@ -53,7 +53,8 @@ module Appsignal
       end
 
       def garbage_collection_profiler
-        @garbage_collection_profiler ||= Appsignal::GarbageCollectionProfiler.new
+        @garbage_collection_profiler ||=
+          Appsignal.config[:enable_gc_instrumentation] ? Appsignal::GarbageCollectionProfiler.new : NilGarbageCollectionProfiler.new
       end
     end
 

data/lib/appsignal/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Appsignal
-  VERSION = "2.7.0".freeze
+  VERSION = "2.7.1".freeze
 end

data/spec/lib/appsignal/garbage_collection_profiler_spec.rb

@@ -64,3 +64,13 @@ describe Appsignal::GarbageCollectionProfiler do
     end
   end
 end
+
+describe Appsignal::NilGarbageCollectionProfiler do
+  let(:profiler) { described_class.new }
+
+  describe "#total_time" do
+    it "has a total time of 0" do
+      expect(profiler.total_time).to eq(0)
+    end
+  end
+end

data/spec/lib/appsignal/transaction_spec.rb

@@ -672,6 +672,23 @@ describe Appsignal::Transaction do
       end
     end
 
+    describe "#garbage_collection_profiler" do
+      before { Appsignal::Transaction.instance_variable_set(:@garbage_collection_profiler, nil) }
+
+      it "returns the NilGarbageCollectionProfiler" do
+        expect(Appsignal::Transaction.garbage_collection_profiler).to be_a(Appsignal::NilGarbageCollectionProfiler)
+      end
+
+      context "when gc profiling is enabled" do
+        before { Appsignal.config.config_hash[:enable_gc_instrumentation] = true }
+        after { Appsignal.config.config_hash[:enable_gc_instrumentation] = false }
+
+        it "returns the GarbageCollectionProfiler" do
+          expect(Appsignal::Transaction.garbage_collection_profiler).to be_a(Appsignal::GarbageCollectionProfiler)
+        end
+      end
+    end
+
     describe "#start_event" do
       it "should start the event in the extension" do
         expect(transaction.ext).to receive(:start_event).with(0).and_call_original

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appsignal
 version: !ruby/object:Gem::Version
-  version: 2.7.0
+  version: 2.7.1
 platform: java
 authors:
 - Robert Beekman
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-08-13 00:00:00.000000000 Z
+date: 2018-09-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack