appsignal 2.3.1 → 2.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ed164d0e73d1000a37c8a10ee2e467f28c999228
-  data.tar.gz: daf2ae18da6c18f75f962aa4a3098fc1df1c2d8e
+  metadata.gz: d5aa85a93e18c0f2eaea8092efacae7a033f139b
+  data.tar.gz: 6cffdf6eacf9c4a7e25ec324b9e24e8638b05341
 SHA512:
-  metadata.gz: c650fb63e59abdfcc63b1ebed5bb447063ee9dbae4c051ecf70dc072ffc6dfd0dbf55a43522a07d17c8a724c966fa3e2483896dfd3beef2614593945bdcb257b
-  data.tar.gz: 1694a0a89dea32073445f3b939a384f0535983d32d8da0752dcba88d266bdc339033787cde8dd20d70841770dfcb23b0a9383e60e948d7c0fc4544a077706370
+  metadata.gz: f53eb19a35f673c2f6b79e8e9a20ccc20f09c9d604c1c4221284fa166b41fba0b1b55787ae8888092672a9fd5ffc822a8c2fb672ed385de345f90ba1ecf00072
+  data.tar.gz: 4813fbced178b4deded50623519c96e87b8d8382b1c8e8ba1bcf396758546999ba6c2e6ce35944f04e476725fad37b039b4c398b6c67e701ea8aa31c5c775514

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 2.3.2
+* Improve Rake argument handling. Allow for more detailed view of which
+  arguments a tasks receives. PR #328
+
 # 2.3.1
 * Fix ActiveSupport::Notifications hook not supporting non-string names for
   events. PR #324

data/lib/appsignal/cli/diagnose.rb

@@ -132,7 +132,8 @@ module Appsignal
             return
           end
 
-          puts "  Your diagnostics report has been sent to AppSignal."
+          puts "  Please email us at support@appsignal.com with the following"
+          puts "  support token."
           begin
             response_data = JSON.parse(response.body)
             puts "  Your support token: #{response_data["token"]}"

data/lib/appsignal/hooks/rake.rb

@@ -15,11 +15,15 @@ module Appsignal
           def execute(*args)
             execute_without_appsignal(*args)
           rescue => error
+            # Format given arguments and cast to hash if possible
+            params, _ = args
+            params = params.to_hash if params.respond_to?(:to_hash)
+
             transaction = Appsignal::Transaction.create(
               SecureRandom.uuid,
               Appsignal::Transaction::BACKGROUND_JOB,
               Appsignal::Transaction::GenericRequest.new(
-                :params => args
+                :params => params
               )
             )
             transaction.set_action(name)

data/lib/appsignal/version.rb

@@ -1,5 +1,5 @@
 require "yaml"
 
 module Appsignal
-  VERSION = "2.3.1".freeze
+  VERSION = "2.3.2".freeze
 end

data/spec/lib/appsignal/cli/diagnose_spec.rb

@@ -104,7 +104,7 @@ describe Appsignal::CLI::Diagnose, :api_stub => true, :report => true do
           run
           expect(output).to include "Diagnostics report",
             "Send diagnostics report to AppSignal? (Y/n): ",
-            "Your diagnostics report has been sent to AppSignal."
+            "Please email us at support@appsignal.com with the following\n  support token."
         end
 
         it "outputs the support token from the server" do

data/spec/lib/appsignal/hooks/rake_spec.rb

@@ -2,6 +2,8 @@ require "rake"
 
 describe Appsignal::Hooks::RakeHook do
   let(:task) { Rake::Task.new("task:name", Rake::Application.new) }
+  let(:arguments) { Rake::TaskArguments.new(["foo"], ["bar"]) }
+  let(:generic_request) { Appsignal::Transaction::GenericRequest.new({}) }
   before(:context) do
     Appsignal.config = project_fixture_config
     expect(Appsignal.active?).to be_truthy
@@ -47,8 +49,24 @@ describe Appsignal::Hooks::RakeHook do
         expect(Appsignal).to receive(:stop).with("rake").ordered
       end
 
+      it "adds the task arguments to the request" do
+        expect(Appsignal::Transaction::GenericRequest).to receive(:new)
+          .with(:params => { :foo => "bar" })
+          .and_return(generic_request)
+      end
+
+      context "when first argument is not a `Rake::TaskArguments`" do
+        let(:arguments) { nil }
+
+        it "adds the first argument regardless" do
+          expect(Appsignal::Transaction::GenericRequest).to receive(:new)
+            .with(:params => nil)
+            .and_return(generic_request)
+        end
+      end
+
       after do
-        expect { task.execute("foo") }.to raise_error VerySpecificError
+        expect { task.execute(arguments) }.to raise_error VerySpecificError
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appsignal
 version: !ruby/object:Gem::Version
-  version: 2.3.1
+  version: 2.3.2
 platform: ruby
 authors:
 - Robert Beekman
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-26 00:00:00.000000000 Z
+date: 2017-08-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack