appsignal 2.11.1-java → 3.0.0.beta.1-java

data/spec/lib/appsignal/transmitter_spec.rb

@@ -143,7 +143,7 @@ describe Appsignal::Transmitter do
     context "with a proxy" do
       let(:config) { project_fixture_config("production", :http_proxy => "http://localhost:8080") }
 
-      it "is of Net::HTTP class", :not_ruby19 do
+      it "is of Net::HTTP class" do
         expect(subject).to be_instance_of(Net::HTTP)
       end
       it { expect(subject.proxy?).to be_truthy }

data/spec/lib/appsignal_spec.rb

@@ -63,11 +63,6 @@ describe Appsignal do
         Appsignal.start
       end
 
-      it "should load deprecated event formatters" do
-        expect(Appsignal::EventFormatter).to receive(:initialize_deprecated_formatters)
-        Appsignal.start
-      end
-
       context "with an extension" do
         before { Appsignal.extensions << Appsignal::MockExtension }
 
@@ -491,6 +486,36 @@ describe Appsignal do
       end
     end
 
+    describe ".add_breadcrumb" do
+      before { allow(Appsignal::Transaction).to receive(:current).and_return(transaction) }
+
+      context "with transaction" do
+        let(:transaction) { double }
+        it "should call add_breadcrumb on transaction" do
+          expect(transaction).to receive(:add_breadcrumb)
+            .with("Network", "http", "User made network request", { :response => 200 }, fixed_time)
+        end
+
+        after do
+          Appsignal.add_breadcrumb(
+            "Network",
+            "http",
+            "User made network request",
+            { :response => 200 },
+            fixed_time
+          )
+        end
+      end
+
+      context "without transaction" do
+        let(:transaction) { nil }
+
+        it "should not call add_breadcrumb on transaction" do
+          expect(Appsignal.add_breadcrumb("Network", "http")).to be_falsy
+        end
+      end
+    end
+
     describe "custom stats" do
       let(:tags) { { :foo => "bar" } }
 
@@ -950,70 +975,6 @@ describe Appsignal do
         end
       end
     end
-
-    describe ".is_ignored_error?" do
-      let(:error) { StandardError.new }
-      let(:err_stream) { std_stream }
-      let(:stderr) { err_stream.read }
-      before do
-        allow(Appsignal).to receive(:config).and_return(:ignore_errors => ["StandardError"])
-      end
-
-      subject do
-        capture_std_streams(std_stream, err_stream) do
-          Appsignal.is_ignored_error?(error)
-        end
-      end
-
-      it "should return true if it's in the ignored list" do
-        is_expected.to be_truthy
-      end
-
-      it "outputs deprecated warning" do
-        subject
-        expect(stderr).to include("Appsignal.is_ignored_error? is deprecated with no replacement")
-      end
-
-      context "when error is not in the ignored list" do
-        let(:error) { Object.new }
-
-        it "should return false" do
-          is_expected.to be_falsy
-        end
-      end
-    end
-
-    describe ".is_ignored_action?" do
-      let(:action) { "TestController#isup" }
-      let(:err_stream) { std_stream }
-      let(:stderr) { err_stream.read }
-      before do
-        allow(Appsignal).to receive(:config).and_return(:ignore_actions => "TestController#isup")
-      end
-
-      subject do
-        capture_std_streams(std_stream, err_stream) do
-          Appsignal.is_ignored_action?(action)
-        end
-      end
-
-      it "should return true if it's in the ignored list" do
-        is_expected.to be_truthy
-      end
-
-      it "outputs deprecated warning" do
-        subject
-        expect(stderr).to include("Appsignal.is_ignored_action? is deprecated with no replacement")
-      end
-
-      context "when action is not in the ingore list" do
-        let(:action) { "TestController#other_action" }
-
-        it "should return false" do
-          is_expected.to be_falsy
-        end
-      end
-    end
   end
 
   describe ".start_logger" do

data/spec/spec_helper.rb

@@ -2,7 +2,7 @@ ENV["RAILS_ENV"] ||= "test"
 ENV["RACK_ENV"] ||= "test"
 ENV["PADRINO_ENV"] ||= "test"
 
-APPSIGNAL_SPEC_DIR = File.expand_path(File.dirname(__FILE__))
+APPSIGNAL_SPEC_DIR = File.expand_path(__dir__)
 $LOAD_PATH.unshift(File.join(APPSIGNAL_SPEC_DIR, "support/stubs"))
 
 Bundler.require :default
@@ -85,20 +85,6 @@ RSpec.configure do |config|
     FileUtils.mkdir_p(spec_system_tmp_dir)
   end
 
-  config.before :each, :only_ruby19 => true do
-    is_ruby19 = Gem::Version.new(RUBY_VERSION) < Gem::Version.new("2.0.0")
-    next if is_ruby19
-
-    skip "Skipping spec. Only for Ruby 1.9"
-  end
-
-  config.before :each, :not_ruby19 => true do
-    is_ruby19 = Gem::Version.new(RUBY_VERSION) < Gem::Version.new("2.0.0")
-    next unless is_ruby19
-
-    skip "Skipping spec for Ruby 1.9"
-  end
-
   config.before do
     stop_minutely_probes
     ENV["RAILS_ENV"] ||= "test"

metadata

@@ -1,16 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: appsignal
 version: !ruby/object:Gem::Version
-  version: 2.11.1
+  version: 3.0.0.beta.1
 platform: java
 authors:
 - Robert Beekman
 - Thijs Cadier
 - Tom de Bruijn
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-12-15 00:00:00.000000000 Z
+date: 2021-01-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -202,7 +202,6 @@ files:
 - lib/appsignal/cli/diagnose/utils.rb
 - lib/appsignal/cli/helpers.rb
 - lib/appsignal/cli/install.rb
-- lib/appsignal/cli/notify_of_deploy.rb
 - lib/appsignal/config.rb
 - lib/appsignal/demo.rb
 - lib/appsignal/environment.rb
@@ -240,22 +239,25 @@ files:
 - lib/appsignal/hooks/sidekiq.rb
 - lib/appsignal/hooks/unicorn.rb
 - lib/appsignal/hooks/webmachine.rb
+- lib/appsignal/integrations/action_cable.rb
+- lib/appsignal/integrations/active_support_notifications.rb
 - lib/appsignal/integrations/capistrano/appsignal.cap
 - lib/appsignal/integrations/capistrano/capistrano_2_tasks.rb
 - lib/appsignal/integrations/data_mapper.rb
 - lib/appsignal/integrations/delayed_job_plugin.rb
 - lib/appsignal/integrations/grape.rb
 - lib/appsignal/integrations/mongo_ruby_driver.rb
+- lib/appsignal/integrations/net_http.rb
 - lib/appsignal/integrations/object.rb
 - lib/appsignal/integrations/padrino.rb
 - lib/appsignal/integrations/que.rb
 - lib/appsignal/integrations/railtie.rb
 - lib/appsignal/integrations/rake.rb
+- lib/appsignal/integrations/redis.rb
 - lib/appsignal/integrations/resque.rb
-- lib/appsignal/integrations/resque_active_job.rb
 - lib/appsignal/integrations/sinatra.rb
+- lib/appsignal/integrations/unicorn.rb
 - lib/appsignal/integrations/webmachine.rb
-- lib/appsignal/js_exception_transaction.rb
 - lib/appsignal/logger.rb
 - lib/appsignal/marker.rb
 - lib/appsignal/minutely.rb
@@ -263,7 +265,6 @@ files:
 - lib/appsignal/probes/puma.rb
 - lib/appsignal/probes/sidekiq.rb
 - lib/appsignal/rack/generic_instrumentation.rb
-- lib/appsignal/rack/js_exception_catcher.rb
 - lib/appsignal/rack/rails_instrumentation.rb
 - lib/appsignal/rack/sinatra_instrumentation.rb
 - lib/appsignal/rack/streaming_listener.rb
@@ -292,7 +293,6 @@ files:
 - spec/lib/appsignal/cli/diagnose_spec.rb
 - spec/lib/appsignal/cli/helpers_spec.rb
 - spec/lib/appsignal/cli/install_spec.rb
-- spec/lib/appsignal/cli/notify_of_deploy_spec.rb
 - spec/lib/appsignal/cli_spec.rb
 - spec/lib/appsignal/config_spec.rb
 - spec/lib/appsignal/demo_spec.rb
@@ -340,18 +340,14 @@ files:
 - spec/lib/appsignal/integrations/padrino_spec.rb
 - spec/lib/appsignal/integrations/que_spec.rb
 - spec/lib/appsignal/integrations/railtie_spec.rb
-- spec/lib/appsignal/integrations/resque_active_job_spec.rb
-- spec/lib/appsignal/integrations/resque_spec.rb
 - spec/lib/appsignal/integrations/sinatra_spec.rb
 - spec/lib/appsignal/integrations/webmachine_spec.rb
-- spec/lib/appsignal/js_exception_transaction_spec.rb
 - spec/lib/appsignal/logger_spec.rb
 - spec/lib/appsignal/marker_spec.rb
 - spec/lib/appsignal/minutely_spec.rb
 - spec/lib/appsignal/probes/puma_spec.rb
 - spec/lib/appsignal/probes/sidekiq_spec.rb
 - spec/lib/appsignal/rack/generic_instrumentation_spec.rb
-- spec/lib/appsignal/rack/js_exception_catcher_spec.rb
 - spec/lib/appsignal/rack/rails_instrumentation_spec.rb
 - spec/lib/appsignal/rack/sinatra_instrumentation_spec.rb
 - spec/lib/appsignal/rack/streaming_listener_spec.rb
@@ -413,7 +409,7 @@ metadata:
   documentation_uri: https://docs.appsignal.com/ruby/
   homepage_uri: https://docs.appsignal.com/ruby/
   source_code_uri: https://github.com/appsignal/appsignal-ruby
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -425,12 +421,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '1.9'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.2.6
+signing_key:
 specification_version: 4
 summary: Logs performance and exception data from your app to appsignal.com
 test_files:
@@ -444,7 +440,6 @@ test_files:
 - spec/lib/appsignal/cli/diagnose_spec.rb
 - spec/lib/appsignal/cli/helpers_spec.rb
 - spec/lib/appsignal/cli/install_spec.rb
-- spec/lib/appsignal/cli/notify_of_deploy_spec.rb
 - spec/lib/appsignal/cli_spec.rb
 - spec/lib/appsignal/config_spec.rb
 - spec/lib/appsignal/demo_spec.rb
@@ -492,18 +487,14 @@ test_files:
 - spec/lib/appsignal/integrations/padrino_spec.rb
 - spec/lib/appsignal/integrations/que_spec.rb
 - spec/lib/appsignal/integrations/railtie_spec.rb
-- spec/lib/appsignal/integrations/resque_active_job_spec.rb
-- spec/lib/appsignal/integrations/resque_spec.rb
 - spec/lib/appsignal/integrations/sinatra_spec.rb
 - spec/lib/appsignal/integrations/webmachine_spec.rb
-- spec/lib/appsignal/js_exception_transaction_spec.rb
 - spec/lib/appsignal/logger_spec.rb
 - spec/lib/appsignal/marker_spec.rb
 - spec/lib/appsignal/minutely_spec.rb
 - spec/lib/appsignal/probes/puma_spec.rb
 - spec/lib/appsignal/probes/sidekiq_spec.rb
 - spec/lib/appsignal/rack/generic_instrumentation_spec.rb
-- spec/lib/appsignal/rack/js_exception_catcher_spec.rb
 - spec/lib/appsignal/rack/rails_instrumentation_spec.rb
 - spec/lib/appsignal/rack/sinatra_instrumentation_spec.rb
 - spec/lib/appsignal/rack/streaming_listener_spec.rb

data/lib/appsignal/cli/notify_of_deploy.rb

@@ -1,131 +0,0 @@
-# frozen_string_literal: true
-
-module Appsignal
-  class CLI
-    # Command line tool to send a "Deploy Marker" for an application to
-    # AppSignal.
-    #
-    # Deploy markers are used on AppSignal.com to indicate changes in an
-    # application, "Deploy markers" indicate a deploy of an application.
-    #
-    # Incidents for exceptions and performance issues will be closed and
-    # reopened if they occur again in the new deploy.
-    #
-    # @note The same logic is used in the Capistrano integration. A deploy
-    #   marker is created on each deploy.
-    #
-    # ## Options
-    #
-    # - `--environment` required. The environment of the application being
-    #   deployed.
-    # - `--user` required. User that triggered the deploy.
-    # - `--revision` required. Git commit SHA or other identifiable revision id.
-    # - `--name` If no "name" config can be found in a `config/appsignal.yml`
-    #   file or based on the `APPSIGNAL_APP_NAME` environment variable, this
-    #   option is required.
-    #
-    # ## Exit codes
-    #
-    # - Exits with status code `0` if the deploy marker is sent.
-    # - Exits with status code `1` if the configuration is not valid and active.
-    # - Exits with status code `1` if the required options aren't present.
-    #
-    # @example basic example
-    #   appsignal notify_of_deploy \
-    #     --user=tom \
-    #     --environment=production \
-    #     --revision=abc1234
-    #
-    # @example using a custom app name
-    #   appsignal notify_of_deploy \
-    #     --user=tom \
-    #     --environment=production \
-    #     --revision=abc1234 \
-    #     --name="My app"
-    #
-    # @example help command
-    #   appsignal notify_of_deploy --help
-    #
-    # @deprecated This method of sending AppSignal deploy markers is
-    #   deprecated. Use the [`revision` config option]
-    #   (https://docs.appsignal.com/ruby/configuration/options.html#app_revision-revision)
-    #   instead. For more information, please read the [deploy markers]
-    #   (https://docs.appsignal.com/application/markers/deploy-markers.html)
-    #   documentation.
-    # @since 0.2.5
-    # @see Appsignal::Marker Appsignal::Marker
-    # @see http://docs.appsignal.com/ruby/command-line/notify_of_deploy.html
-    #   AppSignal notify_of_deploy documentation
-    # @see http://docs.appsignal.com/appsignal/terminology.html#markers
-    #   Terminology: Deploy marker
-    class NotifyOfDeploy
-      class << self
-        include Appsignal::Utils::DeprecationMessage
-
-        # @param options [Hash]
-        # @option options :environment [String] environment to load
-        #   configuration for.
-        # @option options :name [String] custom name of the application.
-        # @option options :user [String] user who triggered the deploy.
-        # @option options :revision [String] the revision that has been
-        #   deployed. E.g. a git commit SHA.
-        # @return [void]
-        def run(options)
-          config = config_for(options[:environment])
-          config[:name] = options[:name] if options[:name]
-
-          validate_active_config(config)
-          required_config = [:revision, :user]
-          required_config << :environment if config.env.empty?
-          required_config << :name if !config[:name] || config[:name].empty?
-          validate_required_options(options, required_config)
-
-          Appsignal::Marker.new(
-            {
-              :revision => options[:revision],
-              :user => options[:user]
-            },
-            config
-          ).transmit
-
-          puts
-          message = "This command (appsignal notify_of_deploy) has been " \
-            "deprecated in favor of the `revision` config option. Please " \
-            "see our documentation for more information on the recommended " \
-            "method: " \
-            "https://docs.appsignal.com/application/markers/deploy-markers.html"
-          deprecation_message message
-        end
-
-        private
-
-        def validate_required_options(options, required_options)
-          missing = required_options.select do |required_option|
-            val = options[required_option]
-            val.nil? || (val.respond_to?(:empty?) && val.empty?)
-          end
-          return unless missing.any?
-
-          puts "Error: Missing options: #{missing.join(", ")}"
-          exit 1
-        end
-
-        def validate_active_config(config)
-          return if config.active?
-
-          puts "Error: No valid config found."
-          exit 1
-        end
-
-        def config_for(environment)
-          Appsignal::Config.new(
-            Dir.pwd,
-            environment,
-            {},
-            Logger.new(StringIO.new)
-          )
-        end
-      end
-    end
-  end
-end

data/lib/appsignal/integrations/resque_active_job.rb

@@ -1,19 +0,0 @@
-# frozen_string_literal: true
-
-module Appsignal
-  module Integrations
-    # @api private
-    module ResqueActiveJobPlugin
-      def self.included(_)
-        callers = caller
-        Appsignal::Utils::DeprecationMessage.message \
-          "The AppSignal ResqueActiveJobPlugin is deprecated and does " \
-          "nothing on extend. In this version of the AppSignal Ruby gem " \
-          "the integration with Resque is automatic on all Resque workers. " \
-          "Please remove the following line from this file to remove this " \
-          "message: include Appsignal::Integrations::ResqueActiveJobPlugin\n" \
-          "#{callers.first}"
-      end
-    end
-  end
-end