appsignal 2.1.0.beta.1 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ae60c35e104278641d1b44e7f90901f0839b3a24
-  data.tar.gz: e7c98edcf3b9c7e66b7d8fdc7d601d53b00512d9
+  metadata.gz: 0c21c84f210750178cad52383cb8945c759e3ef7
+  data.tar.gz: bd2d8b11d9f0dca396b846f5cfcad4cd834b7adc
 SHA512:
-  metadata.gz: 829e1eb8cdac7e35ad52067529d2d5ce50495cc0fa95ea5a6d80e6878dba3396a82c0ffa73d8b0c691b4ff472ccd57e3592e96c823786ec7ebd22666456313fd
-  data.tar.gz: 7887a42b3b30b818bc26337f50963d487e8af94be03315e908126bb8dda5bb850c62a48acfd1232bdf63dc2d86ae3a0cc9eabbeb0473634b5690878006d5a6e8
+  metadata.gz: 0a7d8cfc7c177f158b0da831dd35ce72efccd0f6ebfff7fd36a9ac6053a906db0959c49b6eb6a13ac72da855d4e0344095100c5597daa4e286e2004c047b41b6
+  data.tar.gz: af5c20d7e786bdd702008f942c951da08bfe8d196f2d12b44eac04c51c0a3ebbc85850bafe6c13a6fc8ef78b83ec086adda7d4dfb0c71e531a9d20a7c74cd07f

data/.rspec

@@ -1,3 +1,4 @@
---order default
+--order defined
+--color
 --warnings
 --require spec_helper

data/CHANGELOG.md

@@ -5,6 +5,11 @@
 * Deprecate `Appsignal.is_ignored_error?`. PR #224
 * Deprecate `Appsignal.is_ignored_action?`. PR #224
 * Enforce a coding styleguide with RuboCop. PR #226
+* Remove unused `Appsignal.agent` attribute. PR #244
+* Deprecate unused `Appsignal::AuthCheck` logger argument. PR #245
+
+# 2.0.6
+* Fix `Appsignal::Transaction#record_event` method call. PR #240
 
 # 2.0.5
 * Improved logging for agent connection issues.

data/README.md

@@ -113,8 +113,8 @@ appsignal install [push api key]
 ```
 
 Depending on what framework or gems you use some manual integration is
-required. Follow the steps in the wizard or consult our [Supported systems and
-frameworks] page for help.
+required. Follow the steps in the wizard or consult our [integrations] page for
+help.
 
 If you're stuck feel free to [contact us][contact]!
 
@@ -139,8 +139,8 @@ AppSignal instrumentation doesn't depend on automatic integrations. It's easy
 to set up [custom instrumentation][custom-instrumentation] to add keep track of
 anything.
 
-For more detailed information and examples please visit our [Supported
-frameworks][supported-frameworks] page.
+For more detailed information and examples please visit our
+[integrations] page.
 
 ### Front-end monitoring (Beta)
 
@@ -150,8 +150,7 @@ currently. Be sure to check it out!
 ## Supported systems
 
 Currently the AppSignal agent works on most Unix-like operating systems, such
-as most Linux distributions and macOS, excluding Alpine Linux, FreeBSD and
-Windows.
+as most Linux distributions and macOS, excluding FreeBSD and Windows.
 
 For more detailed information please visit our [Supported
 systems][supported-systems] page.
@@ -229,15 +228,15 @@ the most out of using AppSignal.
 [contact]: mailto:support@appsignal.com
 [waffles-page]: https://appsignal.com/waffles
 [docs]: http://docs.appsignal.com
-[contributing-guide]: http://docs.appsignal.com/contributing
-[supported-systems]: http://docs.appsignal.com/getting-started/supported-frameworks.html
-[supported-frameworks]: http://docs.appsignal.com/getting-started/supported-frameworks.html
-[custom-instrumentation]: http://docs.appsignal.com/tweaks-in-your-code/custom-instrumentation.html
-[front-end-monitoring]: http://docs.appsignal.com/tweaks-in-your-code/frontend-error-catching.html
-[exception-handling]: http://docs.appsignal.com/tweaks-in-your-code/handle-exceptions.html
-[tagging]: http://docs.appsignal.com/tweaks-in-your-code/handle-exceptions.html#tagging-requests
-[host-metrics]: http://docs.appsignal.com/getting-started/host-metrics.html
-[custom-metrics]: http://docs.appsignal.com/getting-started/custom-metrics.html
+[contributing-guide]: http://docs.appsignal.com/appsignal/contributing.html
+[supported-systems]: http://docs.appsignal.com/support/operating-systems.html
+[integrations]: http://docs.appsignal.com/ruby/integrations/index.html
+[custom-instrumentation]: http://docs.appsignal.com/ruby/instrumentation/
+[front-end-monitoring]: http://docs.appsignal.com/front-end/error-handling.html
+[exception-handling]: http://docs.appsignal.com/ruby/instrumentation/exception-handling.html
+[tagging]: http://docs.appsignal.com/ruby/instrumentation/tagging.html
+[host-metrics]: http://docs.appsignal.com/metrics/host.html
+[custom-metrics]: http://docs.appsignal.com/metrics/custom.html
 
 [semver]: http://semver.org/
 [rvm]: http://rvm.io/

data/appsignal.gemspec

@@ -27,7 +27,7 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'thread_safe'
 
   gem.add_development_dependency 'rake', '~> 11'
-  gem.add_development_dependency 'rspec', '~> 2.14.1'
+  gem.add_development_dependency 'rspec', '~> 3.5'
   gem.add_development_dependency 'pry'
   gem.add_development_dependency 'timecop'
   gem.add_development_dependency 'webmock'

data/lib/appsignal.rb

@@ -6,7 +6,7 @@ module Appsignal
   class << self
     extend Gem::Deprecate
 
-    attr_accessor :config, :agent, :extension_loaded
+    attr_accessor :config, :extension_loaded
     attr_writer :logger, :in_memory_log
 
     def extensions

data/lib/appsignal/auth_check.rb

@@ -4,9 +4,12 @@ module Appsignal
 
     attr_reader :config, :logger
 
-    def initialize(config, logger = Appsignal.logger)
+    def initialize(config, logger = nil)
       @config = config
-      @logger = logger
+      if logger # rubocop:disable Style/GuardClause
+        warn "Deprecated: `logger` argument will be removed in the next " \
+          "major version."
+      end
     end
 
     def perform

data/lib/appsignal/cli/demo.rb

@@ -10,7 +10,7 @@ module Appsignal
           puts "Sending demonstration sample data..."
           if Appsignal::Demo.transmit
             puts "Demonstration sample data sent!"
-            puts "It may take about a minute for the data to appear on AppSignal.com/accounts"
+            puts "It may take about a minute for the data to appear on https://appsignal.com/accounts"
           else
             puts "Error: Unable to start the AppSignal agent and send data to AppSignal.com"
             puts "Please use `appsignal diagnose` to debug your configuration."

data/lib/appsignal/cli/diagnose.rb

@@ -159,7 +159,7 @@ module Appsignal
         end
 
         def check_api_key
-          auth_check = ::Appsignal::AuthCheck.new(Appsignal.config, Appsignal.logger)
+          auth_check = ::Appsignal::AuthCheck.new(Appsignal.config)
           print "Validating API key: "
           status, error = auth_check.perform_with_result
           case status

data/lib/appsignal/cli/install.rb

@@ -204,7 +204,7 @@ module Appsignal
             puts "  Sending example data to AppSignal..."
             if Appsignal::Demo.transmit
               puts "  Example data sent!"
-              puts "  It may take about a minute for the data to appear on AppSignal.com/accounts"
+              puts "  It may take about a minute for the data to appear on https://appsignal.com/accounts"
               puts
               puts "  Please return to your browser and follow the instructions."
             else

data/lib/appsignal/transaction.rb

@@ -215,7 +215,8 @@ module Appsignal
         title || BLANK,
         body || BLANK,
         duration,
-        body_format || Appsignal::EventFormatter::DEFAULT
+        body_format || Appsignal::EventFormatter::DEFAULT,
+        self.class.garbage_collection_profiler.total_time
       )
     end
 

data/lib/appsignal/version.rb

@@ -1,5 +1,5 @@
 require "yaml"
 
 module Appsignal
-  VERSION = "2.1.0.beta.1"
+  VERSION = "2.1.0"
 end

data/spec/lib/appsignal/auth_check_spec.rb

@@ -1,29 +1,28 @@
 describe Appsignal::AuthCheck do
   let(:config) { project_fixture_config }
-  let(:logger) { Logger.new(StringIO.new) }
-  let(:auth_check) { Appsignal::AuthCheck.new(config, logger) }
+  let(:auth_check) { Appsignal::AuthCheck.new(config) }
 
   describe "#perform_with_result" do
     it "should give success message" do
-      auth_check.should_receive(:perform).and_return("200")
-      auth_check.perform_with_result.should eq ["200", "AppSignal has confirmed authorization!"]
+      expect(auth_check).to receive(:perform).and_return("200")
+      expect(auth_check.perform_with_result).to eq ["200", "AppSignal has confirmed authorization!"]
     end
 
     it "should give 401 message" do
-      auth_check.should_receive(:perform).and_return("401")
-      auth_check.perform_with_result.should eq ["401", "API key not valid with AppSignal..."]
+      expect(auth_check).to receive(:perform).and_return("401")
+      expect(auth_check.perform_with_result).to eq ["401", "API key not valid with AppSignal..."]
     end
 
     it "should give an error message" do
-      auth_check.should_receive(:perform).and_return("402")
-      auth_check.perform_with_result.should eq ["402", "Could not confirm authorization: 402"]
+      expect(auth_check).to receive(:perform).and_return("402")
+      expect(auth_check.perform_with_result).to eq ["402", "Could not confirm authorization: 402"]
     end
   end
 
   context "transmitting" do
     before do
       @transmitter = double
-      Appsignal::Transmitter.should_receive(:new).with(
+      expect(Appsignal::Transmitter).to receive(:new).with(
         "auth",
         kind_of(Appsignal::Config)
       ).and_return(@transmitter)
@@ -31,7 +30,7 @@ describe Appsignal::AuthCheck do
 
     describe "#perform" do
       it "should not transmit any extra data" do
-        @transmitter.should_receive(:transmit).with({}).and_return({})
+        expect(@transmitter).to receive(:transmit).with({}).and_return({})
         auth_check.perform
       end
     end

data/spec/lib/appsignal/capistrano2_spec.rb

@@ -26,7 +26,7 @@ if DependencyHelper.capistrano2_present?
     end
 
     it "should have a deploy task" do
-      capistrano_config.find_task("appsignal:deploy").should_not be_nil
+      expect(capistrano_config.find_task("appsignal:deploy")).to_not be_nil
     end
 
     describe "appsignal:deploy task" do
@@ -41,7 +41,7 @@ if DependencyHelper.capistrano2_present?
         end
 
         it "should be instantiated with the right params" do
-          Appsignal::Config.should_receive(:new).with(
+          expect(Appsignal::Config).to receive(:new).with(
             project_fixture_path,
             "production",
             {},
@@ -55,7 +55,7 @@ if DependencyHelper.capistrano2_present?
           end
 
           it "should be instantiated with the right params" do
-            Appsignal::Config.should_receive(:new).with(
+            expect(Appsignal::Config).to receive(:new).with(
               project_fixture_path,
               "production",
               { :name => "AppName" },
@@ -70,7 +70,7 @@ if DependencyHelper.capistrano2_present?
             end
 
             it "should be instantiated with the right params" do
-              Appsignal::Config.should_receive(:new).with(
+              expect(Appsignal::Config).to receive(:new).with(
                 project_fixture_path,
                 "rack_production",
                 { :name => "AppName" },
@@ -86,7 +86,7 @@ if DependencyHelper.capistrano2_present?
             end
 
             it "should be instantiated with the right params" do
-              Appsignal::Config.should_receive(:new).with(
+              expect(Appsignal::Config).to receive(:new).with(
                 project_fixture_path,
                 "stage_production",
                 { :name => "AppName" },
@@ -103,7 +103,7 @@ if DependencyHelper.capistrano2_present?
             end
 
             it "should prefer the appsignal_env rather than stage, rails_env and rack_env" do
-              Appsignal::Config.should_receive(:new).with(
+              expect(Appsignal::Config).to receive(:new).with(
                 project_fixture_path,
                 "appsignal_production",
                 { :name => "AppName" },

data/spec/lib/appsignal/capistrano3_spec.rb

@@ -30,7 +30,7 @@ if DependencyHelper.capistrano3_present?
     end
 
     it "should have a deploy task" do
-      Rake::Task.task_defined?("appsignal:deploy").should be_true
+      expect(Rake::Task.task_defined?("appsignal:deploy")).to be_truthy
     end
 
     describe "appsignal:deploy task" do
@@ -41,7 +41,7 @@ if DependencyHelper.capistrano3_present?
 
       context "config" do
         it "should be instantiated with the right params" do
-          Appsignal::Config.should_receive(:new).with(
+          expect(Appsignal::Config).to receive(:new).with(
             project_fixture_path,
             "production",
             {},
@@ -55,7 +55,7 @@ if DependencyHelper.capistrano3_present?
           end
 
           it "should be instantiated with the right params" do
-            Appsignal::Config.should_receive(:new).with(
+            expect(Appsignal::Config).to receive(:new).with(
               project_fixture_path,
               "production",
               { :name => "AppName" },
@@ -70,7 +70,7 @@ if DependencyHelper.capistrano3_present?
             end
 
             it "should be instantiated with the rack env" do
-              Appsignal::Config.should_receive(:new).with(
+              expect(Appsignal::Config).to receive(:new).with(
                 project_fixture_path,
                 "rack_production",
                 { :name => "AppName" },
@@ -86,7 +86,7 @@ if DependencyHelper.capistrano3_present?
             end
 
             it "should prefer the stage rather than rails_env and rack_env" do
-              Appsignal::Config.should_receive(:new).with(
+              expect(Appsignal::Config).to receive(:new).with(
                 project_fixture_path,
                 "stage_production",
                 { :name => "AppName" },
@@ -103,7 +103,7 @@ if DependencyHelper.capistrano3_present?
             end
 
             it "should prefer the appsignal_env rather than stage, rails_env and rack_env" do
-              Appsignal::Config.should_receive(:new).with(
+              expect(Appsignal::Config).to receive(:new).with(
                 project_fixture_path,
                 "appsignal_production",
                 { :name => "AppName" },

data/spec/lib/appsignal/cli/demo_spec.rb

@@ -6,7 +6,7 @@ describe Appsignal::CLI::Demo do
   let(:options) { {} }
   let(:out_stream) { std_stream }
   let(:output) { out_stream.read }
-  before(:all) { Appsignal.stop }
+  before(:context) { Appsignal.stop }
   before do
     ENV.delete("APPSIGNAL_APP_ENV")
     ENV.delete("RAILS_ENV")

data/spec/lib/appsignal/cli/diagnose_spec.rb

@@ -7,7 +7,7 @@ describe Appsignal::CLI::Diagnose, :api_stub => true do
     let(:config) { project_fixture_config }
     let(:cli) { described_class }
     let(:options) { { :environment => config.env } }
-    before(:all) { Appsignal.stop }
+    before(:context) { Appsignal.stop }
     before do
       if DependencyHelper.rails_present?
         allow(Rails).to receive(:root).and_return(Pathname.new(config.root_path))

data/spec/lib/appsignal/cli/helpers_spec.rb

@@ -70,7 +70,7 @@ describe Appsignal::CLI::Helpers do
       set_input "y"
       prepare_input
 
-      expect(yes_or_no).to be_true
+      expect(yes_or_no).to be_truthy
     end
 
     it "takes no for an answer" do
@@ -79,7 +79,7 @@ describe Appsignal::CLI::Helpers do
       set_input "n"
       prepare_input
 
-      expect(yes_or_no).to be_false
+      expect(yes_or_no).to be_falsy
     end
   end
 

data/spec/lib/appsignal/cli/install_spec.rb

@@ -173,7 +173,7 @@ describe Appsignal::CLI::Install do
         run
 
         expect(output).to_not include "Adding AppSignal integration to Capfile"
-        expect(File.exist?(capfile)).to be_false
+        expect(File.exist?(capfile)).to be_falsy
       end
     end
 
@@ -622,7 +622,7 @@ describe Appsignal::CLI::Install do
         expect(output).to include "We could not detect which framework you are using."
         expect(output).to_not include_env_push_api_key
         expect(output).to_not include_env_app_name
-        expect(File.exist?(config_file_path)).to be_false
+        expect(File.exist?(config_file_path)).to be_falsy
       end
     end
   end

data/spec/lib/appsignal/cli_spec.rb

@@ -4,7 +4,7 @@ describe Appsignal::CLI do
   let(:out_stream) { std_stream }
   let(:output) { out_stream.read }
   let(:cli) { Appsignal::CLI }
-  before { Dir.stub(:pwd => project_fixture_path) }
+  before { allow(Dir).to receive(:pwd).and_return(project_fixture_path) }
 
   it "should print the help with no arguments, -h and --help" do
     [nil, "-h", "--help"].each do |arg|
@@ -46,7 +46,7 @@ describe Appsignal::CLI do
 
   describe "diagnose" do
     it "should call Appsignal::Diagnose.install" do
-      Appsignal::CLI::Diagnose.should_receive(:run)
+      expect(Appsignal::CLI::Diagnose).to receive(:run)
 
       cli.run([
         "diagnose"

data/spec/lib/appsignal/config_spec.rb

@@ -39,13 +39,13 @@ describe Appsignal::Config do
         before { ENV["APPSIGNAL_PUSH_API_KEY"] = "abc" }
 
         it "becomes active" do
-          expect(subject).to be_true
+          expect(subject).to be_truthy
         end
       end
 
       context "without APPSIGNAL_PUSH_API_KEY env variable" do
         it "remains inactive" do
-          expect(subject).to be_false
+          expect(subject).to be_falsy
         end
       end
     end
@@ -57,7 +57,7 @@ describe Appsignal::Config do
         around { |example| recognize_as_heroku { example.run } }
 
         it "is set to true" do
-          expect(subject).to be_true
+          expect(subject).to be_truthy
         end
       end
 
@@ -65,7 +65,7 @@ describe Appsignal::Config do
         around { |example| recognize_as_container(:docker) { example.run } }
 
         it "is set to true" do
-          expect(subject).to be_true
+          expect(subject).to be_truthy
         end
       end
 
@@ -73,7 +73,7 @@ describe Appsignal::Config do
         around { |example| recognize_as_container(:none) { example.run } }
 
         it "is set to false" do
-          expect(subject).to be_false
+          expect(subject).to be_falsy
         end
       end
     end
@@ -151,7 +151,7 @@ describe Appsignal::Config do
         subject { config[:running_in_container] }
 
         it "overrides system detected config" do
-          expect(subject).to be_true
+          expect(subject).to be_truthy
         end
       end
 
@@ -169,7 +169,7 @@ describe Appsignal::Config do
           before { ENV["APPSIGNAL_PUSH_API_KEY"] = "abc" }
 
           it "sets given config rather than env variable" do
-            expect(subject).to be_false
+            expect(subject).to be_falsy
           end
         end
       end
@@ -180,8 +180,8 @@ describe Appsignal::Config do
     let(:config) { described_class.new(nil, "production") }
 
     it "is not valid or active" do
-      expect(config.valid?).to be_false
-      expect(config.active?).to be_false
+      expect(config.valid?).to be_falsy
+      expect(config.active?).to be_falsy
     end
   end
 
@@ -189,8 +189,8 @@ describe Appsignal::Config do
     let(:config) { described_class.new(tmp_dir, "production") }
 
     it "is not valid or active" do
-      expect(config.valid?).to be_false
-      expect(config.active?).to be_false
+      expect(config.valid?).to be_falsy
+      expect(config.active?).to be_falsy
     end
   end
 
@@ -198,8 +198,8 @@ describe Appsignal::Config do
     let(:config) { project_fixture_config("production") }
 
     it "is not valid or active" do
-      expect(config.valid?).to be_true
-      expect(config.active?).to be_true
+      expect(config.valid?).to be_truthy
+      expect(config.active?).to be_truthy
     end
 
     it "does not log an error" do
@@ -219,8 +219,8 @@ describe Appsignal::Config do
       around { |example| recognize_as_container(:none) { example.run } }
 
       it "overrides system detected and defaults config" do
-        expect(config[:running_in_container]).to be_true
-        expect(config[:debug]).to be_true
+        expect(config[:running_in_container]).to be_truthy
+        expect(config[:debug]).to be_truthy
       end
     end
 
@@ -228,8 +228,8 @@ describe Appsignal::Config do
       let(:config) { project_fixture_config(:production) }
 
       it "loads the config" do
-        expect(config.valid?).to be_true
-        expect(config.active?).to be_true
+        expect(config.valid?).to be_truthy
+        expect(config.active?).to be_truthy
 
         expect(config[:push_api_key]).to eq("abc")
       end
@@ -239,8 +239,8 @@ describe Appsignal::Config do
       let(:config) { project_fixture_config("nonsense") }
 
       it "is not valid or active" do
-        expect(config.valid?).to be_false
-        expect(config.active?).to be_false
+        expect(config.valid?).to be_falsy
+        expect(config.active?).to be_falsy
       end
 
       it "logs an error" do
@@ -315,14 +315,14 @@ describe Appsignal::Config do
     around { |example| recognize_as_container(:none) { example.run } }
 
     it "overrides config with environment values" do
-      expect(config.valid?).to be_true
-      expect(config.active?).to be_true
+      expect(config.valid?).to be_truthy
+      expect(config.active?).to be_truthy
 
-      expect(config[:running_in_container]).to be_true
+      expect(config[:running_in_container]).to be_truthy
       expect(config[:push_api_key]).to eq "aaa-bbb-ccc"
-      expect(config[:active]).to be_true
+      expect(config[:active]).to be_truthy
       expect(config[:name]).to eq "App name"
-      expect(config[:debug]).to be_true
+      expect(config[:debug]).to be_truthy
       expect(config[:ignore_actions]).to eq ["action1", "action2"]
     end
   end