appsignal 2.0.5 → 2.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2bb230d85f46fd9bf32882d5041a2b70fecaf581
-  data.tar.gz: c816a5187d9011df47bc8333fed497cb96f1a2bd
+  metadata.gz: 71dba256de2f6e7c3fef2638fe3ff22ac1867734
+  data.tar.gz: 19afcda8d5855a43912aee21e4953744990ae96f
 SHA512:
-  metadata.gz: 9214971aa956ff541fcb7e417f73339f3fec5db3e3578bbbe4a4aec2cf2ad722decf545c27392e27d495fd3fd57cb57991b4a1f6243f5097e426bc0f463d26be
-  data.tar.gz: 5b7a5eac23079d4b3ff5913f9c970795659ca3ec444c3782432c90416a3389e9ab22bfa502a7691d3dc6f018a143e9501ebd4047361284761c1f1efd8015b5de
+  metadata.gz: 4abc56838105533b0384f14889fc80af1898bc4744b60f4d55ea7524cfccfaf1052bb9e1c88da98c8840b4f72956ec1e2c854af9a845d6d61e14121183dfb8e1
+  data.tar.gz: fe65746d9243bfc5393519b1d23c0beeefc7c0ed53588043a3b95b0c16a66a2372a2472775d4cd9ba0dc60395cecf32c72c28457ea664ee33dce59c9e659d2e4

data/CHANGELOG.md

@@ -1,6 +1,10 @@
+# 2.0.6
+* Fix `Appsignal::Transaction#record_event` method call. PR #240
+
 # 2.0.5
-* Improved logging for agent connection issues
-* Handle nil request/environments in transactions
+* Improved logging for agent connection issues. Commit
+  cdf9d3286d704e22473eb901c839cab4fab45a6f
+* Handle nil request/environments in transactions. PR #231
 
 # 2.0.4
 * Use consistent log format for both file and STDOUT logs. PR #203

data/lib/appsignal/cli/demo.rb

@@ -10,7 +10,7 @@ module Appsignal
           puts "Sending demonstration sample data..."
           if Appsignal::Demo.transmit
             puts "Demonstration sample data sent!"
-            puts "It may take about a minute for the data to appear on AppSignal.com/accounts"
+            puts "It may take about a minute for the data to appear on https://appsignal.com/accounts"
           else
             puts "Error: Unable to start the AppSignal agent and send data to AppSignal.com"
             puts "Please use `appsignal diagnose` to debug your configuration."

data/lib/appsignal/cli/install.rb

@@ -204,7 +204,7 @@ module Appsignal
             puts "  Sending example data to AppSignal..."
             if Appsignal::Demo.transmit
               puts "  Example data sent!"
-              puts "  It may take about a minute for the data to appear on AppSignal.com/accounts"
+              puts "  It may take about a minute for the data to appear on https://appsignal.com/accounts"
               puts
               puts "  Please return to your browser and follow the instructions."
             else

data/lib/appsignal/transaction.rb

@@ -213,7 +213,8 @@ module Appsignal
         title || BLANK,
         body || BLANK,
         duration,
-        body_format || Appsignal::EventFormatter::DEFAULT
+        body_format || Appsignal::EventFormatter::DEFAULT,
+        self.class.garbage_collection_profiler.total_time
       )
     end
 

data/lib/appsignal/version.rb

@@ -1,5 +1,5 @@
 require 'yaml'
 
 module Appsignal
-  VERSION = '2.0.5'
+  VERSION = '2.0.6'
 end

data/spec/lib/appsignal/capistrano3_spec.rb

@@ -3,9 +3,8 @@ if DependencyHelper.capistrano3_present?
   require 'capistrano/deploy'
   require 'appsignal/capistrano'
 
-  include Capistrano::DSL
-
   describe "Capistrano 3 integration" do
+    let(:capistrano) { Class.new.extend(Capistrano::DSL) }
     let(:config) { project_fixture_config }
     let(:out_stream) { std_stream }
     let(:output) { out_stream.read }
@@ -26,7 +25,7 @@ if DependencyHelper.capistrano3_present?
 
     def run
       capture_std_streams(out_stream, out_stream) do
-        invoke('appsignal:deploy')
+        capistrano.invoke('appsignal:deploy')
       end
     end
 

data/spec/lib/appsignal/transaction_spec.rb

@@ -466,21 +466,29 @@ describe Appsignal::Transaction do
 
     describe "#start_event" do
       it "should start the event in the extension" do
-        transaction.ext.should_receive(:start_event)
+        expect(transaction.ext).to receive(:start_event).with(0).and_call_original
 
         transaction.start_event
       end
     end
 
     describe "#finish_event" do
+      let(:fake_gc_time) { 123 }
+      before do
+        described_class.garbage_collection_profiler
+          .should_receive(:total_time)
+          .at_least(:once)
+          .and_return(fake_gc_time)
+      end
+
       it "should finish the event in the extension" do
         transaction.ext.should_receive(:finish_event).with(
           'name',
           'title',
           'body',
           1,
-          0
-        )
+          fake_gc_time
+        ).and_call_original
 
         transaction.finish_event(
           'name',
@@ -496,8 +504,8 @@ describe Appsignal::Transaction do
           '',
           '',
           0,
-          0
-        )
+          fake_gc_time
+        ).and_call_original
 
         transaction.finish_event(
           'name',
@@ -506,25 +514,26 @@ describe Appsignal::Transaction do
           nil
         )
       end
-
-      it "should add garbage collection time" do
-        allow_any_instance_of(Appsignal::GarbageCollectionProfiler)
-          .to receive(:internal_profiler)
-          .and_return(FakeGCProfiler.new(0.12345))
-
-        transaction.finish_event('name', nil, nil, nil)
-      end
     end
 
     describe "#record_event" do
+      let(:fake_gc_time) { 123 }
+      before do
+        described_class.garbage_collection_profiler
+          .should_receive(:total_time)
+          .at_least(:once)
+          .and_return(fake_gc_time)
+      end
+
       it "should record the event in the extension" do
         transaction.ext.should_receive(:record_event).with(
           'name',
           'title',
           'body',
           1000,
-          1
-        )
+          1,
+          fake_gc_time
+        ).and_call_original
 
         transaction.record_event(
           'name',
@@ -541,8 +550,9 @@ describe Appsignal::Transaction do
           '',
           '',
           1000,
-          0
-        )
+          0,
+          fake_gc_time
+        ).and_call_original
 
         transaction.record_event(
           'name',

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appsignal
 version: !ruby/object:Gem::Version
-  version: 2.0.5
+  version: 2.0.6
 platform: ruby
 authors:
 - Robert Beekman
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-05 00:00:00.000000000 Z
+date: 2017-01-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -332,7 +332,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Logs performance and exception data from your app to appsignal.com
@@ -432,4 +432,3 @@ test_files:
 - spec/support/project_fixture/log/.gitkeep
 - spec/support/rails/my_app.rb
 - spec/support/stubs/delayed_job.rb
-has_rdoc: