appsignal 1.1.5.beta.2 → 1.1.5.beta.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4ce59be8afa0036d43feda6d0448b7f425331710
-  data.tar.gz: fa7a0f18be1dc0bff11b6361df21af99dabca3bd
+  metadata.gz: 8ab24c0a488648acac563bdbf764376900b0d28b
+  data.tar.gz: 5458e8dbfbcc4a16a50c58eda06769c78eca10a8
 SHA512:
-  metadata.gz: 4223ca5924dbe22903844f8231e55cf9676565b4516d2a4760945cacfb32b16ea235eb00d9ce18e621cf930665bf0212da029068058eea15a672f4b9a4188398
-  data.tar.gz: 9a6c39eb3ca679bf9e3bda808dc67091b366f6c796a0fa7fc2c9d58265c34721e290e9453f94a26d72d14c1075250dc2f8810084676e0b59047fbfedd1c9d643
+  metadata.gz: 6d2f97e01145a80d25aede13c6679380feff0778b2ee3bd1e0433d6be0d08d819a847e26459db65bbaa83b88cebd50e575bc4cc50484db1b4e7645b0c7e3330b
+  data.tar.gz: 0bd95af4c2c48c75a27e47d4a14f4a4acc063afdd03ccb3b2da648510f343c25722b706faf8c3a9c7d19d3e360d4b6abedea0b467ce5a0e7e88e2f07498afaad

data/CHANGELOG.md

@@ -4,6 +4,7 @@
 * Warn when overwriting already existing transaction
 * Support for x86-linux
 * Some improvements in debug logging
+* Check of log file path is writable
 
 # 1.1.4
 * Better debug logging for agent issues

data/lib/appsignal.rb

@@ -207,9 +207,7 @@ module Appsignal
 
     def start_logger(path_arg=nil)
       path = Appsignal.config ? Appsignal.config.log_file_path : nil
-      if path && File.writable?(File.dirname(path)) &&
-         !ENV['DYNO'] &&
-         !ENV['SHELLYCLOUD_DEPLOYMENT']
+      if path && !ENV['DYNO']
         @logger = Logger.new(path)
         @logger.formatter = log_formatter
       else

data/lib/appsignal/config.rb

@@ -78,7 +78,11 @@ module Appsignal
 
     def log_file_path
       path = config_hash[:log_path] || root_path
-      File.join(File.realpath(path), 'appsignal.log')
+      if File.writable?(path)
+        File.join(File.realpath(path), 'appsignal.log')
+      else
+        '/tmp/appsignal.log'
+      end
     rescue Errno::ENOENT
       '/tmp/appsignal.log'
     end

data/lib/appsignal/version.rb

@@ -1,5 +1,5 @@
 require 'yaml'
 
 module Appsignal
-  VERSION = '1.1.5.beta.2'
+  VERSION = '1.1.5.beta.3'
 end

data/spec/lib/appsignal/config_spec.rb

@@ -43,6 +43,14 @@ describe Appsignal::Config do
       its(:log_file_path) { should end_with('/tmp/appsignal.log') }
 
       context "if it is not writable" do
+        before { FileUtils.mkdir_p('/tmp/not-writable', :mode => 0555) }
+
+        let(:config) { project_fixture_config('production', :log_path => '/tmp/not-writable') }
+
+        its(:log_file_path) { should == '/tmp/appsignal.log' }
+      end
+
+      context "if it does not exist" do
         let(:config) { project_fixture_config('production', :log_path => '/non-existing') }
 
         its(:log_file_path) { should == '/tmp/appsignal.log' }

data/spec/lib/appsignal_spec.rb

@@ -489,20 +489,6 @@ describe Appsignal do
         end
       end
 
-      context "when we're on Shelly Cloud" do
-        before do
-          ENV['SHELLYCLOUD_DEPLOYMENT'] = 'true'
-        end
-        after { ENV.delete('SHELLYCLOUD_DEPLOYMENT') }
-
-        it "should log to stdout" do
-          Appsignal.start_logger
-          Appsignal.logger.error('Log to stdout')
-          out_stream.string.should include 'appsignal: Log to stdout'
-          out_stream.string.should include 'Log something'
-        end
-      end
-
       context "when there is no in memory log" do
         it "should not crash" do
           Appsignal.in_memory_log = nil

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appsignal
 version: !ruby/object:Gem::Version
-  version: 1.1.5.beta.2
+  version: 1.1.5.beta.3
 platform: ruby
 authors:
 - Robert Beekman
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-14 00:00:00.000000000 Z
+date: 2016-04-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack