appsignal 0.11.15 → 0.11.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e46c381bcac122c334dd4add206d31c1d0055e9e
-  data.tar.gz: d0fed9e09daaeef79be49f0f7239beef0140c15c
+  metadata.gz: 3e8df99b6b521fdda3a9e54873ea46bad0e1667f
+  data.tar.gz: 32711b82d0e91a9cc08bde77ec0bc62bcc858129
 SHA512:
-  metadata.gz: 3441a4fa9552f743e0b3c4e34295b0e1a70cff16b42f7192e85cded61e199e1bfb8f2cd2910cc3ce2aefe6e1f225819a45022e68ddbf8d629e0fa65b06e580e5
-  data.tar.gz: ab491b0cb3fae719b4d3e57a94cf4a6f8bf128f5d58bda193c1e8a1906196b4284fb43ea430e916087660bbcb01470c16b480dd996d181945f17f5824b902dcf
+  metadata.gz: a7b0a13d1709bc11fd09857b56a2090a28dfdf872484bdc8f6c107ebb94935dc6b12bf1928359cee8816bebda5cc25ed41d277c43faace2876dc94bb25600d34
+  data.tar.gz: 052a53b0fe02ff563b6a54aa8e8066e169c5661568cb75d4c27e3ef894ae17f51c4bd35ab25c0dc08d5f20a4738fc522f4fb1ef94bc7f6d002ee8deabab72354

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 0.11.16
+* Send tags passed to the frontend error catcher
+* Fix issue with ActiveAdmin sending incompatible instrumentation events
+
 # 0.11.15
 * Improve Sinatra support
 

data/gemfiles/capistrano2.gemfile

@@ -1,5 +1,6 @@
 source 'https://rubygems.org'
 
 gem 'capistrano', '< 3.0'
+gem 'net-ssh', '2.9.2' # 3.x doesn't compile on < Ruby 2.0
 
 gemspec :path => '../'

data/gemfiles/capistrano3.gemfile

@@ -1,5 +1,6 @@
 source 'https://rubygems.org'
 
 gem 'capistrano', '>= 3.0'
+gem 'net-ssh', '2.9.2' # 3.x doesn't compile on < Ruby 2.0
 
 gemspec :path => '../'

data/lib/appsignal/agent.rb

@@ -68,7 +68,9 @@ module Appsignal
       Appsignal.logger.debug('Subscribing to notifications')
       # Subscribe to notifications that don't start with a !
       @subscriber = ActiveSupport::Notifications.subscribe(/^[^!]/) do |*args|
-        if Appsignal::Transaction.current
+        # Some people abuse the notification system and send their own data over it
+        # (looking at you, active_admin), make sure we only process valid events.
+        if Appsignal::Transaction.current && args.length == 5
           event = Appsignal::Event.event_for_instrumentation(*args)
           if event.name.start_with?('process_action')
             Appsignal::Transaction.current.set_process_action_event(event)

data/lib/appsignal/js_exception_transaction.rb

@@ -27,6 +27,7 @@ module Appsignal
           :kind        => 'frontend',
           :time        => @time,
           :environment => @data['environment'],
+          :tags        => @data['tags'],
           :revision    => Appsignal.agent.revision
         },
         :exception => {

data/lib/appsignal/transaction.rb

@@ -42,7 +42,7 @@ module Appsignal
       @env                  = env
       @params               = defaults[:params] || {}
       @tags                 = defaults[:tags] || {}
-      @kind                 = defaults[:kind] || 'web'
+      @kind                 = defaults[:kind] || 'http_request'
       @action               = defaults[:action]
       @paused               = false
     end

data/lib/appsignal/version.rb

@@ -1,3 +1,3 @@
 module Appsignal
-  VERSION = '0.11.15'
+  VERSION = '0.11.16'
 end

data/spec/lib/appsignal/agent_spec.rb

@@ -180,6 +180,12 @@ describe Appsignal::Agent do
         ActiveSupport::Notifications.instrument '!render_template'
       end
 
+      it "should ignore events that do not confirm to the event spec" do
+        Appsignal::Transaction.current.should_not_receive(:add_event)
+
+        ActiveSupport::Notifications.publish 'borked', 'foo'
+      end
+
       it "should add a normal event" do
         Appsignal::Transaction.current.should_not_receive(:set_process_action_event)
         Appsignal::Transaction.current.should_receive(:add_event).with(

data/spec/lib/appsignal/config_spec.rb

@@ -63,6 +63,7 @@ describe Appsignal::Config do
       it "should merge with the config" do
         subject[:name].should == 'TestApp'
         subject[:initial_key].should == 'value'
+        subject[:ignore_exceptions].should == []
       end
     end
 
@@ -149,6 +150,7 @@ describe Appsignal::Config do
         it "should merge with the config" do
           Appsignal.logger.should_not_receive(:debug)
           subject[:name].should == 'Initial Name'
+          subject[:ignore_exceptions].should == []
         end
       end
 

data/spec/lib/appsignal/js_exception_transaction_spec.rb

@@ -8,7 +8,8 @@ describe Appsignal::JSExceptionTransaction do
       'message'     => 'foo is not a valid method',
       'action'      => 'ExceptionIncidentComponent',
       'path'        => 'foo.bar/moo',
-      'environment' => 'development',
+      'environment' => {"user_agent" => "Mozilla/5.0"},
+      'tags'        => {"intercom_user_id" => "abc123"},
       'backtrace'   => [
         'foo.bar/js:11:1',
         'foo.bar/js:22:2',
@@ -64,7 +65,8 @@ describe Appsignal::JSExceptionTransaction do
           :path        => 'foo.bar/moo',
           :kind        => 'frontend',
           :time        => 123,
-          :environment => 'development',
+          :environment => {"user_agent" => "Mozilla/5.0"},
+          :tags        => {"intercom_user_id" => "abc123"},
           :revision    => 'abcdef'
         },
         :exception => {

data/spec/lib/appsignal/transmitter_spec.rb

@@ -50,7 +50,9 @@ describe Appsignal::Transmitter do
       end
 
       it "should instantiate a new ZippedPayload" do
-        expect( Appsignal::ZippedPayload ).to receive(:new).and_return(payload)
+        expect( Appsignal::ZippedPayload ).to receive(:new).with({'the' => 'payload'})
+                                                           .and_return(payload)
+                                                           .at_least(:once)
         instance.transmit({'the' => 'payload'})
       end
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appsignal
 version: !ruby/object:Gem::Version
-  version: 0.11.15
+  version: 0.11.16
 platform: ruby
 authors:
 - Robert Beekman
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-04 00:00:00.000000000 Z
+date: 2015-10-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack