appsignal 0.11.0 → 0.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e9fd11fafb3322ce74b514c93301324d737e4946
-  data.tar.gz: 9075e749b6dd0f34b966057fd5e0535b5cde5e21
+  metadata.gz: d41abe0ea106adaa95e6273e1187136769252aaf
+  data.tar.gz: 3c1e7c0345cdd1e32eff0d33493025ac13b4e24f
 SHA512:
-  metadata.gz: 0fdbf566062f6f4aaad9c37f640ac0d39d0600807dccc1344b89f7518d9dcf325b921a11c362c6e279f0d3e401859932064827e1195fd0f06529f9c3d776afd7
-  data.tar.gz: c01cdf83266ffea67aa0131a5909485b96638948dea3e415fb30f7303182c98fe3e1f35a7ee89839924f7b0c17f55cf409ede336cb51e05c4c12342e76cd2dca
+  metadata.gz: 1d3dc0a5722caa2109cd7b15ef2bf9929df3e1927b6d2e16f17de79d27d01724d62f8266e4274a6dc8d4b9ea0d8bbf55786ad12f1d19dceaa4ebfde5d852f80f
+  data.tar.gz: 28001d15fced01dd048fd66dada12216ed8044cae66b0d7354964a1fcf6a467341a37003edb03b216af13a505052590d8842d1c3419eb24fec7870cf5fb8adfb

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+# 0.11.1
+* Allow a custom request_class and params_method on  Rack instrumentation
+* Loop through env methods instead of env
+* Add HTTP_CLIENT_IP to env methods
+
 # 0.11.0
 * Improved inter process communication
 * Retry sending data when the push api is not reachable

data/README.md

@@ -67,6 +67,7 @@ bundle --gemfile gemfiles/rails-3.1.gemfile
 bundle --gemfile gemfiles/rails-3.2.gemfile
 bundle --gemfile gemfiles/rails-4.0.gemfile
 bundle --gemfile gemfiles/rails-4.1.gemfile
+bundle --gemfile gemfiles/rails-4.2.gemfile
 bundle --gemfile gemfiles/sinatra.gemfile
 ```
 
@@ -81,6 +82,7 @@ BUNDLE_GEMFILE=gemfiles/rails-3.1.gemfile bundle exec rspec
 BUNDLE_GEMFILE=gemfiles/rails-3.2.gemfile bundle exec rspec
 BUNDLE_GEMFILE=gemfiles/rails-4.0.gemfile bundle exec rspec
 BUNDLE_GEMFILE=gemfiles/rails-4.1.gemfile bundle exec rspec
+BUNDLE_GEMFILE=gemfiles/rails-4.2.gemfile bundle exec rspec
 BUNDLE_GEMFILE=gemfiles/sinatra.gemfile bundle exec rspec
 ```
 

data/Rakefile

@@ -7,6 +7,7 @@ GEMFILES = %w(
   rails-3.2
   rails-4.0
   rails-4.1
+  rails-4.2
   sinatra
 )
 

data/gemfiles/rails-4.1.gemfile

@@ -1,6 +1,6 @@
 source 'https://rubygems.org'
 
-gem 'rails', '~> 4.1.0.beta'
+gem 'rails', '~> 4.1.0'
 
 gem 'generator_spec'
 

data/gemfiles/rails-4.2.gemfile

@@ -0,0 +1,7 @@
+source 'https://rubygems.org'
+
+gem 'rails', '~> 4.2.0.rc'
+
+gem 'generator_spec'
+
+gemspec :path => '../'

data/lib/appsignal/rack/instrumentation.rb

@@ -16,10 +16,11 @@ module Appsignal
       end
 
       def raw_payload(env)
-        request = ::Rack::Request.new(env)
+        request = @options.fetch(:request_class, ::Rack::Request).new(env)
+        params = request.public_send(@options.fetch(:params_method, :params))
         {
           :action => "#{request.request_method}:#{request.path}",
-          :params => request.params,
+          :params => params,
           :method => request.request_method,
           :path   => request.path
         }

data/lib/appsignal/transaction.rb

@@ -9,7 +9,7 @@ module Appsignal
     HTTP_X_QUEUE_TIME HTTP_X_HEROKU_QUEUE_WAIT_TIME HTTP_X_APPLICATION_START
     HTTP_ACCEPT HTTP_ACCEPT_CHARSET HTTP_ACCEPT_ENCODING HTTP_ACCEPT_LANGUAGE
     HTTP_CACHE_CONTROL HTTP_CONNECTION HTTP_USER_AGENT HTTP_FROM HTTP_NEGOTIATE
-    HTTP_PRAGMA HTTP_REFERER HTTP_X_FORWARDED_FOR).freeze
+    HTTP_PRAGMA HTTP_REFERER HTTP_X_FORWARDED_FOR HTTP_CLIENT_IP).freeze
 
     def self.create(request_id, env)
       Appsignal.logger.debug("Creating transaction: #{request_id}")
@@ -197,8 +197,8 @@ module Appsignal
 
     def sanitize_environment!
       return unless env
-      env.each do |key, value|
-        sanitized_environment[key] = value if ENV_METHODS.include?(key)
+      ENV_METHODS.each do |key|
+        sanitized_environment[key] = env[key]
       end
     end
 

data/lib/appsignal/version.rb

@@ -1,3 +1,3 @@
 module Appsignal
-  VERSION = '0.11.0'
+  VERSION = '0.11.1'
 end

data/spec/lib/appsignal/rack/instrumentation_spec.rb

@@ -46,4 +46,28 @@ describe Appsignal::Rack::Instrumentation do
       :path => '/homepage'
     } }
   end
+
+  describe "use a custom request class and parameters method" do
+    let(:request_class) do
+      double(
+        new: double(
+          request_method: 'POST',
+          path: '/somewhere',
+          filtered_params: {'param' => 'changed_something'}
+        )
+      )
+    end
+    let(:options) do
+      { request_class: request_class, params_method: :filtered_params }
+    end
+    let(:middleware) { Appsignal::Rack::Instrumentation.new(app, options) }
+    subject { middleware.raw_payload(env) }
+
+    it { should == {
+      :action => 'POST:/somewhere',
+      :params => {'param' => 'changed_something'},
+      :method => 'POST',
+      :path => '/somewhere'
+    } }
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appsignal
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.11.1
 platform: ruby
 authors:
 - Robert Beekman
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-17 00:00:00.000000000 Z
+date: 2014-12-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rack
@@ -138,6 +138,7 @@ files:
 - gemfiles/rails-3.2.gemfile
 - gemfiles/rails-4.0.gemfile
 - gemfiles/rails-4.1.gemfile
+- gemfiles/rails-4.2.gemfile
 - gemfiles/sinatra.gemfile
 - lib/appsignal.rb
 - lib/appsignal/agent.rb