approvals-approval_tests 0.0.3 → 0.0.4

data/Rakefile

@@ -13,9 +13,8 @@ begin
     gemspec.summary = "Approval testing library"
     gemspec.email = "approvaltests@dangilkerson.com"
     gemspec.homepage = "http://github.com/approvaltests/approval_tests"
-    gemspec.description = "Approval testing library for ruby"
+    gemspec.description = "Approval testing library"
     gemspec.authors = ["Dan Gilkerson, Llewellyn Falco"]
-    gemspec.rubyforge_project = 'approvaltests'
   end
 rescue LoadError
   puts "Jeweler not available. Install it with: sudo gem install technicalpickles-jeweler -s http://gems.github.com"

data/approval_tests.gemspec

@@ -2,12 +2,12 @@
 
 Gem::Specification.new do |s|
   s.name = %q{approval_tests}
-  s.version = "0.0.3"
+  s.version = "0.0.4"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Dan Gilkerson, Llewellyn Falco"]
-  s.date = %q{2009-07-03}
-  s.description = %q{Approval testing library for ruby}
+  s.date = %q{2009-07-02}
+  s.description = %q{Approval testing library}
   s.email = %q{approvaltests@dangilkerson.com}
   s.extra_rdoc_files = [
     "README"
@@ -27,18 +27,13 @@ Gem::Specification.new do |s|
      "lib/approval_tests/reporters/text_mate_reporter.rb",
      "lib/approval_tests/writers/html_writer.rb",
      "lib/approval_tests/writers/text_writer.rb",
-     "lib/approval_tests/writers/xml_writer.rb",
      "spec/a.txt",
-     "spec/approvals_lists_should_show_empty_lists.approved.txt",
-     "spec/approvals_lists_should_write_arrays.approved.txt",
-     "spec/approvals_lists_should_write_maps.approved.txt",
      "spec/approvals_multiple_describes_should_approve_multiple_describes.approved.txt",
      "spec/approvals_should_approve_shared_behaviors.approved.txt",
      "spec/approvals_should_successfully_approve_text.approved.txt",
      "spec/approvals_spec.rb",
      "spec/approvals_using_approval_blocks.approved.txt",
      "spec/approvals_using_approval_blocks_the_last_statement.approved.txt",
-     "spec/approvals_xml_should_be_pretty.approved.txt",
      "spec/b.txt",
      "spec/cleanup_reporter.rb",
      "spec/spec.opts",
@@ -47,7 +42,6 @@ Gem::Specification.new do |s|
   s.homepage = %q{http://github.com/approvaltests/approval_tests}
   s.rdoc_options = ["--charset=UTF-8"]
   s.require_paths = ["lib"]
-  s.rubyforge_project = %q{approvaltests}
   s.rubygems_version = %q{1.3.4}
   s.summary = %q{Approval testing library}
   s.test_files = [

data/lib/approval_tests/approvals.rb

@@ -4,7 +4,6 @@ require "#{__DIR__}/namers/rspec_namer"
 require "#{__DIR__}/approvers/file_approver"
 require "#{__DIR__}/writers/text_writer"
 require "#{__DIR__}/writers/html_writer"
-require "#{__DIR__}/writers/xml_writer"
 require "#{__DIR__}/reporters/quiet_reporter"
 require "#{__DIR__}/reporters/text_mate_reporter"
 require "#{__DIR__}/reporters/diff_reporter"
@@ -38,32 +37,25 @@ module ApprovalTests
         end
         approve(out)
       end
-      def approve(data)
-        approve_with_writer(TextWriter.new(data))
-      end
-      
-      def approve_html(data)
-        approve_with_writer(HtmlWriter.new(data))
-      end
-      
-      def approve_xml(data)
-        approve_with_writer(TextWriter.new(XmlWriter.pretty_xml(data)))
-      end
-      
-      def approve_with_writer(writer)
-          approver = FileApprover.new(writer, @namer)
-          if approver.approve()
-            approver.clean_up_after_success()
-          else
-            @reporter = get_default_reporter()
-            approver.report_failure(@reporter)
+      def approve(data, writer_option = :text)
+        case writer_option
+          when :html then writer = HtmlWriter.new(data)
+          when :text then writer = TextWriter.new(data)
+        end
+        
+        approver = FileApprover.new(writer, @namer)
+        if approver.approve()
+          approver.clean_up_after_success()
+        else
+          @reporter = get_default_reporter()
+          approver.report_failure(@reporter)
 
-            if @reporter.approved_when_reported()
-              approver.clean_up_after_sucess()
-            else
-              approver.fail()
-            end
+          if @reporter.approved_when_reported()
+            approver.clean_up_after_sucess()
+          else
+            approver.fail()
           end
+        end
       end
       
       def namer=(namer)

data/spec/approvals_spec.rb

@@ -45,11 +45,6 @@ describe "Approvals" do
     end
   end
   
-  describe "xml" do
-    it "should be pretty" do
-      Approvals.approve_xml('<?xml version="1.0" encoding="ISO-8859-1"?><data><a><b>Bee</b><c>Sea</c></a></data>')
-    end
-  end
   
   describe "DiffReporter" do
     it "should launch" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: approvals-approval_tests
 version: !ruby/object:Gem::Version 
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors: 
 - Dan Gilkerson, Llewellyn Falco
@@ -9,11 +9,11 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-07-03 00:00:00 -07:00
+date: 2009-07-02 00:00:00 -07:00
 default_executable: 
 dependencies: []
 
-description: Approval testing library for ruby
+description: Approval testing library
 email: approvaltests@dangilkerson.com
 executables: []
 
@@ -36,18 +36,13 @@ files:
 - lib/approval_tests/reporters/text_mate_reporter.rb
 - lib/approval_tests/writers/html_writer.rb
 - lib/approval_tests/writers/text_writer.rb
-- lib/approval_tests/writers/xml_writer.rb
 - spec/a.txt
-- spec/approvals_lists_should_show_empty_lists.approved.txt
-- spec/approvals_lists_should_write_arrays.approved.txt
-- spec/approvals_lists_should_write_maps.approved.txt
 - spec/approvals_multiple_describes_should_approve_multiple_describes.approved.txt
 - spec/approvals_should_approve_shared_behaviors.approved.txt
 - spec/approvals_should_successfully_approve_text.approved.txt
 - spec/approvals_spec.rb
 - spec/approvals_using_approval_blocks.approved.txt
 - spec/approvals_using_approval_blocks_the_last_statement.approved.txt
-- spec/approvals_xml_should_be_pretty.approved.txt
 - spec/b.txt
 - spec/cleanup_reporter.rb
 - spec/spec.opts
@@ -73,7 +68,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
   version: 
 requirements: []
 
-rubyforge_project: approvaltests
+rubyforge_project: 
 rubygems_version: 1.2.0
 signing_key: 
 specification_version: 3

data/lib/approval_tests/writers/xml_writer.rb

@@ -1,81 +0,0 @@
-require 'rexml/document'
-include REXML
-
-module ApprovalTests
-  module Writers
-    class XmlWriter
-      def initialize(data)
-        @data = data
-      end
-      
-      def get_approval_filename(basename)
-        basename + ".approved.xml"
-      end
-      
-      def get_received_filename(basename)
-        basename + ".received.xml"
-      end
-      
-      def write_received_file(received)
-        f = File.new("#{received}", "w+")
-        f.write(@data)
-        f.close()
-        f.path
-      end
-      class << self
-        def pretty_print(parent_node, itab)
-          buffer = ''
-
-          parent_node.elements.each do |node|
-
-            buffer += ' ' * itab + "<#{node.name}#{get_att_list(node)}"
-
-            if node.to_a.length > 0
-              buffer += ">"
-              if node.text.nil?
-                buffer += "\n"
-                buffer += pretty_print(node,itab+2) 
-                buffer += ' ' * itab + "</#{node.name}>\n"
-              else
-                node_text = node.text.strip
-                if node_text != ''
-                  buffer += node_text 
-                  buffer += "</#{node.name}>\n"        
-                else
-                  buffer += "\n" + pretty_print(node,itab+2) 
-                  buffer += ' ' * itab + "</#{node.name}>\n"        
-                end
-              end
-            else
-              buffer += "/>\n"
-            end
-
-          end
-          buffer
-        end
-
-        def get_att_list(node)
-          att_list = ''
-          node.attributes.each { |attribute, val| att_list += " #{attribute}='#{val}'" }
-          att_list
-        end
-
-        def pretty_xml(xml_string)
-          doc = Document.new(xml_string)
-
-          buffer = ''
-          xml_declaration = doc.to_s.match('<\?.*\?>').to_s
-          buffer += "#{xml_declaration}\n" if not xml_declaration.nil?
-          xml_doctype = doc.to_s.match('<\!.*\">').to_s
-          buffer += "#{xml_doctype}\n" if not xml_doctype.nil?
-          buffer += "<#{doc.root.name}#{get_att_list(doc.root)}"
-          if doc.root.to_a.length > 0
-            buffer +=">\n#{pretty_print(doc.root,2)}</#{doc.root.name}>"
-          else
-            buffer += "/>\n"
-          end
-        end
-      end
-    end
-  end
-end

data/spec/approvals_lists_should_show_empty_lists.approved.txt

@@ -1 +0,0 @@
-tv.count = 0

data/spec/approvals_lists_should_write_arrays.approved.txt

@@ -1 +0,0 @@
-name[0] = tom 

data/spec/approvals_lists_should_write_maps.approved.txt

@@ -1 +0,0 @@
-[name] = harry 

data/spec/approvals_xml_should_be_pretty.approved.txt

@@ -1,8 +0,0 @@
-<?xml version='1.0' encoding='ISO-8859-1'?>
-
-<data>
-  <a>
-    <b>Bee</b>
-    <c>Sea</c>
-  </a>
-</data>