appraisal 1.0.0.beta3 → 1.0.0

data/spec/acceptance/gemspec_spec.rb

@@ -0,0 +1,75 @@
+require 'spec_helper'
+
+describe 'Gemspec' do
+  before do
+    build_appraisal_file
+    build_rakefile
+  end
+
+  it 'supports gemspec syntax with default options' do
+    build_gemspec
+
+    write_file 'Gemfile', <<-Gemfile
+      gem 'appraisal', path: #{PROJECT_ROOT.inspect}
+
+      gemspec
+    Gemfile
+
+    run 'bundle install --local'
+    run 'appraisal install'
+    output = run 'appraisal rake version'
+
+    expect(output).to include 'Loaded 1.1.0'
+  end
+
+  it 'supports gemspec syntax with path option' do
+    build_gemspec 'specdir'
+
+    write_file 'Gemfile', <<-Gemfile
+      gem 'appraisal', path: #{PROJECT_ROOT.inspect}
+
+      gemspec path: './specdir'
+    Gemfile
+
+    run 'bundle install --local'
+    run 'appraisal install'
+    output = run 'appraisal rake version'
+
+    expect(output).to include 'Loaded 1.1.0'
+  end
+
+  def build_appraisal_file
+    super <<-Appraisals
+      appraise 'stock' do
+        gem 'rake'
+      end
+    Appraisals
+  end
+
+  def build_rakefile
+    write_file 'Rakefile', <<-rakefile
+      require 'rubygems'
+      require 'bundler/setup'
+      require 'appraisal'
+
+      task :version do
+        require 'dummy'
+        puts "Loaded \#{$dummy_version}"
+      end
+    rakefile
+  end
+
+  def build_gemspec(path = '.')
+    Dir.mkdir("tmp/stage/#{path}") rescue nil
+
+    write_file File.join(path, 'gemspec_project.gemspec'), <<-gemspec
+      Gem::Specification.new do |s|
+        s.name = 'gemspec_project'
+        s.version = '0.1'
+        s.summary = 'Awesome Gem!'
+
+        s.add_development_dependency('dummy', '1.1.0')
+      end
+    gemspec
+  end
+end

data/spec/appraisal/gemspec_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+require 'appraisal/gemspec'
+
+describe Appraisal::Gemspec do
+  describe '#to_s' do
+    context 'when path is an absolute path' do
+      it 'returns the path as-is' do
+        gemspec = Appraisal::Gemspec.new(path: '/tmp')
+
+        expect(gemspec.to_s).to eq 'gemspec :path => "/tmp"'
+      end
+    end
+
+    context 'when path contains "./"' do
+      it 'strips out "./"' do
+        gemspec = Appraisal::Gemspec.new(path: './tmp/./appraisal././')
+
+        expect(gemspec.to_s).to eq 'gemspec :path => "../tmp/appraisal./"'
+      end
+    end
+  end
+end

data/spec/appraisal/utils_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+require 'appraisal/utils'
+
+describe Appraisal::Utils do
+  describe '.format_string' do
+    it 'prints out a nice looking hash without a brackets' do
+      hash = { :foo => 'bar', 'baz' => { :ball => 'boo' } }
+
+      expect(Appraisal::Utils.format_string(hash)).to eq(
+        ':foo => "bar", "baz" => { :ball => "boo" }'
+      )
+    end
+  end
+
+  describe '.format_arguments' do
+    it 'prints out arguments without enclosing square brackets' do
+      arguments = [:foo, bar: { baz: 'ball' }]
+
+      expect(Appraisal::Utils.format_arguments(arguments)).to eq(
+        ':foo, :bar => { :baz => "ball" }'
+      )
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,6 +1,5 @@
 require 'rubygems'
 require 'bundler/setup'
-require 'aruba/api'
 require './spec/support/acceptance_test_helpers'
 
 PROJECT_ROOT = File.expand_path(File.join(File.dirname(__FILE__), '..')).freeze

data/spec/support/acceptance_test_helpers.rb

@@ -1,23 +1,25 @@
 require 'rspec/expectations/expectation_target'
 require 'active_support/core_ext/string/strip'
 require 'active_support/concern'
-require './features/support/dependency_helpers'
+require 'appraisal/utils'
+require_relative 'dependency_helpers'
 
 module AcceptanceTestHelpers
   extend ActiveSupport::Concern
-  include Aruba::Api
   include DependencyHelpers
 
+  BUNDLER_ENVIRONMENT_VARIABLES = %w(RUBYOPT BUNDLE_PATH BUNDLE_BIN_PATH
+    BUNDLE_GEMFILE)
+
   included do
     metadata[:type] = :acceptance
 
     before :all do
-      initialize_aruba_instance_variables
       build_default_dummy_gems
     end
 
     after :all do
-      cleanup_default_gems
+      cleanup_gem_home
     end
 
     before parallel: true do
@@ -28,13 +30,38 @@ module AcceptanceTestHelpers
 
     before do
       cleanup_artifacts
+      save_environment_variables
+      unset_bundler_environment_variables
+      add_binstub_path
       build_default_gemfile
-      unset_bundler_env_vars
-      ENV["GEM_PATH"] = [TMP_GEM_ROOT, ENV["GEM_PATH"]].join(":")
     end
 
     after do
-      restore_env
+      restore_environment_variables
+    end
+  end
+
+  def save_environment_variables
+    @original_environment_variables = {}
+
+    (BUNDLER_ENVIRONMENT_VARIABLES + %w(PATH)).each do |key|
+      @original_environment_variables[key] = ENV[key]
+    end
+  end
+
+  def unset_bundler_environment_variables
+    BUNDLER_ENVIRONMENT_VARIABLES.each do |key|
+      ENV[key] = nil
+    end
+  end
+
+  def add_binstub_path
+    ENV['PATH'] = "bin:#{ENV['PATH']}"
+  end
+
+  def restore_environment_variables
+    @original_environment_variables.each_pair do |key, value|
+      ENV[key] = value
     end
   end
 
@@ -47,15 +74,15 @@ module AcceptanceTestHelpers
   end
 
   def add_gemspec_to_gemfile
-    append_to_file 'gemfile', 'gemspec'
+    in_test_directory do
+      File.open('Gemfile', 'a') { |file| file.puts 'gemspec' }
+    end
   end
 
   def build_gemspec
-    gem_name = dirs.last
-
-    write_file "#{gem_name}.gemspec", <<-gemspec
+    write_file "stage.gemspec", <<-gemspec
       Gem::Specification.new do |s|
-        s.name = '#{gem_name}'
+        s.name = 'stage'
         s.version = '0.1'
         s.summary = 'Awesome Gem!'
       end
@@ -67,41 +94,29 @@ module AcceptanceTestHelpers
   end
 
   def file(path)
-    Pathname.new(current_dir) + path
+    Pathname.new(current_directory) + path
   end
 
   def be_exists
     be_exist
   end
 
-  def run_simple(command, fail_on_error = true)
-    super "bundle exec #{command}", fail_on_error
-  end
+  private
 
-  def output_from(command)
-    super "bundle exec #{command}"
-  rescue ArgumentError
-    super command
+  def current_directory
+    File.expand_path('tmp/stage')
   end
 
-  private
-
-  def cleanup_artifacts
-    FileUtils.rm_rf(current_dir)
+  def write_file(filename, content)
+    in_test_directory { File.open(filename, 'w') { |file| file.puts content } }
   end
 
-  def cleanup_default_gems
-    FileUtils.rm_rf(TMP_GEM_ROOT)
+  def cleanup_artifacts
+    FileUtils.rm_rf current_directory
   end
 
-  def initialize_aruba_instance_variables
-    @announce_stdout = nil
-    @announce_stderr = nil
-    @announce_cmd = nil
-    @announce_dir = nil
-    @announce_env = nil
-    @aruba_timeout_seconds = 60
-    @aruba_io_wait_seconds = nil
+  def cleanup_gem_home
+    FileUtils.rm_rf TMP_GEM_ROOT
   end
 
   def build_default_dummy_gems
@@ -116,8 +131,31 @@ module AcceptanceTestHelpers
     build_gemfile <<-Gemfile
       source 'https://rubygems.org'
 
-      gem 'dummy'
       gem 'appraisal', :path => '#{PROJECT_ROOT}'
     Gemfile
+
+    in_test_directory do
+      `bundle install --binstubs --local`
+    end
+  end
+
+  def in_test_directory(&block)
+    FileUtils.mkdir_p current_directory
+    Dir.chdir current_directory, &block
+  end
+
+  def run(command, raise_on_error = true)
+    in_test_directory do
+      `#{command}`.tap do |output|
+        exitstatus = $?.exitstatus
+
+        if raise_on_error && exitstatus != 0
+          raise RuntimeError, <<-error_message.strip_heredoc
+            Command #{command.inspect} exited with status #{exitstatus}. Output:
+            #{output.gsub(/^/, '  ')}
+          error_message
+        end
+      end
+    end
   end
 end

data/spec/support/dependency_helpers.rb

@@ -0,0 +1,49 @@
+module DependencyHelpers
+  def build_gem(gem_name, version = '1.0.0')
+    ENV['GEM_HOME'] = TMP_GEM_ROOT
+
+    unless File.exist? "tmp/gems/gems/#{gem_name}-#{version}"
+      FileUtils.mkdir_p "tmp/gems/#{gem_name}/lib"
+
+      FileUtils.cd "tmp/gems/#{gem_name}" do
+        gemspec = "#{gem_name}.gemspec"
+        lib_file = "lib/#{gem_name}.rb"
+
+        File.open gemspec, 'w' do |file|
+          file.puts <<-gemspec
+            Gem::Specification.new do |s|
+              s.name    = #{gem_name.inspect}
+              s.version = #{version.inspect}
+              s.authors = 'Mr. Smith'
+              s.summary = 'summary'
+              s.files   = #{lib_file.inspect}
+            end
+          gemspec
+        end
+
+        File.open lib_file, 'w' do |file|
+          file.puts "$#{gem_name}_version = '#{version}'"
+        end
+
+        `gem build #{gemspec} 2>&1`
+        `gem install -lN #{gem_name}-#{version}.gem -v #{version} 2>&1`
+      end
+    end
+  end
+
+  def build_gems(gems)
+    gems.each { |gem| build_gem(gem) }
+  end
+
+  def build_git_gem(gem_name, version = '1.0.0')
+    build_gem gem_name, version
+
+    Dir.chdir "tmp/gems/#{gem_name}" do
+      `git init .`
+      `git config user.email "appraisal@thoughtbot.com"`
+      `git config user.name "Appraisal"`
+      `git add .`
+      `git commit -a -m "initial commit"`
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appraisal
 version: !ruby/object:Gem::Version
-  version: 1.0.0.beta3
+  version: 1.0.0
 platform: ruby
 authors:
 - Joe Ferris
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-28 00:00:00.000000000 Z
+date: 2014-04-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -67,20 +67,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.13
-- !ruby/object:Gem::Dependency
-  name: cucumber
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -95,20 +81,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.6'
-- !ruby/object:Gem::Dependency
-  name: aruba
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.5.1
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.5.1
 description: Appraisal integrates with bundler and rake to test your library against
   different versions of dependencies in repeatable scenarios called "appraisals."
 email:
@@ -129,35 +101,42 @@ files:
 - Rakefile
 - appraisal.gemspec
 - bin/appraisal
-- features/appraisals.feature
-- features/bundler_gemfile_compatibility.feature
-- features/gemspec.feature
-- features/missing_appraisals_file.feature
-- features/step_definitions/dependency_steps.rb
-- features/support/aruba.rb
 - features/support/dependency_helpers.rb
-- features/support/env.rb
 - lib/appraisal.rb
 - lib/appraisal/appraisal.rb
 - lib/appraisal/cli.rb
 - lib/appraisal/command.rb
 - lib/appraisal/dependency.rb
+- lib/appraisal/dependency_list.rb
 - lib/appraisal/errors.rb
 - lib/appraisal/file.rb
 - lib/appraisal/gemfile.rb
 - lib/appraisal/gemspec.rb
 - lib/appraisal/git_source.rb
 - lib/appraisal/group.rb
+- lib/appraisal/path_source.rb
 - lib/appraisal/platform.rb
 - lib/appraisal/task.rb
 - lib/appraisal/utils.rb
 - lib/appraisal/version.rb
-- spec/acceptance/cli_spec.rb
+- spec/acceptance/appraisals_file_bundler_dsl_compatibility_spec.rb
+- spec/acceptance/cli/clean_spec.rb
+- spec/acceptance/cli/generate_spec.rb
+- spec/acceptance/cli/help_spec.rb
+- spec/acceptance/cli/install_spec.rb
+- spec/acceptance/cli/run_spec.rb
+- spec/acceptance/cli/update_spec.rb
+- spec/acceptance/cli/with_no_arguments_spec.rb
+- spec/acceptance/gemfile_dsl_compatibility_spec.rb
+- spec/acceptance/gemspec_spec.rb
 - spec/appraisal/appraisal_spec.rb
 - spec/appraisal/file_spec.rb
 - spec/appraisal/gemfile_spec.rb
+- spec/appraisal/gemspec_spec.rb
+- spec/appraisal/utils_spec.rb
 - spec/spec_helper.rb
 - spec/support/acceptance_test_helpers.rb
+- spec/support/dependency_helpers.rb
 homepage: http://github.com/thoughtbot/appraisal
 licenses:
 - MIT
@@ -173,9 +152,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.2.2
@@ -183,17 +162,22 @@ signing_key:
 specification_version: 4
 summary: Find out what your Ruby gems are worth
 test_files:
-- features/appraisals.feature
-- features/bundler_gemfile_compatibility.feature
-- features/gemspec.feature
-- features/missing_appraisals_file.feature
-- features/step_definitions/dependency_steps.rb
-- features/support/aruba.rb
 - features/support/dependency_helpers.rb
-- features/support/env.rb
-- spec/acceptance/cli_spec.rb
+- spec/acceptance/appraisals_file_bundler_dsl_compatibility_spec.rb
+- spec/acceptance/cli/clean_spec.rb
+- spec/acceptance/cli/generate_spec.rb
+- spec/acceptance/cli/help_spec.rb
+- spec/acceptance/cli/install_spec.rb
+- spec/acceptance/cli/run_spec.rb
+- spec/acceptance/cli/update_spec.rb
+- spec/acceptance/cli/with_no_arguments_spec.rb
+- spec/acceptance/gemfile_dsl_compatibility_spec.rb
+- spec/acceptance/gemspec_spec.rb
 - spec/appraisal/appraisal_spec.rb
 - spec/appraisal/file_spec.rb
 - spec/appraisal/gemfile_spec.rb
+- spec/appraisal/gemspec_spec.rb
+- spec/appraisal/utils_spec.rb
 - spec/spec_helper.rb
 - spec/support/acceptance_test_helpers.rb
+- spec/support/dependency_helpers.rb