appraisal 0.5.2 → 1.0.0.beta1

data/lib/appraisal/utils.rb

@@ -0,0 +1,8 @@
+module Appraisal
+  # Contains methods for various operations
+  module Utils
+    def self.support_parallel_installation?
+      Gem::Version.create(Bundler::VERSION) >= Gem::Version.create('1.4.0.pre.1')
+    end
+  end
+end

data/lib/appraisal/version.rb

@@ -1,3 +1,3 @@
 module Appraisal
-  VERSION = '0.5.2'.freeze
+  VERSION = '1.0.0.beta1'.freeze
 end

data/spec/acceptance/cli_spec.rb

@@ -0,0 +1,233 @@
+require 'spec_helper'
+require 'appraisal/utils'
+
+describe 'CLI' do
+  context 'appraisal (with no arguments)' do
+    it 'runs install command' do
+      build_appraisal_file <<-Appraisal
+        appraise '1.0.0' do
+          gem 'dummy', '1.0.0'
+        end
+      Appraisal
+
+      run_simple 'appraisal'
+
+      expect(file 'gemfiles/1.0.0.gemfile').to be_exists
+      expect(file 'gemfiles/1.0.0.gemfile.lock').to be_exists
+    end
+  end
+
+  context 'appraisal (with arguments)' do
+    before do
+      build_appraisal_file <<-Appraisal
+        appraise '1.0.0' do
+          gem 'dummy', '1.0.0'
+        end
+
+        appraise '1.1.0' do
+          gem 'dummy', '1.1.0'
+        end
+      Appraisal
+
+      run_simple 'appraisal install'
+      write_file 'test.rb', 'puts "Running: #{$dummy_version}"'
+    end
+
+    it 'sets APPRAISAL_INITIALIZED environment variable' do
+      write_file 'test.rb', <<-TEST_FILE.strip_heredoc
+        if ENV['APPRAISAL_INITIALIZED']
+          puts "Appraisal initialized!"
+        end
+      TEST_FILE
+
+      test_command = 'appraisal 1.0.0 ruby -rbundler/setup -rdummy test.rb'
+      run_simple test_command
+      expect(output_from test_command).to include 'Appraisal initialized!'
+    end
+
+    context 'with appraisal name' do
+      it 'runs the given command against a correct versions of dependency' do
+        test_command = 'appraisal 1.0.0 ruby -rbundler/setup -rdummy test.rb'
+        run_simple test_command
+
+        expect(output_from test_command).to include 'Running: 1.0.0'
+        expect(output_from test_command).to_not include 'Running: 1.1.0'
+      end
+    end
+
+    context 'without appraisal name' do
+      it 'runs the given command against all versions of dependency' do
+        test_command = 'appraisal ruby -rbundler/setup -rdummy test.rb'
+        run_simple test_command
+
+        expect(output_from test_command).to include 'Running: 1.0.0'
+        expect(output_from test_command).to include 'Running: 1.1.0'
+      end
+    end
+  end
+
+  context 'appraisal generate' do
+    it 'generates the gemfiles' do
+      build_appraisal_file <<-Appraisal
+        appraise '1.0.0' do
+          gem 'dummy', '1.0.0'
+        end
+
+        appraise '1.1.0' do
+          gem 'dummy', '1.1.0'
+        end
+      Appraisal
+
+      run_simple 'appraisal generate'
+
+      expect(file 'gemfiles/1.0.0.gemfile').to be_exists
+      expect(file 'gemfiles/1.1.0.gemfile').to be_exists
+      expect(content_of 'gemfiles/1.0.0.gemfile').to eq <<-gemfile.strip_heredoc
+        # This file was generated by Appraisal
+
+        source "https://rubygems.org"
+
+        gem "appraisal", :path=>"#{PROJECT_ROOT}"
+        gem "dummy", "1.0.0"
+      gemfile
+    end
+  end
+
+  context 'appraisal install' do
+    it 'installs the dependencies' do
+      build_appraisal_file <<-Appraisal
+        appraise '1.0.0' do
+          gem 'dummy', '1.0.0'
+        end
+
+        appraise '1.1.0' do
+          gem 'dummy', '1.1.0'
+        end
+      Appraisal
+
+      run_simple 'appraisal install'
+
+      expect(file 'gemfiles/1.0.0.gemfile.lock').to be_exists
+      expect(file 'gemfiles/1.1.0.gemfile.lock').to be_exists
+    end
+
+    it 'relativize directory in gemfile.lock' do
+      build_gemspec
+      add_gemspec_to_gemfile
+      build_appraisal_file <<-Appraisal
+        appraise '1.0.0' do
+          gem 'dummy', '1.0.0'
+        end
+      Appraisal
+
+      run_simple 'appraisal install'
+
+      expect(content_of 'gemfiles/1.0.0.gemfile.lock').not_to include current_dir
+    end
+
+    context 'with job size', parallel: true do
+      before do
+        build_appraisal_file <<-Appraisal
+          appraise '1.0.0' do
+            gem 'dummy', '1.0.0'
+          end
+        Appraisal
+      end
+
+      it 'accepts --jobs option to set job size' do
+        run_simple 'appraisal install --jobs=2'
+
+        expect(output_from 'appraisal install --jobs=2').to include
+          'bundle install --gemfile=gemfiles/1.0.0.gemfile --jobs=2'
+      end
+
+      it 'ignores --jobs option if the job size is less than or equal to 1' do
+        run_simple 'appraisal install --jobs=0'
+
+        expect(output_from 'appraisal install --jobs=0').not_to include
+          'bundle install --gemfile=gemfiles/1.0.0.gemfile'
+        expect(output_from 'appraisal install --jobs=0').not_to include
+          'bundle install --gemfile=gemfiles/1.0.0.gemfile --jobs=0'
+        expect(output_from 'appraisal install --jobs=0').not_to include
+          'bundle install --gemfile=gemfiles/1.0.0.gemfile --jobs=1'
+      end
+    end
+  end
+
+  context 'appraisal clean' do
+    it 'remove all gemfiles from gemfiles directory' do
+      build_appraisal_file <<-Appraisal
+        appraise '1.0.0' do
+          gem 'dummy', '1.0.0'
+        end
+      Appraisal
+
+      run_simple 'appraisal install'
+      write_file 'gemfiles/non_related_file', ''
+
+      run_simple 'appraisal clean'
+
+      expect(file 'gemfiles/1.0.0.gemfile').not_to be_exists
+      expect(file 'gemfiles/1.0.0.gemfile.lock').not_to be_exists
+      expect(file 'gemfiles/non_related_file').to be_exists
+    end
+  end
+
+  context 'appraisal update' do
+    before do
+      build_gem 'dummy2', '1.0.0'
+
+      build_appraisal_file <<-Appraisal
+        appraise 'dummy' do
+          gem 'dummy', '~> 1.0.0'
+          gem 'dummy2', '~> 1.0.0'
+        end
+      Appraisal
+
+      run_simple 'appraisal install'
+      build_gem 'dummy', '1.0.1'
+      build_gem 'dummy2', '1.0.1'
+    end
+
+    after do
+      in_current_dir do
+        `gem uninstall dummy -v 1.0.1`
+        `gem uninstall dummy2 -a`
+      end
+    end
+
+    context 'with no arguments' do
+      it 'updates all the gems' do
+        run_simple 'appraisal update'
+
+        expect(content_of 'gemfiles/dummy.gemfile.lock').to include 'dummy (1.0.1)'
+        expect(content_of 'gemfiles/dummy.gemfile.lock').to include 'dummy2 (1.0.1)'
+      end
+    end
+
+    context 'with a list of gems' do
+      it 'only updates specified gems' do
+        run_simple 'appraisal update dummy'
+
+        expect(content_of 'gemfiles/dummy.gemfile.lock').to include 'dummy (1.0.1)'
+        expect(content_of 'gemfiles/dummy.gemfile.lock').to include 'dummy2 (1.0.0)'
+      end
+    end
+  end
+
+  context 'appraisal help' do
+    it 'prints usage along with commands, and list of appraisals' do
+      build_appraisal_file <<-Appraisal
+        appraise '1.0.0' do
+          gem 'dummy', '1.0.0'
+        end
+      Appraisal
+
+      run_simple 'appraisal help'
+
+      expect(output_from 'appraisal help').to include 'Usage:'
+      expect(output_from 'appraisal help').to include 'appraisal [APPRAISAL_NAME] EXTERNAL_COMMAND'
+      expect(output_from 'appraisal help').to include '1.0.0'
+    end
+  end
+end

data/spec/appraisal/appraisal_spec.rb

@@ -1,14 +1,9 @@
 require 'spec_helper'
 require 'appraisal/appraisal'
+require 'tempfile'
+require 'active_support/core_ext/kernel/reporting'
 
 describe Appraisal::Appraisal do
-  it "creates a proper bundle command" do
-    appraisal = Appraisal::Appraisal.new('fake', 'fake')
-    appraisal.stub(:gemfile_path).and_return("/home/test/test directory")
-
-    appraisal.bundle_command.should == "bundle check --gemfile='/home/test/test directory' || bundle install --gemfile='/home/test/test directory'"
-  end
-
   it "converts spaces to underscores in the gemfile path" do
     appraisal = Appraisal::Appraisal.new("one two", "Gemfile")
     appraisal.gemfile_path.should =~ /one_two\.gemfile$/
@@ -23,4 +18,63 @@ describe Appraisal::Appraisal do
     appraisal = Appraisal::Appraisal.new("rails3.0", "Gemfile")
     appraisal.gemfile_path.should =~ /rails3\.0\.gemfile$/
   end
+
+  context 'gemfiles generation' do
+    before do
+      @output = Tempfile.new('output')
+    end
+
+    after do
+      @output.close
+      @output.unlink
+    end
+
+    it 'generates a gemfile with a newline at the end of file' do
+      appraisal = Appraisal::Appraisal.new('fake', 'fake')
+      appraisal.stub(:gemfile_path) { @output.path }
+      appraisal.write_gemfile
+      @output.read.should =~ /[^\n]*\n\z/m
+    end
+  end
+
+  context 'parallel installation' do
+    before do
+      @appraisal = Appraisal::Appraisal.new('fake', 'fake')
+      @appraisal.stub(:gemfile_path).and_return("/home/test/test directory")
+      Appraisal::Command.stub(:new => double(:run => true))
+    end
+
+    it 'runs single install command on Bundler < 1.4.0' do
+      stub_const('Bundler::VERSION', '1.3.0')
+
+      warning = capture(:stderr) do
+        @appraisal.install(42)
+      end
+
+      Appraisal::Command.should have_received(:new).
+        with("#{bundle_check_command} || #{bundle_single_install_command}")
+      warning.should include 'Please upgrade Bundler'
+    end
+
+    it 'runs parallel install command on Bundler >= 1.4.0' do
+      stub_const('Bundler::VERSION', '1.4.0')
+
+      @appraisal.install(42)
+
+      Appraisal::Command.should have_received(:new).
+        with("#{bundle_check_command} || #{bundle_parallel_install_command}")
+    end
+
+    def bundle_check_command
+      "bundle check --gemfile='/home/test/test directory'"
+    end
+
+    def bundle_single_install_command
+      "bundle install --gemfile='/home/test/test directory'"
+    end
+
+    def bundle_parallel_install_command
+      "bundle install --gemfile='/home/test/test directory' --jobs=42"
+    end
+  end
 end

data/spec/appraisal/file_spec.rb

@@ -0,0 +1,9 @@
+require 'spec_helper'
+require 'appraisal/file'
+
+describe Appraisal::File do
+  it "should complain when no Appraisals file is found" do
+    ::File.stub(:exist?).with("Appraisals").and_return(false)
+    expect { described_class.new }.to raise_error(Appraisal::AppraisalsNotFound)
+  end
+end

data/spec/appraisal/gemfile_spec.rb

@@ -1,5 +1,6 @@
 require 'spec_helper'
 require 'appraisal/gemfile'
+require 'active_support/core_ext/string/strip'
 
 describe Appraisal::Gemfile do
   it "supports gemfiles without sources" do
@@ -27,4 +28,46 @@ describe Appraisal::Gemfile do
     gemfile.source :one
     gemfile.to_s.strip.should == %{source :one}
   end
+
+  it 'supports group syntax' do
+    gemfile = Appraisal::Gemfile.new
+
+    gemfile.group :development, :test do
+      gem "one"
+    end
+
+    gemfile.to_s.should == <<-GEMFILE.strip_heredoc.strip
+      group :development, :test do
+        gem "one"
+      end
+    GEMFILE
+  end
+
+  context "excess new line" do
+    context "no contents" do
+      it "shows empty string" do
+        gemfile = Appraisal::Gemfile.new
+        gemfile.to_s.should eq ""
+      end
+    end
+
+    context "full contents" do
+      it "does not show newline at end" do
+        gemfile = Appraisal::Gemfile.new
+        gemfile.source "source"
+        gemfile.gem "gem"
+        gemfile.gemspec
+        gemfile.to_s.should =~ /[^\n]\z/m
+      end
+    end
+
+    context "no gemspec" do
+      it "does not show newline at end" do
+        gemfile = Appraisal::Gemfile.new
+        gemfile.source "source"
+        gemfile.gem "gem"
+        gemfile.to_s.should =~ /[^\n]\z/m
+      end
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -1,2 +1,13 @@
 require 'rubygems'
 require 'bundler/setup'
+require 'aruba/api'
+require './spec/support/acceptance_test_helpers'
+
+PROJECT_ROOT = File.expand_path(File.join(File.dirname(__FILE__), '..')).freeze
+TMP_GEM_ROOT = File.join(PROJECT_ROOT, "tmp", "gems")
+
+RSpec.configure do |config|
+  config.include AcceptanceTestHelpers, :type => :acceptance, :example_group => {
+    :file_path => %r{spec\/acceptance\/}
+  }
+end

data/spec/support/acceptance_test_helpers.rb

@@ -0,0 +1,113 @@
+require 'rspec/expectations/expectation_target'
+require 'active_support/core_ext/string/strip'
+require 'active_support/concern'
+require './features/support/dependency_helpers'
+
+module AcceptanceTestHelpers
+  extend ActiveSupport::Concern
+  include Aruba::Api
+  include DependencyHelpers
+
+  included do
+    metadata[:type] = :acceptance
+
+    before :all do
+      initialize_aruba_instance_variables
+      build_default_dummy_gems
+    end
+
+    after :all do
+      cleanup_default_gems
+    end
+
+    before parallel: true do
+      unless Appraisal::Utils.support_parallel_installation?
+        pending 'This Bundler version does not support --jobs flag.'
+      end
+    end
+
+    before do
+      cleanup_artifacts
+      build_default_gemfile
+      unset_bundler_env_vars
+      ENV["GEM_PATH"] = [TMP_GEM_ROOT, ENV["GEM_PATH"]].join(":")
+    end
+
+    after do
+      restore_env
+    end
+  end
+
+  def build_appraisal_file(content)
+    write_file 'Appraisals', content.strip_heredoc
+  end
+
+  def build_gemfile(content)
+    write_file 'Gemfile', content.strip_heredoc
+  end
+
+  def add_gemspec_to_gemfile
+    append_to_file 'gemfile', 'gemspec'
+  end
+
+  def build_gemspec
+    gem_name = dirs.last
+
+    write_file "#{gem_name}.gemspec", <<-gemspec
+      Gem::Specification.new do |s|
+        s.name = '#{gem_name}'
+        s.version = '0.1'
+        s.summary = 'Awesome Gem!'
+      end
+    gemspec
+  end
+
+  def content_of(path)
+    file(path).read
+  end
+
+  def file(path)
+    Pathname.new(current_dir) + path
+  end
+
+  def be_exists
+    be_exist
+  end
+
+  private
+
+  def cleanup_artifacts
+    FileUtils.rm_rf(current_dir)
+  end
+
+  def cleanup_default_gems
+    FileUtils.rm_rf(TMP_GEM_ROOT)
+  end
+
+  def initialize_aruba_instance_variables
+    @announce_stdout = nil
+    @announce_stderr = nil
+    @announce_cmd = nil
+    @announce_dir = nil
+    @announce_env = nil
+    @aruba_timeout_seconds = 60
+    @aruba_io_wait_seconds = nil
+  end
+
+  def build_default_dummy_gems
+    FileUtils.rm_rf(TMP_GEM_ROOT)
+    FileUtils.mkdir_p(TMP_GEM_ROOT)
+
+    build_gem 'dummy', '1.0.0'
+    build_gem 'dummy', '1.1.0'
+  end
+
+  def build_default_gemfile
+    build_gemfile <<-Gemfile
+      source 'https://rubygems.org'
+
+      gem 'dummy'
+      gem 'appraisal', :path => '#{PROJECT_ROOT}'
+    Gemfile
+  end
+end