appoxy-simple_record 1.1.12 → 1.1.13

data/README.markdown

@@ -51,7 +51,7 @@ NOTE: All objects will automatically have :id, :created, :updated attributes.
 
 Add string attributes.
 
-    class MyModel
+    class MyModel < SimpleRecord::Base
       has_attributes :name
     end
 
@@ -59,7 +59,7 @@ Add string attributes.
 
 Lets simple_record know that certain attributes defined in has_attributes should be treated as integers, dates or booleans. This is required because SimpleDB only has strings so SimpleRecord needs to know how to convert, pad, offset, etc.
 
-    class MyModel
+    class MyModel < SimpleRecord::Base
       has_attributes :name
       has_ints :age, :height
       has_dates :birthday
@@ -70,7 +70,7 @@ Lets simple_record know that certain attributes defined in has_attributes should
 
 Creates a many-to-one relationship. Can only have one per belongs_to call.
 
-    class MyModel
+    class MyModel < SimpleRecord::Base
         belongs_to :school
         has_attributes :name
         has_ints :age, :height
@@ -86,7 +86,7 @@ Which requires another class called 'School' or you can specify the class explic
 
 If you want to use a custom domain for a model object, you can specify it with set_table_name (or set_domain_name).
 
-    class SomeModel
+    class SomeModel < SimpleRecord::Base
         set_table_name :different_model
     end
 

data/lib/simple_record.rb

@@ -261,7 +261,7 @@ module SimpleRecord
 
         def make_dirty(arg, value)
             # todo: only set dirty if it changed
-            #puts 'making dirty ' + @dirty.inspect
+            #puts 'making dirty arg=' + arg.to_s + ' --- ' + @dirty.inspect
             @dirty[arg] = get_attribute(arg) # Store old value (not sure if we need it?)
             #puts 'end making dirty ' + @dirty.inspect
         end
@@ -271,7 +271,7 @@ module SimpleRecord
                 defined_attributes[arg] = SimpleRecord::Base::Attribute.new(:string) if defined_attributes[arg].nil?
                 # define reader method
                 arg_s = arg.to_s # to get rid of all the to_s calls
-                send :define_method, arg do
+                send(:define_method, arg) do
                     ret = nil
                     ret = get_attribute(arg)
                     return nil if ret.nil?
@@ -279,16 +279,15 @@ module SimpleRecord
                 end
 
                 # define writer method
-                method_name = (arg_s+"=")
-                send(:define_method, method_name) do |value|
+                send(:define_method, arg_s+"=") do |value|
                     make_dirty(arg_s, value)
-                    self[arg.to_s]=value
+                    self[arg_s]=value
                 end
 
                 # Now for dirty methods: http://api.rubyonrails.org/classes/ActiveRecord/Dirty.html
                 # define changed? method
                 send(:define_method, arg_s + "_changed?") do
-                    !@dirty[arg_s].nil?
+                    @dirty.has_key?(arg_s)
                 end
 
                 # define change method
@@ -490,7 +489,7 @@ module SimpleRecord
         end
 
         def []=(attribute, values)
-            @dirty[attribute] = get_attribute(attribute)
+            make_dirty(attribute, values)
             super
         end
 

data/test/test_simple_record.rb

@@ -178,7 +178,7 @@ class TestSimpleRecord < Test::Unit::TestCase
 
         mms = MyModel.find(:all) # select 2
         assert mms.size > 0 # select 3
-        assert mms.size == count # skipped
+        assert mms.size == count, "size != count! size=" + mms.size.to_s + " count=" + count.to_s
         assert SimpleRecord.stats.selects == 3, "should have been 3 select, but was actually #{SimpleRecord.stats.selects}" # count should not have been called twice
 
         count = MyModel.find(:count, :conditions=>["name=?", "Travis"])

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: appoxy-simple_record
 version: !ruby/object:Gem::Version 
-  version: 1.1.12
+  version: 1.1.13
 platform: ruby
 authors: 
 - Travis Reeder
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-08-18 00:00:00 -07:00
+date: 2009-08-23 00:00:00 -07:00
 default_executable: 
 dependencies: []