appoptics_apm 4.0.2

data/test/instrumentation/faraday_test.rb

@@ -0,0 +1,228 @@
+# Copyright (c) 2016 SolarWinds, LLC.
+# All rights reserved.
+
+require 'minitest_helper'
+
+describe "Faraday" do
+  before do
+    clear_all_traces
+    @collect_backtraces = AppOpticsAPM::Config[:faraday][:collect_backtraces]
+  end
+
+  after do
+    AppOpticsAPM::Config[:faraday][:collect_backtraces] = @collect_backtraces
+  end
+
+  it 'Faraday should be defined and ready' do
+    defined?(::Faraday).wont_match nil
+  end
+
+  it 'Faraday should have appoptics_apm methods defined' do
+    [ :run_request_with_appoptics ].each do |m|
+      ::Faraday::Connection.method_defined?(m).must_equal true
+    end
+  end
+
+  it "should trace cross-app request" do
+    AppOpticsAPM::API.start_trace('faraday_test') do
+      conn = Faraday.new(:url => 'http://127.0.0.1:8101') do |faraday|
+        faraday.adapter  Faraday.default_adapter  # make requests with Net::HTTP
+      end
+      response = conn.get '/games?q=1'
+      response.headers["x-trace"].wont_match nil
+    end
+
+    traces = get_all_traces
+    traces.count.must_equal 11
+
+    validate_outer_layers(traces, 'faraday_test')
+
+    traces[1]['Layer'].must_equal 'faraday'
+    traces[1].key?('Backtrace').must_equal AppOpticsAPM::Config[:faraday][:collect_backtraces]
+
+    traces[6]['Layer'].must_equal 'net-http'
+    traces[6]['IsService'].must_equal 1
+    traces[6]['RemoteProtocol'].must_equal 'HTTP'
+    traces[6]['RemoteHost'].must_equal '127.0.0.1:8101'
+    traces[6]['ServiceArg'].must_equal '/games?q=1'
+    traces[6]['HTTPMethod'].must_equal 'GET'
+    traces[6]['HTTPStatus'].must_equal '200'
+
+    traces[7]['Layer'].must_equal 'net-http'
+    traces[7]['Label'].must_equal 'exit'
+
+    traces[8]['Layer'].must_equal 'faraday'
+    traces[9]['Label'].must_equal 'exit'
+  end
+
+  it 'should trace a Faraday request' do
+    AppOpticsAPM::API.start_trace('faraday_test') do
+      conn = Faraday.new(:url => 'http://127.0.0.1:8101') do |faraday|
+        faraday.adapter  Faraday.default_adapter  # make requests with Net::HTTP
+      end
+      conn.get '/?q=ruby_test_suite'
+    end
+
+    traces = get_all_traces
+    traces.count.must_equal 11
+
+    assert valid_edges?(traces), "Invalid edge in traces"
+    validate_outer_layers(traces, 'faraday_test')
+
+    traces[1]['Layer'].must_equal 'faraday'
+    traces[1].key?('Backtrace').must_equal AppOpticsAPM::Config[:faraday][:collect_backtraces]
+
+    traces[6]['Layer'].must_equal 'net-http'
+    traces[6]['Label'].must_equal 'info'
+    traces[6]['IsService'].must_equal 1
+    traces[6]['RemoteProtocol'].must_equal 'HTTP'
+    traces[6]['RemoteHost'].must_equal '127.0.0.1:8101'
+    traces[6]['ServiceArg'].must_equal '/?q=ruby_test_suite'
+    traces[6]['HTTPMethod'].must_equal 'GET'
+    traces[6]['HTTPStatus'].must_equal '200'
+
+    traces[7]['Layer'].must_equal 'net-http'
+    traces[7]['Label'].must_equal 'exit'
+
+    traces[8]['Layer'].must_equal 'faraday'
+    traces[8]['Label'].must_equal 'info'
+
+    traces[9]['Layer'].must_equal 'faraday'
+    traces[9]['Label'].must_equal 'exit'
+  end
+
+  it 'should trace a Faraday class style request' do
+    AppOpticsAPM::API.start_trace('faraday_test') do
+      Faraday.get('http://127.0.0.1:8101/', {:a => 1})
+    end
+
+    traces = get_all_traces
+    traces.count.must_equal 11
+
+    assert valid_edges?(traces), "Invalid edge in traces"
+    validate_outer_layers(traces, 'faraday_test')
+
+    traces[1]['Layer'].must_equal 'faraday'
+    traces[1].key?('Backtrace').must_equal AppOpticsAPM::Config[:faraday][:collect_backtraces]
+
+    traces[6]['Layer'].must_equal 'net-http'
+    traces[6]['Label'].must_equal 'info'
+    traces[6]['IsService'].must_equal 1
+    traces[6]['RemoteProtocol'].must_equal 'HTTP'
+    traces[6]['RemoteHost'].must_equal '127.0.0.1:8101'
+    traces[6]['ServiceArg'].must_equal '/?a=1'
+    traces[6]['HTTPMethod'].must_equal 'GET'
+    traces[6]['HTTPStatus'].must_equal '200'
+
+    traces[7]['Layer'].must_equal 'net-http'
+    traces[7]['Label'].must_equal 'exit'
+
+    traces[8]['Layer'].must_equal 'faraday'
+    traces[8]['Label'].must_equal 'info'
+
+    traces[9]['Layer'].must_equal 'faraday'
+    traces[9]['Label'].must_equal 'exit'
+  end
+
+  it 'should trace a Faraday with the excon adapter' do
+    AppOpticsAPM::API.start_trace('faraday_test') do
+      conn = Faraday.new(:url => 'http://127.0.0.1:8101') do |faraday|
+        faraday.adapter :excon
+      end
+      conn.get '/?q=1'
+    end
+
+    traces = get_all_traces
+    traces.count.must_equal 10
+
+    assert valid_edges?(traces), "Invalid edge in traces"
+    validate_outer_layers(traces, 'faraday_test')
+
+    traces[1]['Layer'].must_equal 'faraday'
+    traces[1].key?('Backtrace').must_equal AppOpticsAPM::Config[:faraday][:collect_backtraces]
+
+    traces[2]['Layer'].must_equal 'excon'
+    traces[2]['Label'].must_equal 'entry'
+    traces[2]['IsService'].must_equal 1
+    traces[2]['RemoteProtocol'].must_equal 'HTTP'
+    traces[2]['RemoteHost'].must_equal '127.0.0.1'
+    traces[2]['ServiceArg'].must_equal '/?q=1'
+    traces[2]['HTTPMethod'].must_equal 'GET'
+
+    traces[6]['Layer'].must_equal 'excon'
+    traces[6]['Label'].must_equal 'exit'
+    traces[6]['HTTPStatus'].must_equal 200
+
+    traces[7]['Layer'].must_equal 'faraday'
+    traces[7]['Label'].must_equal 'info'
+    traces[7]['Middleware'].must_equal '[Faraday::Adapter::Excon]'
+
+    traces[8]['Layer'].must_equal 'faraday'
+    traces[8]['Label'].must_equal 'exit'
+  end
+
+  it 'should trace a Faraday with the httpclient adapter' do
+    AppOpticsAPM::API.start_trace('faraday_test') do
+      conn = Faraday.new(:url => 'http://127.0.0.1:8101') do |faraday|
+        faraday.adapter :httpclient
+      end
+      conn.get '/?q=1'
+    end
+
+    traces = get_all_traces
+    traces.count.must_equal 10
+
+    assert valid_edges?(traces), "Invalid edge in traces"
+    validate_outer_layers(traces, 'faraday_test')
+
+    traces[1]['Layer'].must_equal 'faraday'
+    traces[1].key?('Backtrace').must_equal AppOpticsAPM::Config[:faraday][:collect_backtraces]
+
+    traces[2]['Layer'].must_equal 'httpclient'
+    traces[2]['Label'].must_equal 'entry'
+    traces[2]['IsService'].must_equal 1
+    traces[2]['RemoteProtocol'].must_equal 'HTTP'
+    traces[2]['RemoteHost'].must_equal '127.0.0.1:8101'
+    traces[2]['ServiceArg'].must_equal '/?q=1'
+    traces[2]['HTTPMethod'].must_equal 'GET'
+
+    traces[6]['Layer'].must_equal 'httpclient'
+    traces[6]['Label'].must_equal 'exit'
+    traces[6]['HTTPStatus'].must_equal 200
+
+    traces[7]['Layer'].must_equal 'faraday'
+    traces[7]['Label'].must_equal 'info'
+    traces[7]['Middleware'].must_equal '[Faraday::Adapter::HTTPClient]'
+
+    traces[8]['Layer'].must_equal 'faraday'
+    traces[8]['Label'].must_equal 'exit'
+  end
+
+  it 'should obey :collect_backtraces setting when true' do
+    AppOpticsAPM::Config[:faraday][:collect_backtraces] = true
+
+    AppOpticsAPM::API.start_trace('faraday_test') do
+      conn = Faraday.new(:url => 'http://127.0.0.1:8101') do |faraday|
+        faraday.adapter  Faraday.default_adapter  # make requests with Net::HTTP
+      end
+      conn.get '/?q=ruby_test_suite'
+    end
+
+    traces = get_all_traces
+    layer_has_key(traces, 'faraday', 'Backtrace')
+  end
+
+  it 'should obey :collect_backtraces setting when false' do
+    AppOpticsAPM::Config[:faraday][:collect_backtraces] = false
+
+    AppOpticsAPM::API.start_trace('faraday_test') do
+      conn = Faraday.new(:url => 'http://127.0.0.1:8101') do |faraday|
+        faraday.adapter  Faraday.default_adapter  # make requests with Net::HTTP
+      end
+      conn.get '/?q=ruby_test_suite'
+    end
+
+    traces = get_all_traces
+    layer_doesnt_have_key(traces, 'faraday', 'Backtrace')
+  end
+end

data/test/instrumentation/http_test.rb

@@ -0,0 +1,143 @@
+# Copyright (c) 2016 SolarWinds, LLC.
+# All rights reserved.
+
+require 'minitest_helper'
+require 'net/http'
+
+describe "Net::HTTP"  do
+  before do
+    clear_all_traces
+    @collect_backtraces = AppOpticsAPM::Config[:nethttp][:collect_backtraces]
+    @log_args = AppOpticsAPM::Config[:nethttp][:log_args]
+  end
+
+  after do
+    AppOpticsAPM::Config[:nethttp][:collect_backtraces] = @collect_backtraces
+    AppOpticsAPM::Config[:nethttp][:log_args] = @log_args
+  end
+
+  it 'Net::HTTP should be defined and ready' do
+    defined?(::Net::HTTP).wont_match nil
+  end
+
+  it 'Net::HTTP should have appoptics_apm methods defined' do
+    [ :request_with_appoptics ].each do |m|
+      ::Net::HTTP.method_defined?(m).must_equal true
+    end
+  end
+
+  it "should trace a Net::HTTP request to an instr'd app" do
+    AppOpticsAPM::API.start_trace('net-http_test', '', {}) do
+      uri = URI('http://127.0.0.1:8101/?q=1')
+      http = Net::HTTP.new(uri.host, uri.port)
+      request = Net::HTTP::Get.new(uri.request_uri)
+      response = http.request(request)
+      # The HTTP response should have an X-Trace header inside of it
+      response["x-trace"].wont_match nil
+    end
+
+    traces = get_all_traces
+    traces.count.must_equal 8
+    valid_edges?(traces).must_equal true
+    validate_outer_layers(traces, 'net-http_test')
+
+    traces[1]['Layer'].must_equal 'net-http'
+    traces[1]['Label'].must_equal 'entry'
+
+    traces[2]['Layer'].must_equal 'rack'
+    traces[2]['Label'].must_equal 'entry'
+
+    traces[3]['Layer'].must_equal 'rack'
+    traces[3]['Label'].must_equal 'info'
+
+    traces[4]['Layer'].must_equal 'rack'
+    traces[4]['Label'].must_equal 'exit'
+
+    traces[5]['IsService'].must_equal 1
+    traces[5]['RemoteProtocol'].must_equal "HTTP"
+    traces[5]['RemoteHost'].must_equal "127.0.0.1:8101"
+    traces[5]['ServiceArg'].must_equal "/?q=1"
+    traces[5]['HTTPMethod'].must_equal "GET"
+    traces[5]['HTTPStatus'].must_equal "200"
+    traces[5].has_key?('Backtrace').must_equal AppOpticsAPM::Config[:nethttp][:collect_backtraces]
+  end
+
+  it "should trace a GET request" do
+    AppOpticsAPM::API.start_trace('net-http_test', '', {}) do
+      uri = URI('http://127.0.0.1:8101/')
+      http = Net::HTTP.new(uri.host, uri.port)
+      http.get('/?q=1').read_body
+    end
+
+    traces = get_all_traces
+    traces.count.must_equal 8
+    valid_edges?(traces).must_equal true
+
+    validate_outer_layers(traces, 'net-http_test')
+
+    traces[1]['Layer'].must_equal 'net-http'
+    traces[5]['IsService'].must_equal 1
+    traces[5]['RemoteProtocol'].must_equal "HTTP"
+    traces[5]['RemoteHost'].must_equal "127.0.0.1:8101"
+    traces[5]['ServiceArg'].must_equal "/?q=1"
+    traces[5]['HTTPMethod'].must_equal "GET"
+    traces[5]['HTTPStatus'].must_equal "200"
+    traces[5].has_key?('Backtrace').must_equal AppOpticsAPM::Config[:nethttp][:collect_backtraces]
+  end
+
+  it "should obey :log_args setting when true" do
+    AppOpticsAPM::Config[:nethttp][:log_args] = true
+
+    AppOpticsAPM::API.start_trace('nethttp_test', '', {}) do
+      uri = URI('http://127.0.0.1:8101/')
+      http = Net::HTTP.new(uri.host, uri.port)
+      http.use_ssl = false
+      http.get('/?q=ruby_test_suite').read_body
+    end
+
+    traces = get_all_traces
+    traces[5]['ServiceArg'].must_equal '/?q=ruby_test_suite'
+  end
+
+  it "should obey :log_args setting when false" do
+    AppOpticsAPM::Config[:nethttp][:log_args] = false
+
+    AppOpticsAPM::API.start_trace('nethttp_test', '', {}) do
+      uri = URI('http://127.0.0.1:8101/')
+      http = Net::HTTP.new(uri.host, uri.port)
+      http.use_ssl = false
+      http.get('/?q=ruby_test_suite').read_body
+    end
+
+    traces = get_all_traces
+    traces[5]['ServiceArg'].must_equal '/'
+  end
+
+  it "should obey :collect_backtraces setting when true" do
+    AppOpticsAPM::Config[:nethttp][:collect_backtraces] = true
+
+    AppOpticsAPM::API.start_trace('nethttp_test', '', {}) do
+      uri = URI('http://127.0.0.1:8101/')
+      http = Net::HTTP.new(uri.host, uri.port)
+      http.use_ssl = false
+      http.get('/?q=ruby_test_suite').read_body
+    end
+
+    traces = get_all_traces
+    layer_has_key(traces, 'net-http', 'Backtrace')
+  end
+
+  it "should obey :collect_backtraces setting when false" do
+    AppOpticsAPM::Config[:nethttp][:collect_backtraces] = false
+
+    AppOpticsAPM::API.start_trace('nethttp_test', '', {}) do
+      uri = URI('http://127.0.0.1:8101/')
+      http = Net::HTTP.new(uri.host, uri.port)
+      http.use_ssl = false
+      http.get('/?q=ruby_test_suite').read_body
+    end
+
+    traces = get_all_traces
+    layer_doesnt_have_key(traces, 'net-http', 'Backtrace')
+  end
+end

data/test/instrumentation/httpclient_test.rb

@@ -0,0 +1,320 @@
+# Copyright (c) 2016 SolarWinds, LLC.
+# All rights reserved.
+
+unless defined?(JRUBY_VERSION)
+  require 'minitest_helper'
+  require 'appoptics_apm/inst/rack'
+  require File.expand_path(File.dirname(__FILE__) + '../../frameworks/apps/sinatra_simple')
+
+  class HTTPClientTest < Minitest::Test
+    include Rack::Test::Methods
+
+    def app
+      SinatraSimple
+    end
+
+    def setup
+      clear_all_traces
+      AppOpticsAPM::Config[:tracing_mode] = :always
+    end
+
+    def test_reports_version_init
+      init_kvs = ::AppOpticsAPM::Util.build_init_report
+      assert init_kvs.key?('Ruby.httpclient.Version')
+      assert_equal ::HTTPClient::VERSION, init_kvs['Ruby.httpclient.Version']
+    end
+
+    def test_get_request
+      clear_all_traces
+
+      response = nil
+
+      AppOpticsAPM::API.start_trace('httpclient_tests') do
+        clnt = HTTPClient.new
+        response = clnt.get('http://127.0.0.1:8101/', :query => { :keyword => 'ruby', :lang => 'en' })
+      end
+
+      traces = get_all_traces
+
+      # Validate returned xtrace
+      assert response.headers.key?("X-Trace")
+      assert AppOpticsAPM::XTrace.valid?(response.headers["X-Trace"])
+
+      assert_equal traces.count, 7
+      assert valid_edges?(traces), "Invalid edge in traces"
+      validate_outer_layers(traces, "httpclient_tests")
+
+      assert_equal traces[1]['IsService'], 1
+      assert_equal traces[1]['RemoteURL'], 'http://127.0.0.1:8101/?keyword=ruby&lang=en'
+      assert_equal traces[1]['HTTPMethod'], 'GET'
+      assert traces[1].key?('Backtrace')
+
+      assert_equal traces[5]['Layer'], 'httpclient'
+      assert_equal traces[5]['Label'], 'exit'
+      assert_equal traces[5]['HTTPStatus'], 200
+    end
+
+    def test_get_with_header_hash
+      clear_all_traces
+
+      response = nil
+
+      AppOpticsAPM::API.start_trace('httpclient_tests') do
+        clnt = HTTPClient.new
+        response = clnt.get('http://127.0.0.1:8101/', nil, { "SOAPAction" => "HelloWorld" })
+      end
+
+      traces = get_all_traces
+
+      xtrace = response.headers['X-Trace']
+      assert xtrace
+      assert AppOpticsAPM::XTrace.valid?(xtrace)
+
+      assert_equal traces.count, 7
+      assert valid_edges?(traces), "Invalid edge in traces"
+      validate_outer_layers(traces, "httpclient_tests")
+
+      assert_equal traces[1]['IsService'], 1
+      assert_equal traces[1]['RemoteURL'], 'http://127.0.0.1:8101/'
+      assert_equal traces[1]['HTTPMethod'], 'GET'
+      assert traces[1].key?('Backtrace')
+
+      assert_equal traces[5]['Layer'], 'httpclient'
+      assert_equal traces[5]['Label'], 'exit'
+      assert_equal traces[5]['HTTPStatus'], 200
+    end
+
+    def test_get_with_header_array
+      clear_all_traces
+
+      response = nil
+
+      AppOpticsAPM::API.start_trace('httpclient_tests') do
+        clnt = HTTPClient.new
+        response = clnt.get('http://127.0.0.1:8101/', nil, [["Accept", "text/plain"], ["Accept", "text/html"]])
+      end
+
+      traces = get_all_traces
+
+      xtrace = response.headers['X-Trace']
+      assert xtrace
+      assert AppOpticsAPM::XTrace.valid?(xtrace)
+
+      assert_equal traces.count, 7
+      assert valid_edges?(traces), "Invalid edge in traces"
+      validate_outer_layers(traces, "httpclient_tests")
+
+      assert_equal traces[1]['IsService'], 1
+      assert_equal traces[1]['RemoteURL'], 'http://127.0.0.1:8101/'
+      assert_equal traces[1]['HTTPMethod'], 'GET'
+      assert traces[1].key?('Backtrace')
+
+      assert_equal traces[5]['Layer'], 'httpclient'
+      assert_equal traces[5]['Label'], 'exit'
+      assert_equal traces[5]['HTTPStatus'], 200
+    end
+
+    def test_post_request
+      clear_all_traces
+
+      response = nil
+
+      AppOpticsAPM::API.start_trace('httpclient_tests') do
+        clnt = HTTPClient.new
+        response = clnt.post('http://127.0.0.1:8101/')
+      end
+
+      traces = get_all_traces
+
+      xtrace = response.headers['X-Trace']
+      assert xtrace
+      assert AppOpticsAPM::XTrace.valid?(xtrace)
+
+      assert_equal traces.count, 7
+      assert valid_edges?(traces), "Invalid edge in traces"
+      validate_outer_layers(traces, "httpclient_tests")
+
+      assert_equal traces[1]['IsService'], 1
+      assert_equal traces[1]['RemoteURL'], 'http://127.0.0.1:8101/'
+      assert_equal traces[1]['HTTPMethod'], 'POST'
+      assert traces[1].key?('Backtrace')
+
+      assert_equal traces[5]['Layer'], 'httpclient'
+      assert_equal traces[5]['Label'], 'exit'
+      assert_equal traces[5]['HTTPStatus'], 200
+    end
+
+    def test_async_get
+      clear_all_traces
+
+      conn = nil
+
+      AppOpticsAPM::API.start_trace('httpclient_tests') do
+        clnt = HTTPClient.new
+        conn = clnt.get_async('http://127.0.0.1:8101/?blah=1')
+      end
+
+      # Allow async request to finish
+      Thread.pass until conn.finished?
+
+      traces = get_all_traces
+
+      assert_equal traces.count, 7
+      assert valid_edges?(traces), "Invalid edge in traces"
+
+      # In the case of async the layers are not always ordered the same
+      # validate_outer_layers is not applicable, so we make sure we get the pair for 'httpclient_tests'
+      assert_equal 2, traces.select { |trace| trace['Layer'] == 'httpclient_tests' }.size
+
+      # because of possible different ordering of traces we can't rely on an index and need to use find
+      async_entry = traces.find { |trace| trace['Layer'] == 'httpclient' && trace['Label'] == 'entry' }
+      assert_equal 1, async_entry['Async']
+      assert_equal 1, async_entry['IsService']
+      assert_equal 'http://127.0.0.1:8101/?blah=1', async_entry['RemoteURL']
+      assert_equal 'GET', async_entry['HTTPMethod']
+      assert async_entry.key?('Backtrace')
+
+      assert_equal 'httpclient', traces[6]['Layer']
+      assert_equal 'exit', traces[6]['Label']
+      assert_equal 200, traces[6]['HTTPStatus']
+    end
+
+    def test_cross_app_tracing
+      clear_all_traces
+
+      response = nil
+
+      AppOpticsAPM::API.start_trace('httpclient_tests') do
+        clnt = HTTPClient.new
+        response = clnt.get('http://127.0.0.1:8101/', :query => { :keyword => 'ruby', :lang => 'en' })
+      end
+
+      xtrace = response.headers['X-Trace']
+      assert xtrace
+      assert AppOpticsAPM::XTrace.valid?(xtrace)
+
+      traces = get_all_traces
+
+      assert_equal traces.count, 7
+      assert valid_edges?(traces), "Invalid edge in traces"
+      validate_outer_layers(traces, "httpclient_tests")
+
+      assert_equal 1, traces[1]['IsService']
+      assert_equal 'http://127.0.0.1:8101/?keyword=ruby&lang=en', traces[1]['RemoteURL']
+      assert_equal 'GET', traces[1]['HTTPMethod']
+      assert traces[1].key?('Backtrace')
+
+      assert_equal 'rack', traces[2]['Layer']
+      assert_equal 'entry', traces[2]['Label']
+      assert_equal 'rack', traces[3]['Layer']
+      assert_equal 'info', traces[3]['Label']
+      assert_equal 'rack', traces[4]['Layer']
+      assert_equal 'exit', traces[4]['Label']
+
+      assert_equal 'httpclient', traces[5]['Layer']
+      assert_equal 'exit', traces[5]['Label']
+      assert_equal 200, traces[5]['HTTPStatus']
+    end
+
+    def test_requests_with_errors
+      clear_all_traces
+
+      result = nil
+      begin
+        AppOpticsAPM::API.start_trace('httpclient_tests') do
+          clnt = HTTPClient.new
+          result = clnt.get('http://asfjalkfjlajfljkaljf/')
+        end
+      rescue
+      end
+
+      traces = get_all_traces
+      assert_equal 5, traces.count
+      assert valid_edges?(traces), "Invalid edge in traces"
+      validate_outer_layers(traces, "httpclient_tests")
+
+      assert_equal 1, traces[1]['IsService']
+      assert_equal 'http://asfjalkfjlajfljkaljf/', traces[1]['RemoteURL']
+      assert_equal 'GET', traces[1]['HTTPMethod']
+      assert traces[1].key?('Backtrace')
+
+      assert_equal 'httpclient', traces[2]['Layer']
+      assert_equal 'error', traces[2]['Label']
+      assert_equal "SocketError", traces[2]['ErrorClass']
+      assert traces[2].key?('ErrorMsg')
+      assert traces[2].key?('Backtrace')
+
+      assert_equal 'httpclient', traces[3]['Layer']
+      assert_equal 'exit', traces[3]['Label']
+    end
+
+    def test_log_args_when_true
+      clear_all_traces
+
+      @log_args = AppOpticsAPM::Config[:httpclient][:log_args]
+      AppOpticsAPM::Config[:httpclient][:log_args] = true
+
+      response = nil
+
+      AppOpticsAPM::API.start_trace('httpclient_tests') do
+        clnt = HTTPClient.new
+        response = clnt.get('http://127.0.0.1:8101/', :query => { :keyword => 'ruby', :lang => 'en' })
+      end
+
+      traces = get_all_traces
+
+      xtrace = response.headers['X-Trace']
+      assert xtrace
+      assert AppOpticsAPM::XTrace.valid?(xtrace)
+
+      assert_equal 7, traces.count
+      assert valid_edges?(traces), "Invalid edge in traces"
+
+      assert_equal 'http://127.0.0.1:8101/?keyword=ruby&lang=en', traces[1]['RemoteURL']
+
+      AppOpticsAPM::Config[:httpclient][:log_args] = @log_args
+    end
+
+    def test_log_args_when_false
+      clear_all_traces
+
+      @log_args = AppOpticsAPM::Config[:httpclient][:log_args]
+      AppOpticsAPM::Config[:httpclient][:log_args] = false
+
+      response = nil
+
+      AppOpticsAPM::API.start_trace('httpclient_tests') do
+        clnt = HTTPClient.new
+        response = clnt.get('http://127.0.0.1:8101/', :query => { :keyword => 'ruby', :lang => 'en' })
+      end
+
+      traces = get_all_traces
+
+      xtrace = response.headers['X-Trace']
+      assert xtrace
+      assert AppOpticsAPM::XTrace.valid?(xtrace)
+
+      assert_equal 7, traces.count
+      assert valid_edges?(traces), "Invalid edge in traces"
+
+      assert_equal 'http://127.0.0.1:8101/', traces[1]['RemoteURL']
+
+      AppOpticsAPM::Config[:httpclient][:log_args] = @log_args
+    end
+
+    def test_without_tracing
+      clear_all_traces
+
+      clnt = HTTPClient.new
+      clnt.get('http://127.0.0.1:8101/', :query => { :keyword => 'ruby', :lang => 'en' })
+
+      traces = get_all_traces
+      # we only get traces from rack
+      assert_equal 3, traces.count
+      traces.each do |trace|
+        assert_equal 'rack', trace["Layer"]
+      end
+
+    end
+  end
+end