appmap 0.99.0 → 0.99.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 463cf482f8d6b1a33721886b5d049ae0ce11c469759562a4ea0b8c6c149abb23
-  data.tar.gz: 727ecbc15e19e486f69ed668d9e077a3045c10b24c0892b66801346d11a02a4d
+  metadata.gz: c0d8aa81209b5f8d33fc480c3ff3b7f6cd61027dc51fad74c9ad4f19ba6c7faf
+  data.tar.gz: 5d8ac162d8cf5eacfc045ff81a16c2b473df79ae0619ddaface5b4bab8d422cb
 SHA512:
-  metadata.gz: cec680149e2742d4ed403a73d7283c454e0e561a95207ab426b9996c4056fa93626d0544de0923f575252038869a7e7e6b6f351eaaab4f1b7576ef20467bb527
-  data.tar.gz: 573b7ba81cae478ea658c27937563410bd83143bb0c13b9aeea3402422460ac55debff2adeffc83cb77c4be1372f6e49f1c640d8ff193c18199597a0bff25f58
+  metadata.gz: 34c7b6b0fd6e45c33158776e3c3f1a8725031913ad49856f24aa5af50cbc41efd2e047face5c3c1f02a9c20670af08be43492e5bd665a17323578c735b07900b
+  data.tar.gz: 0ea3f5be3436ea8eec1d8e14cd959b67e6e4547d03de6401c6e21250b3ba91b521b57f665298e1e4ec3be9616a1fbcf0a2f11b8ff09a5c53cd0d60c2d4a358f6

data/CHANGELOG.md

@@ -1,3 +1,17 @@
+## [0.99.2](https://github.com/getappmap/appmap-ruby/compare/v0.99.1...v0.99.2) (2023-05-10)
+
+
+### Bug Fixes
+
+* Ensure that signature hash key consists of strings ([acb5db9](https://github.com/getappmap/appmap-ruby/commit/acb5db9ecb0a6cdf40de83bf506f45f5283f641b))
+
+## [0.99.1](https://github.com/getappmap/appmap-ruby/compare/v0.99.0...v0.99.1) (2023-04-24)
+
+
+### Bug Fixes
+
+* backtrace_locations may be nil ([7f3890a](https://github.com/getappmap/appmap-ruby/commit/7f3890a00d5f4425fac273c72e5576cf7752eeaf)), closes [#324](https://github.com/getappmap/appmap-ruby/issues/324)
+
 # [0.99.0](https://github.com/getappmap/appmap-ruby/compare/v0.98.1...v0.99.0) (2023-04-13)
 
 

data/lib/appmap/config.rb

@@ -499,6 +499,11 @@ module AppMap
     end
 
     def never_hook?(cls, method)
+      unless method
+        HookLog.log "method is nil" if HookLog.enabled?
+        return true
+      end
+
       _, separator, = ::AppMap::Hook.qualify_method_name(method)
       if exclude.member?(cls.name) || exclude.member?([ cls.name, separator, method.name ].join)
         HookLog.log "Hooking of #{method} disabled by configuration" if HookLog.enabled?

data/lib/appmap/hook/method.rb

@@ -4,11 +4,23 @@ require 'appmap/util'
 
 module AppMap
   class Hook
+    class << self
+      def method_hash_key(cls, method)
+        [ cls, method.name ].hash
+      rescue TypeError => e
+        warn "Error building hash key for #{cls}, #{method}: #{e}"
+      end
+    end
+    
+
     SIGNATURES = {}
     LOOKUP_SIGNATURE = lambda do |id|
       method = super(id)
 
-      signature = SIGNATURES[[ method.owner, method.name ]]
+      hash_key = Hook.method_hash_key(method.owner, method)
+      return method unless hash_key
+
+      signature = SIGNATURES[hash_key]
       if signature
         method.singleton_class.module_eval do
           define_method(:parameters) do
@@ -48,7 +60,8 @@ module AppMap
         end
 
         hook_method_parameters = hook_method.parameters.dup.freeze
-        SIGNATURES[[ hook_class, hook_method.name ]] = hook_method_parameters
+        hash_key = Hook.method_hash_key(hook_class, hook_method)
+        SIGNATURES[hash_key] = hook_method_parameters if hash_key
 
         # irb(main):001:0> Kernel.public_instance_method(:system)
         # (irb):1:in `public_instance_method': method `system' for module `Kernel' is  private (NameError)

data/lib/appmap/minitest.rb

@@ -38,14 +38,7 @@ module AppMap
         if failed
           failure_exception = failures.first || exception
           warn "Failure exception: #{failure_exception}" if AppMap::Minitest::LOG
-
-          first_location = failure_exception.backtrace_locations.find { |location| !Pathname.new(Util.normalize_path(location.absolute_path)).absolute? }
-          failure_location = [ Util.normalize_path(first_location.path), first_location.lineno ].join(':') if first_location
-
-          test_failure = {
-            message: failure_exception.message,
-            location: failure_location,
-          }
+          test_failure = Util.extract_test_failure(failure_exception)
         end
 
         events = []

data/lib/appmap/rspec.rb

@@ -104,14 +104,7 @@ module AppMap
         if failed
           failure_exception = failure || exception
           warn "Failure exception: #{failure_exception}" if AppMap::RSpec::LOG
-
-          first_location = failure_exception.backtrace_locations.find { |location| !Pathname.new(Util.normalize_path(location.absolute_path)).absolute? }
-          failure_location = [ Util.normalize_path(first_location.path), first_location.lineno ].join(':') if first_location
-
-          test_failure = {
-            message: failure_exception.message.strip,
-            location: failure_location,
-          }
+          test_failure = Util.extract_test_failure(failure_exception)
         end
 
         events = []

data/lib/appmap/util.rb

@@ -157,6 +157,15 @@ module AppMap
         }
       end
 
+      def extract_test_failure(exception)
+        return unless exception
+
+        { message: exception.message }.tap do |test_failure|
+          first_location = exception.backtrace_locations&.find { |location| !Pathname.new(normalize_path(location.absolute_path)).absolute? }
+          test_failure[:location] = [ normalize_path(first_location.path), first_location.lineno ].join(':') if first_location
+        end
+      end
+
       # Convert a Rails-style path from /org/:org_id(.:format)
       # to Swagger-style paths like /org/{org_id}
       def swaggerize_path(path)

data/lib/appmap/version.rb

@@ -3,7 +3,7 @@
 module AppMap
   URL = 'https://github.com/applandinc/appmap-ruby'
 
-  VERSION = '0.99.0'
+  VERSION = '0.99.2'
 
   APPMAP_FORMAT_VERSION = '1.12.0'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: appmap
 version: !ruby/object:Gem::Version
-  version: 0.99.0
+  version: 0.99.2
 platform: ruby
 authors:
 - Kevin Gilpin
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-04-13 00:00:00.000000000 Z
+date: 2023-05-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: method_source