appmap 0.93.4 → 0.93.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 61b703d48969c96f7967495b9719c47c2a391d8cbe612581480152614ff60cc5
-  data.tar.gz: 5fb1da8f5574f3d96db8216fdcc4710e83c2d1a72a66f9b942be9eeba7b2ea95
+  metadata.gz: e06f80a7364f75faaa0a8838b5053ea147349c3737b4072003aef809e6e2bbec
+  data.tar.gz: 004e1d57ebe2a8c1aa718062cec50d1846526e12b6cd014b7780cbb636417500
 SHA512:
-  metadata.gz: d040f5fda6f71885a66090e1f14e7d1c0bc815ae4bc59b2c99ef47cbe982b4143ba8af8f4eeb2d6ad032c324b66ee4a61731723b9a27b33a712f55cac7e66d37
-  data.tar.gz: e915ca689cece094856ad434241c5107dc78914967ab0b355586c512c36397a1055634e411145b604b9581b19a89afa8e7cea63e68741c35e03afe20ba1c627b
+  metadata.gz: 524637c14e1fb40dc5d8174af904adf7f5f72827d8c2c61689e612602d1d9a15464697ec65c207d295e7a9752af9bdaeedab26ff515e2db3f324bec4bc3de97a
+  data.tar.gz: 2239720d8ede87ba270e57299dfd63842eee3e07d9426249d647cbcc48095ba6439d796f090b5ab55fd76ba62afd8c3117944db067180d5d0628c9e19fed30e5

data/.rubocop.yml

@@ -14,6 +14,9 @@ Layout/CaseIndentation:
 Layout/FirstArgumentIndentation:
   EnforcedStyle: consistent
 
+Layout/FirstArrayElementIndentation:
+  EnforcedStyle: consistent
+
 Layout/SpaceInsideArrayLiteralBrackets:
   Enabled: false
 

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+## [0.93.5](https://github.com/getappmap/appmap-ruby/compare/v0.93.4...v0.93.5) (2022-11-08)
+
+
+### Bug Fixes
+
+* Only show a warning in non-Rails projects ([4ed86c7](https://github.com/getappmap/appmap-ruby/commit/4ed86c705ea0183940714af47bdda81917ad3f92)), closes [#292](https://github.com/getappmap/appmap-ruby/issues/292)
+
 ## [0.93.4](https://github.com/getappmap/appmap-ruby/compare/v0.93.3...v0.93.4) (2022-11-04)
 
 

data/lib/appmap/command/agent_setup/validate.rb

@@ -14,7 +14,7 @@ module AppMap
           schema = YAML.safe_load(File.read(schema_path))
           result = {
             version: 2,
-            errors: config_validator.valid? ? [] : config_validator.violations.map(&:to_h),
+            errors: config_validator.violations.map(&:to_h),
             schema: schema
           }
           puts JSON.pretty_generate(result)

data/lib/appmap/service/config_analyzer.rb

@@ -25,7 +25,11 @@ module AppMap
 
       def errors
         valid?
-        config_validator.violations.map(&:message)
+        config_validator.violations.filter(&:error?).map(&:message)
+      end
+
+      def warnings
+        config_validator.violations.filter(&:warning?).map(&:message)
       end
 
       private

data/lib/appmap/service/validator/config_validator.rb

@@ -7,8 +7,6 @@ module AppMap
   module Service
     module Validator
       class ConfigValidator
-        attr_reader :violations
-
         def initialize(config_file)
           @config_file = config_file
           @violations = []
@@ -19,17 +17,29 @@ module AppMap
         end
 
         def valid?
+          validate
+          @violations.none?(&:error?)
+        end
+
+        def violations
+          validate
+          @violations
+        end
+
+        private
+
+        def validate
+          return if @validated
+
           @violations = []
           validate_ruby_version
           validate_rails_presence
           validate_config_presence
           parse_config
           validate_config_load
-          @violations.empty?
+          @validated = true
         end
 
-        private
-
         def present?
           File.exist?(@config_file)
         end
@@ -71,8 +81,10 @@ module AppMap
 
         def validate_rails_presence
           unless Gem.loaded_specs.has_key?('rails')
-            @violations << Violation.error(
-              message: 'AppMap auto-configuration is currently not available for non Rails projects'
+            @violations << Violation.warning(
+              message: "This is not a Rails project. AppMap won't be automatically loaded.",
+              detailed_message: "Please ensure you `require 'appmap'` in your test environment.",
+              help_urls: [ 'https://appmap.io/docs/reference/appmap-ruby#tests-recording' ]
             )
           end
         end

data/lib/appmap/service/validator/violation.rb

@@ -44,6 +44,14 @@ module AppMap
             hash[var.to_s.delete("@")] = self.instance_variable_get(var)
           end.compact
         end
+
+        def error?
+          @level == :error
+        end
+
+        def warning?
+          @level == :warning
+        end
       end
     end
   end

data/lib/appmap/version.rb

@@ -3,7 +3,7 @@
 module AppMap
   URL = 'https://github.com/applandinc/appmap-ruby'
 
-  VERSION = '0.93.4'
+  VERSION = '0.93.5'
 
   APPMAP_FORMAT_VERSION = '1.9.0'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: appmap
 version: !ruby/object:Gem::Version
-  version: 0.93.4
+  version: 0.93.5
 platform: ruby
 authors:
 - Kevin Gilpin
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-11-04 00:00:00.000000000 Z
+date: 2022-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: method_source