appmap 0.93.3 → 0.93.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 21061232aa6830335a8a3861f1f646cf30a1fc7b4817689dddcc95ff88fd9055
-  data.tar.gz: dfd9dd996ac35e5648f3d8b48610b3e0944e321128f533631d00a1e6bb2fff5a
+  metadata.gz: e06f80a7364f75faaa0a8838b5053ea147349c3737b4072003aef809e6e2bbec
+  data.tar.gz: 004e1d57ebe2a8c1aa718062cec50d1846526e12b6cd014b7780cbb636417500
 SHA512:
-  metadata.gz: ec3b00c06f9ecfc143c3deaa926e4740a1bd2b152dc4ab2b4d52802a0d420454281b34f10fad994c318a5b3013239337c238edfe3b4b29c2f912cb07db664eed
-  data.tar.gz: 546db9702fd815c56bb5da540eae30b20bbd67ade8b05b8a7c6aec1ee4e052ab2a596ba812bc2ebcf4d53ab1c3ebec35b78dc41edd870954c48ce510eeae66f9
+  metadata.gz: 524637c14e1fb40dc5d8174af904adf7f5f72827d8c2c61689e612602d1d9a15464697ec65c207d295e7a9752af9bdaeedab26ff515e2db3f324bec4bc3de97a
+  data.tar.gz: 2239720d8ede87ba270e57299dfd63842eee3e07d9426249d647cbcc48095ba6439d796f090b5ab55fd76ba62afd8c3117944db067180d5d0628c9e19fed30e5

data/.rubocop.yml

@@ -14,6 +14,9 @@ Layout/CaseIndentation:
 Layout/FirstArgumentIndentation:
   EnforcedStyle: consistent
 
+Layout/FirstArrayElementIndentation:
+  EnforcedStyle: consistent
+
 Layout/SpaceInsideArrayLiteralBrackets:
   Enabled: false
 

data/.travis.yml

@@ -10,15 +10,11 @@ rbenv:
 - 3.0
 - 3.1
 
+node_js: lts/*
+
 services:
 - postgresql
 
-before_install:
-  - |
-    nvm install --lts \
-      && nvm use --lts \
-      && npm i -g yarn
-
 before_deploy:
   - |
     npm i -g \

data/CHANGELOG.md

@@ -1,3 +1,17 @@
+## [0.93.5](https://github.com/getappmap/appmap-ruby/compare/v0.93.4...v0.93.5) (2022-11-08)
+
+
+### Bug Fixes
+
+* Only show a warning in non-Rails projects ([4ed86c7](https://github.com/getappmap/appmap-ruby/commit/4ed86c705ea0183940714af47bdda81917ad3f92)), closes [#292](https://github.com/getappmap/appmap-ruby/issues/292)
+
+## [0.93.4](https://github.com/getappmap/appmap-ruby/compare/v0.93.3...v0.93.4) (2022-11-04)
+
+
+### Bug Fixes
+
+* Use correct signature for Init_appmap() in appmap.c ([1157085](https://github.com/getappmap/appmap-ruby/commit/11570859a1fedd2e1cc7004d291ae8fecd23714a))
+
 ## [0.93.3](https://github.com/getappmap/appmap-ruby/compare/v0.93.2...v0.93.3) (2022-10-11)
 
 

data/ext/appmap/appmap.c

@@ -101,7 +101,7 @@ am_previous_bindings(VALUE self, VALUE level)
   return rb_debug_inspector_open(bindings_callback, (void *) level);
 }
 
-void Init_appmap() {
+void Init_appmap(void) {
   VALUE appmap = rb_define_module("AppMap");
   am_AppMapHook = rb_define_class_under(appmap, "Hook", rb_cObject);
 

data/lib/appmap/command/agent_setup/validate.rb

@@ -14,7 +14,7 @@ module AppMap
           schema = YAML.safe_load(File.read(schema_path))
           result = {
             version: 2,
-            errors: config_validator.valid? ? [] : config_validator.violations.map(&:to_h),
+            errors: config_validator.violations.map(&:to_h),
             schema: schema
           }
           puts JSON.pretty_generate(result)

data/lib/appmap/service/config_analyzer.rb

@@ -25,7 +25,11 @@ module AppMap
 
       def errors
         valid?
-        config_validator.violations.map(&:message)
+        config_validator.violations.filter(&:error?).map(&:message)
+      end
+
+      def warnings
+        config_validator.violations.filter(&:warning?).map(&:message)
       end
 
       private

data/lib/appmap/service/validator/config_validator.rb

@@ -7,8 +7,6 @@ module AppMap
   module Service
     module Validator
       class ConfigValidator
-        attr_reader :violations
-
         def initialize(config_file)
           @config_file = config_file
           @violations = []
@@ -19,17 +17,29 @@ module AppMap
         end
 
         def valid?
+          validate
+          @violations.none?(&:error?)
+        end
+
+        def violations
+          validate
+          @violations
+        end
+
+        private
+
+        def validate
+          return if @validated
+
           @violations = []
           validate_ruby_version
           validate_rails_presence
           validate_config_presence
           parse_config
           validate_config_load
-          @violations.empty?
+          @validated = true
         end
 
-        private
-
         def present?
           File.exist?(@config_file)
         end
@@ -71,8 +81,10 @@ module AppMap
 
         def validate_rails_presence
           unless Gem.loaded_specs.has_key?('rails')
-            @violations << Violation.error(
-              message: 'AppMap auto-configuration is currently not available for non Rails projects'
+            @violations << Violation.warning(
+              message: "This is not a Rails project. AppMap won't be automatically loaded.",
+              detailed_message: "Please ensure you `require 'appmap'` in your test environment.",
+              help_urls: [ 'https://appmap.io/docs/reference/appmap-ruby#tests-recording' ]
             )
           end
         end

data/lib/appmap/service/validator/violation.rb

@@ -44,6 +44,14 @@ module AppMap
             hash[var.to_s.delete("@")] = self.instance_variable_get(var)
           end.compact
         end
+
+        def error?
+          @level == :error
+        end
+
+        def warning?
+          @level == :warning
+        end
       end
     end
   end

data/lib/appmap/version.rb

@@ -3,7 +3,7 @@
 module AppMap
   URL = 'https://github.com/applandinc/appmap-ruby'
 
-  VERSION = '0.93.3'
+  VERSION = '0.93.5'
 
   APPMAP_FORMAT_VERSION = '1.9.0'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: appmap
 version: !ruby/object:Gem::Version
-  version: 0.93.3
+  version: 0.93.5
 platform: ruby
 authors:
 - Kevin Gilpin
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-10-11 00:00:00.000000000 Z
+date: 2022-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: method_source