appmap 0.68.0 → 0.70.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4d54229f9f87639b89c9388722e8e9ee30e327a39f9e4effe40739033229de5f
-  data.tar.gz: 2a87b31d06444d8091f78ec00e0751b900f2068ee87003c945b3b6da3e58602d
+  metadata.gz: 64006e414b4b6cece101a113b5b5359c370b77b96761cfcb02818c07e621d8c5
+  data.tar.gz: e7ab888c17031adb8ae993dae863539b32359e967c706b2cc2b13f1f2bb11761
 SHA512:
-  metadata.gz: 3a6efa5f3fbac309a6df73405f281deaaf4a577de3d22466e04e2a8587af59dc418e99c032387f5cf00d604da2d43cedfaa745f63589ae39f8edba685f9ab5b9
-  data.tar.gz: 390d01607fcf6ae24852758a50f4f174b90c4d59f5b008c77c60108540a9d58c65917a36242ce495430fc7bfe38bdd58a4be050d106ebbb4c7ad6a3ea7d2104e
+  metadata.gz: e9b9fbf621b59dfb72875365d2c4485e174b4532b159d62854883e77fd741451f1e8ca4609b0a5323cccc562fcf31ead2ef19923bd3be3e6b0d5d28d5c188635
+  data.tar.gz: 4a079f0b5ae28e45a065187e0044446bdbef6a5a91df88f9072b71a825a18c86e3ba6eaf8dc54102b224eb16f3eae1ea0b9e3b8da3958b209bdd9f5d78d0ac50

data/CHANGELOG.md

@@ -1,3 +1,32 @@
+# [0.70.0](https://github.com/applandinc/appmap-ruby/compare/v0.69.0...v0.70.0) (2021-12-08)
+
+
+### Features
+
+* Hook protected methods ([a3722b5](https://github.com/applandinc/appmap-ruby/commit/a3722b504b8e5b8c032988b586b13bdd071fe577))
+* Report sub-packages for nested folders ([dce709b](https://github.com/applandinc/appmap-ruby/commit/dce709b077fd64fc2b34f9abb30a65db529f824b))
+
+# [0.69.0](https://github.com/applandinc/appmap-ruby/compare/v0.68.2...v0.69.0) (2021-12-01)
+
+
+### Features
+
+* Add labels for job creation and canceling ([644fafe](https://github.com/applandinc/appmap-ruby/commit/644fafe7f0eab626a9e0a52243ad4faf052a883a))
+
+## [0.68.2](https://github.com/applandinc/appmap-ruby/compare/v0.68.1...v0.68.2) (2021-11-25)
+
+
+### Bug Fixes
+
+* Missing gems will no longer attempt to be hooked ([ac6cf26](https://github.com/applandinc/appmap-ruby/commit/ac6cf264897e492c73ba4b66233709eb4eaf7b36))
+
+## [0.68.1](https://github.com/applandinc/appmap-ruby/compare/v0.68.0...v0.68.1) (2021-11-12)
+
+
+### Bug Fixes
+
+* Support new style of `functions` syntax in appmap.yml ([dca327c](https://github.com/applandinc/appmap-ruby/commit/dca327c98db1bddf849056995541306a5fc07eea))
+
 # [0.68.0](https://github.com/applandinc/appmap-ruby/compare/v0.67.1...v0.68.0) (2021-11-05)
 
 

data/config-schema.yml

@@ -45,13 +45,25 @@ properties:
       type: object
       additionalProperties: false
       properties:
-        package:
+        method:
           type: string
-        class:
-          type: string
-        function:
+        label:
           type: string
+        methods:
+          type: array
+          items:
+            type: string
         labels:
           type: array
           items:
             type: string
+        require_name:
+          type: string
+        gem:
+          type: string
+        path:
+          type: string
+        builtin:
+          type: boolean
+        force:
+          type: boolean

data/lib/appmap/class_map.rb

@@ -76,24 +76,39 @@ module AppMap
         methods.each do |method|
           add_function root, method
         end
-        root.children.map(&:to_h)
+
+        collapse_package = lambda do |package|
+          return unless package.type == 'package'
+
+          while package.children.length == 1 && package.children.all? { |child| child.type == 'package' }
+            child = package.children[0]
+            package.children.clear
+            child.children.each { |child| package.children << child }
+            package.name = [ package.name, child.name ].join('/')
+          end
+          package.tap do
+            package.children.map(&collapse_package)
+          end
+        end
+
+        root.children.map(&collapse_package).map(&:to_h)
       end
 
       protected
 
       def add_function(root, method)
-        object_infos = [
-          {
-            name: method.package,
-            type: 'package'
-          }
-        ]
-        object_infos += method.class_name.split('::').map do |name|
-          {
-            name: name,
-            type: 'class'
-          }
-        end
+        object_infos = \
+          method.package.split('/').map do |name|
+            {
+              name: name,
+              type: 'package'
+            }
+          end + method.class_name.split('::').map do |name|
+            {
+              name: name,
+              type: 'class'
+            }
+          end
         function_info = {
           name: method.name,
           type: 'function',

data/lib/appmap/config.rb

@@ -44,6 +44,21 @@ module AppMap
         shallow
       end
 
+      # Clones this package into a sub-package, if needed.
+      # For example, suppose the appmap.yml specifies package `app/models`. If some code in
+      # `app/models/dao/user.rb` is mapped, it will be associated with a sub-package
+      # `app/models/dao`.
+      def subpackage(location, config)
+        return self if gem
+
+        path = location.split('/')[0...-1].join('/')
+        clone.tap do |pkg|
+          pkg.name = path
+          pkg.path = path
+          config.packages << pkg
+        end
+      end
+
       class << self
         # Builds a package for a path, such as `app/models` in a Rails app. Generally corresponds to a `path:` entry
         # in appmap.yml. Also used for mapping specific methods via TargetMethods.
@@ -191,7 +206,7 @@ module AppMap
         }.compact
 
         handler_class = hook_decl['handler_class']
-        options[:handler_class] = Util::class_from_string(handler_class) if handler_class
+        options[:handler_class] = Util.class_from_string(handler_class) if handler_class
         
         package_hooks(methods, **options)
       end
@@ -215,7 +230,7 @@ module AppMap
         builtin = hook_decl['builtin']
 
         package_options = {}
-        package_options[:labels] = Array(labels).map(&:to_s) if labels if labels
+        package_options[:labels] = Array(labels).map(&:to_s) if labels
         package_options[:require_name] = req
         package_options[:require_name] ||= package if builtin
         tm = TargetMethods.new(functions, Package.build_from_path(package, **package_options))
@@ -366,7 +381,7 @@ module AppMap
               # hook config.
               declare_hook(hook_decl)
             end
-          end
+          end.flatten
         end
 
         config_params[:packages] = \
@@ -449,13 +464,17 @@ module AppMap
         return unless location_file
 
         location_file = AppMap::Util.normalize_path(location_file)
-        config
-          .packages
-          .select { |pkg| pkg.path }
-          .find do |pkg|
-            (location_file.index(pkg.path) == 0) &&
-              !pkg.exclude.find { |p| location_file.index(p) }
-          end
+
+        pkg = config
+              .packages
+              .select { |pkg| pkg.path }
+              .select do |pkg|
+                (location_file.index(pkg.path) == 0) &&
+                  !pkg.exclude.find { |p| location_file.index(p) }
+              end
+              .min { |a, b| b.path <=> a.path } # Longest matching package first
+
+        pkg.subpackage(location_file, config) if pkg
       end
     end
 

data/lib/appmap/gem_hooks/activejob-cancel.yml

@@ -0,0 +1,2 @@
+- method: ActiveJob::Cancel#cancel
+  label: job.cancel

data/lib/appmap/gem_hooks/activejob.yml

@@ -0,0 +1,2 @@
+- method: ActiveJob::Enqueuing#enqueue
+  label: job.create

data/lib/appmap/gem_hooks/resque.yml

@@ -0,0 +1,4 @@
+- method: Resque::Job.create
+  label: job.create
+- method: Resque::Job.destroy
+  label: job.cancel

data/lib/appmap/gem_hooks/sidekiq.yml

@@ -0,0 +1,4 @@
+- method: Sidekiq::Client#push
+  label: job.create
+- method: Sidekiq::Job#delete
+  label: job.cancel

data/lib/appmap/hook.rb

@@ -7,8 +7,10 @@ module AppMap
     LOG = (ENV['APPMAP_DEBUG'] == 'true' || ENV['DEBUG'] == 'true')
     LOG_HOOK = (ENV['DEBUG_HOOK'] == 'true')
 
-    OBJECT_INSTANCE_METHODS = %i[! != !~ <=> == === =~ __id__ __send__ class clone define_singleton_method display dup enum_for eql? equal? extend freeze frozen? hash inspect instance_eval instance_exec instance_of? instance_variable_defined? instance_variable_get instance_variable_set instance_variables is_a? itself kind_of? method methods nil? object_id private_methods protected_methods public_method public_methods public_send remove_instance_variable respond_to? send singleton_class singleton_method singleton_methods taint tainted? tap then to_enum to_s to_h to_a trust untaint untrust untrusted? yield_self].freeze
-    OBJECT_STATIC_METHODS = %i[! != !~ < <= <=> == === =~ > >= __id__ __send__ alias_method allocate ancestors attr attr_accessor attr_reader attr_writer autoload autoload? class class_eval class_exec class_variable_defined? class_variable_get class_variable_set class_variables clone const_defined? const_get const_missing const_set constants define_method define_singleton_method deprecate_constant display dup enum_for eql? equal? extend freeze frozen? hash include include? included_modules inspect instance_eval instance_exec instance_method instance_methods instance_of? instance_variable_defined? instance_variable_get instance_variable_set instance_variables is_a? itself kind_of? method method_defined? methods module_eval module_exec name new nil? object_id prepend private_class_method private_constant private_instance_methods private_method_defined? private_methods protected_instance_methods protected_method_defined? protected_methods public_class_method public_constant public_instance_method public_instance_methods public_method public_method_defined? public_methods public_send remove_class_variable remove_instance_variable remove_method respond_to? send singleton_class singleton_class? singleton_method singleton_methods superclass taint tainted? tap then to_enum to_s trust undef_method untaint untrust untrusted? yield_self].freeze
+    OBJECT_INSTANCE_METHODS = %i[! != !~ <=> == === =~ __id__ __send__ class clone define_singleton_method display dup
+                                 enum_for eql? equal? extend freeze frozen? hash inspect instance_eval instance_exec instance_of? instance_variable_defined? instance_variable_get instance_variable_set instance_variables is_a? itself kind_of? method methods nil? object_id private_methods protected_methods public_method public_methods public_send remove_instance_variable respond_to? send singleton_class singleton_method singleton_methods taint tainted? tap then to_enum to_s to_h to_a trust untaint untrust untrusted? yield_self].freeze
+    OBJECT_STATIC_METHODS = %i[! != !~ < <= <=> == === =~ > >= __id__ __send__ alias_method allocate ancestors attr
+                               attr_accessor attr_reader attr_writer autoload autoload? class class_eval class_exec class_variable_defined? class_variable_get class_variable_set class_variables clone const_defined? const_get const_missing const_set constants define_method define_singleton_method deprecate_constant display dup enum_for eql? equal? extend freeze frozen? hash include include? included_modules inspect instance_eval instance_exec instance_method instance_methods instance_of? instance_variable_defined? instance_variable_get instance_variable_set instance_variables is_a? itself kind_of? method method_defined? methods module_eval module_exec name new nil? object_id prepend private_class_method private_constant private_instance_methods private_method_defined? private_methods protected_instance_methods protected_method_defined? protected_methods public_class_method public_constant public_instance_method public_instance_methods public_method public_method_defined? public_methods public_send remove_class_variable remove_instance_variable remove_method respond_to? send singleton_class singleton_class? singleton_method singleton_methods superclass taint tainted? tap then to_enum to_s trust undef_method untaint untrust untrusted? yield_self].freeze
     SLOW_PACKAGE_THRESHOLD = 0.05
 
     @unbound_method_arity = ::UnboundMethod.instance_method(:arity)
@@ -29,7 +31,7 @@ module AppMap
       def already_hooked?(method)
         # After a method is defined, the statement "module_function <the-method>" can convert that method
         # into a module (class) method. The method is hooked first when it's defined, then AppMap will attempt to
-        # hook it again when it's redefined as a module method. So we check the method source location - if it's 
+        # hook it again when it's redefined as a module method. So we check the method source location - if it's
         # part of the AppMap source tree, we ignore it.
         method.source_location && method.source_location[0].index(__dir__) == 0
       end
@@ -63,7 +65,7 @@ module AppMap
       @notrace_paths = Set.new
       # Locations that have already been visited.
       @trace_locations = Set.new
-      @module_load_times = Hash.new {|memo,k| memo[k] = 0}
+      @module_load_times = Hash.new { |memo, k| memo[k] = 0 }
       @slow_packages = Set.new
 
       if ENV['APPMAP_PROFILE_HOOK'] == 'true'
@@ -90,18 +92,20 @@ module AppMap
     end
 
     # hook_builtins builds hooks for code that is built in to the Ruby standard library.
-    # No TracePoint events are emitted for builtins, so a separate hooking mechanism is needed. 
+    # No TracePoint events are emitted for builtins, so a separate hooking mechanism is needed.
     def hook_builtins
       return unless self.class.hook_builtins?
 
       hook_loaded_code = lambda do |hooks_by_class, builtin|
         hooks_by_class.each do |class_name, hooks|
           Array(hooks).each do |hook|
-            require hook.package.require_name if builtin && hook.package.require_name && hook.package.require_name != 'ruby'
+            if builtin && hook.package.require_name && hook.package.require_name != 'ruby'
+              require hook.package.require_name
+            end
 
             Array(hook.method_names).each do |method_name|
               method_name = method_name.to_sym
-              base_cls = Util::class_from_string(class_name, must: false)
+              base_cls = Util.class_from_string(class_name, must: false)
               next unless base_cls
 
               hook_method = lambda do |entry|
@@ -113,8 +117,10 @@ module AppMap
 
               methods = []
               methods << [ base_cls, base_cls.public_instance_method(method_name) ] rescue nil
+              methods << [ base_cls, base_cls.protected_instance_method(method_name) ] rescue nil
               if base_cls.respond_to?(:singleton_class)
                 methods << [ base_cls.singleton_class, base_cls.singleton_class.public_instance_method(method_name) ] rescue nil
+                methods << [ base_cls.singleton_class, base_cls.singleton_class.protected_instance_method(method_name) ] rescue nil
               end
               methods.compact!
               if methods.empty?
@@ -144,19 +150,19 @@ module AppMap
 
       path = trace_point.path
       enabled = !@notrace_paths.member?(path) && config.path_enabled?(path)
-      if !enabled
-        warn "Not hooking - path is not enabled" if Hook::LOG || Hook::LOG_HOOK
+      unless enabled
+        warn 'Not hooking - path is not enabled' if Hook::LOG || Hook::LOG_HOOK
         @notrace_paths << path
         return
       end
 
       cls = trace_point.self
 
-      instance_methods = cls.public_instance_methods(false) - OBJECT_INSTANCE_METHODS
+      instance_methods = cls.public_instance_methods(false) + cls.protected_instance_methods(false) - OBJECT_INSTANCE_METHODS
       # NoMethodError: private method `singleton_class' called for Rack::MiniProfiler:Class
       class_methods = begin
         if cls.respond_to?(:singleton_class)
-          cls.singleton_class.public_instance_methods(false) - instance_methods - OBJECT_STATIC_METHODS
+          cls.singleton_class.public_instance_methods(false) + cls.singleton_class.protected_instance_methods(false) - instance_methods - OBJECT_STATIC_METHODS
         else
           []
         end
@@ -172,12 +178,13 @@ module AppMap
 
           next if method_id == :call
 
-          method = begin
-            hook_cls.public_instance_method(method_id)
-          rescue NameError
-            warn "AppMap: Method #{hook_cls} #{method.name} is not accessible" if LOG
-            next
-          end
+          method = \
+            begin
+              hook_cls.instance_method(method_id)
+            rescue NameError
+              warn "AppMap: Method #{hook_cls} #{fn} is not accessible: #{$!}" if LOG
+              next
+            end
 
           next if self.class.already_hooked?(method)
 

data/lib/appmap/util.rb

@@ -226,7 +226,9 @@ module AppMap
         elsif ENV['DEBUG'] == 'true'
           warn msg
         end
-      end  
+
+        nil
+      end
 
       def ruby_minor_version
         @ruby_minor_version ||= RUBY_VERSION.split('.')[0..1].join('.').to_f

data/lib/appmap/version.rb

@@ -3,7 +3,7 @@
 module AppMap
   URL = 'https://github.com/applandinc/appmap-ruby'
 
-  VERSION = '0.68.0'
+  VERSION = '0.70.0'
 
   APPMAP_FORMAT_VERSION = '1.5.1'
 

data/spec/class_map_spec.rb

@@ -16,7 +16,7 @@ describe 'AppMap::ClassMap' do
     end
 
     def ruby_method(method)
-      AppMap::Trace::RubyMethod.new AppMap::Config::Package.new, method.receiver.class.name, method, false
+      AppMap::Trace::RubyMethod.new AppMap::Config::Package.new('pkg'), method.receiver.class.name, method, false
     end
 
     def dig_map(map, depth)

data/spec/config_spec.rb

@@ -11,6 +11,10 @@ describe AppMap::Config, docker: false do
       functions: [
         {
           name: 'pkg/cls#fn',
+        },
+        {
+          methods: ['cls#new_fn'],
+          path: 'pkg'
         }
       ]
     }.deep_stringify_keys!
@@ -64,6 +68,15 @@ describe AppMap::Config, docker: false do
               "fn"
             ]
           }
+        },
+        {
+          "cls": "cls",
+          "target_methods": {
+            "package": "pkg",
+            "method_names": [
+              "new_fn"
+            ]
+          }
         }
       ],
       "builtin_hooks": {
@@ -195,6 +208,12 @@ describe AppMap::Config, docker: false do
             "method_names": [
               "fn"
             ]
+          },
+          {
+            "package": "pkg",
+            "method_names": [
+              "new_fn"
+            ]
           }
         ],
         "ActiveSupport::Callbacks::CallbackSequence": [
@@ -224,6 +243,21 @@ describe AppMap::Config, docker: false do
     FIXTURE
   end
 
+  describe AppMap::Config::Package do
+    describe :build_from_gem do
+      let(:mock_rails) { double(logger: double(info: true)) }
+
+      before do
+        stub_const('Rails', mock_rails)
+      end
+
+      it 'does not return a truthy value on failure' do
+        result = AppMap::Config::Package.build_from_gem('some_missing_gem_name', optional: true)
+        expect(result).to_not be_truthy
+      end
+    end
+  end
+
   context do
     let(:warnings) { @warnings ||= [] }
     let(:warning) { warnings.join }

data/spec/fixtures/hook/pkg_a/a.rb

@@ -0,0 +1,7 @@
+module PkgA
+  class A
+    def self.hello
+      'hello'
+    end
+  end
+end

data/spec/fixtures/hook/protected_method.rb

@@ -0,0 +1,29 @@
+# frozen_string_literal: true
+
+class ProtectedMethod
+  def call_protected
+    protected_method
+  end
+
+  def to_s
+    'Protected Method fixture'
+  end
+
+  class << self
+    def call_protected
+      protected_method
+    end
+
+    protected
+  
+    def protected_method
+      'self.protected'
+    end
+  end
+
+  protected
+  
+  def protected_method
+    'protected'
+  end
+end

data/spec/fixtures/hook/sub_packages.rb

@@ -0,0 +1,7 @@
+require_relative 'pkg_a/a'
+
+module SubPackages
+  def self.invoke_a
+    PkgA::A.hello
+  end
+end

data/spec/hook_spec.rb

@@ -9,7 +9,7 @@ require 'diffy'
 # empty. This make some of the expected YAML below easier to
 # understand.
 module ShowYamlNulls
-  def visit_NilClass(o)
+  def visit_NilClass(_o)
     @emitter.scalar('null', nil, 'tag:yaml.org,2002:null', true, false, Psych::Nodes::Scalar::ANY)
   end
 end
@@ -18,10 +18,10 @@ Psych::Visitors::YAMLTree.prepend(ShowYamlNulls)
 describe 'AppMap class Hooking', docker: false do
   include_context 'collect events'
 
-  def invoke_test_file(file, setup: nil, &block)
+  def invoke_test_file(file, setup: nil, packages: nil)
     AppMap.configuration = nil
-    package = AppMap::Config::Package.build_from_path(file)
-    config = AppMap::Config.new('hook_spec', packages: [ package ])
+    packages ||= [ AppMap::Config::Package.build_from_path(file) ]
+    config = AppMap::Config.new('hook_spec', packages: packages)
     AppMap.configuration = config
     tracer = nil
     AppMap::Hook.new(config).enable do
@@ -153,7 +153,7 @@ describe 'AppMap class Hooking', docker: false do
     class_map = AppMap.class_map(tracer.event_methods).to_yaml
     expect(Diffy::Diff.new(<<~YAML, class_map).to_s).to eq('')
     ---
-    - :name: spec/fixtures/hook/labels.rb
+    - :name: spec/fixtures/hook
       :type: package
       :children:
       - :name: ClassWithLabel
@@ -166,7 +166,41 @@ describe 'AppMap class Hooking', docker: false do
           :labels:
           - has-fn-label
           :comment: "# @label has-fn-label\\n"
-      YAML
+    YAML
+  end
+
+  it 'reports sub-folders as distinct packages' do
+    _, tracer = invoke_test_file 'spec/fixtures/hook/sub_packages.rb',
+                                 packages: [ AppMap::Config::Package.build_from_path('spec/fixtures/hook') ] do
+      SubPackages.invoke_a
+    end
+    class_map = AppMap.class_map(tracer.event_methods).to_yaml
+    expect(Diffy::Diff.new(<<~YAML, class_map).to_s).to eq('')
+    ---
+    - :name: spec/fixtures/hook
+      :type: package
+      :children:
+      - :name: SubPackages
+        :type: class
+        :children:
+        - :name: invoke_a
+          :type: function
+          :location: spec/fixtures/hook/sub_packages.rb:4
+          :static: true
+      - :name: pkg_a
+        :type: package
+        :children:
+        - :name: PkgA
+          :type: class
+          :children:
+          - :name: A
+            :type: class
+            :children:
+            - :name: hello
+              :type: function
+              :location: spec/fixtures/hook/pkg_a/a.rb:3
+              :static: true
+    YAML
   end
 
   it 'hooks an instance method that takes no arguments' do
@@ -210,7 +244,7 @@ describe 'AppMap class Hooking', docker: false do
     class_map = AppMap.class_map(tracer.event_methods).to_yaml
     expect(Diffy::Diff.new(<<~YAML, class_map).to_s).to eq('')
     ---
-    - :name: spec/fixtures/hook/instance_method.rb
+    - :name: spec/fixtures/hook
       :type: package
       :children:
       - :name: InstanceMethod
@@ -243,6 +277,92 @@ describe 'AppMap class Hooking', docker: false do
     end
   end
 
+  it 'records protected instance methods' do
+    events_yaml = <<~YAML
+    ---
+    - :id: 1
+      :event: :call
+      :defined_class: ProtectedMethod
+      :method_id: call_protected
+      :path: spec/fixtures/hook/protected_method.rb
+      :lineno: 4
+      :static: false
+      :parameters: []
+      :receiver:
+        :class: ProtectedMethod
+        :value: Protected Method fixture
+    - :id: 2
+      :event: :call
+      :defined_class: ProtectedMethod
+      :method_id: protected_method
+      :path: spec/fixtures/hook/protected_method.rb
+      :lineno: 26
+      :static: false
+      :parameters: []
+      :receiver:
+        :class: ProtectedMethod
+        :value: Protected Method fixture
+    - :id: 3
+      :event: :return
+      :parent_id: 2
+      :return_value:
+        :class: String
+        :value: protected
+    - :id: 4
+      :event: :return
+      :parent_id: 1
+      :return_value:
+        :class: String
+        :value: protected
+    YAML
+    test_hook_behavior 'spec/fixtures/hook/protected_method.rb', events_yaml do
+      expect(ProtectedMethod.new.call_protected).to eq('protected')
+    end
+  end
+
+  it 'records protected singleton (static) methods' do
+    events_yaml = <<~YAML
+    ---
+    - :id: 1
+      :event: :call
+      :defined_class: ProtectedMethod
+      :method_id: call_protected
+      :path: spec/fixtures/hook/protected_method.rb
+      :lineno: 13
+      :static: true
+      :parameters: []
+      :receiver:
+        :class: Class
+        :value: ProtectedMethod
+    - :id: 2
+      :event: :call
+      :defined_class: ProtectedMethod
+      :method_id: protected_method
+      :path: spec/fixtures/hook/protected_method.rb
+      :lineno: 19
+      :static: true
+      :parameters: []
+      :receiver:
+        :class: Class
+        :value: ProtectedMethod
+    - :id: 3
+      :event: :return
+      :parent_id: 2
+      :return_value:
+        :class: String
+        :value: self.protected
+    - :id: 4
+      :event: :return
+      :parent_id: 1
+      :return_value:
+        :class: String
+        :value: self.protected
+    YAML
+    test_hook_behavior 'spec/fixtures/hook/protected_method.rb', events_yaml do
+      expect(ProtectedMethod.call_protected).to eq('self.protected')
+    end
+  end
+
   it 'hooks an instance method that takes an argument' do
     events_yaml = <<~YAML
     ---
@@ -483,7 +603,6 @@ describe 'AppMap class Hooking', docker: false do
     end
   end
 
-
   it 'hooks an included method' do
     events_yaml = <<~YAML
     ---
@@ -607,11 +726,9 @@ describe 'AppMap class Hooking', docker: false do
         :lineno: 9
     YAML
     test_hook_behavior 'spec/fixtures/hook/exception_method.rb', events_yaml do
-      begin
-        ExceptionMethod.new.raise_exception
-      rescue
-        # don't let the exception fail the test
-      end
+      ExceptionMethod.new.raise_exception
+    rescue
+      # don't let the exception fail the test
     end
   end
 
@@ -639,16 +756,13 @@ describe 'AppMap class Hooking', docker: false do
         :lineno: 59
     YAML
     test_hook_behavior 'spec/fixtures/hook/exception_method.rb', events_yaml do
-      begin
-        ExceptionMethod.new.raise_illegal_utf8_message
-      rescue
-        # don't let the exception fail the test
-      end
+      ExceptionMethod.new.raise_illegal_utf8_message
+    rescue
+      # don't let the exception fail the test
     end
   end
 
   context 'string conversions works for the receiver when' do
-
     it 'is missing #to_s' do
       events_yaml = <<~YAML
       ---
@@ -979,7 +1093,7 @@ describe 'AppMap class Hooking', docker: false do
     end
   end
 
-  it "preserves the arity of hooked methods" do
+  it 'preserves the arity of hooked methods' do
     invoke_test_file 'spec/fixtures/hook/instance_method.rb' do
       expect(InstanceMethod.instance_method(:say_echo).arity).to be(1)
       expect(InstanceMethod.new.method(:say_echo).arity).to be(1)

data/spec/rails_recording_spec.rb

@@ -157,31 +157,31 @@ describe 'Rails' do
             )
 
             expect(appmap['classMap']).to include hash_including(
-              'name' => 'app/views',
+              'name' => 'app',
               'children' => include(hash_including(
-                'name' => 'app_views_users_index_html_haml',
+                'name' => 'views',
                 'children' => include(hash_including(
-                  'name' => 'render',
-                  'type' => 'function',
-                  'location' => 'app/views/users/index.html.haml',
-                  'static' => true,
-                  'labels' => [ 'mvc.template' ]
-                ))
-              ))
-            )
+                  'name' => 'app_views_users_index_html_haml',
+                  'children' => include(hash_including(
+                    'name' => 'render',
+                    'type' => 'function',
+                    'location' => 'app/views/users/index.html.haml',
+                    'static' => true,
+                    'labels' => [ 'mvc.template' ]
+                  )))))))
             expect(appmap['classMap']).to include hash_including(
-              'name' => 'app/views',
+              'name' => 'app',
               'children' => include(hash_including(
-                'name' => 'app_views_layouts_application_html_haml',
+                'name' => 'views',
                 'children' => include(hash_including(
-                  'name' => 'render',
-                  'type' => 'function',
-                  'location' => 'app/views/layouts/application.html.haml',
-                  'static' => true,
-                  'labels' => [ 'mvc.template' ]
-                ))
-              ))
-            )
+                  'name' => 'app_views_layouts_application_html_haml',
+                  'children' => include(hash_including(
+                    'name' => 'render',
+                    'type' => 'function',
+                    'location' => 'app/views/layouts/application.html.haml',
+                    'static' => true,
+                    'labels' => [ 'mvc.template' ]
+                  )))))))
           end
         end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: appmap
 version: !ruby/object:Gem::Version
-  version: 0.68.0
+  version: 0.70.0
 platform: ruby
 authors:
 - Kevin Gilpin
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-11-05 00:00:00.000000000 Z
+date: 2021-12-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -3429,8 +3429,12 @@ files:
 - lib/appmap/event.rb
 - lib/appmap/gem_hooks/actionpack.yml
 - lib/appmap/gem_hooks/actionview.yml
+- lib/appmap/gem_hooks/activejob-cancel.yml
+- lib/appmap/gem_hooks/activejob.yml
 - lib/appmap/gem_hooks/activesupport.yml
 - lib/appmap/gem_hooks/cancancan.yml
+- lib/appmap/gem_hooks/resque.yml
+- lib/appmap/gem_hooks/sidekiq.yml
 - lib/appmap/handler/function.rb
 - lib/appmap/handler/net_http.rb
 - lib/appmap/handler/rails/request_handler.rb
@@ -3502,10 +3506,13 @@ files:
 - spec/fixtures/hook/kwargs.rb
 - spec/fixtures/hook/labels.rb
 - spec/fixtures/hook/method_named_call.rb
+- spec/fixtures/hook/pkg_a/a.rb
+- spec/fixtures/hook/protected_method.rb
 - spec/fixtures/hook/revoke_api_key.appmap.json
 - spec/fixtures/hook/singleton_method.rb
 - spec/fixtures/hook/spec/api_spec.rb
 - spec/fixtures/hook/spec/user_spec.rb
+- spec/fixtures/hook/sub_packages.rb
 - spec/fixtures/hook/user_page_scenario.appmap.json
 - spec/fixtures/rack_users_app/.dockerignore
 - spec/fixtures/rack_users_app/.gitignore