application_service 0.2.4 → 0.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b15acb3ccb93f710feacd808e1585005638843f7
-  data.tar.gz: def0376ab7d6c65223191490bc7d71815f0b6390
+  metadata.gz: 6b800abf813eb3e4b9355dd7494b739610a00404
+  data.tar.gz: 86a7a6b368a8b35dddcef04fe3dd133c8833fb18
 SHA512:
-  metadata.gz: e80715590ec3ee6174c938dd681652b2539c4abb2e6a6e04296333b00915ce0afb511ec719b8abd4a10233d3b43a0499d65d70c110d3cc552ec71fc44aac5cdc
-  data.tar.gz: 0f8e90eaa1acc799fb8932d78252b7e463dea6557c7e78709f8acddf2ef0c9dbadc12a051e57f0bcc24f09f3ba1651b8704cd9a4c7d9c2f49be5b94e5a7d5632
+  metadata.gz: b5c332a969dc635e75481547fd59ca8c837c16e29f65ea3b513f629da8f736f8d1c8e71edf44f667afb81746f58a0f9740f0d5e8645fd13ab035340e5a7c879b
+  data.tar.gz: bbbfbde306ce4f35cfdbcedecebd2c5d652918d4bfc19694d026b32d1d3e2bf5931b3b9535d64c5bef5f17a5cf3d0473eb39ab7df35b3f0ea04ec4e773f04707

data/.ruby-version

@@ -1 +1 @@
-2.2.4
+2.2.5

data/Gemfile

@@ -9,5 +9,5 @@ gem 'activesupport'
 # Include everything needed to run rake, tests, features, etc.
 group :development do
   gem "rspec"
-  gem "jeweler", "~> 1.8.4"
+  gem "jeweler"
 end

data/Gemfile.lock

@@ -1,62 +1,76 @@
 GEM
   remote: http://rubygems.org/
   specs:
-    activesupport (4.2.5.1)
+    activesupport (5.0.0.1)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (~> 0.7)
-      json (~> 1.7, >= 1.7.7)
       minitest (~> 5.1)
-      thread_safe (~> 0.3, >= 0.3.4)
       tzinfo (~> 1.1)
-    addressable (2.3.6)
+    addressable (2.5.0)
+      public_suffix (~> 2.0, >= 2.0.2)
     builder (3.2.2)
-    diff-lcs (1.2.4)
-    faraday (0.8.9)
-      multipart-post (~> 1.2.0)
-    git (1.2.7)
-    github_api (0.10.1)
-      addressable
-      faraday (~> 0.8.1)
+    concurrent-ruby (1.0.2)
+    descendants_tracker (0.0.4)
+      thread_safe (~> 0.3, >= 0.3.1)
+    diff-lcs (1.2.5)
+    faraday (0.9.2)
+      multipart-post (>= 1.2, < 3)
+    git (1.3.0)
+    github_api (0.11.3)
+      addressable (~> 2.3)
+      descendants_tracker (~> 0.0.1)
+      faraday (~> 0.8, < 0.10)
       hashie (>= 1.2)
-      multi_json (~> 1.4)
-      nokogiri (~> 1.5.2)
+      multi_json (>= 1.7.5, < 2.0)
+      nokogiri (~> 1.6.0)
       oauth2
-    hashie (3.2.0)
-    highline (1.6.21)
+    hashie (3.4.6)
+    highline (1.7.8)
     i18n (0.7.0)
-    jeweler (1.8.8)
+    jeweler (2.2.1)
       builder
-      bundler (~> 1.0)
+      bundler (>= 1.0)
       git (>= 1.2.5)
-      github_api (= 0.10.1)
+      github_api (~> 0.11.0)
       highline (>= 1.6.15)
-      nokogiri (= 1.5.10)
+      nokogiri (>= 1.5.10)
+      psych (~> 2.2)
       rake
       rdoc
-    json (1.8.1)
-    jwt (1.0.0)
-    minitest (5.8.4)
-    multi_json (1.11.2)
-    multi_xml (0.5.5)
-    multipart-post (1.2.0)
-    nokogiri (1.5.10)
-    oauth2 (1.0.0)
+      semver
+    jwt (1.5.6)
+    mini_portile2 (2.1.0)
+    minitest (5.10.1)
+    multi_json (1.12.1)
+    multi_xml (0.6.0)
+    multipart-post (2.0.0)
+    nokogiri (1.6.8.1)
+      mini_portile2 (~> 2.1.0)
+    oauth2 (1.2.0)
       faraday (>= 0.8, < 0.10)
       jwt (~> 1.0)
       multi_json (~> 1.3)
       multi_xml (~> 0.5)
-      rack (~> 1.2)
-    rack (1.5.2)
-    rake (10.3.2)
-    rdoc (4.1.1)
-      json (~> 1.4)
-    rspec (2.14.1)
-      rspec-core (~> 2.14.0)
-      rspec-expectations (~> 2.14.0)
-      rspec-mocks (~> 2.14.0)
-    rspec-core (2.14.4)
-    rspec-expectations (2.14.0)
-      diff-lcs (>= 1.1.3, < 2.0)
-    rspec-mocks (2.14.2)
+      rack (>= 1.2, < 3)
+    psych (2.2.1)
+    public_suffix (2.0.4)
+    rack (2.0.1)
+    rake (12.0.0)
+    rdoc (5.0.0)
+    rspec (3.5.0)
+      rspec-core (~> 3.5.0)
+      rspec-expectations (~> 3.5.0)
+      rspec-mocks (~> 3.5.0)
+    rspec-core (3.5.4)
+      rspec-support (~> 3.5.0)
+    rspec-expectations (3.5.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.5.0)
+    rspec-mocks (3.5.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.5.0)
+    rspec-support (3.5.0)
+    semver (1.0.1)
     thread_safe (0.3.5)
     tzinfo (1.2.2)
       thread_safe (~> 0.1)
@@ -66,8 +80,8 @@ PLATFORMS
 
 DEPENDENCIES
   activesupport
-  jeweler (~> 1.8.4)
+  jeweler
   rspec
 
 BUNDLED WITH
-   1.11.2
+   1.13.6

data/VERSION

@@ -1 +1 @@
-0.2.4
+0.2.5

data/application_service.gemspec

@@ -2,18 +2,18 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: application_service 0.2.4 ruby lib
+# stub: application_service 0.2.5 ruby lib
 
 Gem::Specification.new do |s|
-  s.name = "application_service"
-  s.version = "0.2.4"
+  s.name = "application_service".freeze
+  s.version = "0.2.5"
 
-  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
-  s.require_paths = ["lib"]
-  s.authors = ["Nathan Woodhull"]
-  s.date = "2016-02-06"
-  s.description = "A service layer scaffold for rails apps extracted from Agra"
-  s.email = "woodhull@gmail.com"
+  s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
+  s.require_paths = ["lib".freeze]
+  s.authors = ["Nathan Woodhull".freeze]
+  s.date = "2016-12-07"
+  s.description = "A service layer scaffold for rails apps extracted from Agra".freeze
+  s.email = "woodhull@gmail.com".freeze
   s.extra_rdoc_files = [
     "LICENSE.txt",
     "README.rdoc"
@@ -34,27 +34,27 @@ Gem::Specification.new do |s|
     "spec/application_service_spec.rb",
     "spec/spec_helper.rb"
   ]
-  s.homepage = "http://github.com/woodhull/application_service"
-  s.licenses = ["MIT"]
-  s.rubygems_version = "2.4.8"
-  s.summary = "Service Layer Scaffold"
+  s.homepage = "http://github.com/woodhull/application_service".freeze
+  s.licenses = ["MIT".freeze]
+  s.rubygems_version = "2.6.8".freeze
+  s.summary = "Service Layer Scaffold".freeze
 
   if s.respond_to? :specification_version then
     s.specification_version = 4
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_runtime_dependency(%q<activesupport>, [">= 0"])
-      s.add_development_dependency(%q<rspec>, [">= 0"])
-      s.add_development_dependency(%q<jeweler>, ["~> 1.8.4"])
+      s.add_runtime_dependency(%q<activesupport>.freeze, [">= 0"])
+      s.add_development_dependency(%q<rspec>.freeze, [">= 0"])
+      s.add_development_dependency(%q<jeweler>.freeze, [">= 0"])
     else
-      s.add_dependency(%q<activesupport>, [">= 0"])
-      s.add_dependency(%q<rspec>, [">= 0"])
-      s.add_dependency(%q<jeweler>, ["~> 1.8.4"])
+      s.add_dependency(%q<activesupport>.freeze, [">= 0"])
+      s.add_dependency(%q<rspec>.freeze, [">= 0"])
+      s.add_dependency(%q<jeweler>.freeze, [">= 0"])
     end
   else
-    s.add_dependency(%q<activesupport>, [">= 0"])
-    s.add_dependency(%q<rspec>, [">= 0"])
-    s.add_dependency(%q<jeweler>, ["~> 1.8.4"])
+    s.add_dependency(%q<activesupport>.freeze, [">= 0"])
+    s.add_dependency(%q<rspec>.freeze, [">= 0"])
+    s.add_dependency(%q<jeweler>.freeze, [">= 0"])
   end
 end
 

data/lib/application_service.rb

@@ -3,7 +3,7 @@ require 'active_support/all'
 class ApplicationService
 
   include ActiveSupport::Callbacks
-  define_callbacks :save, :create, :update, :destroy, {terminator: ->(target, result) { result == false }, skip_after_callbacks_if_terminated: true}
+  define_callbacks :save, :create, :update, :destroy, {terminator: ->(target, result) { result.call == false }, skip_after_callbacks_if_terminated: true}
 
   def initialize
   end

data/spec/application_service_spec.rb

@@ -9,35 +9,35 @@ describe ApplicationService do
     it "should allow set and get" do
       obj = double()
       as = ApplicationService.new
-      as.current_object= obj
-      as.current_object.should == obj
+      as.current_object = obj
+      expect(as.current_object).to eq(obj)
     end
   end
 
   describe "#save" do
     it "should let you save an object" do
       obj = double()
-      obj.stub(:new_record?).and_return(true)
-      obj.should_receive(:save)
+      allow(obj).to receive(:new_record?).and_return(true)
+      expect(obj).to receive(:save)
       subject.save(obj)
     end
 
     it "should trigger create" do
       obj = double()
-      obj.stub(:new_record?).and_return(true)
-      obj.stub(:save)
+      allow(obj).to receive(:new_record?).and_return(true)
+      allow(obj).to receive(:save)
 
-      subject.should_receive(:create)
+      expect(subject).to receive(:create)
       subject.save(obj)
     end
 
 
     it "should trigger update" do
       obj = double()
-      obj.stub(:new_record?).and_return(false)
-      obj.stub(:save)
+      allow(obj).to receive(:new_record?).and_return(false)
+      allow(obj).to receive(:save)
 
-      subject.should_receive(:update)
+      expect(subject).to receive(:update)
       subject.save(obj)
     end
   end
@@ -45,27 +45,27 @@ describe ApplicationService do
   describe "#save!" do
     it "should let you save an object" do
       obj = double()
-      obj.stub(:new_record?).and_return(true)
-      obj.should_receive(:save!)
+      allow(obj).to receive(:new_record?).and_return(true)
+      expect(obj).to receive(:save!)
       subject.save!(obj)
     end
 
     it "should trigger create" do
       obj = double()
-      obj.stub(:new_record?).and_return(true)
-      obj.stub(:save!)
+      allow(obj).to receive(:new_record?).and_return(true)
+      allow(obj).to receive(:save!)
 
-      subject.should_receive(:create!)
+      expect(subject).to receive(:create!)
       subject.save!(obj)
     end
 
 
     it "should trigger update" do
       obj = double()
-      obj.stub(:new_record?).and_return(false)
-      obj.stub(:save!)
+      allow(obj).to receive(:new_record?).and_return(false)
+      allow(obj).to receive(:save!)
 
-      subject.should_receive(:update!)
+      expect(subject).to receive(:update!)
       subject.save!(obj)
     end
   end
@@ -73,8 +73,8 @@ describe ApplicationService do
   describe "#update_attributes" do
     it "should trigger update" do
       obj = double()
-      obj.should_receive(:assign_attributes).with( {:foo => 'bar'}).and_return(:true)
-      obj.should_receive(:save)
+      expect(obj).to receive(:assign_attributes).with( {:foo => 'bar'}).and_return(:true)
+      expect(obj).to receive(:save)
 
       subject.update_attributes(obj, {:foo => 'bar'})
     end
@@ -83,7 +83,7 @@ describe ApplicationService do
   describe '#destroy' do
     it "should trigger destroy" do
       obj = double()
-      obj.should_receive(:destroy)
+      expect(obj).to receive(:destroy)
 
       subject.destroy(obj)
     end
@@ -159,7 +159,7 @@ describe ApplicationService do
           expect(service).to receive(:before_save_callback).once
           expect(service).to receive(:after_save_callback).once
 
-          expect { service.admin_save(object) }.to raise_error
+          expect { service.admin_save(object) }.to raise_error(StandardError)
 
           expect(object).to receive(:save).and_return(true)
 
@@ -209,12 +209,12 @@ describe ApplicationService do
         end
 
         service = service_klass.new
-        service.should_not_receive(:before_save_callback)
+        expect(service).to_not receive(:before_save_callback)
         service.save(object)
 
         invoke_callback = true
         service = service_klass.new
-        service.should_receive(:before_save_callback).and_return(true)
+        expect(service).to receive(:before_save_callback).and_return(true)
         service.save(object)
       end
 
@@ -226,14 +226,14 @@ describe ApplicationService do
         end
 
         service = service_klass.new
-        service.should_not_receive(:before_save_callback_1)
-        service.should_not_receive(:before_save_callback_2)
+        expect(service).not_to receive(:before_save_callback_1)
+        expect(service).not_to receive(:before_save_callback_2)
         service.save(object)
 
         invoke_callback = true
         service = service_klass.new
-        service.should_receive(:before_save_callback_1).and_return(true)
-        service.should_receive(:before_save_callback_2).and_return(true)
+        expect(service).to receive(:before_save_callback_1).and_return(true)
+        expect(service).to receive(:before_save_callback_2).and_return(true)
         service.save(object)
       end
 
@@ -243,8 +243,8 @@ describe ApplicationService do
         end
 
         service = service_klass.new
-        service.should_not_receive(:before_save_callback2)
-        service.stub(:before_save_callback1).and_return(false)
+        expect(service).not_to receive(:before_save_callback2)
+        allow(service).to receive(:before_save_callback1).and_return(false)
         service.save(object)
       end
 
@@ -254,8 +254,8 @@ describe ApplicationService do
         end
 
         service = service_klass.new
-        service.should_receive(:before_save_callback2)
-        service.stub(:before_save_callback1).and_return(true)
+        expect(service).to receive(:before_save_callback2)
+        allow(service).to receive(:before_save_callback1).and_return(true)
         service.save(object)
       end
 
@@ -267,10 +267,10 @@ describe ApplicationService do
         end
 
         service = service_klass.new
-        service.should_not_receive(:before_save_callback)
-        service.should_receive(:before_save_callback_2)
+        expect(service).not_to receive(:before_save_callback)
+        expect(service).to receive(:before_save_callback_2)
 
-        object.should_receive(:save).and_return(true)
+        expect(object).to receive(:save).and_return(true)
 
         service.save(object)
       end
@@ -281,8 +281,8 @@ describe ApplicationService do
         end
 
         service = service_klass.new
-        service.stub(:before_save_callback).and_return(false)
-        object.should_not_receive(:save)
+        allow(service).to receive(:before_save_callback).and_return(false)
+        expect(object).not_to receive(:save)
         expect(service.save(object)).to eq(false)
       end
 
@@ -292,7 +292,7 @@ describe ApplicationService do
         end
 
         service = service_klass.new
-        service.should_receive(:before_save_callback).and_return(true)
+        expect(service).to receive(:before_save_callback).and_return(true)
         expect(service.save(object)).to eq(true)
       end
     end
@@ -306,12 +306,12 @@ describe ApplicationService do
         end
 
         service = service_klass.new
-        service.should_not_receive(:after_save_callback)
+        expect(service).not_to receive(:after_save_callback)
         service.save(object)
 
         invoke_callback = true
         service = service_klass.new
-        service.should_receive(:after_save_callback).and_return(true)
+        expect(service).to receive(:after_save_callback).and_return(true)
         service.save(object)
       end
 
@@ -323,14 +323,14 @@ describe ApplicationService do
         end
 
         service = service_klass.new
-        service.should_not_receive(:after_save_callback_1)
-        service.should_not_receive(:after_save_callback_2)
+        expect(service).not_to receive(:after_save_callback_1)
+        expect(service).not_to receive(:after_save_callback_2)
         service.save(object)
 
         invoke_callback = true
         service = service_klass.new
-        service.should_receive(:after_save_callback_1).and_return(true)
-        service.should_receive(:after_save_callback_2).and_return(true)
+        expect(service).to receive(:after_save_callback_1).and_return(true)
+        expect(service).to receive(:after_save_callback_2).and_return(true)
         service.save(object)
       end
 
@@ -340,7 +340,7 @@ describe ApplicationService do
         end
 
         service = service_klass.new
-        service.should_receive(:after_save_callback).and_return(true)
+        expect(service).to receive(:after_save_callback).and_return(true)
         expect(service.save(object)).to eq(true)
       end
 
@@ -350,7 +350,7 @@ describe ApplicationService do
         end
 
         service = service_klass.new
-        service.should_not_receive(:after_save_callback)
+        expect(service).not_to receive(:after_save_callback)
         expect(service.save(object)).to eq(true)
       end
 
@@ -360,8 +360,8 @@ describe ApplicationService do
         end
 
         service = service_klass.new
-        object.should_receive(:save).and_return(false)
-        service.should_not_receive(:after_save_callback)
+        expect(object).to receive(:save).and_return(false)
+        expect(service).not_to receive(:after_save_callback)
         expect(service.save(object)).to eq(false)
       end
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: application_service
 version: !ruby/object:Gem::Version
-  version: 0.2.4
+  version: 0.2.5
 platform: ruby
 authors:
 - Nathan Woodhull
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-06 00:00:00.000000000 Z
+date: 2016-12-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -42,16 +42,16 @@ dependencies:
   name: jeweler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.8.4
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.8.4
+        version: '0'
 description: A service layer scaffold for rails apps extracted from Agra
 email: woodhull@gmail.com
 executables: []
@@ -94,7 +94,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Service Layer Scaffold