apple_shove 2.0.1 → 2.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fddaff591f202cc2de8d07ce6e6bd5d1ad00d545
-  data.tar.gz: 49a5b28b2c56c774435afc25784f0209308e6b65
+  metadata.gz: b119daa9b46ae843bed8fc8327dd77ac20189551
+  data.tar.gz: f2a2c0b62cc2593f5f3a1cb3a239552cd3092028
 SHA512:
-  metadata.gz: afaa11ebc095e9fdc384b63a4f8bdcffd5ca9def1a3be8b1899461eb4b60675b70d5e1777d1422d16dec32cc49290086bde30bf3a38a3192859470a4d98f5562
-  data.tar.gz: 692a7a94043eb7976a4ba2ec2aa1b3e942231fdc97d2c52f5594af94294ad755d48b17052668ce797e3bd48808bdbda33f8ee346f0caf6e3f09dedba68b20333
+  metadata.gz: 329d709e3ea8811764a41fe55928e3a2e48bb1a62262c920c15d3c8166c8901b2d92a3e2ec4c3bed360f92ee582b78e023804af41cf053932dbaaca3ab77e3e8
+  data.tar.gz: fdad094d6ff2b8519ec200e2b4066b7a2a0d5f26bfce390370c389e7bcc5d061c450b780bcbf265a174837269a7267ffa0948370e8edf26594c86fb77ac2e5a4

data/.travis.yml

@@ -0,0 +1,9 @@
+language: ruby
+rvm:
+    - 2.0.0
+    - 1.9.3
+    - jruby-19mode
+    - ruby-head
+    - jruby-head
+
+script: bundle exec rspec

data/README.md

@@ -1,4 +1,4 @@
-# AppleShove [![Code Climate](https://codeclimate.com/github/tboyko/apple_shove.png)](https://codeclimate.com/github/tboyko/apple_shove)
+# AppleShove [![Code Climate](https://codeclimate.com/github/tboyko/apple_shove.png)](https://codeclimate.com/github/tboyko/apple_shove) [![Build Status](https://travis-ci.org/tboyko/apple_shove.png?branch=master)](https://travis-ci.org/tboyko/apple_shove)
 
 APN Service Provider. More powerful than a push...
 

data/lib/apple_shove/apns/notify_connection.rb

@@ -23,7 +23,7 @@ module AppleShove
       end
 
       exclusive
-      
+
       def connect
         super
         @last_used = Time.now
@@ -42,16 +42,22 @@ module AppleShove
         rescue Exception => e
           handler = WriteExceptionHandler.new(e)
           Logger.warn(handler.message, self, notification)
-          reconnect                   if handler.reconnect?
-          socket.write @last_message  if handler.rewrite? && @last_message
+
+          begin
+            reconnect                   if handler.reconnect?
+            socket.write @last_message  if handler.rewrite? && @last_message
+          rescue Exception => e
+            Logger.warn("failed while trying to recover from write error", self, notification)
+          end
+
           retry                       if handler.retry?
         else
           Logger.info("delivered notification", self, notification)
-        end
 
-        @last_message = message
-        @last_used    = Time.now
-        @pending_notifications -= 1
+          @last_message = message
+          @last_used    = Time.now
+          @pending_notifications -= 1
+        end
       end
 
       def shutdown

data/lib/apple_shove/version.rb

@@ -1,3 +1,3 @@
 module AppleShove
-  VERSION = "2.0.1"
+  VERSION = "2.0.2"
 end

data/spec/notification_queue_spec.rb

@@ -13,21 +13,30 @@ describe AppleShove::NotificationQueue do
   end
 
   it 'should add notifications to the queue' do
+    expect_any_instance_of(Redis).to receive(:rpush)
+
     n = generate_notification
     @q.add(n)
   end
 
   it 'should count notification on the queue when they are there' do
-    @q.size.should_not eql(0)
+    expect_any_instance_of(Redis).to receive(:llen).and_return(1)
+
+    expect(@q.size).to be_a_kind_of(Integer)
   end
 
   it 'should get notifications from the queue' do
-    while n = @q.get
-      n.should be_an_instance_of(AppleShove::Notification)
-    end
+    json = { p12: 'some p12', device_token: '123123123', payload: 'this is a test payload' }.to_json
+    expect_any_instance_of(Redis).to receive(:lpop).and_return(json)
+
+    notification = @q.get
+    
+    expect(notification).to be_an_instance_of(AppleShove::Notification)
   end
 
   it 'should count 0 notifications when the queue is empty' do
+    expect_any_instance_of(Redis).to receive(:llen).and_return(0)
+    
     @q.size.should eql(0)
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: apple_shove
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.0.2
 platform: ruby
 authors:
 - Taylor Boyko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-24 00:00:00.000000000 Z
+date: 2014-08-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -103,6 +103,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .travis.yml
 - Gemfile
 - LICENSE.txt
 - README.md