appium_lib_core 9.1.2 → 9.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 827943442ec187cb8560448ab4eca8ce3305e09c1ba14416e9105e29120623f2
-  data.tar.gz: 25a47149ae8ad01da298b922bbc0155fe0a2721b2ae723207354f165bff13f22
+  metadata.gz: 51fd1b5928d24942e7f5f944099c63728960f27cdab978cde119fe2ee68b0d73
+  data.tar.gz: 2d64236e6c3ed7501b260894e0fcbd58b16f6bf552e7f962c55331517e6d602b
 SHA512:
-  metadata.gz: 9737c683de56476af3f64cbd5f0d5f7f041af46de93ca27f839de54121e3c62a8cee70af0b0648b31f1ec303da8d5a5d2994bb04dac03528f0e260e8ae22febc
-  data.tar.gz: 0d4cabc1242a5e02e08aa3306d44b83560768b986cde550870a9f351c6519c60f671bfb209302b3997088fcb36622ae1ef287d5d853aa57a077ec88f95f1db91
+  metadata.gz: e10e20452f9dcbfc61e96e2dc1545de62b3baf549d36d0a87383dbfec1a3de12ee5aabf2ecc956fbf279baf74fc0e151c8d87238effad36acda81420b81048e1
+  data.tar.gz: 10fc303ae86844b8be9eb778c7395832ffa65a6eee4786d1d0684f554016483a48d5ddf1e1c5be3735c681bbc81b84321a2bfbc880a864bf7d3c934831fc2682

data/CHANGELOG.md

@@ -10,7 +10,12 @@ Read `release_notes.md` for commit level details.
 
 ### Deprecations
 
-## [9.1.2] - 2024-06-03
+## [9.2.0] - 2024-07-21
+### Enhancements
+- Raise defined errors in this library instead of Ruby general errors in some places.
+    - Most of errors have already followed this method. This version has updated rest of them.
+
+## [9.1.3., 9.1.2] - 2024-06-03
 
 ### Bug fixes
 - Fix `server_url` usage in `core.start_driver` to respect the given value every time.

data/README.md

@@ -2,7 +2,9 @@
 
 [![Gem Version](https://badge.fury.io/rb/appium_lib_core.svg)](https://badge.fury.io/rb/appium_lib_core)
 
-[![Build Status](https://dev.azure.com/AppiumCI/Appium%20CI/_apis/build/status/appium.ruby_lib_core?branchName=master)](https://dev.azure.com/AppiumCI/Appium%20CI/_build/latest?definitionId=54&branchName=master)
+[![Runs lint and unit tests](https://github.com/appium/ruby_lib_core/actions/workflows/unittest.yml/badge.svg)](https://github.com/appium/ruby_lib_core/actions/workflows/unittest.yml)
+[![Functional Tests](https://github.com/appium/ruby_lib_core/actions/workflows/functional-test.yml/badge.svg)](https://github.com/appium/ruby_lib_core/actions/workflows/functional-test.yml)
+
 
 This library is a Ruby client for Appium.  The gem is available via [appium_lib_core](https://rubygems.org/gems/appium_lib_core).
 

data/appium_lib_core.gemspec

@@ -29,7 +29,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'minitest-reporters', '~> 1.1'
   spec.add_development_dependency 'parallel_tests'
   spec.add_development_dependency 'rake', '~> 13.0'
-  spec.add_development_dependency 'rubocop', '1.64.1'
+  spec.add_development_dependency 'rubocop', '1.65.0'
   spec.add_development_dependency 'simplecov'
   spec.add_development_dependency 'webmock', '~> 3.23.0'
   spec.add_development_dependency 'yard', '~> 0.9.11'

data/lib/appium_lib_core/android/device/clipboard.rb

@@ -23,7 +23,8 @@ module Appium
             ::Appium::Core::Device.add_endpoint_method(:get_clipboard) do
               def get_clipboard(content_type: :plaintext)
                 unless ::Appium::Core::Base::Device::Clipboard::CONTENT_TYPE.member?(content_type)
-                  raise "content_type should be #{::Appium::Core::Base::Device::Clipboard::CONTENT_TYPE}"
+                  raise ::Appium::Core::Error::ArgumentError,
+                        "content_type should be #{::Appium::Core::Base::Device::Clipboard::CONTENT_TYPE}"
                 end
 
                 params = { contentType: content_type }
@@ -36,7 +37,8 @@ module Appium
             ::Appium::Core::Device.add_endpoint_method(:set_clipboard) do
               def set_clipboard(content:, content_type: :plaintext, label: nil)
                 unless ::Appium::Core::Base::Device::Clipboard::CONTENT_TYPE.member?(content_type)
-                  raise "content_type should be #{::Appium::Core::Base::Device::Clipboard::CONTENT_TYPE}"
+                  raise ::Appium::Core::Error::ArgumentError,
+                        "content_type should be #{::Appium::Core::Base::Device::Clipboard::CONTENT_TYPE}"
                 end
 
                 params = {

data/lib/appium_lib_core/android/device/emulator.rb

@@ -122,7 +122,7 @@ module Appium
             ::Appium::Core::Device.add_endpoint_method(:gsm_call) do
               def gsm_call(phone_number:, action:)
                 unless GSM_CALL_ACTIONS.member? action.to_sym
-                  raise "action: should be member of #{GSM_CALL_ACTIONS}. Not #{action}."
+                  raise ::Appium::Core::Error::ArgumentError, "action: should be member of #{GSM_CALL_ACTIONS}. Not #{action}."
                 end
 
                 execute(:gsm_call, {}, { phoneNumber: phone_number, action: action })
@@ -131,7 +131,10 @@ module Appium
 
             ::Appium::Core::Device.add_endpoint_method(:gsm_signal) do
               def gsm_signal(signal_strength)
-                raise "#{signal_strength} should be member of #{GSM_SIGNALS.keys} " if GSM_SIGNALS[signal_strength.to_sym].nil?
+                if GSM_SIGNALS[signal_strength.to_sym].nil?
+                  raise ::Appium::Core::Error::ArgumentError,
+                        "#{signal_strength} should be member of #{GSM_SIGNALS.keys} "
+                end
 
                 execute(:gsm_signal, {}, { signalStrength: GSM_SIGNALS[signal_strength],
                                            signalStrengh: GSM_SIGNALS[signal_strength] })
@@ -141,7 +144,7 @@ module Appium
             ::Appium::Core::Device.add_endpoint_method(:gsm_voice) do
               def gsm_voice(state)
                 unless GSM_VOICE_STATES.member? state.to_sym
-                  raise "The state should be member of #{GSM_VOICE_STATES}. Not #{state}."
+                  raise ::Appium::Core::Error::ArgumentError, "The state should be member of #{GSM_VOICE_STATES}. Not #{state}."
                 end
 
                 execute(:gsm_voice, {}, { state: state })
@@ -150,7 +153,10 @@ module Appium
 
             ::Appium::Core::Device.add_endpoint_method(:set_network_speed) do
               def set_network_speed(netspeed)
-                raise "The netspeed should be member of #{NET_SPEED}. Not #{netspeed}." unless NET_SPEED.member? netspeed.to_sym
+                unless NET_SPEED.member? netspeed.to_sym
+                  raise ::Appium::Core::Error::ArgumentError,
+                        "The netspeed should be member of #{NET_SPEED}. Not #{netspeed}."
+                end
 
                 execute(:set_network_speed, {}, { netspeed: netspeed })
               end
@@ -169,7 +175,7 @@ module Appium
             ::Appium::Core::Device.add_endpoint_method(:set_power_ac) do
               def set_power_ac(state)
                 unless POWER_AC_STATE.member? state.to_sym
-                  raise "The state should be member of #{POWER_AC_STATE}. Not #{state}."
+                  raise ::Appium::Core::Error::ArgumentError, "The state should be member of #{POWER_AC_STATE}. Not #{state}."
                 end
 
                 execute(:set_power_ac, {}, { state: state })

data/lib/appium_lib_core/android/device/screen.rb

@@ -41,7 +41,9 @@ module Appium
                 option[:bitRate] = bit_rate unless bit_rate.nil?
 
                 unless bug_report.nil?
-                  raise 'bug_report should be true or false' unless [true, false].member?(bug_report)
+                  unless [true, false].member?(bug_report)
+                    raise ::Appium::Core::Error::ArgumentError, 'bug_report should be true or false'
+                  end
 
                   option[:bugReport] = bug_report
                 end

data/lib/appium_lib_core/android/device.rb

@@ -417,15 +417,15 @@ module Appium
               def start_activity(opts)
                 ::Appium::Logger.warn "[DEPRECATION] Please use 'mobile: startActivity' extension instead"
 
-                raise 'opts must be a hash' unless opts.is_a? Hash
+                raise ::Appium::Core::Error::ArgumentError, 'opts must be a hash' unless opts.is_a? Hash
 
                 option = {}
 
                 app_package = opts[:app_package]
-                raise 'app_package is required' unless app_package
+                raise ::Appium::Core::Error::ArgumentError, 'app_package is required' unless app_package
 
                 app_activity = opts[:app_activity]
-                raise 'app_activity is required' unless app_activity
+                raise ::Appium::Core::Error::ArgumentError, 'app_activity is required' unless app_activity
 
                 option[:appPackage] = app_package
                 option[:appActivity] = app_activity

data/lib/appium_lib_core/common/base/capabilities.rb

@@ -34,7 +34,7 @@ module Appium
             # here do not convert to camel case
             key.to_s
           else
-            raise TypeError, "expected String or Symbol, got #{key.inspect}:#{key.class}"
+            raise ::Appium::Core::Error::ArgumentError, "expected String or Symbol, got #{key.inspect}:#{key.class}"
           end
         end
       end

data/lib/appium_lib_core/common/base/screenshot.rb

@@ -48,7 +48,7 @@ module Appium
           when :png
             bridge.screenshot.unpack('m')[0]
           else
-            raise Core::Error::UnsupportedOperationError, "unsupported format: #{format.inspect}"
+            raise ::Appium::Core::Error::UnsupportedOperationError, "unsupported format: #{format.inspect}"
           end
         end
 
@@ -88,7 +88,7 @@ module Appium
           when :png
             bridge.element_screenshot(element.id).unpack('m')[0]
           else
-            raise Core::Error::UnsupportedOperationError, "unsupported format: #{format.inspect}"
+            raise ::Appium::Core::Error::UnsupportedOperationError, "unsupported format: #{format.inspect}"
           end
         end
 

data/lib/appium_lib_core/common/device/image_comparison.rb

@@ -65,14 +65,17 @@ module Appium
                                     good_matches_factor: nil,
                                     visualize: false)
             unless MATCH_FEATURES[:detector_name].member?(detector_name.to_s)
-              raise "detector_name should be #{MATCH_FEATURES[:detector_name]}"
+              raise ::Appium::Core::Error::ArgumentError, "detector_name should be #{MATCH_FEATURES[:detector_name]}"
             end
 
             unless MATCH_FEATURES[:match_func].member?(match_func.to_s)
-              raise "match_func should be #{MATCH_FEATURES[:match_func]}"
+              raise ::Appium::Core::Error::ArgumentError, "match_func should be #{MATCH_FEATURES[:match_func]}"
             end
 
-            raise "visualize should be #{MATCH_FEATURES[:visualize]}" unless MATCH_FEATURES[:visualize].member?(visualize)
+            unless MATCH_FEATURES[:visualize].member?(visualize)
+              raise ::Appium::Core::Error::ArgumentError,
+                    "visualize should be #{MATCH_FEATURES[:visualize]}"
+            end
 
             options = {}
             options[:detectorName] = detector_name.to_s.upcase
@@ -109,7 +112,10 @@ module Appium
           #
           def find_image_occurrence(full_image:, partial_image:, visualize: false, threshold: nil,
                                     multiple: nil, match_neighbour_threshold: nil)
-            raise "visualize should be #{MATCH_TEMPLATE[:visualize]}" unless MATCH_TEMPLATE[:visualize].member?(visualize)
+            unless MATCH_TEMPLATE[:visualize].member?(visualize)
+              raise ::Appium::Core::Error::ArgumentError,
+                    "visualize should be #{MATCH_TEMPLATE[:visualize]}"
+            end
 
             options = {}
             options[:visualize] = visualize
@@ -136,7 +142,10 @@ module Appium
           #     File.write 'images_similarity_visual.png', Base64.decode64(visual['visualization']) # if the image is PNG
           #
           def get_images_similarity(first_image:, second_image:, visualize: false)
-            raise "visualize should be #{GET_SIMILARITY[:visualize]}" unless GET_SIMILARITY[:visualize].member?(visualize)
+            unless GET_SIMILARITY[:visualize].member?(visualize)
+              raise ::Appium::Core::Error::ArgumentError,
+                    "visualize should be #{GET_SIMILARITY[:visualize]}"
+            end
 
             options = {}
             options[:visualize] = visualize
@@ -158,7 +167,7 @@ module Appium
           #                 See the documentation on +appium-support+ module for more details.
           #
           def compare_images(mode: :matchFeatures, first_image:, second_image:, options: nil)
-            raise "content_type should be #{MODE}" unless MODE.member?(mode)
+            raise ::Appium::Core::Error::ArgumentError, "content_type should be #{MODE}" unless MODE.member?(mode)
 
             params = {}
             params[:mode] = mode

data/lib/appium_lib_core/common/device/screen_record.rb

@@ -30,7 +30,10 @@ module Appium
             @upload_option = if remote_path.nil?
                                {}
                              else
-                               raise 'method should be POST or PUT' unless METHOD.member?(method.to_s.upcase)
+                               unless METHOD.member?(method.to_s.upcase)
+                                 raise ::Appium::Core::Error::ArgumentError,
+                                       'method should be POST or PUT'
+                               end
 
                                option = {}
                                option[:remotePath] = remote_path
@@ -45,7 +48,10 @@ module Appium
 
             return if force_restart.nil?
 
-            raise 'force_restart should be true or false' unless [true, false].member?(force_restart)
+            unless [true, false].member?(force_restart)
+              raise ::Appium::Core::Error::ArgumentError,
+                    'force_restart should be true or false'
+            end
 
             @upload_option[:forceRestart] = force_restart
           end

data/lib/appium_lib_core/common/error.rb

@@ -27,6 +27,7 @@ module Appium
       class ServerError < CoreError; end
 
       # ruby_lib_core library specific errors
+      class SessionNotCreatedError < CoreError; end
       class ArgumentError < CoreError; end
     end
   end

data/lib/appium_lib_core/driver.rb

@@ -394,7 +394,9 @@ module Appium
 
       def start_driver(server_url: nil,
                        http_client_ops: { http_client: nil, open_timeout: 999_999, read_timeout: 999_999 })
-        @custom_url = server_url || "http://127.0.0.1:#{@port}/wd/hub"
+
+        @custom_url ||= "http://127.0.0.1:#{@port}/wd/hub"
+        @custom_url = server_url unless server_url.nil?
 
         @http_client = get_http_client http_client: http_client_ops.delete(:http_client),
                                        open_timeout: http_client_ops.delete(:open_timeout),
@@ -473,7 +475,8 @@ module Appium
                                                      automation_name: automation_name,
                                                      platform_name: platform_name)
         rescue Errno::ECONNREFUSED
-          raise "ERROR: Unable to connect to Appium. Is the server running on #{@custom_url}?"
+          raise ::Appium::Core::Error::SessionNotCreatedError,
+                "ERROR: Unable to connect to Appium. Is the server running on #{@custom_url}?"
         end
 
         @driver

data/lib/appium_lib_core/element.rb

@@ -117,7 +117,7 @@ module Appium
         when :png
           bridge.element_screenshot(@id).unpack('m')[0]
         else
-          raise Core::Error::UnsupportedOperationError, "unsupported format: #{format.inspect}"
+          raise ::Appium::Core::Error::UnsupportedOperationError, "unsupported format: #{format.inspect}"
         end
       end
 

data/lib/appium_lib_core/ios/device/clipboard.rb

@@ -23,7 +23,8 @@ module Appium
             ::Appium::Core::Device.add_endpoint_method(:get_clipboard) do
               def get_clipboard(content_type: :plaintext)
                 unless ::Appium::Core::Base::Device::Clipboard::CONTENT_TYPE.member?(content_type)
-                  raise "content_type should be #{::Appium::Core::Base::Device::Clipboard::CONTENT_TYPE}"
+                  raise ::Appium::Core::Error::ArgumentError,
+                        "content_type should be #{::Appium::Core::Base::Device::Clipboard::CONTENT_TYPE}"
                 end
 
                 params = { contentType: content_type }
@@ -36,7 +37,8 @@ module Appium
             ::Appium::Core::Device.add_endpoint_method(:set_clipboard) do
               def set_clipboard(content:, content_type: :plaintext)
                 unless ::Appium::Core::Base::Device::Clipboard::CONTENT_TYPE.member?(content_type)
-                  raise "content_type should be #{::Appium::Core::Base::Device::Clipboard::CONTENT_TYPE}"
+                  raise ::Appium::Core::Error::ArgumentError,
+                        "content_type should be #{::Appium::Core::Base::Device::Clipboard::CONTENT_TYPE}"
                 end
 
                 params = {

data/lib/appium_lib_core/version.rb

@@ -14,7 +14,7 @@
 
 module Appium
   module Core
-    VERSION = '9.1.2' unless defined? ::Appium::Core::VERSION
-    DATE    = '2024-06-03' unless defined? ::Appium::Core::DATE
+    VERSION = '9.2.0' unless defined? ::Appium::Core::VERSION
+    DATE    = '2024-07-21' unless defined? ::Appium::Core::DATE
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: appium_lib_core
 version: !ruby/object:Gem::Version
-  version: 9.1.2
+  version: 9.2.0
 platform: ruby
 authors:
 - Kazuaki MATSUO
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-06-04 00:00:00.000000000 Z
+date: 2024-07-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faye-websocket
@@ -114,14 +114,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.64.1
+        version: 1.65.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.64.1
+        version: 1.65.0
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement