appium_lib_core 2.0.5 → 2.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 364a81fd6f049768204fc9dc30f2f51265176de7
-  data.tar.gz: 75dc09e05f7772dc5d7ee4423179a0d41d2721e4
+  metadata.gz: 50de09b5e32508e0e2841b1905fb3cc0bb4cb8b4
+  data.tar.gz: 44d09537b742efbe6639c82c813eae1e8645d21d
 SHA512:
-  metadata.gz: 260ec3ebbf46eb42899faffe340c118f7c088c9c904f3d2e392398a7bd7dd7cf11331c4c76b6dad8d877fd58f42f2aae1a20af08dae643463770f444ab02743d
-  data.tar.gz: 13864b02d704a12247ba774e2bee8ca827ebc5a22bed183657910f45437fd68bacbde2f6c6754870eb9b3b6555dc1db463a84750eb950b786319b0171170bc8e
+  metadata.gz: cbcffe7d2fdf5812d106329813c73cf5a0fc125c3b0a5ee6974cebc871bae072091a7dcd6eb0e9312ee6cee86428686028ee402b965c2d1aad347feb3bd630fd
+  data.tar.gz: 0f733629ea7fb84cf3bf335f689dcd2a0d5f235567fdd6204b31dbae94baa9ff57273d2eebe2389f097de43c8f7690e1a6de2256090e32c91a8b7054a7e7eb6a

data/.rubocop.yml

@@ -16,6 +16,8 @@ Metrics/PerceivedComplexity:
   Max: 10
 Metrics/ParameterLists:
   Max: 6
+Lint/NestedMethodDefinition:
+  Enabled: false
 Style/Documentation:
   Enabled: false
 Style/CommentedKeyword:
@@ -24,9 +26,9 @@ Style/PercentLiteralDelimiters:
   Enabled: false
 Style/BracesAroundHashParameters:
   Enabled: false
-Lint/NestedMethodDefinition:
+Style/SymbolArray:
   Enabled: false
 Naming/AccessorMethodName:
   Enabled: false
-Style/SymbolArray:
+Naming/MemoizedInstanceVariableName:
   Enabled: false

data/CHANGELOG.md

@@ -9,6 +9,15 @@ Read `release_notes.md` for commit level details.
 
 ### Deprecations
 
+## [2.0.6] - 2018-11-08
+### Enhancements
+- Allow selenium update following Pi versioning like 3.141.0
+- [internal] Update dev libraries
+
+### Bug fixes
+
+### Deprecations
+
 ## [2.0.5] - 2018-10-30
 ### Enhancements
 - [internal] No longer send `strategy: :tapOutside` as default value in Android

data/README.md

@@ -34,7 +34,8 @@ $ appium --relaxed-security # To run all tests in local
 - Conduct tests
  ```bash
 $ bundle install
-$ rake test:func:android # Andorid 
+$ rake test:func:android # Andorid, uiautomator2
+$ AUTOMATION_NAME=espresso rake test:func:android # Andorid, uiautomator2
 $ rake test:func:ios     # iOS
 ```
 
@@ -87,7 +88,7 @@ opts = {
 - Run the script
 ```bash
 # shell 1
-$ appium
+$ appium --log-level warn:error # show only warning and error logs
 
 # shell 2
 $ ruby test.rb

data/Rakefile

@@ -57,8 +57,18 @@ namespace :test do
 end
 
 namespace :android do
+  desc('uninstall all of test apks from a test device')
+  task :uninstall_test_apks do |_t, _args|
+    `adb uninstall io.appium.uiautomator2.server.test`
+    `adb uninstall io.appium.uiautomator2.server`
+    `adb uninstall io.appium.settings`
+    `adb uninstall io.appium.android.ime`
+    `adb uninstall io.appium.espressoserver.test`
+  end
+
+
   desc('Generate and launch android emulators')
-  task :gen_device  do |_t, _args|
+  task :gen_device do |_t, _args|
     SWARMER_VERSION = '0.2.4'
     CPU_ARCHITECTURE = 'x86'
     IMAGE = 'google_apis'
@@ -95,10 +105,11 @@ RuboCop::RakeTask.new(:rubocop) do |t|
   t.fail_on_error = true
 end
 
-desc("print commands which haven't implemented yet.")
+desc("print commands which Ruby client has not implemented them yet.")
 namespace :commands do
   require './script/commands'
 
+  desc('Mobile JSON protocol')
   task :mjsonwp do |_t, _args|
     c = Script::CommandsChecker.new
     c.get_mjsonwp_routes
@@ -106,6 +117,7 @@ namespace :commands do
     c.all_diff_commands_mjsonwp.each { |key, value| puts("command: #{key}, method: #{value}") }
   end
 
+  desc('W3C protocol')
   task :w3c do |_t, _args|
     c = Script::CommandsChecker.new
     c.get_mjsonwp_routes

data/appium_lib_core.gemspec

@@ -22,7 +22,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency 'selenium-webdriver', '~> 3.14.1'
+  spec.add_runtime_dependency 'selenium-webdriver', '~> 3.14', '>= 3.14.1'
   spec.add_runtime_dependency 'faye-websocket', '~> 0.10.0'
 
   spec.add_development_dependency 'bundler', '~> 1.14'
@@ -30,9 +30,9 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'yard', '~> 0.9.11'
   spec.add_development_dependency 'minitest', '~> 5.0'
   spec.add_development_dependency 'minitest-reporters', '~> 1.1'
-  spec.add_development_dependency 'webmock', '~> 3.1.0'
-  spec.add_development_dependency 'rubocop', '0.51.0'
-  spec.add_development_dependency 'appium_thor', '~> 0.0', '>= 0.0.7'
+  spec.add_development_dependency 'webmock', '~> 3.4.0'
+  spec.add_development_dependency 'rubocop', '0.60.0'
+  spec.add_development_dependency 'appium_thor', '~> 1.0'
   spec.add_development_dependency 'pry'
   spec.add_development_dependency 'pry-byebug'
   spec.add_development_dependency 'parallel_tests'

data/lib/appium_lib_core.rb

@@ -20,11 +20,11 @@ module Appium
 
     hash.each_with_object({}) do |pair, acc|
       key = begin
-        pair[0].to_sym
-      rescue StandardError => e
-        ::Appium::Logger.warn(e.message)
-        pair[0]
-      end
+              pair[0].to_sym
+            rescue StandardError => e
+              ::Appium::Logger.warn(e.message)
+              pair[0]
+            end
 
       value = pair[1]
       acc[key] = value.is_a?(Hash) ? symbolize_keys(value) : value

data/lib/appium_lib_core/android/device.rb

@@ -294,10 +294,13 @@ module Appium
             ::Appium::Core::Device.add_endpoint_method(:start_activity) do
               def start_activity(opts)
                 raise 'opts must be a hash' unless opts.is_a? Hash
+
                 app_package = opts[:app_package]
                 raise 'app_package is required' unless app_package
+
                 app_activity = opts[:app_activity]
                 raise 'app_activity is required' unless app_activity
+
                 app_wait_package  = opts.fetch(:app_wait_package, '')
                 app_wait_activity = opts.fetch(:app_wait_activity, '')
 

data/lib/appium_lib_core/android/device/emulator.rb

@@ -135,9 +135,7 @@ module Appium
 
             ::Appium::Core::Device.add_endpoint_method(:set_network_speed) do
               def set_network_speed(netspeed)
-                unless NET_SPEED.member? netspeed.to_sym
-                  raise "The netspeed should be member of #{NET_SPEED}. Not #{netspeed}."
-                end
+                raise "The netspeed should be member of #{NET_SPEED}. Not #{netspeed}." unless NET_SPEED.member? netspeed.to_sym
 
                 execute(:set_network_speed, {}, { netspeed: netspeed })
               end
@@ -145,9 +143,7 @@ module Appium
 
             ::Appium::Core::Device.add_endpoint_method(:set_power_capacity) do
               def set_power_capacity(percent)
-                unless (0..100).member? percent
-                  raise "The  percent should be between 0 and 100. Not #{percent}."
-                end
+                raise "The  percent should be between 0 and 100. Not #{percent}." unless (0..100).member? percent
 
                 execute(:set_power_capacity, {}, { percent: percent })
               end

data/lib/appium_lib_core/android/device/screen.rb

@@ -24,6 +24,7 @@ module Appium
 
                 unless bug_report.nil?
                   raise 'bug_report should be true or false' unless [true, false].member?(bug_report)
+
                   option[:bugReport] = bug_report
                 end
 

data/lib/appium_lib_core/common/base/bridge.rb

@@ -25,6 +25,7 @@ module Appium
             unless ::Selenium::WebDriver::Remote::Capabilities.respond_to?(desired_capabilities)
               raise ::Selenium::WebDriver::Error::WebDriverError, "invalid desired capability: #{desired_capabilities.inspect}"
             end
+
             desired_capabilities = ::Selenium::WebDriver::Remote::Capabilities.__send__(desired_capabilities)
           end
 
@@ -105,9 +106,7 @@ module Appium
             end
           end
 
-          unless @session_id
-            raise ::Selenium::WebDriver::Error::WebDriverError, 'no sessionId in returned payload'
-          end
+          raise ::Selenium::WebDriver::Error::WebDriverError, 'no sessionId in returned payload' unless @session_id
 
           json_create(oss_status, value)
         end

data/lib/appium_lib_core/common/base/driver.rb

@@ -281,6 +281,9 @@ module Appium
         #
         #   @driver.push_file "/file/to/path", "data"
         #
+        #   file = File.read "your/path/to/test_image.png"
+        #   @driver.push_file "/sdcard/Pictures", file # Push a file binary to /sdcard/Pictures path in Android
+        #
         def push_file(path, filedata)
           @bridge.push_file(path, filedata)
         end

data/lib/appium_lib_core/common/base/search_context.rb

@@ -4,6 +4,7 @@ module Appium
       module SearchContext
         # referenced: ::Selenium::WebDriver::SearchContext
 
+        # rubocop:disable Layout/AlignHash
         FINDERS = ::Selenium::WebDriver::SearchContext::FINDERS.merge(
           accessibility_id:     'accessibility id',
           image:                '-image',
@@ -20,6 +21,7 @@ module Appium
           # Tizen
           tizen_uiautomation:   '-tizen uiautomation'
         )
+        # rubocop:enable Layout/AlignHash
 
         #
         # Find the first element matching the given arguments
@@ -119,6 +121,7 @@ module Appium
         def _set_by_from_finders(how)
           by = FINDERS[how.to_sym]
           raise ArgumentError, "cannot find element by #{how.inspect}. Available finders are #{FINDERS.keys}." unless by
+
           by
         end
 
@@ -129,15 +132,12 @@ module Appium
           when 1
             arg = args.first
 
-            unless arg.respond_to?(:shift)
-              raise ArgumentError, "expected #{arg.inspect}:#{arg.class} to respond to #shift"
-            end
+            raise ArgumentError, "expected #{arg.inspect}:#{arg.class} to respond to #shift" unless arg.respond_to?(:shift)
 
             # this will be a single-entry hash, so use #shift over #first or #[]
             arr = arg.dup.shift
-            unless arr.size == 2
-              raise ArgumentError, "expected #{arr.inspect} to have 2 elements"
-            end
+
+            raise ArgumentError, "expected #{arr.inspect} to have 2 elements" unless arr.size == 2
 
             arr
           else

data/lib/appium_lib_core/common/command/common.rb

@@ -1,3 +1,4 @@
+# rubocop:disable Layout/AlignHash
 module Appium
   module Core
     # ref: https://github.com/appium/appium-base-driver/blob/master/lib/mjsonwp/routes.js
@@ -87,3 +88,4 @@ module Appium
     end # module Commands
   end # module Core
 end # module Appium
+# rubocop:enable Layout/AlignHash

data/lib/appium_lib_core/common/command/mjsonwp.rb

@@ -1,3 +1,4 @@
+# rubocop:disable Layout/AlignHash
 module Appium
   module Core
     module Commands
@@ -12,3 +13,4 @@ module Appium
     end # module Commands
   end # module Core
 end # Appium
+# rubocop:enable Layout/AlignHash

data/lib/appium_lib_core/common/command/w3c.rb

@@ -1,3 +1,4 @@
+# rubocop:disable Layout/AlignHash
 module Appium
   module Core
     module Commands
@@ -40,3 +41,4 @@ module Appium
     end # module Commands
   end # module Core
 end # module Appium
+# rubocop:enable Layout/AlignHash

data/lib/appium_lib_core/common/device/image_comparison.rb

@@ -111,12 +111,12 @@ module Appium
             unless MATCH_FEATURES[:detector_name].member?(detector_name.to_s)
               raise "detector_name should be #{MATCH_FEATURES[:detector_name]}"
             end
+
             unless MATCH_FEATURES[:match_func].member?(match_func.to_s)
               raise "match_func should be #{MATCH_FEATURES[:match_func]}"
             end
-            unless MATCH_FEATURES[:visualize].member?(visualize)
-              raise "visualize should be #{MATCH_FEATURES[:visualize]}"
-            end
+
+            raise "visualize should be #{MATCH_FEATURES[:visualize]}" unless MATCH_FEATURES[:visualize].member?(visualize)
 
             options = {}
             options[:detectorName] = detector_name.to_s.upcase
@@ -128,9 +128,7 @@ module Appium
           end
 
           def find_image_occurrence(full_image:, partial_image:, visualize: false, threshold: nil)
-            unless MATCH_TEMPLATE[:visualize].member?(visualize)
-              raise "visualize should be #{MATCH_TEMPLATE[:visualize]}"
-            end
+            raise "visualize should be #{MATCH_TEMPLATE[:visualize]}" unless MATCH_TEMPLATE[:visualize].member?(visualize)
 
             options = {}
             options[:visualize] = visualize
@@ -140,9 +138,7 @@ module Appium
           end
 
           def get_images_similarity(first_image:, second_image:, visualize: false)
-            unless GET_SIMILARITY[:visualize].member?(visualize)
-              raise "visualize should be #{GET_SIMILARITY[:visualize]}"
-            end
+            raise "visualize should be #{GET_SIMILARITY[:visualize]}" unless GET_SIMILARITY[:visualize].member?(visualize)
 
             options = {}
             options[:visualize] = visualize

data/lib/appium_lib_core/common/device/screen_record.rb

@@ -28,6 +28,7 @@ module Appium
             return if force_restart.nil?
 
             raise 'force_restart should be true or false' unless [true, false].member?(force_restart)
+
             @upload_option[:forceRestart] = force_restart
           end
 

data/lib/appium_lib_core/device.rb

@@ -45,6 +45,7 @@ module Appium
         # @private CoreBridge
         def extend_webdriver_with_forwardable
           return if ::Appium::Core::Base::Driver.is_a? Forwardable
+
           ::Appium::Core::Base::Driver.class_eval do
             extend Forwardable
           end
@@ -58,6 +59,7 @@ module Appium
 
         def delegate_driver_method(method)
           return if ::Appium::Core::Base::Driver.method_defined? method
+
           ::Appium::Core::Base::Driver.class_eval { def_delegator :@bridge, method }
         end
 

data/lib/appium_lib_core/driver.rb

@@ -132,12 +132,16 @@ module Appium
         new(opts)
       end
 
+      private
+
       # @private
       # For testing purpose of delegate_from_appium_driver
-      private def delegated_target_for_test
+      def delegated_target_for_test
         @delegate_target
       end
 
+      public
+
       # @private
       def initialize(opts = {})
         @delegate_target = self # for testing purpose
@@ -227,7 +231,7 @@ module Appium
       private
 
       def create_http_client(http_client: nil, open_timeout: nil, read_timeout: nil)
-        @http_client ||= http_client ? http_client : Appium::Core::Base::Http::Default.new
+        @http_client ||= http_client || Appium::Core::Base::Http::Default.new
 
         # open_timeout and read_timeout are explicit wait.
         @http_client.open_timeout = open_timeout if open_timeout
@@ -257,7 +261,7 @@ module Appium
       #
       def quit_driver
         @driver.quit
-      rescue # rubocop:disable Lint/RescueWithoutErrorClass
+      rescue # rubocop:disable Style/RescueStandardError
         nil
       end
 
@@ -284,6 +288,7 @@ module Appium
         @driver.remote_status
       rescue Selenium::WebDriver::Error::ServerError => e
         raise ::Appium::Core::Error::ServerError unless e.message.include?('status code 500')
+
         # driver.remote_status returns 500 error for using selenium grid
         {}
       end
@@ -444,6 +449,7 @@ module Appium
       # @private
       def set_automation_name_if_nil
         return unless @automation_name.nil?
+
         @automation_name = if @driver.capabilities['automationName']
                              @driver.capabilities['automationName'].downcase.strip.intern
                            end

data/lib/appium_lib_core/patch.rb

@@ -68,3 +68,4 @@ module Appium
     end
   end # module Core
 end # module Appium
+# rubocop:enable Style/ClassAndModuleChildren

data/lib/appium_lib_core/version.rb

@@ -1,6 +1,6 @@
 module Appium
   module Core
-    VERSION = '2.0.5'.freeze unless defined? ::Appium::Core::VERSION
-    DATE    = '2018-10-30'.freeze unless defined? ::Appium::Core::DATE
+    VERSION = '2.0.6'.freeze unless defined? ::Appium::Core::VERSION
+    DATE    = '2018-11-08'.freeze unless defined? ::Appium::Core::DATE
   end
 end

data/release_notes.md

@@ -1,3 +1,20 @@
+#### v2.0.6 2018-11-08
+
+- [b7ede91](https://github.com/appium/ruby_lib_core/commit/b7ede919a26b4d83b88955cb7d595a8538f5c146) Release 2.0.6
+- [3f04490](https://github.com/appium/ruby_lib_core/commit/3f04490b6c64f38cbc191ac2e4486eefbe3ea727) add desc in some rake tasks
+- [c4670c2](https://github.com/appium/ruby_lib_core/commit/c4670c2a275042d6297067f810de01d00be2333f) Allow update pi versioning (#159)
+- [2dd19fa](https://github.com/appium/ruby_lib_core/commit/2dd19fa70b2fbf4684776ebcd438f133d426a91a) Update mobile_command.md
+- [f8af2e3](https://github.com/appium/ruby_lib_core/commit/f8af2e3e8dbff2e6616c554db6394b42c588ddeb) append a test of push file
+- [442e787](https://github.com/appium/ruby_lib_core/commit/442e787851dfd47a7a0b4caed7f4712444c6ebac) tweak readme
+- [7183715](https://github.com/appium/ruby_lib_core/commit/718371524cbc977b2bf8b0b242f95ba92ca5037a) bump and fix rubocop (#158)
+- [6b9f74d](https://github.com/appium/ruby_lib_core/commit/6b9f74d0b66ebf4a512dee77fa4657230ee27990) remove one todo
+- [3a42bc3](https://github.com/appium/ruby_lib_core/commit/3a42bc301f76466266efa31b7919f6418fc9680b) fix rubocop
+- [92712d4](https://github.com/appium/ruby_lib_core/commit/92712d4dcca1da3902e5aeea8e7eb78c3a116f17) add chrome option into helper
+- [2bfc6b5](https://github.com/appium/ruby_lib_core/commit/2bfc6b53034ab5076fdea3dd67fb01445ab8d7ed) add MjpegServerTest
+- [a84aa18](https://github.com/appium/ruby_lib_core/commit/a84aa18291d003655584262872004c3c835fa70d) add adbExecTimeout as an example for test
+- [6400a8d](https://github.com/appium/ruby_lib_core/commit/6400a8def717cc1deb8933e23c4bfa253cc3e1e6) increase w3c functional tests for android (#157)
+
+
 #### v2.0.5 2018-10-30
 
 - [3197865](https://github.com/appium/ruby_lib_core/commit/31978651941fb169b2d63bb35aeb6005622ca9bc) Release 2.0.5

data/script/commands.rb

@@ -40,7 +40,7 @@ module Script
     end
 
     # @private
-    HTTP_METHOD_MATCH = /GET:|POST:|DELETE:|PUT:|PATCH:/
+    HTTP_METHOD_MATCH = /GET:|POST:|DELETE:|PUT:|PATCH:/.freeze
     # @private
     WD_HUB_PREFIX_MATCH = "'/wd/hub/".freeze
 

metadata

@@ -1,20 +1,23 @@
 --- !ruby/object:Gem::Specification
 name: appium_lib_core
 version: !ruby/object:Gem::Version
-  version: 2.0.5
+  version: 2.0.6
 platform: ruby
 authors:
 - Kazuaki MATSUO
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-10-30 00:00:00.000000000 Z
+date: 2018-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: selenium-webdriver
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.14'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.14.1
   type: :runtime
@@ -22,6 +25,9 @@ dependencies:
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.14'
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.14.1
 - !ruby/object:Gem::Dependency
@@ -114,48 +120,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: 3.4.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.1.0
+        version: 3.4.0
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.51.0
+        version: 0.60.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.51.0
+        version: 0.60.0
 - !ruby/object:Gem::Dependency
   name: appium_thor
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.0'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.0.7
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.0'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 0.0.7
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement