appium_lib_core 12.1.0 → 12.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cb6226306206eafec9dbd6f2c2f1ac09c86fee48ee841be8616df8acf6ce56a5
-  data.tar.gz: ab63b82ecafb824a8b0edfdcbcba8d9ec0e1530e8a42f86c4c95aa95246a6871
+  metadata.gz: b8b24034cf3c55ee8315eea3f56344e02705caed8f7cfd0d2a859ff3e8195a79
+  data.tar.gz: a3c665e85f24c552cd8b80a52934d81fad4764794cea23d2af38632641d1a890
 SHA512:
-  metadata.gz: 2573d787ffb963708aae21889b3f3ab6f68b7747b623a7ba906fff4065f7514557608dfaa6b9b05b8ceddaf4a6f0ae96edb20a436af01e3148c5c13ed64bf598
-  data.tar.gz: 21c2e01a1bdfb8bfd81ad309eb8e6fbdfa6d5abba485c77b52c257652be9c8b58a4f62a110a78128f2f26438e0d018cebfe6f1cffd8f60e1aa91293c2d14e269
+  metadata.gz: a06868c2fe0fd5c243aa18338029510dedf336f8911073289324334b4b3cfdbc6f2b247ce4ca42da2ec0f301223dfbdf2f89bfed5bbbcc452bc4bd7ae82e14ea
+  data.tar.gz: 472c0d31754e6e48a673bc0d363fd54ccf4d6f5be1f9b1880a0ef60cdf1d4f6a91214ee66cc59bff20a1020433ef7c4b4cd8b9ae38d084c1225193feed79b877

data/CHANGELOG.md

@@ -2,6 +2,9 @@
 All notable changes to this project will be documented in this file.
 Read `release_notes.md` for commit level details.
 
+## [12.2.0] - 2026-06-25
+- Add validation for direct connect URL when `direct_connect` capability is `true`.
+
 ## [12.1.0] - 2026-03-21
 - Replace internal `add_command` method with Selnium Bridge's `add_command` to simplify the codebase.
 

data/Gemfile

@@ -8,7 +8,7 @@ gem 'minitest', '~> 5.0'
 gem 'minitest-reporters', '~> 1.1'
 gem 'parallel_tests'
 gem 'rake', '~> 13.0'
-gem 'rubocop', '1.85.1'
+gem 'rubocop', '1.86.1'
 gem 'simplecov'
 gem 'steep', '~> 1.10.0'
 gem 'webmock', '~> 3.26.0'

data/lib/appium_lib_core/driver.rb

@@ -13,6 +13,9 @@
 # limitations under the License.
 
 require 'uri'
+require 'socket'
+require 'ipaddr'
+require 'timeout'
 
 module Appium
   # The struct for 'location'
@@ -99,6 +102,59 @@ module Appium
         @port = capabilities[W3C_KEYS[:port]] || capabilities[KEYS[:port]]
         @path = capabilities[W3C_KEYS[:path]] || capabilities[KEYS[:path]]
       end
+
+      def valid?
+        return false unless [@protocol, @host, @port, @path].none?(&:nil?)
+
+        addresses = resolve_addresses(@host)
+        return false if addresses.empty?
+
+        addresses.find { |ip| disallowed? ip }.nil?
+      end
+
+      private
+
+      # Do not allow loopback, link-local, unspecified and multicast addresses for
+      # direct connect since they are not accessible from outside of the server.
+      DNS_RESOLVE_TIMEOUT_SECONDS = 30
+      LOOPBACK_RANGES = [IPAddr.new('127.0.0.0/8'), IPAddr.new('::1/128')].freeze
+      LINK_LOCAL_RANGES = [IPAddr.new('169.254.0.0/16'), IPAddr.new('fe80::/10')].freeze
+      UNSPECIFIED_RANGES = [IPAddr.new('0.0.0.0/32'), IPAddr.new('::/128')].freeze
+      MULTICAST_RANGES = [IPAddr.new('224.0.0.0/4'), IPAddr.new('ff00::/8')].freeze
+      DISALLOWED_RANGES = [
+        *LOOPBACK_RANGES,
+        *LINK_LOCAL_RANGES,
+        *UNSPECIFIED_RANGES,
+        *MULTICAST_RANGES
+      ].freeze
+
+      def resolve_addresses(host)
+        normalized_host = host.to_s.delete_prefix('[').delete_suffix(']')
+        # If the host is already an IP literal, skip DNS resolution to avoid blocking calls
+        return [normalized_host] if ip_literal?(normalized_host)
+
+        Timeout.timeout(DNS_RESOLVE_TIMEOUT_SECONDS) do
+          Socket.getaddrinfo(normalized_host, nil).map { |entry| entry[3] }.uniq
+        end
+      rescue Timeout::Error
+        ::Appium::Logger.warn("DNS resolution for '#{host}' timed out after #{DNS_RESOLVE_TIMEOUT_SECONDS}s")
+        []
+      rescue SocketError => e
+        ::Appium::Logger.warn("Failed to resolve host '#{host}' for direct connect: #{e.message}")
+        []
+      end
+
+      def ip_literal?(host)
+        IPAddr.new(host)
+        true
+      rescue IPAddr::InvalidAddressError
+        false
+      end
+
+      def disallowed?(ip)
+        address = IPAddr.new ip
+        DISALLOWED_RANGES.any? { |range| range.include? address }
+      end
     end
 
     class Driver
@@ -164,8 +220,7 @@ module Appium
       # @return [Appium::Core::Base::Driver]
       attr_reader :driver
 
-      # <b>[Experimental feature]</b><br>
-      # Enable an experimental feature updating Http client endpoint following below keys by Appium/Selenium server.<br>
+      # Enable updating Http client endpoint following below keys by Appium/Selenium server.<br>
       # This works with {Appium::Core::Base::Http::Default}.
       #
       # If your Selenium/Appium server decorates the new session capabilities response with the following keys:<br>
@@ -177,6 +232,12 @@ module Appium
       # ignore them if this parameter is <code>false</code>. Defaults to true.
       # These keys can have <code>appium:</code> prefix.
       #
+      # Note that the server should provide the keys with valid values. The host value must not be
+      # - loopback (for example `127.0.0.1`, `::1`)
+      # - link-local (for example `169.254.x.x`, `fe80::/10`)
+      # - unspecified/wildcard (`0.0.0.0`, `::`)
+      # - multicast (`224.0.0.0/4`, `ff00::/8`)
+      #
       # @return [Bool]
       attr_reader :direct_connect
 
@@ -419,7 +480,14 @@ module Appium
 
           if @direct_connect
             d_c = DirectConnections.new(@driver.capabilities)
-            @driver.update_sending_request_to(protocol: d_c.protocol, host: d_c.host, port: d_c.port, path: d_c.path)
+            if d_c.valid?
+              @driver.update_sending_request_to(protocol: d_c.protocol, host: d_c.host, port: d_c.port, path: d_c.path)
+            else
+              ::Appium::Logger.warn(
+                "Direct connect is enabled but the server did not provide valid direct connect information (#{d_c.protocol}, #{d_c.host}, #{d_c.port}, #{d_c.path}). " \
+                "Continue with the original URL (#{@custom_url})"
+              )
+            end
           end
         rescue Errno::ECONNREFUSED => e
           raise "ERROR: Unable to connect to Appium. Is the server running on #{@custom_url}? Error: #{e}"

data/lib/appium_lib_core/version.rb

@@ -14,7 +14,7 @@
 
 module Appium
   module Core
-    VERSION = '12.1.0' unless defined? ::Appium::Core::VERSION
-    DATE    = '2026-03-21' unless defined? ::Appium::Core::DATE
+    VERSION = '12.2.0' unless defined? ::Appium::Core::VERSION
+    DATE    = '2026-04-19' unless defined? ::Appium::Core::DATE
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: appium_lib_core
 version: !ruby/object:Gem::Version
-  version: 12.1.0
+  version: 12.2.0
 platform: ruby
 authors:
 - Kazuaki MATSUO
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-03-22 00:00:00.000000000 Z
+date: 2026-04-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: selenium-webdriver