appium_lib_core 1.2.4 → 1.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 44fc100d5d5e9bd6eca0c7710db01c24e6f80c2e
-  data.tar.gz: cdba41bed57c4d4f509e39460a273f697f1d19d8
+  metadata.gz: 926da09e2b71204628bf30a3816623e7f31419db
+  data.tar.gz: 176cf553eeca40bcb83b39972ee8b2e67de7d5c8
 SHA512:
-  metadata.gz: 6ffd78624d5ffec1e6835dbf3f17c6664addc16e6d16ff4b1d58befaa96f0b1b6b0b6a5625cc7be98946858a69c2126e7b264668de458da94df48a03b71219fe
-  data.tar.gz: 83e202a1d228ae437a1ae20daecbf94b1a460994e3f6a829374872558a61cdaa1fe0221517945ad331168607f0e71e25aa1ce31863efba945f0037a8dcfb1d24
+  metadata.gz: 50de46fcccbf804027e8cf84a46740be981b4f22679a033f277d16cf167194116df00473b9edea2684aad775cefc6807d57634856b26f760a35625742e3797d9
+  data.tar.gz: 295e932533dda3278df4b75fa99f1823f926187436480b15fbd8a88e9b911966c959227f6bfa85cd1fd2d58ccc80c117ed26d21480c23ed204cdbe22ea3e8bcc

data/CHANGELOG.md

@@ -8,6 +8,15 @@ All notable changes to this project will be documented in this file.
 
 ### Deprecations
 
+## [1.2.5] - 2018-01-13
+### Enhancements
+- Enhance W3C support
+    - Timeout related methods
+
+### Bug fixes
+
+### Deprecations
+
 ## [1.2.4] - 2018-01-03
 ### Enhancements
 - Refactor `create_session` in `Appium::Core::Base::Bridge`

data/lib/appium_lib_core/common/base/bridge.rb

@@ -5,6 +5,8 @@ module Appium
         # Prefix for extra capability defined by W3C
         APPIUM_PREFIX = 'appium:'.freeze
 
+        FORCE_MJSONWP = :forceMjsonwp
+
         # Almost same as self.handshake in ::Selenium::WebDriver::Remote::Bridge
         #
         # Implements protocol handshake which:
@@ -123,7 +125,7 @@ module Appium
             next if value.is_a?(String) && value.empty?
 
             capability_name = name.to_s
-            w3c_name = appium_prefix?(capability_name, w3c_capabilities) ? name : "#{APPIUM_PREFIX}#{capability_name}"
+            w3c_name = extension_prefix?(capability_name, w3c_capabilities) ? name : "#{APPIUM_PREFIX}#{capability_name}"
 
             w3c_capabilities[w3c_name] = value
           end
@@ -133,13 +135,13 @@ module Appium
 
         private
 
-        def appium_prefix?(capability_name, w3c_capabilities)
+        def extension_prefix?(capability_name, w3c_capabilities)
           snake_cased_capability_names = ::Selenium::WebDriver::Remote::W3C::Capabilities::KNOWN.map(&:to_s)
           camel_cased_capability_names = snake_cased_capability_names.map(&w3c_capabilities.method(:camel_case))
 
           snake_cased_capability_names.include?(capability_name) ||
             camel_cased_capability_names.include?(capability_name) ||
-            capability_name.start_with?(APPIUM_PREFIX)
+            capability_name.match(::Selenium::WebDriver::Remote::W3C::Capabilities::EXTENSION_CAPABILITY_PATTERN)
         end
 
         def json_create(oss_status, value)
@@ -161,7 +163,7 @@ module Appium
           capabilities.each do |name, value|
             next if value.nil?
             next if value.is_a?(String) && value.empty?
-            next if name == :forceMjsonwp
+            next if name == FORCE_MJSONWP
 
             w3c_capabilities[name] = value
           end
@@ -170,7 +172,7 @@ module Appium
         end
 
         def merged_capabilities(desired_capabilities)
-          force_mjsonwp = desired_capabilities[:forceMjsonwp]
+          force_mjsonwp = desired_capabilities[FORCE_MJSONWP]
           desired_capabilities = delete_force_mjsonwp(desired_capabilities) unless force_mjsonwp.nil?
 
           if force_mjsonwp

data/lib/appium_lib_core/common/base/bridge/w3c.rb

@@ -34,6 +34,10 @@ module Appium
           end
           alias actions action
 
+          def get_timeouts
+            execute :get_timeouts
+          end
+
           # For Appium
           # override
           def page_source

data/lib/appium_lib_core/common/base/driver.rb

@@ -68,6 +68,18 @@ module Appium
         def logs
           @logs ||= Logs.new(@bridge)
         end
+
+        # For W3C.
+        # Get the timeout related settings on the server side.
+        #
+        # @return [Hash]
+        #
+        # @example
+        #   @driver.get_timeouts
+        #
+        def get_timeouts
+          @bridge.get_timeouts
+        end
       end # class Driver
     end # class Base
   end # module Core

data/lib/appium_lib_core/common/command.rb

@@ -89,6 +89,8 @@ module Appium
           # The fix will be included in selenium-3.8.2
           get_page_source: [:get, 'session/:session_id/source'.freeze],
 
+          get_timeouts: [:get, 'session/:session_id/timeouts'.freeze],
+
           ## Add OSS commands to W3C commands
           ### rotatable
           get_screen_orientation: [:get, 'session/:session_id/orientation'.freeze],

data/lib/appium_lib_core/common/device.rb

@@ -403,11 +403,6 @@ module Appium
             add_endpoint_method method
           end
 
-          # Don't define selenium-side methods. We pick up from them.
-          # ::Appium::Core::Base::Commands::MJSONWP.each_key do |method|
-          #   add_endpoint_method method
-          # end
-
           add_endpoint_method(:available_contexts) do
             def available_contexts
               # return empty array instead of nil on failure

data/lib/appium_lib_core/driver.rb

@@ -254,7 +254,7 @@ module Appium
       #
       # @example
       #
-      #     @core.platform_version #=> [10.1.1]
+      #     @core.platform_version #=> [10,1,1]
       #
       def platform_version
         p_version = @driver.capabilities['platformVersion']

data/lib/appium_lib_core/version.rb

@@ -1,6 +1,6 @@
 module Appium
   module Core
-    VERSION = '1.2.4'.freeze unless defined? ::Appium::Core::VERSION
-    DATE    = '2018-01-03'.freeze unless defined? ::Appium::Core::DATE
+    VERSION = '1.2.5'.freeze unless defined? ::Appium::Core::VERSION
+    DATE    = '2018-01-13'.freeze unless defined? ::Appium::Core::DATE
   end
 end

data/release_notes.md

@@ -1,3 +1,16 @@
+#### v1.2.5 2018-01-13
+
+- [0934b97](https://github.com/appium/ruby_lib_core/commit/0934b977419d6b5359dcc8e5b7c4edcd7f4916f4) Release 1.2.5
+- [9497621](https://github.com/appium/ruby_lib_core/commit/9497621a62cdee727614d9c48ffff0f0f2faa7da) ignore extensional prefix (#49)
+- [6337c78](https://github.com/appium/ruby_lib_core/commit/6337c7887873c12093ef854dde5a960bbe199449) update readme
+- [9cbad5c](https://github.com/appium/ruby_lib_core/commit/9cbad5ca553d513c66508ede5f5f977aeb9f365d) add get timeouts for w3c (#46)
+- [dacdc36](https://github.com/appium/ruby_lib_core/commit/dacdc3601cdc8a43b974db52ae164170945cc7ba) remove skip tests from unit tests (#45)
+- [2d5c7ae](https://github.com/appium/ruby_lib_core/commit/2d5c7aed33a524d754cc28b5ae46cec917f48318) Fix typo in documentation of Driver#platform_version (#44)
+- [d70f244](https://github.com/appium/ruby_lib_core/commit/d70f244ba260fed6c2d522a98d0c5516f3673c47) fix rubocop
+- [c6f6528](https://github.com/appium/ruby_lib_core/commit/c6f652817b9d1ad104002d067bfb0452074653aa) add unit tests for forceMjsonwp
+- [591a9bd](https://github.com/appium/ruby_lib_core/commit/591a9bd35b72287f10e47bdeae0de9dc2646b44a) add unit tests for w3c case (#43)
+
+
 #### v1.2.4 2018-01-03
 
 - [7032bc0](https://github.com/appium/ruby_lib_core/commit/7032bc02acc44640542eb545067a4125a7f1811f) Release 1.2.4

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: appium_lib_core
 version: !ruby/object:Gem::Version
-  version: 1.2.4
+  version: 1.2.5
 platform: ruby
 authors:
 - Kazuaki MATSUO
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-01-02 00:00:00.000000000 Z
+date: 2018-01-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: selenium-webdriver