appium_console 4.3.0 → 4.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d35c8ccbcf449176ebd22cb03bf4debd2c1b3538db04d09ed5a8af308bdb53d8
-  data.tar.gz: 6315d3dca7927d2137760d71f75bd04b9c47d63ceaf2576000620736bad18ffc
+  metadata.gz: fc37fbc880b7dcbed662e916d4674a981c4630240bef1a0ed1339fde7886078c
+  data.tar.gz: '0148595cf014a6419ada0b95ffa58d290d652a54376efd59ce4e75bf9fd0bcb6'
 SHA512:
-  metadata.gz: 1de4c84924901e5303ed218540d22926f98ed9ccd9ad337030f2a89bd462508c89bdeec7d80aa12edf0cf1461de2cfc035cc34cd00058ae900f72e146659be06
-  data.tar.gz: 1df9030b98171cf15667ccf98044c7290c914061a046f6023ef849b74f822947fb535bef611f6d381c737f0b6bc305a768ff8c59854c23ab1a027bf7b31fa6bc
+  metadata.gz: 04dca7e6ebbefb4d049b66d68b29fdf61cf6d5c058ad3339621d675279b18051f0b1d62e47996d41e85eb15964aa91e755c31e95ed9b5b7e4887ca3e53f6a380
+  data.tar.gz: '09b27e4fe7d39af8c59850a7e06ae2332d8e24e10ee2420f723b3f32ba40e5dd12cf0b8ab753678c0e830767226c2a9f900b25738d7f2287c8b18a0961c89e12'

data/CHANGELOG.md

@@ -3,6 +3,13 @@
 Historical commit-level notes through 4.2.0 are in [release_notes.md](release_notes.md).
 New entries are maintained by Release Please.
 
+## [4.3.1](https://github.com/appium/ruby_console/compare/v4.3.0...v4.3.1) (2026-10-28)
+
+
+### Bug Fixes
+
+* guard after_session hook and avoid duplicate newCommandTimeout capability ([#270](https://github.com/appium/ruby_console/issues/270)) ([6b45836](https://github.com/appium/ruby_console/commit/6b45836fd4fd9b2ddc7498744009c6a53f5904be))
+
 ## [4.3.0](https://github.com/appium/ruby_console/compare/v4.2.0...v4.3.0) (2026-09-20)
 
 

data/Gemfile

@@ -3,4 +3,4 @@ gemspec
 
 gem 'minitest', '~> 5.0'
 gem 'rake', '~> 13.0'
-gem 'rubocop', '1.91.0'
+gem 'rubocop', '1.92.1'

data/lib/appium_console/version.rb

@@ -4,7 +4,7 @@
 module Appium; end unless defined? Appium
 module Appium
   module Console
-    VERSION = '4.3.0' unless defined? ::Appium::Console::VERSION
-    DATE = '2026-09-20' unless defined? ::Appium::Console::DATE # x-release-please-date
+    VERSION = '4.3.1' unless defined? ::Appium::Console::VERSION
+    DATE = '2026-10-28' unless defined? ::Appium::Console::DATE # x-release-please-date
   end
 end

data/lib/appium_console.rb

@@ -13,17 +13,17 @@ module Appium
   module Console
     class << self
       def setup(appium_txt_path)
-        Pry.send(:define_singleton_method, :pry_load_appium_txt) do |opts = {}|
+        define_pry_method(:pry_load_appium_txt) do |opts = {}|
           verbose = opts.fetch :verbose, false
           path = appium_txt_path
           Appium.load_appium_txt file: path, verbose: verbose
         end
 
-        Pry.send(:define_singleton_method, :reload) do
+        define_pry_method(:reload) do
           parsed = Pry.pry_load_appium_txt
-          return unless parsed && parsed[:appium_lib] && parsed[:appium_lib][:require]
+          requires = parsed&.dig(:appium_lib, :require)
+          return unless requires
 
-          requires = parsed[:appium_lib][:require]
           requires.each do |file|
             # If a page obj is deleted then load will error.
             load file
@@ -38,10 +38,8 @@ module Appium
         cmd = ['-r', start]
 
         parsed = Pry.pry_load_appium_txt verbose: true
-        has_requires = parsed && parsed[:appium_lib] && parsed[:appium_lib][:require]
-        if has_requires
-          requires = parsed[:appium_lib][:require]
-
+        requires = parsed&.dig(:appium_lib, :require)
+        if requires
           unless requires.empty?
             load_files = requires.map { |f| "require #{f.dump};" }.join "\n"
             cmd += ['-e', load_files]
@@ -50,14 +48,28 @@ module Appium
           $stdout.puts "pry #{cmd.join(' ')}"
         end
 
-        Pry.hooks.add_hook(:after_session, 'Release session hook') do |output, _binding, _pry|
-          output.puts 'Closing appium session...'
-          x
-        end
+        register_release_session_hook
 
         opts = Pry::CLI.parse_options cmd
         Pry::CLI.start(opts)
       end
+
+      private
+
+      def define_pry_method(name, &)
+        Pry.singleton_class.send(:remove_method, name) if Pry.respond_to?(name)
+        Pry.send(:define_singleton_method, name, &)
+      end
+
+      def register_release_session_hook
+        if Pry.hooks.hook_exists?(:after_session, 'Release session hook')
+          Pry.hooks.delete_hook(:after_session, 'Release session hook')
+        end
+        Pry.hooks.add_hook(:after_session, 'Release session hook') do |output, _binding, _pry|
+          output.puts 'Closing appium session...'
+          x if respond_to?(:x, true)
+        end
+      end
     end
   end
 end

data/lib/start.rb

@@ -11,7 +11,9 @@ Pry.respond_to?(:config) ? Pry.config.command_prefix = '%' : ''
 
 opts = Pry.pry_load_appium_txt
 # override command timeout so the server doesn't shut down after 60 seconds
-new_command_timeout = { caps: { newCommandTimeout: 999_999 }.merge(opts[:caps] || {}) }
+caps = opts[:caps] || {}
+has_command_timeout = caps.key?(:newCommandTimeout) || caps.key?(:'appium:newCommandTimeout')
+new_command_timeout = { caps: (has_command_timeout ? {} : { newCommandTimeout: 999_999 }).merge(caps) }
 opts = opts.merge(new_command_timeout)
 core = Appium::Driver.new opts, false
 core.start_driver

data/test/console_test.rb

@@ -43,4 +43,23 @@ class ConsoleTest < Minitest::Test
       end
     end
   end
+
+  def test_after_session_hook_handles_missing_driver_and_repeated_start
+    Appium::Console.setup('appium.txt')
+    Appium.stub(:load_appium_txt, {}) do
+      Pry::CLI.stub(:parse_options, ->(args) { args }) do
+        Pry::CLI.stub(:start, ->(_args) {}) do
+          Appium::Console.start
+          Appium::Console.start
+        end
+      end
+    end
+    output = StringIO.new
+    Pry.hooks.errors.clear
+    Pry.hooks.get_hook(:after_session, 'Release session hook').call(output, binding, Pry.new)
+    assert_empty Pry.hooks.errors
+    assert_includes output.string, 'Closing appium session...'
+  ensure
+    Pry.hooks.delete_hook(:after_session, 'Release session hook')
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: appium_console
 version: !ruby/object:Gem::Version
-  version: 4.3.0
+  version: 4.3.1
 platform: ruby
 authors:
 - code@bootstraponline.com