appfuel 0.2.10 → 0.2.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fb01f2af404a6c49b1f3d16b0da2a5a3b390ddba
-  data.tar.gz: 793a7ea7d2116b085efebf3edd2a85ab650abeed
+  metadata.gz: 684209e19f1a18b1b855531cc3cfa8a3780add38
+  data.tar.gz: fa2a53437d5dc7c08dc8364bb83a4bd6bf2ee5d6
 SHA512:
-  metadata.gz: b9b64371ae4dec6e1d64ba75932e9051216d3fdc4a94fbef43d11788b5f5ffac8490d6f39f3a9086a4d3f2cf23bba3a8153872e7b6c0501afca24b6c8d60e49a
-  data.tar.gz: f2d8f9667d9d51eeb42d091ab752933a6043fee82f1d187d01ea2fa81c55f0b3cdbcf39da79c45b34f885d4d2d0ed42f0b833b534462603fd7d30c423521860a
+  metadata.gz: e16e8282f66922d69856c3c693ab007984a319898248392210de9412c4ace6e2b78d6798ecb2bcfea84f566fadf5dc0eaed10e71a6721e7dc1346f1f44c52a95
+  data.tar.gz: 51369a25b4359e1bd30dd8162a3303e9685a6e953a3e435dd5124d032d33fc6e0311bdbe2ca84239bdd7a368b6b254510166470e9f689977e25ab72f5e1bb6b7

data/CHANGELOG.md

@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file. (Pending ap
 
 
 # Releases
+## [[0.2.11]](https://github.com/rsb/appfuel/releases/tag/0.2.9) 2017-06-15
+### Changed
+- Adding error handling to dispatching. Errors are converted to responses
+
 ## [[0.2.10]](https://github.com/rsb/appfuel/releases/tag/0.2.9) 2017-06-14
 ### Fixed
 - configuration delete was using string for the key, corrected to symbol

data/lib/appfuel/application/dispatcher.rb

@@ -5,25 +5,14 @@ module Appfuel
       def dispatch(request, container)
         begin
           container[:feature_initializer].call(request.feature, container)
-          action = container[:action_loader].call(request.namespace, container)
+          action   = container[:action_loader].call(request.namespace, container)
           response = action.run(request.inputs)
         rescue => e
-          handle_error(e, container)
+          handler = Appfuel::ResponseHandler.new
+          response = handler.error(e)
         end
 
-        if response.failure?
-          handle_error(contaier,  :failed, error)
-        end
-      end
-
-      private
-      def handle_error(e, container)
-        p e.message
-        p e.backtrace
-      end
-
-      def default_error_handling(e, container)
-
+        response
       end
     end
   end

data/lib/appfuel/feature/initializer.rb

@@ -13,13 +13,20 @@ module Appfuel
       # @return [Boolean]
       def call(name, container)
         name = name.to_s.underscore
-        feature_key = "features.#{name}"
+        feature_key  = "features.#{name}"
+        return false if initialized?(container, feature_key)
+
         unless container.key?(feature_key)
           Appfuel.setup_container_dependencies(feature_key, container)
         end
 
         unless require_feature_disabled?(container, feature_key)
-          require "#{container[:features_path]}/#{name}"
+          feature_path = "#{container[:features_path]}/#{name}"
+          begin
+            require feature_path
+          rescue LoadError => _e
+            raise "[#{feature_key} initialize] could not load #{feature_path}"
+          end
         end
 
         container[:auto_register_classes].each do |klass|
@@ -27,7 +34,6 @@ module Appfuel
           container.register(klass.container_class_path, klass)
         end
 
-        return false if initialized?(container, feature_key)
 
         Appfuel.run_initializers(feature_key, container)
         true

data/lib/appfuel/version.rb

@@ -1,3 +1,3 @@
 module Appfuel
-  VERSION = "0.2.10"
+  VERSION = "0.2.11"
 end

data/lib/appfuel.rb

@@ -142,10 +142,15 @@ module Appfuel
       end
 
       exclude.map! {|item| item.to_s}
-      namespace   = "#{key}.initializers"
-      runlist_key = "#{namespace}.run"
-      env         = container['env']
-      config      = container['config']
+      namespace    = "#{key}.initializers"
+      finished_key = "#{key}.initialized"
+      runlist_key  = "#{namespace}.run"
+      env          = container['env']
+      config       = container['config']
+
+      if container.key?(finished_key) && container[finished_key] == true
+        return false
+      end
 
       runlist = []
       if container.key?(runlist_key)
@@ -173,7 +178,7 @@ module Appfuel
           raise error
         end
       end
-      container.register("#{key}.initialized", true)
+      container.register(finished_key, true)
 
       container
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: appfuel
 version: !ruby/object:Gem::Version
-  version: 0.2.10
+  version: 0.2.11
 platform: ruby
 authors:
 - Robert Scott-Buccleuch
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-06-14 00:00:00.000000000 Z
+date: 2017-06-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord