appbundler 0.12.3 → 0.13.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7e28f2e4515160806c46bb209b6c77bafc27a3ee85f3a6c150395533f71769bd
-  data.tar.gz: f1d0721a380ebfa6ff3be21e94d9fa60684e7838a8f10daae7db86e9bf4e905f
+  metadata.gz: b358a8a633dd6341cf56809d02b4c99ca7d78db88813e36ab385d24f861be8e0
+  data.tar.gz: 842dec2877ea932c7da9c5c849abb822f33a9eba10049a11d2089db42d3239ca
 SHA512:
-  metadata.gz: 660b086281a966d5376a6f595afd6a059340815746733a71f85de6fb853bc20ddb22b94a07ff69dc324c094089ef6ed8c30554b75363e49b13a0aadbc35a9469
-  data.tar.gz: c763835a1fbc8a0c5a72f5c0081acb95f6380141f644c4e365fb93160d4c9cf97e6e7cad8a2b0b9e6da0875ae1a7221c424654edb727240a958e30caaf2a3877
+  metadata.gz: a80ca5d2b58325a163f433b70b71ce81f3008513ce72faa6956ab1c32783bfddc377e9fedc9644dcc0392723b264697392d48cb072404d8ff3257fd0ff2c45fd
+  data.tar.gz: 4cf2163f2b0aaefbb5495c08d90da311c39dcb29216fc7ac1eb0f7e0f66595d3145a21f40abb9a968091731c27ca09c0f893e13b5cb787da7b69b7e31dafa547

data/Gemfile

@@ -1,4 +1,28 @@
 source "https://rubygems.org"
 
-# Specify your gem's dependencies in appbundler.gemspec
 gemspec
+
+group :docs do
+  gem "yard"
+  gem "redcarpet"
+  gem "github-markup"
+end
+
+group :test do
+  gem "chefstyle"
+  gem "rspec", "~> 3.0"
+  gem "rake"
+end
+
+group :debug do
+  gem "pry"
+  gem "pry-byebug"
+  gem "pry-stack_explorer"
+  gem "rb-readline"
+end
+
+instance_eval(ENV["GEMFILE_MOD"]) if ENV["GEMFILE_MOD"]
+
+# If you want to load debugging tools into the bundle exec sandbox,
+# add these additional dependencies into Gemfile.local
+eval_gemfile(__FILE__ + ".local") if File.exist?(__FILE__ + ".local")

data/Rakefile

@@ -1 +1,41 @@
 require "bundler/gem_tasks"
+
+begin
+  require "rspec/core/rake_task"
+  RSpec::Core::RakeTask.new do |t|
+    t.pattern = "spec/**/*_spec.rb"
+  end
+rescue LoadError
+  desc "rspec is not installed, this task is disabled"
+  task :spec do
+    abort "rspec is not installed. bundle install first to make sure all dependencies are installed."
+  end
+end
+
+begin
+  require "chefstyle"
+  require "rubocop/rake_task"
+  desc "Run Chefstyle tests"
+  RuboCop::RakeTask.new(:style) do |task|
+    task.options += ["--display-cop-names", "--no-color"]
+  end
+rescue LoadError
+  puts "chefstyle gem is not installed. bundle install first to make sure all dependencies are installed."
+end
+
+begin
+  require "yard"
+  YARD::Rake::YardocTask.new(:docs)
+rescue LoadError
+  puts "yard is not available. bundle install first to make sure all dependencies are installed."
+end
+
+task :console do
+  require "irb"
+  require "irb/completion"
+  require "appbundler"
+  ARGV.clear
+  IRB.start
+end
+
+task default: [:spec, :style]

data/appbundler.gemspec

@@ -13,16 +13,12 @@ Gem::Specification.new do |spec|
   spec.homepage      = "https://github.com/chef/appbundler"
   spec.license       = "Apache-2.0"
 
-  spec.files         = `git ls-files`.split($/)
+  spec.files         = Dir.glob("{bin,lib,spec}/**/*").reject { |f| File.directory?(f) } + %w{ LICENSE appbundler.gemspec Rakefile Gemfile }
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.required_ruby_version = ">= 2.3"
-
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "rspec", "~> 3.0"
-  spec.add_development_dependency "pry"
+  spec.required_ruby_version = ">= 2.4"
 
   spec.add_dependency "mixlib-shellout", ">= 2.0", "< 4.0"
   spec.add_dependency "mixlib-cli", ">= 1.4", "< 3.0"

data/lib/appbundler/app.rb

@@ -17,7 +17,6 @@ module Appbundler
     attr_reader :bundle_path
     attr_reader :target_bin_dir
     attr_reader :name
-    attr_reader :extra_bin_files
 
     # The bundle_path is always the path to the Gemfile.lock being used, e.g.
     # /var/cache/omnibus/src/chef/chef-14.10.9/Gemfile.lock or whatever.  If
@@ -31,11 +30,10 @@ module Appbundler
     # @param bundle_path [String] the directory path of the Gemfile.lock
     # @param target_bin_dir [String] the binstub dir, e.g. /opt/chefdk/bin
     # @param name [String] name of the gem
-    def initialize(bundle_path, target_bin_dir, name, extra_bin_files = [])
+    def initialize(bundle_path, target_bin_dir, name)
       @bundle_path = bundle_path
       @target_bin_dir = target_bin_dir
       @name = name
-      @extra_bin_files = extra_bin_files
     end
 
     # For the 2-arg version this is the gemfile in the omnibus build directory:
@@ -86,7 +84,7 @@ module Appbundler
     # of our appbundle calls.  But to ship ChefDK 2.0 we just do this.
     SHITLIST = [
       "github_changelog_generator",
-    ]
+    ].freeze
 
     # This is a check which is equivalent to asking if we are running 2-arg or 3-arg.  If
     # we have an "external_lockfile" that means the chef-dk omnibus Gemfile.lock, e.g.:
@@ -111,11 +109,11 @@ module Appbundler
     #
     def local_gemfile_lock_specs
       gemfile_lock_specs.map do |s|
-        #if SHITLIST.include?(s.name)
+        # if SHITLIST.include?(s.name)
         #  nil
-        #else
-          safe_resolve_local_gem(s)
-        #end
+        # else
+        safe_resolve_local_gem(s)
+        # end
       end.compact
     end
 
@@ -129,7 +127,7 @@ module Appbundler
       gem_path = installed_spec.gem_dir
       # If we're already using that directory, don't copy (it won't work anyway)
       return if gem_path == File.dirname(gemfile_lock)
-      FileUtils.install(gemfile_lock, gem_path, :mode => 0644)
+      FileUtils.install(gemfile_lock, gem_path, mode: 0644)
       if File.exist?(dot_bundle_dir) && File.directory?(dot_bundle_dir)
         FileUtils.cp_r(dot_bundle_dir, gem_path)
         FileUtils.chmod_R("ugo+rX", File.join(gem_path, ".bundle"))
@@ -155,7 +153,7 @@ module Appbundler
         locked_gems = {}
 
         gemfile_lock_specs.each do |s|
-          #next if SHITLIST.include?(s.name)
+          # next if SHITLIST.include?(s.name)
           spec = safe_resolve_local_gem(s)
           next if spec.nil?
 
@@ -197,7 +195,7 @@ module Appbundler
         end
 
         t.close
-        puts IO.read(t.path)  # debugging
+        puts IO.read(t.path) # debugging
         Dir.chdir(app_dir) do
           FileUtils.rm_f "#{app_dir}/Gemfile.lock"
           Bundler.with_clean_env do
@@ -208,7 +206,7 @@ module Appbundler
           FileUtils.mv t.path, "#{app_dir}/Gemfile"
         end
       end
-      return "#{app_dir}/Gemfile"
+      "#{app_dir}/Gemfile"
     end
 
     def write_executable_stubs
@@ -247,10 +245,10 @@ module Appbundler
 
     def batchfile_stub
       ruby_relpath_windows = ruby_relative_path.tr("/", '\\')
-      <<-E
-@ECHO OFF
-"%~dp0\\#{ruby_relpath_windows}" "%~dpn0" %*
-E
+      <<~E
+        @ECHO OFF
+        "%~dp0\\#{ruby_relpath_windows}" "%~dpn0" %*
+      E
     end
 
     # Relative path from #target_bin_dir to #ruby. This is used to
@@ -288,24 +286,30 @@ E
     # APPBUNDLER_ALLOW_RVM environment variable to "true". This feature
     # exists to make tests run correctly on travis.ci (which uses rvm).
     def env_sanitizer
-      <<-EOS
-require "rubygems"
-
-begin
-  # this works around rubygems/rubygems#2196 and can be removed in rubygems > 2.7.6
-  require "rubygems/bundler_version_finder"
-rescue LoadError
-  # probably means rubygems is too old or too new to have this class, and we don't care
-end
+      <<~EOS
+        require "rubygems"
+
+        # this works around OpenSSL FIPS fingerprint matching issue where
+        # it expects to be loaded in image base known at compile time. We
+        # load OpenSSL early so that the shared library gets loaded in its
+        # preferred image base address
+        require "openssl"
+
+        begin
+          # this works around rubygems/rubygems#2196 and can be removed in rubygems > 2.7.6
+          require "rubygems/bundler_version_finder"
+        rescue LoadError
+          # probably means rubygems is too old or too new to have this class, and we don't care
+        end
 
-# avoid appbundling if we are definitely running within a Bundler bundle.
-# most likely the check for defined?(Bundler) is enough since we don't require
-# bundler above, but just for paranoia's sake also we test to see if Bundler is
-# really doing its thing or not.
-unless defined?(Bundler) && Bundler.instance_variable_defined?("@load")
-  ENV["GEM_HOME"] = ENV["GEM_PATH"] = nil unless ENV["APPBUNDLER_ALLOW_RVM"] == "true"
-  ::Gem.clear_paths
-EOS
+        # avoid appbundling if we are definitely running within a Bundler bundle.
+        # most likely the check for defined?(Bundler) is enough since we don't require
+        # bundler above, but just for paranoia's sake also we test to see if Bundler is
+        # really doing its thing or not.
+        unless defined?(Bundler) && Bundler.instance_variable_defined?("@load")
+          ENV["GEM_HOME"] = ENV["GEM_PATH"] = nil unless ENV["APPBUNDLER_ALLOW_RVM"] == "true"
+          ::Gem.clear_paths
+      EOS
     end
 
     def runtime_activate
@@ -325,21 +329,28 @@ EOS
     def load_statement_for(bin_file)
       name, version = app_spec.name, app_spec.version
       bin_basename = File.basename(bin_file)
-      <<-E
-  gem "#{name}", "= #{version}"
-  spec = Gem::Specification.find_by_name("#{name}", "= #{version}")
-else
-  spec = Gem::Specification.find_by_name("#{name}")
-end
+      <<~E
+          gem "#{name}", "= #{version}"
+          gem "bundler" # force activation of bundler to avoid unresolved specs if there are multiple bundler versions
+          spec = Gem::Specification.find_by_name("#{name}", "= #{version}")
+        else
+          spec = Gem::Specification.find_by_name("#{name}")
+        end
+
+        unless Gem::Specification.unresolved_deps.empty?
+          $stderr.puts "APPBUNDLER WARNING: unresolved deps are CRITICAL performance bug, this MUST be fixed"
+          Gem::Specification.reset
+        end
 
-bin_file = spec.bin_file("#{bin_basename}")
+        bin_file = spec.bin_file("#{bin_basename}")
 
-Kernel.load(bin_file)
-E
+        Kernel.load(bin_file)
+      E
     end
 
     def executables
-      installed_spec.executables.map { |e| installed_spec.bin_file(e) } + extra_bin_files
+      spec = installed_spec
+      spec.executables.map { |e| spec.bin_file(e) }
     end
 
     def runtime_dep_specs
@@ -413,12 +424,12 @@ E
       inaccessable_gems = inaccessable_git_sourced_gems
       return true if inaccessable_gems.empty?
 
-      message = <<-MESSAGE
-Application '#{name}' contains gems in the lockfile which are
-not accessible by rubygems. This usually occurs when you fetch gems from git in
-your Gemfile and do not install the same version of the gems beforehand.
+      message = <<~MESSAGE
+        Application '#{name}' contains gems in the lockfile which are
+        not accessible by rubygems. This usually occurs when you fetch gems from git in
+        your Gemfile and do not install the same version of the gems beforehand.
 
-MESSAGE
+      MESSAGE
 
       message << "The Gemfile.lock is located here:\n- #{gemfile_lock}\n\n"
 

data/lib/appbundler/cli.rb

@@ -1,54 +1,48 @@
-require "appbundler/version"
-require "appbundler/app"
+require_relative "version"
+require_relative "app"
 require "mixlib/cli"
 
 module Appbundler
   class CLI
     include Mixlib::CLI
 
-    banner(<<-BANNER)
-* appbundler #{VERSION} *
+    banner(<<~BANNER)
+      * appbundler #{VERSION} *
 
-Usage: appbundler BUNDLE_DIR BINSTUB_DIR [GEM_NAME] [GEM_NAME] ...
+      Usage: appbundler BUNDLE_DIR BINSTUB_DIR [GEM_NAME] [GEM_NAME] ...
 
-  BUNDLE_DIR is the root directory to the bundle containing your app
-  BINSTUB_DIR is the directory where you want generated executables to be written
-  GEM_NAME is the name of a gem you want to appbundle. Default is the directory name
-           of BUNDLE_DIR (e.g. /src/chef -> chef)
+        BUNDLE_DIR is the root directory to the bundle containing your app
+        BINSTUB_DIR is the directory where you want generated executables to be written
+        GEM_NAME is the name of a gem you want to appbundle. Default is the directory name
+                 of BUNDLE_DIR (e.g. /src/chef -> chef)
 
-Your bundled application must already be gem installed.  Generated binstubs
-will point to the gem, not your working copy.
-BANNER
+      Your bundled application must already be gem installed.  Generated binstubs
+      will point to the gem, not your working copy.
+    BANNER
 
     # this is used by chef-dk, its probably not an external API, here be dragons
     option :without,
-      :long => "--without GROUPS",
-      :description => "Comma separated list of groups to exclude when building transitive Gemfile.locks (internal API)",
-      :proc => lambda { |o| o.split(/[\s,]+/) },
-      :default => []
-
-    option :extra_bin_files,
-      :long => "--extra-bin-files bin1,bin2",
-      :description => "Comma separated list of extra binstubs to wire up which are not listed in the gemspec",
-      :proc => lambda { |o| o.split(/[\s,]+/) },
-      :default => []
+      long: "--without GROUPS",
+      description: "Comma separated list of groups to exclude when building transitive Gemfile.locks (internal API)",
+      proc: lambda { |o| o.split(/[\s,]+/) },
+      default: []
 
     option :version,
-      :short => "-v",
-      :long => "--version",
-      :description => "Show appbundler version",
-      :boolean => true,
-      :proc => lambda { |v| $stdout.puts("Appbundler Version: #{::Appbundler::VERSION}") },
-      :exit => 0
+      short: "-v",
+      long: "--version",
+      description: "Show appbundler version",
+      boolean: true,
+      proc: lambda { |v| $stdout.puts("Appbundler Version: #{::Appbundler::VERSION}") },
+      exit: 0
 
     option :help,
-      :short => "-h",
-      :long => "--help",
-      :description => "Show this message",
-      :on => :tail,
-      :boolean => true,
-      :show_options => true,
-      :exit => 0
+      short: "-h",
+      long: "--help",
+      description: "Show this message",
+      on: :tail,
+      boolean: true,
+      show_options: true,
+      exit: 0
 
     def self.run(argv)
       cli = new(argv)
@@ -104,7 +98,7 @@ BANNER
 
     def run
       gems.each do |g|
-        app = App.new(bundle_path, bin_path, g, config[:extra_bin_files])
+        app = App.new(bundle_path, bin_path, g)
         created_stubs = app.write_executable_stubs
         created_stubs.each do |real_executable_path, stub_path|
           $stdout.puts "Generated binstub #{stub_path} => #{real_executable_path}"

data/lib/appbundler/version.rb

@@ -1,3 +1,3 @@
 module Appbundler
-  VERSION = "0.12.3"
+  VERSION = "0.13.4".freeze
 end

data/spec/appbundler/app_spec.rb

@@ -11,15 +11,15 @@ describe Appbundler do
   end
 
   def double_spec(name, version, dep_names)
-    deps = dep_names.map { |n| double("Bundler::Dependency #{n}", :name => n.to_s) }
+    deps = dep_names.map { |n| double("Bundler::Dependency #{n}", name: n.to_s) }
     source = double("Bundler::Source::Rubygems")
-    spec = double("Bundler::LazySpecification '#{name}'", :name => name.to_s, :version => version, :dependencies => deps, :source => source)
+    spec = double("Bundler::LazySpecification '#{name}'", name: name.to_s, version: version, dependencies: deps, source: source)
     all_specs << spec
     spec
   end
 
   def shellout!(cmd)
-    s = Mixlib::ShellOut.new(cmd, :env => { "RUBYOPT" => nil, "BUNDLE_GEMFILE" => nil, "APPBUNDLER_ALLOW_RVM" => "true" })
+    s = Mixlib::ShellOut.new(cmd, env: { "RUBYOPT" => nil, "BUNDLE_GEMFILE" => nil, "APPBUNDLER_ALLOW_RVM" => "true" })
     s.run_command
     s.error!
     s
@@ -99,23 +99,48 @@ describe Appbundler do
     end
 
     it "locks the main app's gem via rubygems, and loads the proper binary" do
-      expected_loading_code = <<-CODE
-gem "app", "= 1.0.0"
-
-spec = Gem::Specification.find_by_name("app", "= 1.0.0")
-bin_file = spec.bin_file("foo")
-
-Kernel.load(bin_file)
-CODE
+      expected_loading_code = <<~CODE
+          gem "app", "= 1.0.0"
+          gem "bundler" # force activation of bundler to avoid unresolved specs if there are multiple bundler versions
+          spec = Gem::Specification.find_by_name("app", "= 1.0.0")
+        else
+          spec = Gem::Specification.find_by_name("app")
+        end
+         unless Gem::Specification.unresolved_deps.empty?
+          $stderr.puts "APPBUNDLER WARNING: unresolved deps are CRITICAL performance bug, this MUST be fixed"
+          Gem::Specification.reset
+        end
+         bin_file = spec.bin_file("foo")
+         Kernel.load(bin_file)
+      CODE
       expect(app.load_statement_for(bin_path)).to eq(expected_loading_code)
     end
 
     it "generates code to override GEM_HOME and GEM_PATH (e.g., rvm)" do
-      expected = <<-EOS
-ENV["GEM_HOME"] = ENV["GEM_PATH"] = nil unless ENV["APPBUNDLER_ALLOW_RVM"] == "true"
-require "rubygems"
-::Gem.clear_paths
-EOS
+      expected = <<~EOS
+        require "rubygems"
+
+        # this works around OpenSSL FIPS fingerprint matching issue where
+        # it expects to be loaded in image base known at compile time. We
+        # load OpenSSL early so that the shared library gets loaded in its
+        # preferred image base address
+        require "openssl"
+
+        begin
+          # this works around rubygems/rubygems#2196 and can be removed in rubygems > 2.7.6
+          require "rubygems/bundler_version_finder"
+        rescue LoadError
+          # probably means rubygems is too old or too new to have this class, and we don't care
+        end
+
+        # avoid appbundling if we are definitely running within a Bundler bundle.
+        # most likely the check for defined?(Bundler) is enough since we don't require
+        # bundler above, but just for paranoia's sake also we test to see if Bundler is
+        # really doing its thing or not.
+        unless defined?(Bundler) && Bundler.instance_variable_defined?("@load")
+          ENV["GEM_HOME"] = ENV["GEM_PATH"] = nil unless ENV["APPBUNDLER_ALLOW_RVM"] == "true"
+          ::Gem.clear_paths
+      EOS
 
       expect(app.env_sanitizer).to eq(expected)
       expect(app.runtime_activate).to include(expected)
@@ -134,10 +159,10 @@ EOS
       end
 
       it "generates batchfile stub code" do
-        expected_batch_code = <<-E
-@ECHO OFF
-"%~dp0\\..\\embedded\\bin\\ruby.exe" "%~dpn0" %*
-E
+        expected_batch_code = <<~E
+          @ECHO OFF
+          "%~dp0\\..\\embedded\\bin\\ruby.exe" "%~dpn0" %*
+        E
         expect(app.batchfile_stub).to eq(expected_batch_code)
       end
 
@@ -155,8 +180,8 @@ E
 
       # Ensure that the behavior we emulate in our stubs is correct:
       it "sanity checks rubygems behavior" do
-        expect { Gem::Specification.find_by_name("there-is-no-such-gem-named-this", "= 999.999.999") }.
-          to raise_error(Gem::LoadError)
+        expect { Gem::Specification.find_by_name("there-is-no-such-gem-named-this", "= 999.999.999") }
+          .to raise_error(Gem::LoadError)
       end
 
       context "and the gems are not accessible by rubygems" do
@@ -238,123 +263,123 @@ E
 
     it "generates runtime activation code for the app" do
       expected_gem_activates = if windows?
-                                 <<-E
-ENV["GEM_HOME"] = ENV["GEM_PATH"] = nil unless ENV["APPBUNDLER_ALLOW_RVM"] == "true"
-require "rubygems"
-::Gem.clear_paths
-
-gem "chef", "= 12.4.1"
-gem "chef-config", "= 12.4.1"
-gem "mixlib-config", "= 2.2.1"
-gem "mixlib-shellout", "= 2.2.0"
-gem "win32-process", "= 0.7.5"
-gem "ffi", "= 1.9.10"
-gem "chef-zero", "= 4.3.0"
-gem "ffi-yajl", "= 2.2.2"
-gem "libyajl2", "= 1.2.0"
-gem "hashie", "= 2.1.2"
-gem "mixlib-log", "= 1.6.0"
-gem "rack", "= 1.6.4"
-gem "uuidtools", "= 2.1.5"
-gem "diff-lcs", "= 1.2.5"
-gem "erubis", "= 2.7.0"
-gem "highline", "= 1.7.3"
-gem "mixlib-authentication", "= 1.3.0"
-gem "mixlib-cli", "= 1.5.0"
-gem "net-ssh", "= 2.9.2"
-gem "net-ssh-multi", "= 1.2.1"
-gem "net-ssh-gateway", "= 1.2.0"
-gem "ohai", "= 8.5.1"
-gem "ipaddress", "= 0.8.0"
-gem "mime-types", "= 2.6.1"
-gem "rake", "= 10.1.1"
-gem "systemu", "= 2.6.5"
-gem "wmi-lite", "= 1.0.0"
-gem "plist", "= 3.1.0"
-gem "pry", "= 0.9.12.6"
-gem "coderay", "= 1.1.0"
-gem "method_source", "= 0.8.2"
-gem "slop", "= 3.4.7"
-gem "win32console", "= 1.3.2"
-gem "rspec-core", "= 3.3.2"
-gem "rspec-support", "= 3.3.0"
-gem "rspec-expectations", "= 3.3.1"
-gem "rspec-mocks", "= 3.3.2"
-gem "rspec_junit_formatter", "= 0.2.3"
-gem "builder", "= 3.2.2"
-gem "serverspec", "= 2.23.1"
-gem "multi_json", "= 1.11.2"
-gem "rspec", "= 3.3.0"
-gem "rspec-its", "= 1.2.0"
-gem "specinfra", "= 2.43.3"
-gem "net-scp", "= 1.2.1"
-gem "net-telnet", "= 0.1.1"
-gem "sfl", "= 2.2"
-gem "syslog-logger", "= 1.6.8"
-gem "win32-api", "= 1.5.3"
-gem "win32-dir", "= 0.5.0"
-gem "win32-event", "= 0.6.1"
-gem "win32-ipc", "= 0.6.6"
-gem "win32-eventlog", "= 0.6.3"
-gem "win32-mmap", "= 0.4.1"
-gem "win32-mutex", "= 0.4.2"
-gem "win32-service", "= 0.8.6"
-gem "windows-api", "= 0.4.4"
-gem "windows-pr", "= 1.2.4"
-E
+                                 <<~E
+                                   ENV["GEM_HOME"] = ENV["GEM_PATH"] = nil unless ENV["APPBUNDLER_ALLOW_RVM"] == "true"
+                                   require "rubygems"
+                                   ::Gem.clear_paths
+
+                                   gem "chef", "= 12.4.1"
+                                   gem "chef-config", "= 12.4.1"
+                                   gem "mixlib-config", "= 2.2.1"
+                                   gem "mixlib-shellout", "= 2.2.0"
+                                   gem "win32-process", "= 0.7.5"
+                                   gem "ffi", "= 1.9.10"
+                                   gem "chef-zero", "= 4.3.0"
+                                   gem "ffi-yajl", "= 2.2.2"
+                                   gem "libyajl2", "= 1.2.0"
+                                   gem "hashie", "= 2.1.2"
+                                   gem "mixlib-log", "= 1.6.0"
+                                   gem "rack", "= 1.6.4"
+                                   gem "uuidtools", "= 2.1.5"
+                                   gem "diff-lcs", "= 1.2.5"
+                                   gem "erubis", "= 2.7.0"
+                                   gem "highline", "= 1.7.3"
+                                   gem "mixlib-authentication", "= 1.3.0"
+                                   gem "mixlib-cli", "= 1.5.0"
+                                   gem "net-ssh", "= 2.9.2"
+                                   gem "net-ssh-multi", "= 1.2.1"
+                                   gem "net-ssh-gateway", "= 1.2.0"
+                                   gem "ohai", "= 8.5.1"
+                                   gem "ipaddress", "= 0.8.0"
+                                   gem "mime-types", "= 2.6.1"
+                                   gem "rake", "= 10.1.1"
+                                   gem "systemu", "= 2.6.5"
+                                   gem "wmi-lite", "= 1.0.0"
+                                   gem "plist", "= 3.1.0"
+                                   gem "pry", "= 0.9.12.6"
+                                   gem "coderay", "= 1.1.0"
+                                   gem "method_source", "= 0.8.2"
+                                   gem "slop", "= 3.4.7"
+                                   gem "win32console", "= 1.3.2"
+                                   gem "rspec-core", "= 3.3.2"
+                                   gem "rspec-support", "= 3.3.0"
+                                   gem "rspec-expectations", "= 3.3.1"
+                                   gem "rspec-mocks", "= 3.3.2"
+                                   gem "rspec_junit_formatter", "= 0.2.3"
+                                   gem "builder", "= 3.2.2"
+                                   gem "serverspec", "= 2.23.1"
+                                   gem "multi_json", "= 1.11.2"
+                                   gem "rspec", "= 3.3.0"
+                                   gem "rspec-its", "= 1.2.0"
+                                   gem "specinfra", "= 2.43.3"
+                                   gem "net-scp", "= 1.2.1"
+                                   gem "net-telnet", "= 0.1.1"
+                                   gem "sfl", "= 2.2"
+                                   gem "syslog-logger", "= 1.6.8"
+                                   gem "win32-api", "= 1.5.3"
+                                   gem "win32-dir", "= 0.5.0"
+                                   gem "win32-event", "= 0.6.1"
+                                   gem "win32-ipc", "= 0.6.6"
+                                   gem "win32-eventlog", "= 0.6.3"
+                                   gem "win32-mmap", "= 0.4.1"
+                                   gem "win32-mutex", "= 0.4.2"
+                                   gem "win32-service", "= 0.8.6"
+                                   gem "windows-api", "= 0.4.4"
+                                   gem "windows-pr", "= 1.2.4"
+                                 E
                                else
-                                 <<-E
-ENV["GEM_HOME"] = ENV["GEM_PATH"] = nil unless ENV["APPBUNDLER_ALLOW_RVM"] == "true"
-require "rubygems"
-::Gem.clear_paths
-
-gem "chef", "= 12.4.1"
-gem "chef-config", "= 12.4.1"
-gem "mixlib-config", "= 2.2.1"
-gem "mixlib-shellout", "= 2.2.0"
-gem "chef-zero", "= 4.3.0"
-gem "ffi-yajl", "= 2.2.2"
-gem "libyajl2", "= 1.2.0"
-gem "hashie", "= 2.1.2"
-gem "mixlib-log", "= 1.6.0"
-gem "rack", "= 1.6.4"
-gem "uuidtools", "= 2.1.5"
-gem "diff-lcs", "= 1.2.5"
-gem "erubis", "= 2.7.0"
-gem "highline", "= 1.7.3"
-gem "mixlib-authentication", "= 1.3.0"
-gem "mixlib-cli", "= 1.5.0"
-gem "net-ssh", "= 2.9.2"
-gem "net-ssh-multi", "= 1.2.1"
-gem "net-ssh-gateway", "= 1.2.0"
-gem "ohai", "= 8.5.1"
-gem "ffi", "= 1.9.10"
-gem "ipaddress", "= 0.8.0"
-gem "mime-types", "= 2.6.1"
-gem "rake", "= 10.1.1"
-gem "systemu", "= 2.6.5"
-gem "wmi-lite", "= 1.0.0"
-gem "plist", "= 3.1.0"
-gem "pry", "= 0.9.12.6"
-gem "coderay", "= 1.1.0"
-gem "method_source", "= 0.8.2"
-gem "slop", "= 3.4.7"
-gem "rspec-core", "= 3.3.2"
-gem "rspec-support", "= 3.3.0"
-gem "rspec-expectations", "= 3.3.1"
-gem "rspec-mocks", "= 3.3.2"
-gem "rspec_junit_formatter", "= 0.2.3"
-gem "builder", "= 3.2.2"
-gem "serverspec", "= 2.23.1"
-gem "multi_json", "= 1.11.2"
-gem "rspec", "= 3.3.0"
-gem "rspec-its", "= 1.2.0"
-gem "specinfra", "= 2.43.3"
-gem "net-scp", "= 1.2.1"
-gem "net-telnet", "= 0.1.1"
-gem "sfl", "= 2.2"
-gem "syslog-logger", "= 1.6.8"
-E
+                                 <<~E
+                                   ENV["GEM_HOME"] = ENV["GEM_PATH"] = nil unless ENV["APPBUNDLER_ALLOW_RVM"] == "true"
+                                   require "rubygems"
+                                   ::Gem.clear_paths
+
+                                   gem "chef", "= 12.4.1"
+                                   gem "chef-config", "= 12.4.1"
+                                   gem "mixlib-config", "= 2.2.1"
+                                   gem "mixlib-shellout", "= 2.2.0"
+                                   gem "chef-zero", "= 4.3.0"
+                                   gem "ffi-yajl", "= 2.2.2"
+                                   gem "libyajl2", "= 1.2.0"
+                                   gem "hashie", "= 2.1.2"
+                                   gem "mixlib-log", "= 1.6.0"
+                                   gem "rack", "= 1.6.4"
+                                   gem "uuidtools", "= 2.1.5"
+                                   gem "diff-lcs", "= 1.2.5"
+                                   gem "erubis", "= 2.7.0"
+                                   gem "highline", "= 1.7.3"
+                                   gem "mixlib-authentication", "= 1.3.0"
+                                   gem "mixlib-cli", "= 1.5.0"
+                                   gem "net-ssh", "= 2.9.2"
+                                   gem "net-ssh-multi", "= 1.2.1"
+                                   gem "net-ssh-gateway", "= 1.2.0"
+                                   gem "ohai", "= 8.5.1"
+                                   gem "ffi", "= 1.9.10"
+                                   gem "ipaddress", "= 0.8.0"
+                                   gem "mime-types", "= 2.6.1"
+                                   gem "rake", "= 10.1.1"
+                                   gem "systemu", "= 2.6.5"
+                                   gem "wmi-lite", "= 1.0.0"
+                                   gem "plist", "= 3.1.0"
+                                   gem "pry", "= 0.9.12.6"
+                                   gem "coderay", "= 1.1.0"
+                                   gem "method_source", "= 0.8.2"
+                                   gem "slop", "= 3.4.7"
+                                   gem "rspec-core", "= 3.3.2"
+                                   gem "rspec-support", "= 3.3.0"
+                                   gem "rspec-expectations", "= 3.3.1"
+                                   gem "rspec-mocks", "= 3.3.2"
+                                   gem "rspec_junit_formatter", "= 0.2.3"
+                                   gem "builder", "= 3.2.2"
+                                   gem "serverspec", "= 2.23.1"
+                                   gem "multi_json", "= 1.11.2"
+                                   gem "rspec", "= 3.3.0"
+                                   gem "rspec-its", "= 1.2.0"
+                                   gem "specinfra", "= 2.43.3"
+                                   gem "net-scp", "= 1.2.1"
+                                   gem "net-telnet", "= 0.1.1"
+                                   gem "sfl", "= 2.2"
+                                   gem "syslog-logger", "= 1.6.8"
+                                 E
                                end
       expect(app.runtime_activate).to include(expected_gem_activates)
     end
@@ -391,8 +416,8 @@ E
       binary_2 = File.join(target_bindir, "app-binary-2")
       expect(File.exist?(binary_1)).to be(true)
       expect(File.exist?(binary_2)).to be(true)
-      expect(File.executable?(binary_1) || File.exists?(binary_1 + ".bat")).to be(true)
-      expect(File.executable?(binary_1) || File.exists?(binary_1 + ".bat")).to be(true)
+      expect(File.executable?(binary_1) || File.exist?(binary_1 + ".bat")).to be(true)
+      expect(File.executable?(binary_1) || File.exist?(binary_1 + ".bat")).to be(true)
       expect(shellout!(binary_1).stdout.strip).to eq("binary 1 ran")
       expect(shellout!(binary_2).stdout.strip).to eq("binary 2 ran")
     end
@@ -401,7 +426,7 @@ E
       spec = Gem::Specification.find_by_name("appbundler-example-app", "= 1.0.0")
       gem_path = spec.gem_dir
       app.copy_bundler_env
-      expect(File.exists?(File.join(gem_path, "Gemfile.lock"))).to be(true)
+      expect(File.exist?(File.join(gem_path, "Gemfile.lock"))).to be(true)
     end
 
     it "copies over .bundler to the gem directory" do
@@ -409,7 +434,7 @@ E
       gem_path = spec.gem_dir
       app.copy_bundler_env
       expect(File.directory?(File.join(gem_path, ".bundle"))).to be(true)
-      expect(File.exists?(File.join(gem_path, ".bundle/config"))).to be(true)
+      expect(File.exist?(File.join(gem_path, ".bundle/config"))).to be(true)
     end
     context "and the executable is symlinked to a different directory", :not_supported_on_windows do
 
@@ -449,10 +474,10 @@ E
       end
 
       let(:expected_batch_code) do
-        <<-E
-@ECHO OFF
-"%~dp0\\#{expected_ruby_relpath}" "%~dpn0" %*
-E
+        <<~E
+          @ECHO OFF
+          "%~dp0\\#{expected_ruby_relpath}" "%~dpn0" %*
+        E
       end
 
       before do