apnd 0.1.7 → 0.1.8

data/README.markdown

@@ -100,9 +100,13 @@ push notifications to APND.
 
     # Send multiple notifications at once to avoid overhead in
     # opening/closing the upstream socket connection each time
+    #
+    # *IMPORTANT!* Use sock.puts as it appends a new line. If you don't,
+    # you'll only receive the first notification.
+
     APND::Notification.open_upstream_socket do |sock|
-      sock.write(notification1.to_bytes)
-      sock.write(notification2.to_bytes)
+      sock.puts(notification1.to_bytes)
+      sock.puts(notification2.to_bytes)
     end
 
 

data/lib/apnd/daemon/protocol.rb

@@ -17,16 +17,11 @@ module APND
     #
     # Called when a client connection is closed
     #
-    def unbind
-      APND.ohai "#{@address.last}:#{@address.first} closed connection"
-    end
-
+    # Checks @buffer for any pending notifications to be
+    # queued
     #
-    # Add incoming notification(s) to the queue
-    #
-    def receive_data(data)
-      (@buffer ||= "") << data
-      @buffer.each_line do |line|
+    def unbind
+      @buffer.chomp.split("\n").each do |line|
         if notification = APND::Notification.valid?(line)
           APND.ohai "#{@address.last}:#{@address.first} added new Notification to queue"
           queue.push(notification)
@@ -34,6 +29,15 @@ module APND
           APND.ohai "#{@address.last}:#{@address.first} submitted invalid Notification"
         end
       end
+      APND.ohai "#{@address.last}:#{@address.first} closed connection"
+    end
+
+    #
+    # Add incoming notification(s) to @buffer
+    #
+    def receive_data(data)
+      APND.ohai "#{@address.last}:#{@address.first} buffering data"
+      (@buffer ||= "") << data
     end
   end
 end

data/lib/apnd/version.rb

@@ -2,7 +2,7 @@ module APND
   class Version #:nodoc:
     MAJOR = 0
     MINOR = 1
-    TINY  = 7
+    TINY  = 8
 
     def self.to_s
       [MAJOR, MINOR, TINY].join('.')

data/test/apnd_test.rb

@@ -61,11 +61,13 @@ class APNDTest < Test::Unit::TestCase
 
       should "add valid notification to queue" do
         @daemon.receive_data(@@bytes)
+        @daemon.unbind
         assert_equal 1, @daemon.queue.size
       end
 
       should "receive multiple Notifications in a single packet" do
         @daemon.receive_data([@@bytes, @@bytes, @@bytes].join("\n"))
+        @daemon.unbind
         assert_equal 3, @daemon.queue.size
       end
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: apnd
 version: !ruby/object:Gem::Version 
-  hash: 21
+  hash: 11
   prerelease: 
   segments: 
   - 0
   - 1
-  - 7
-  version: 0.1.7
+  - 8
+  version: 0.1.8
 platform: ruby
 authors: 
 - Joshua Priddle
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-02-17 00:00:00 -05:00
+date: 2011-02-18 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency