apisync-rails 0.0.4 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 34ddbfb8791d1f24a61b9c7944494f006c2b543a
-  data.tar.gz: ec710fff7c676929cfd11d70d958aa1b56ca768d
+  metadata.gz: a583b9bcbe4c6e0dafb2d339832e45f00d10940c
+  data.tar.gz: 767adc9866af63552c5bf288280a265e85e27a81
 SHA512:
-  metadata.gz: cd78a4b8aed59f148678befaa4e9e27eb08f32448aedb1a5cfff6783ca6eb74354f3dc494c959043a8f31ca96a73dc80b6af4b9dda46c3416530653835cb2d14
-  data.tar.gz: '091e34cb46df93b256f10b2811548facbd597d02d75dcdbe29fc61fc9d64c760691c3d97601f271923fd993785f3cfae812b1ec023fb0d89a69d5e04b1bc5742'
+  metadata.gz: 0e10811ce56132875c6c302fe78575536f914237ced8a63aad970aea767f4862f4e1b09acdadcee083ddbd4675997060cd7aa746db6f5767e0a983cb4ca84f45
+  data.tar.gz: '08476e75fd97d3068103a344304359fe7ff00eade77e99d63038f333fab71564dce0962272353edd76065df2f6d63d8653388c4ebe9d34f279fd14e7caf38d2f'

data/README.md

@@ -100,6 +100,11 @@ class Product < ActiveRecord::Base
 end
 ```
 
+**Step 3: test on the console:** on the Rails console, try saving the model.
+The request and response should show up.
+
+You can turn off these logs, use `Apisync.verbose = false`.
+
 **Explanation**
 
 **sync_if** defines if the item should be synchronized. The method with the
@@ -132,6 +137,13 @@ over and over.
 By default, `reference_id` is set to whatever **id** value is. You can
 customize it, e.g `attribute :reference_id, from: :my_custom_id`.
 
+### Failed requests
+
+A `warning` will be logged (`Rails.logger.warn`) whenever a request fails.
+
+In asynchronous cases (e.g Sidekiq), an exception will be raised
+(`Apisync::RequestFailed`) so jobs can be retried.
+
 ### Note on callbacks
 
 This gem uses Rails' callbacks to trigger synchronization.

data/apisync-rails.gemspec

@@ -23,7 +23,7 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency "activesupport", ">= 4.2"
   spec.add_dependency "activerecord", ">= 4.2"
-  spec.add_dependency "apisync", ">= 0.1.4"
+  spec.add_dependency "apisync", ">= 0.2.3"
 
   spec.add_development_dependency "bundler", "~> 1.15"
   spec.add_development_dependency "rake", "~> 10.0"

data/lib/apisync/rails/http.rb

@@ -7,10 +7,10 @@ class Apisync
 
         if ::Rails.respond_to?(:gem_version)
           rails_version = ::Rails.gem_version.to_s
-        elsif Rails::VERSION.is_a?(String)
-          rails_version = Rails::VERSION
-        elsif Rails::VERSION::STRING
-          rails_version = Rails::VERSION::STRING
+        elsif ::Rails::VERSION.is_a?(String)
+          rails_version = ::Rails::VERSION
+        elsif ::Rails::VERSION::STRING
+          rails_version = ::Rails::VERSION::STRING
         end
 
         headers["X-Framework"] = "Ruby on Rails #{rails_version}"
@@ -23,8 +23,29 @@ class Apisync
           headers["X-TooManyRequests-Attempts"] = too_many_requests_attempts.to_s
         end
 
-        client = Apisync.new
-        client.inventory_items.save(attributes: attrs, headers: headers)
+        if Apisync.logger.nil?
+          Apisync.logger = ::Rails.logger
+        end
+
+        if Apisync.verbose.nil?
+          verbose = ::Rails.env.development?
+        else
+          verbose = Apisync.verbose
+        end
+
+        client = Apisync.new(verbose: verbose)
+        response = client.inventory_items.save(attributes: attrs, headers: headers)
+
+        unless response.success?
+          reference_id_msg = ""
+          if attrs["reference_id"].present?
+            reference_id_msg = "with reference_id '#{attrs[:reference_id]}' "
+          end
+
+          ::Rails.logger.warn "[APISync] Request #{reference_id_msg}failed: #{response.body}"
+        end
+
+        response
       end
     end
   end

data/lib/apisync/rails/model.rb

@@ -48,6 +48,8 @@ class Apisync
           validate!(payload)
           log_warnings(payload)
 
+          Apisync::Rails::Extensions.setup
+
           if defined?(::Sidekiq)
             Apisync::Rails::SyncModelJob::Sidekiq.perform_async(
               @model.class.name,

data/lib/apisync/rails/sync_model_job/sidekiq.rb

@@ -15,13 +15,17 @@ class Apisync
           end
 
           begin
-            Apisync::Rails::Http.post(
+            response = Apisync::Rails::Http.post(
               attributes,
               request_concurrency: :asynchronous,
               concurrency_lib: "Sidekiq #{::Sidekiq::VERSION}",
               too_many_requests_attempts: attempt.to_s
             )
 
+            unless response.success?
+              raise Apisync::RequestFailed, "[apisync] Request failed: #{response.body}"
+            end
+
           # When there are too many requests and ApiSync's API cannot take it,
           # this algorithm will push this job to be retried in the future.
           rescue Apisync::TooManyRequests

data/lib/apisync/rails/version.rb

@@ -1,5 +1,5 @@
 class Apisync
   module Rails
-    VERSION = "0.0.4"
+    VERSION = "0.1.1"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: apisync-rails
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.1.1
 platform: ruby
 authors:
 - Alexandre de Oliveira
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-13 00:00:00.000000000 Z
+date: 2018-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.1.4
+        version: 0.2.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.1.4
+        version: 0.2.3
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement