apipie-rails 1.4.0 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ad4ac03f9bd83b8517dacdc1827c821bf9413649984eb84dee775ce7972a9e7d
-  data.tar.gz: 4dfa2be9dcc9ac7aab06b930164beb1eede84351c1f9a0eef23aef6e224985cb
+  metadata.gz: e4cb2ed68221a7fd10e07cf119bf3084189ef41b3609530827e026896d0ebee7
+  data.tar.gz: f225bc005c87046b5a2018f7294e9a3c1f387ac60bb9a73d295bb2c97b96b6b4
 SHA512:
-  metadata.gz: 98af0fe369f7b730c7dbf5a40d8c63e67ae2ca0f5b201ad4510827090a634cb30965dd5c737b46c26bd1e2084153481671e606ee970a814c859277a3eacadd2c
-  data.tar.gz: 5db3aef55422e20fc2b5bcafd2df97daf2ee10a0c09947b77791f614665615d8a607e393a76a72bdbb5f718ff879b048ab49fb49edebd70376fe284d5cb2967a
+  metadata.gz: 1b25a40e9f115f20a9c9faf2e5fbf13322b1960bef8182d6b797f67cf8ec3bbefa1afe17fc3b91bff520e4b53252837ca44c34740743002a02b7e75a3aaf793c
+  data.tar.gz: a20b72f7e53d2051d2a6bcad867c13ddad70256d4be012f5bbf711c177eb4ab5b0de930c23f0af2ace3c317d49d32dbef06e4c3c9d754c3a5d462031c9986e8d

data/.rubocop.yml

@@ -1,6 +1,7 @@
 require:
   - rubocop-rails
   - rubocop-rspec
+  - rubocop-rspec_rails
   - rubocop-performance
 
 inherit_from: .rubocop_todo.yml

data/.rubocop_todo.yml

@@ -1,11 +1,15 @@
 # This configuration was generated by
-# `rubocop --auto-gen-config --exclude-limit 200`
-# on 2023-10-11 12:02:42 UTC using RuboCop version 1.57.0.
+# `rubocop --auto-gen-config --exclude-limit 180`
+# on 2024-02-19 23:31:58 UTC using RuboCop version 1.60.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
+RubyVersionGlobalsUsage:
+  Exclude:
+    - apipie-rails.gemspec
+
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: Severity, Include.
@@ -154,7 +158,7 @@ Layout/EmptyLineBetweenDefs:
     - 'spec/dummy/app/controllers/pets_using_auto_views_controller.rb'
     - 'spec/dummy/app/controllers/pets_using_self_describing_classes_controller.rb'
 
-# Offense count: 56
+# Offense count: 55
 # This cop supports safe autocorrection (--autocorrect).
 Layout/EmptyLines:
   Exclude:
@@ -192,7 +196,7 @@ Layout/EmptyLinesAroundAttributeAccessor:
   Exclude:
     - 'lib/apipie/configuration.rb'
 
-# Offense count: 92
+# Offense count: 91
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: empty_lines, no_empty_lines
@@ -213,7 +217,6 @@ Layout/EmptyLinesAroundBlockBody:
     - 'spec/lib/apipie/extractor/writer_spec.rb'
     - 'spec/lib/apipie/file_handler_spec.rb'
     - 'spec/lib/apipie/generator/swagger/param_description/composite_spec.rb'
-    - 'spec/lib/apipie/generator/swagger/param_description/type_spec.rb'
     - 'spec/lib/apipie/param_description_spec.rb'
     - 'spec/lib/apipie/param_group_spec.rb'
     - 'spec/lib/apipie/validator_spec.rb'
@@ -314,15 +317,6 @@ Layout/ExtraSpacing:
     - 'spec/lib/apipie/generator/swagger/param_description/type_spec.rb'
     - 'spec/lib/swagger/swagger_dsl_spec.rb'
 
-# Offense count: 9
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: special_inside_parentheses, consistent, align_brackets
-Layout/FirstArrayElementIndentation:
-  Exclude:
-    - 'spec/dummy/app/controllers/pets_controller.rb'
-    - 'spec/dummy/app/controllers/pets_using_self_describing_classes_controller.rb'
-
 # Offense count: 38
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, IndentationWidth.
@@ -387,13 +381,6 @@ Layout/IndentationWidth:
     - 'lib/apipie/resource_description.rb'
     - 'lib/tasks/apipie.rake'
 
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-Layout/InitialIndentation:
-  Exclude:
-    - 'spec/dummy/app/controllers/extending_concern.rb'
-    - 'spec/dummy/app/controllers/sample_controller.rb'
-
 # Offense count: 15
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowDoxygenCommentStyle, AllowGemfileRubyComment.
@@ -454,7 +441,7 @@ Layout/SpaceAfterColon:
   Exclude:
     - 'spec/dummy/app/controllers/included_param_group_controller.rb'
 
-# Offense count: 42
+# Offense count: 41
 # This cop supports safe autocorrection (--autocorrect).
 Layout/SpaceAfterComma:
   Exclude:
@@ -490,8 +477,9 @@ Layout/SpaceAfterNot:
 
 # Offense count: 142
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator.
+# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator, EnforcedStyleForRationalLiterals.
 # SupportedStylesForExponentOperator: space, no_space
+# SupportedStylesForRationalLiterals: space, no_space
 Layout/SpaceAroundOperators:
   Exclude:
     - 'app/controllers/apipie/apipies_controller.rb'
@@ -505,7 +493,7 @@ Layout/SpaceAroundOperators:
     - 'spec/lib/swagger/rake_swagger_spec.rb'
     - 'spec/lib/swagger/swagger_dsl_spec.rb'
 
-# Offense count: 32
+# Offense count: 29
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
 # SupportedStyles: space, no_space
@@ -518,9 +506,6 @@ Layout/SpaceBeforeBlockBraces:
     - 'lib/apipie/param_description.rb'
     - 'lib/apipie/response_description.rb'
     - 'lib/apipie/routes_formatter.rb'
-    - 'lib/tasks/apipie.rake'
-    - 'spec/controllers/users_controller_spec.rb'
-    - 'spec/dummy/app/controllers/pets_using_auto_views_controller.rb'
     - 'spec/lib/swagger/swagger_dsl_spec.rb'
 
 # Offense count: 4
@@ -540,7 +525,7 @@ Layout/SpaceInsideArrayLiteralBrackets:
     - 'lib/apipie/generator/swagger/param_description/composite.rb'
     - 'spec/controllers/users_controller_spec.rb'
 
-# Offense count: 63
+# Offense count: 60
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
 # SupportedStyles: space, no_space
@@ -553,9 +538,7 @@ Layout/SpaceInsideBlockBraces:
     - 'lib/apipie/response_description.rb'
     - 'lib/apipie/routes_formatter.rb'
     - 'lib/apipie/validator.rb'
-    - 'lib/tasks/apipie.rake'
     - 'spec/controllers/users_controller_spec.rb'
-    - 'spec/dummy/app/controllers/pets_using_auto_views_controller.rb'
     - 'spec/lib/apipie/application_spec.rb'
     - 'spec/lib/apipie/generator/swagger/operation_id_spec.rb'
     - 'spec/lib/apipie/generator/swagger/warning_spec.rb'
@@ -726,21 +709,18 @@ Lint/UnderscorePrefixedVariableName:
     - 'lib/apipie/application.rb'
     - 'lib/apipie/dsl_definition.rb'
 
-# Offense count: 26
+# Offense count: 22
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
 Lint/UnusedBlockArgument:
   Exclude:
     - 'lib/apipie/configuration.rb'
-    - 'lib/apipie/extractor/collector.rb'
-    - 'lib/apipie/extractor/recorder.rb'
     - 'lib/apipie/param_description.rb'
     - 'lib/apipie/resource_description.rb'
     - 'lib/apipie/rspec/response_validation_helper.rb'
     - 'lib/tasks/apipie.rake'
     - 'spec/controllers/users_controller_spec.rb'
     - 'spec/lib/apipie/apipies_controller_spec.rb'
-    - 'spec/lib/apipie/extractor_spec.rb'
     - 'spec/lib/swagger/swagger_dsl_spec.rb'
     - 'spec/spec_helper.rb'
 
@@ -802,7 +782,7 @@ Metrics/MethodLength:
 Metrics/ModuleLength:
   Max: 119
 
-# Offense count: 4
+# Offense count: 5
 # Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   MaxOptionalParameters: 5
@@ -917,13 +897,6 @@ Performance/RedundantMerge:
     - 'lib/apipie/generator/swagger/param_description/type.rb'
     - 'lib/apipie/middleware/checksum_in_headers.rb'
 
-# Offense count: 7
-# This cop supports safe autocorrection (--autocorrect).
-Performance/RegexpMatch:
-  Exclude:
-    - 'lib/apipie/extractor/writer.rb'
-    - 'lib/apipie/helpers.rb'
-
 # Offense count: 7
 # This cop supports safe autocorrection (--autocorrect).
 Performance/StringIdentifierArgument:
@@ -974,7 +947,7 @@ RSpec/BeforeAfterAll:
   Exclude:
     - 'spec/controllers/users_controller_spec.rb'
 
-# Offense count: 53
+# Offense count: 54
 # Configuration parameters: Prefixes, AllowedPatterns.
 # Prefixes: when, with, without
 RSpec/ContextWording:
@@ -1052,28 +1025,6 @@ RSpec/EmptyLineAfterHook:
 RSpec/ExampleLength:
   Max: 85
 
-# Offense count: 159
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: CustomTransform, IgnoredWords, DisallowedExamples.
-# DisallowedExamples: works
-RSpec/ExampleWording:
-  Exclude:
-    - 'spec/controllers/api/v1/architectures_controller_spec.rb'
-    - 'spec/controllers/api/v2/nested/resources_controller_spec.rb'
-    - 'spec/controllers/concerns_controller_spec.rb'
-    - 'spec/controllers/extended_controller_spec.rb'
-    - 'spec/controllers/included_param_group_controller_spec.rb'
-    - 'spec/controllers/users_controller_spec.rb'
-    - 'spec/lib/apipie/application_spec.rb'
-    - 'spec/lib/apipie/extractor/writer_spec.rb'
-    - 'spec/lib/apipie/method_description_spec.rb'
-    - 'spec/lib/apipie/param_description_spec.rb'
-    - 'spec/lib/apipie/param_group_spec.rb'
-    - 'spec/lib/apipie/resource_description_spec.rb'
-    - 'spec/lib/apipie/validator_spec.rb'
-    - 'spec/lib/swagger/swagger_dsl_spec.rb'
-    - 'spec/test_engine/memes_controller_spec.rb'
-
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 RSpec/ExcessiveDocstringSpacing:
@@ -1141,7 +1092,7 @@ RSpec/MessageSpies:
 RSpec/MultipleExpectations:
   Max: 19
 
-# Offense count: 160
+# Offense count: 163
 # Configuration parameters: AllowSubject.
 RSpec/MultipleMemoizedHelpers:
   Max: 15
@@ -1166,7 +1117,7 @@ RSpec/NamedSubject:
     - 'spec/lib/swagger/rake_swagger_spec.rb'
     - 'spec/lib/swagger/swagger_dsl_spec.rb'
 
-# Offense count: 96
+# Offense count: 97
 # Configuration parameters: AllowedGroups.
 RSpec/NestedGroups:
   Max: 6
@@ -1208,7 +1159,7 @@ RSpec/PredicateMatcher:
 # Offense count: 1
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: Inferences.
-RSpec/Rails/InferredSpecType:
+RSpecRails/InferredSpecType:
   Exclude:
     - 'spec/controllers/pets_controller_spec.rb'
 
@@ -1293,7 +1244,7 @@ Rails/NegateInclude:
     - 'lib/apipie/extractor/writer.rb'
     - 'spec/spec_helper.rb'
 
-# Offense count: 7
+# Offense count: 6
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: Include.
 # Include: app/**/*.rb, config/**/*.rb, db/**/*.rb, lib/**/*.rb
@@ -1371,21 +1322,6 @@ Style/AndOr:
   Exclude:
     - 'lib/apipie/param_description.rb'
 
-# Offense count: 18
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, AllowedMethods, AllowedPatterns, AllowBracesOnProceduralOneLiners, BracesRequiredMethods.
-# SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces
-# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
-# FunctionalMethods: let, let!, subject, watch
-# AllowedMethods: lambda, proc, it
-Style/BlockDelimiters:
-  Exclude:
-    - 'lib/tasks/apipie.rake'
-    - 'spec/controllers/users_controller_spec.rb'
-    - 'spec/dummy/app/controllers/pets_using_auto_views_controller.rb'
-    - 'spec/lib/apipie/extractor/writer_spec.rb'
-    - 'spec/lib/swagger/swagger_dsl_spec.rb'
-
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowOnConstant, AllowOnSelfClass.
@@ -1677,19 +1613,6 @@ Style/MultilineBlockChain:
   Exclude:
     - 'lib/apipie/param_description.rb'
 
-# Offense count: 7
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: literals, strict
-Style/MutableConstant:
-  Exclude:
-    - 'lib/apipie/extractor/recorder.rb'
-    - 'lib/apipie/generator/swagger/param_description/in.rb'
-    - 'lib/apipie/generator/swagger/type_extractor.rb'
-    - 'lib/apipie/generator/swagger/warning.rb'
-    - 'lib/apipie/routes_formatter.rb'
-    - 'lib/apipie/version.rb'
-
 # Offense count: 8
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
@@ -1921,7 +1844,7 @@ Style/StringConcatenation:
     - 'lib/apipie/application.rb'
     - 'lib/apipie/extractor/writer.rb'
 
-# Offense count: 1214
+# Offense count: 1229
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
 # SupportedStyles: single_quotes, double_quotes
@@ -2021,7 +1944,7 @@ Style/TrailingCommaInArrayLiteral:
     - 'spec/controllers/users_controller_spec.rb'
     - 'spec/dummy/app/controllers/pets_using_self_describing_classes_controller.rb'
 
-# Offense count: 4
+# Offense count: 5
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyleForMultiline.
 # SupportedStylesForMultiline: comma, consistent_comma, no_comma

data/CHANGELOG.md

@@ -1,6 +1,17 @@
  Changelog
 ===========
 
+## [v1.4.1](https://github.com/Apipie/apipie-rails/tree/v1.4.1) (2024-07-09)
+[Full Changelog](https://github.com/Apipie/apipie-rails/compare/v1.4.0...v1.4.1)
+* Fix multiple rubocop offenses via rubocop_challenger. (Mathieu Jobin)
+  * RSpec/ExampleWording (#913)
+  * Layout/FirstArrayElementIndentation (#914)
+  * Style/BlockDelimiters (#917)
+  * Style/MutableConstant (#916)
+  * Layout/InitialIndentation (#915)
+  * Performance/RegexpMatch (#918)
+* Fix CI: build green for modern ruby, rack, and rubocop-rspec (#939) (Murray Steele)
+
 ## [v1.4.0](https://github.com/Apipie/apipie-rails/tree/v1.4.0) (2024-05-30)
 [Full Changelog](https://github.com/Apipie/apipie-rails/compare/v1.3.0...v1.4.0)
 * Add Ruby 3.3.0 to CI build matrix (#906) Masato Nakamura

data/apipie-rails.gemspec

@@ -38,6 +38,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rubocop-rails'
   s.add_development_dependency 'rubocop-rspec'
   s.add_development_dependency 'rubocop-performance'
+  s.add_development_dependency 'rubocop-rspec_rails' if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new("2.7")
   s.add_development_dependency "simplecov"
   s.add_development_dependency "sqlite3"
 end

data/lib/apipie/error_description.rb

@@ -5,9 +5,7 @@ module Apipie
 
     def self.from_dsl_data(args)
       code_or_options, desc, options = args
-      Apipie::ErrorDescription.new(code_or_options,
-                                   desc,
-                                   options)
+      Apipie::ErrorDescription.new(code_or_options, desc, options)
     end
 
     def initialize(code_or_options, desc = nil, options = {})
@@ -17,9 +15,13 @@ module Apipie
         @metadata = code_or_options[:meta]
         @description = code_or_options[:desc] || code_or_options[:description]
       else
-        @code = 
+        @code =
           if code_or_options.is_a? Symbol
-            Rack::Utils::SYMBOL_TO_STATUS_CODE[code_or_options]
+            begin
+              Rack::Utils.status_code(code_or_options)
+            rescue ArgumentError
+              nil
+            end
           else
             code_or_options
           end

data/lib/apipie/extractor/recorder.rb

@@ -1,7 +1,7 @@
 module Apipie
   module Extractor
     class Recorder
-      MULTIPART_BOUNDARY = 'APIPIE_RECORDER_EXAMPLE_BOUNDARY'
+      MULTIPART_BOUNDARY = 'APIPIE_RECORDER_EXAMPLE_BOUNDARY'.freeze
 
       def initialize
         @ignored_params = [:controller, :action]
@@ -14,12 +14,12 @@ module Apipie
         @params = Rack::Utils.parse_nested_query(@query)
         @params.merge!(env["action_dispatch.request.request_parameters"] || {})
         rack_input = env["rack.input"]
-        if data = parse_data(rack_input.read)
+        if data = parse_data(rack_input&.read)
           @request_data = data
         elsif form_hash = env["rack.request.form_hash"]
           @request_data = reformat_multipart_data(form_hash)
         end
-        rack_input.rewind
+        rack_input&.rewind
       end
 
       def analyse_controller(controller)

data/lib/apipie/extractor/writer.rb

@@ -324,7 +324,7 @@ module Apipie
           desc ||= case @action.to_s
                    when "show", "create", "update", "destroy"
                      name = name.singularize
-                     "#{@action.capitalize} #{name =~ /^[aeiou]/ ? 'an' : 'a'} #{name}"
+                     "#{@action.capitalize} #{/^[aeiou]/.match?(name) ? 'an' : 'a'} #{name}"
                    when "index"
                      "List #{name}"
                    end
@@ -341,7 +341,7 @@ module Apipie
         params.sort_by {|n,_| n }.each do |(name, desc)|
           desc[:type] = (desc[:type] && desc[:type].first) || Object
           code << "#{indent}param"
-          if name =~ /\W/
+          if /\W/.match?(name)
             code << " :'#{name}'"
           else
             code << " :#{name}"
@@ -397,7 +397,7 @@ module Apipie
         lines_to_add = []
         block_level = 0
         ensure_line_breaks(controller_content.lines).first(action_line).reverse_each do |line|
-          if line =~ /\s*\bend\b\s*/
+          if /\s*\bend\b\s*/.match?(line)
             block_level += 1
           end
           if block_level > 0
@@ -405,10 +405,10 @@ module Apipie
           else
             added_lines << line
           end
-          if line =~ /\s*\b(module|class|def)\b /
+          if /\s*\b(module|class|def)\b /.match?(line)
             break
           end
-          next unless line =~ /do\s*(\|.*?\|)?\s*$/
+          next unless /do\s*(\|.*?\|)?\s*$/.match?(line)
           block_level -= 1
           if block_level == 0
             added_lines.concat(lines_to_add)
@@ -426,7 +426,7 @@ module Apipie
       #   https://github.com/puppetlabs/puppet/blob/0dc44695/lib/puppet/util/monkey_patches.rb
       def ensure_line_breaks(lines)
         if lines.to_a.size > 1 && lines.first !~ /\n\Z/
-          lines.map { |l| l !~ /\n\Z/ ? (l << "\n") : l }.to_enum
+          lines.map { |l| !/\n\Z/.match?(l) ? (l << "\n") : l }.to_enum
         else
           lines
         end

data/lib/apipie/generator/swagger/param_description/in.rb

@@ -2,7 +2,7 @@ class Apipie::Generator::Swagger::ParamDescription::In
   IN_KEYWORD_DEFAULT_VALUES = {
     form_data: 'formData',
     query: 'query'
-  }
+  }.freeze
 
   def initialize(param_description, in_schema:, default_in_value:, http_method:)
     @param_description = param_description

data/lib/apipie/generator/swagger/type_extractor.rb

@@ -18,7 +18,7 @@ class Apipie::Generator::Swagger::TypeExtractor
     date: Apipie::Generator::Swagger::Type.new('string', 'date'),
     dateTime: Apipie::Generator::Swagger::Type.new('string', 'date-time'),
     password: Apipie::Generator::Swagger::Type.new('string', 'password')
-  }
+  }.freeze
 
   # @param [Apipie::Validator::BaseValidator, ResponseDescriptionAdapter::PropDesc::Validator, nil] validator
   def initialize(validator)

data/lib/apipie/generator/swagger/warning.rb

@@ -17,7 +17,7 @@ class Apipie::Generator::Swagger::Warning
     optional_without_default_value: OPTIONAL_WITHOUT_DEFAULT_VALUE_CODE,
     param_ignored_in_form_data: PARAM_IGNORED_IN_FORM_DATA_CODE,
     path_param_not_described_code: PATH_PARAM_NOT_DESCRIBED_CODE
-  }
+  }.freeze
 
   MESSAGES = {
     MISSING_METHOD_SUMMARY_CODE => "Missing short description for method",
@@ -28,7 +28,7 @@ class Apipie::Generator::Swagger::Warning
     OPTIONAL_WITHOUT_DEFAULT_VALUE_CODE => "The parameter :%{parameter} is optional but default value is not specified (use :default_value => ...)",
     PARAM_IGNORED_IN_FORM_DATA_CODE => "Ignoring param :%{parameter} -- cannot include Hash without fields in a formData specification",
     PATH_PARAM_NOT_DESCRIBED_CODE => "The parameter :%{name} appears in the path %{path} but is not described"
-  }
+  }.freeze
 
   attr_reader :code
 

data/lib/apipie/helpers.rb

@@ -27,7 +27,7 @@ module Apipie
       end
       path = path.sub(%r{^/},"")
       ret = "#{@url_prefix}/#{path}"
-      ret.insert(0,"/") unless ret =~ %r{\A[./]}
+      ret.insert(0,"/") unless %r{\A[./]}.match?(ret)
       ret.sub!(%r{/*\Z},"")
       ret
     end

data/lib/apipie/response_description.rb

@@ -88,11 +88,16 @@ module Apipie
 
       @method_description = method_description
 
-      if code.is_a? Symbol
-        @code = Rack::Utils::SYMBOL_TO_STATUS_CODE[code]
-      else
-        @code = code
-      end
+      @code =
+        if code.is_a? Symbol
+          begin
+            Rack::Utils.status_code(code)
+          rescue ArgumentError
+            nil
+          end
+        else
+          code
+        end
 
       @description = options[:desc]
       if @description.nil?

data/lib/apipie/routes_formatter.rb

@@ -1,6 +1,6 @@
 module Apipie
   class RoutesFormatter
-    API_METHODS = %w{GET POST PUT PATCH OPTIONS DELETE}
+    API_METHODS = %w{GET POST PUT PATCH OPTIONS DELETE}.freeze
 
     # The entry method called by Apipie to extract the array
     # representing the api dsl from the routes definition.

data/lib/apipie/version.rb

@@ -1,3 +1,3 @@
 module Apipie
-  VERSION = "1.4.0"
+  VERSION = "1.4.1".freeze
 end

data/lib/tasks/apipie.rake

@@ -70,17 +70,17 @@ namespace :apipie do
     with_loaded_documentation do
       out = ENV["OUT_REF"] || File.join(Rails.root, Apipie.configuration.doc_path, 'apidoc_ref')
       paths = generate_swagger_using_args(args, out)
-      paths.each {|path|
+      paths.each do |path|
         existing_files_in_dir = Pathname(out).children(true)
 
         make_reference = false
 
         # reference filenames have the format <basename>.<counter>.swagger_ref
-        reference_files = existing_files_in_dir.select{|f|
+        reference_files = existing_files_in_dir.select do |f|
               f.extname == '.swagger_ref' &&
               f.basename.sub_ext("").extname.delete('.').to_i > 0 &&
               f.basename.sub_ext("").sub_ext("") == path.basename.sub_ext("")
-        }
+        end
         if reference_files.empty?
           print "Reference file does not exist for [#{path}]\n"
           counter = 1
@@ -111,7 +111,7 @@ namespace :apipie do
         if reference_files.length > num_refs_to_keep
           (reference_files - reference_files[-num_refs_to_keep..-1]).each(&:delete)
         end
-      }
+      end
     end
   end
 

data/spec/controllers/api/v1/architectures_controller_spec.rb

@@ -4,7 +4,7 @@ describe Api::V1::ArchitecturesController do
   describe "resource description" do
     subject { Apipie.get_resource_description(Api::V1::ArchitecturesController, "1.0") }
 
-    it "should be version 1.0" do
+    it "is version 1.0" do
       expect(subject._version).to eq('1.0')
 
       expect(Apipie.resource_descriptions['1.0'].size).to eq(2)
@@ -14,11 +14,11 @@ describe Api::V1::ArchitecturesController do
     context "there is another version" do
       let(:v2) { archv2 = Apipie.get_resource_description(Api::V2::ArchitecturesController, "2.0") }
 
-      it "should have unique doc url" do
+      it "has unique doc url" do
         expect(subject.doc_url).not_to eq(v2.doc_url)
       end
 
-      it "should have unique methods" do
+      it "has unique methods" do
         expect(subject._methods.keys).to include(:index)
         expect(v2._methods.keys).to include(:index)
         expect(subject._methods[:index]).not_to eq(v2._methods[:index])

data/spec/controllers/api/v2/nested/resources_controller_spec.rb

@@ -20,7 +20,7 @@ describe Api::V2::Nested::ResourcesController do
   describe '.get_resource_id' do
     subject { Apipie.get_resource_id(Api::V2::Nested::ResourcesController) }
 
-    it "should have resource_id set" do
+    it "has resource_id set" do
       expect(subject).to eq("resource")
     end
   end

data/spec/controllers/concerns_controller_spec.rb

@@ -7,12 +7,12 @@ describe ConcernsController do
     expect(Apipie["concern_resources#show"]).to be
   end
 
-  it "should reply to valid request" do
+  it "replies to valid request" do
     get :show, :params => { :id => '5' }, :session => { :user_id => "secret_hash" }
     assert_response :success
   end
 
-  it "should pass if required parameter is missing" do
+  it "passes if required parameter is missing" do
     expect { get :show, :params => { :id => '5' } }.not_to raise_error
   end
 

data/spec/controllers/extended_controller_spec.rb

@@ -2,13 +2,13 @@ require "spec_helper"
 
 describe ExtendedController do
 
-  it 'should include params from both original controller and extending concern' do
+  it 'includes params from both original controller and extending concern' do
     expect(Apipie["extended#create"].params.keys).to eq [:oauth, :user, :admin]
     user_param = Apipie["extended#create"].params[:user]
     expect(user_param.validator.params_ordered.map(&:name)).to eq [:name, :password, :from_concern]
   end
 
-  it 'should include updated metadata' do
+  it 'includes updated metadata' do
     expect(Apipie['extended#create'].metadata).to eq metadata: 'data'
   end
 end

data/spec/controllers/included_param_group_controller_spec.rb

@@ -5,7 +5,7 @@ describe IncludedParamGroupController do
 
   let(:dsl_data) { ActionController::Base.send(:_apipie_dsl_data_init) }
 
-  it "should not error when there is a param_group that is deeply nested in response description" do
+  it "does not error when there is a param_group that is deeply nested in response description" do
     subject = Apipie.get_resource_description(IncludedParamGroupController, Apipie.configuration.default_version)
     expect(subject._methods.keys).to include(:show)
   end