apipie-rails 0.9.3 → 0.9.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5c985a0a0a96f041421d812221f6352f69fb32eb93ec6a6bb4a990b2151a39f8
-  data.tar.gz: 3d21ade5a4dfb08bc0faaf5c46fa8fe5e7cf294f14d9ee637c3e019b522f5bbf
+  metadata.gz: 6b80c8d9148eb30ad409dcbd396a7b48a55f168c9f64f3dbc699bf11ba2f5a71
+  data.tar.gz: 7530489978c584ec75e533c913acf179a76ed0b6ee9c8fa5a0947f8c163cb07d
 SHA512:
-  metadata.gz: 907ba718cd32695e13ce42203d639891de031221f90475712b2c7e816b1db7304174922ea796d2a31cdc4050f768871b06c3e9efc968e4db447400531ad0ca45
-  data.tar.gz: 234ba3b4eab287d9530e09ae28c79821a509c4c57f8b42b1bf2da83d93141d3fb807c88cef97d9a889c4e4b1a70a94d41f92a2f5c6bf0e79f8c9ad3a65aa9f50
+  metadata.gz: 2c1fd67f999a263c2d1655eaf5e7424ef7c98b6bb269b9f54ace1f201cad01447f769dc2ec83ba3d8ec60057f28ee2661e849061a22af49514fd03f1cbc7d75f
+  data.tar.gz: 7fbdd5e6bd529f66327346986ec8ba093518b1e94281da7a4f72c05cc00d1b64090736f70681b1142a9489fbb0f41a1956d9ef72b3f7b65694d8c59fa0831cc0

data/.github/workflows/rubocop.yml

@@ -10,10 +10,10 @@ jobs:
     steps:
       - uses: actions/checkout@v3
 
-      - name: Set up Ruby 2.7
+      - name: Set up Ruby 3.2.1
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 2.7
+          ruby-version: 3.2.1
           bundler-cache: true
 
       - name: Run rubocop

data/.rubocop.yml

@@ -55,6 +55,9 @@ Naming/PredicateName:
   AllowedMethods:
     - have_field?
 
+Style/IfUnlessModifier:
+  Enabled: false
+
 Style/NumericPredicate:
   Enabled: false
 
@@ -113,6 +116,18 @@ Style/Documentation:
     - spec/lib/validators/array_validator_spec.rb
     - spec/dummy/**/*.rb
 
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+Style/InverseMethods:
+  Enabled: false
+
 Naming/BlockForwarding:
   EnforcedStyle: explicit
   BlockForwardingName: block
+
+Lint/MissingSuper:
+  Exclude:
+    - 'lib/apipie/errors.rb'
+    - 'lib/apipie/response_description_adapter.rb'
+    - 'lib/apipie/validator.rb'

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --exclude-limit 180`
-# on 2023-03-06 23:34:08 UTC using RuboCop version 1.48.0.
+# on 2023-04-03 23:33:58 UTC using RuboCop version 1.49.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -521,33 +521,6 @@ Layout/SpaceAfterNot:
     - 'lib/apipie/extractor/collector.rb'
     - 'lib/apipie/extractor/writer.rb'
 
-# Offense count: 35
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: space, no_space
-Layout/SpaceAroundEqualsInParameterDefault:
-  Exclude:
-    - 'app/helpers/apipie_helper.rb'
-    - 'lib/apipie/apipie_module.rb'
-    - 'lib/apipie/application.rb'
-    - 'lib/apipie/dsl_definition.rb'
-    - 'lib/apipie/error_description.rb'
-    - 'lib/apipie/method_description.rb'
-    - 'lib/apipie/response_description.rb'
-    - 'lib/apipie/response_description_adapter.rb'
-    - 'lib/apipie/rspec/response_validation_helper.rb'
-    - 'lib/apipie/swagger_generator.rb'
-    - 'lib/apipie/validator.rb'
-    - 'lib/tasks/apipie.rake'
-    - 'spec/lib/swagger/swagger_dsl_spec.rb'
-    - 'spec/spec_helper.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Layout/SpaceAroundMethodCallOperator:
-  Exclude:
-    - 'lib/apipie/validator.rb'
-
 # Offense count: 142
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator.
@@ -738,13 +711,6 @@ Lint/IdentityComparison:
   Exclude:
     - 'spec/lib/swagger/swagger_dsl_spec.rb'
 
-# Offense count: 5
-Lint/MissingSuper:
-  Exclude:
-    - 'lib/apipie/errors.rb'
-    - 'lib/apipie/response_description_adapter.rb'
-    - 'lib/apipie/validator.rb'
-
 # Offense count: 11
 # This cop supports unsafe autocorrection (--autocorrect-all).
 Lint/NonAtomicFileOperation:
@@ -998,11 +964,10 @@ Performance/RedundantMerge:
     - 'lib/apipie/generator/swagger/param_description/type.rb'
     - 'lib/apipie/middleware/checksum_in_headers.rb'
 
-# Offense count: 8
+# Offense count: 7
 # This cop supports safe autocorrection (--autocorrect).
 Performance/RegexpMatch:
   Exclude:
-    - 'app/controllers/apipie/apipies_controller.rb'
     - 'lib/apipie/extractor/writer.rb'
     - 'lib/apipie/helpers.rb'
 
@@ -1014,12 +979,6 @@ Performance/StringIdentifierArgument:
     - 'spec/controllers/users_controller_spec.rb'
     - 'spec/lib/apipie/method_description_spec.rb'
 
-# Offense count: 2
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Performance/StringInclude:
-  Exclude:
-    - 'app/controllers/apipie/apipies_controller.rb'
-
 # Offense count: 7
 # This cop supports safe autocorrection (--autocorrect).
 Performance/StringReplacement:
@@ -1121,15 +1080,6 @@ RSpec/EmptyExampleGroup:
   Exclude:
     - 'spec/lib/apipie/generator/swagger/param_description/composite_spec.rb'
 
-# Offense count: 11
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowConsecutiveOneLiners.
-RSpec/EmptyLineAfterExample:
-  Exclude:
-    - 'spec/lib/apipie/apipies_controller_spec.rb'
-    - 'spec/lib/apipie/generator/swagger/context_spec.rb'
-    - 'spec/lib/swagger/swagger_dsl_spec.rb'
-
 # Offense count: 6
 # This cop supports safe autocorrection (--autocorrect).
 RSpec/EmptyLineAfterExampleGroup:
@@ -1254,7 +1204,7 @@ RSpec/MessageSpies:
 RSpec/MultipleExpectations:
   Max: 19
 
-# Offense count: 64
+# Offense count: 66
 # Configuration parameters: AllowSubject.
 RSpec/MultipleMemoizedHelpers:
   Max: 15
@@ -1479,14 +1429,6 @@ Rails/RootPathnameMethods:
     - 'spec/lib/rake_spec.rb'
     - 'spec/lib/swagger/rake_swagger_spec.rb'
 
-# Offense count: 4
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: strict, flexible
-Rails/TimeZone:
-  Exclude:
-    - 'lib/tasks/apipie.rake'
-
 # Offense count: 1
 # This cop supports unsafe autocorrection (--autocorrect-all).
 Security/IoMethods:
@@ -1720,153 +1662,6 @@ Style/For:
 Style/FormatStringToken:
   EnforcedStyle: template
 
-# Offense count: 140
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: always, always_true, never
-Style/FrozenStringLiteralComment:
-  Exclude:
-    - 'Rakefile'
-    - 'apipie-rails.gemspec'
-    - 'app/controllers/apipie/apipies_controller.rb'
-    - 'app/helpers/apipie_helper.rb'
-    - 'lib/apipie-rails.rb'
-    - 'lib/apipie/apipie_module.rb'
-    - 'lib/apipie/application.rb'
-    - 'lib/apipie/configuration.rb'
-    - 'lib/apipie/core_ext/route.rb'
-    - 'lib/apipie/dsl_definition.rb'
-    - 'lib/apipie/error_description.rb'
-    - 'lib/apipie/errors.rb'
-    - 'lib/apipie/extractor.rb'
-    - 'lib/apipie/extractor/collector.rb'
-    - 'lib/apipie/extractor/recorder.rb'
-    - 'lib/apipie/extractor/writer.rb'
-    - 'lib/apipie/generator/generator.rb'
-    - 'lib/apipie/generator/swagger/context.rb'
-    - 'lib/apipie/generator/swagger/operation_id.rb'
-    - 'lib/apipie/generator/swagger/param_description.rb'
-    - 'lib/apipie/generator/swagger/param_description/builder.rb'
-    - 'lib/apipie/generator/swagger/param_description/composite.rb'
-    - 'lib/apipie/generator/swagger/param_description/description.rb'
-    - 'lib/apipie/generator/swagger/param_description/in.rb'
-    - 'lib/apipie/generator/swagger/param_description/name.rb'
-    - 'lib/apipie/generator/swagger/param_description/type.rb'
-    - 'lib/apipie/generator/swagger/swagger.rb'
-    - 'lib/apipie/generator/swagger/type.rb'
-    - 'lib/apipie/generator/swagger/type_extractor.rb'
-    - 'lib/apipie/generator/swagger/warning.rb'
-    - 'lib/apipie/generator/swagger/warning_writer.rb'
-    - 'lib/apipie/helpers.rb'
-    - 'lib/apipie/markup.rb'
-    - 'lib/apipie/method_description.rb'
-    - 'lib/apipie/method_description/api.rb'
-    - 'lib/apipie/method_description/apis_service.rb'
-    - 'lib/apipie/middleware/checksum_in_headers.rb'
-    - 'lib/apipie/param_description.rb'
-    - 'lib/apipie/railtie.rb'
-    - 'lib/apipie/resource_description.rb'
-    - 'lib/apipie/response_description.rb'
-    - 'lib/apipie/response_description_adapter.rb'
-    - 'lib/apipie/routes_formatter.rb'
-    - 'lib/apipie/routing.rb'
-    - 'lib/apipie/rspec/response_validation_helper.rb'
-    - 'lib/apipie/see_description.rb'
-    - 'lib/apipie/static_dispatcher.rb'
-    - 'lib/apipie/swagger_generator.rb'
-    - 'lib/apipie/tag_list_description.rb'
-    - 'lib/apipie/validator.rb'
-    - 'lib/apipie/version.rb'
-    - 'lib/generators/apipie/install/install_generator.rb'
-    - 'lib/generators/apipie/views_generator.rb'
-    - 'lib/tasks/apipie.rake'
-    - 'spec/controllers/api/v1/architectures_controller_spec.rb'
-    - 'spec/controllers/api/v2/architectures_controller_spec.rb'
-    - 'spec/controllers/api/v2/nested/resources_controller_spec.rb'
-    - 'spec/controllers/concerns_controller_spec.rb'
-    - 'spec/controllers/extended_controller_spec.rb'
-    - 'spec/controllers/included_param_group_controller_spec.rb'
-    - 'spec/controllers/pets_controller_spec.rb'
-    - 'spec/controllers/users_controller_spec.rb'
-    - 'spec/dummy/Rakefile'
-    - 'spec/dummy/app/controllers/api/base_controller.rb'
-    - 'spec/dummy/app/controllers/api/v1/architectures_controller.rb'
-    - 'spec/dummy/app/controllers/api/v1/base_controller.rb'
-    - 'spec/dummy/app/controllers/api/v2/architectures_controller.rb'
-    - 'spec/dummy/app/controllers/api/v2/base_controller.rb'
-    - 'spec/dummy/app/controllers/api/v2/nested/architectures_controller.rb'
-    - 'spec/dummy/app/controllers/api/v2/nested/resources_controller.rb'
-    - 'spec/dummy/app/controllers/application_controller.rb'
-    - 'spec/dummy/app/controllers/concerns_controller.rb'
-    - 'spec/dummy/app/controllers/extended_controller.rb'
-    - 'spec/dummy/app/controllers/extending_concern.rb'
-    - 'spec/dummy/app/controllers/files_controller.rb'
-    - 'spec/dummy/app/controllers/included_param_group_controller.rb'
-    - 'spec/dummy/app/controllers/overridden_concerns_controller.rb'
-    - 'spec/dummy/app/controllers/pets_controller.rb'
-    - 'spec/dummy/app/controllers/pets_using_auto_views_controller.rb'
-    - 'spec/dummy/app/controllers/pets_using_self_describing_classes_controller.rb'
-    - 'spec/dummy/app/controllers/sample_controller.rb'
-    - 'spec/dummy/app/controllers/tagged_cats_controller.rb'
-    - 'spec/dummy/app/controllers/tagged_dogs_controller.rb'
-    - 'spec/dummy/app/controllers/twitter_example_controller.rb'
-    - 'spec/dummy/app/controllers/users_controller.rb'
-    - 'spec/dummy/app/helpers/random_param_group.rb'
-    - 'spec/dummy/components/test_engine/Gemfile'
-    - 'spec/dummy/components/test_engine/app/controllers/test_engine/application_controller.rb'
-    - 'spec/dummy/components/test_engine/app/controllers/test_engine/memes_controller.rb'
-    - 'spec/dummy/components/test_engine/config/routes.rb'
-    - 'spec/dummy/components/test_engine/lib/test_engine.rb'
-    - 'spec/dummy/components/test_engine/test_engine.gemspec'
-    - 'spec/dummy/config.ru'
-    - 'spec/dummy/config/application.rb'
-    - 'spec/dummy/config/boot.rb'
-    - 'spec/dummy/config/environment.rb'
-    - 'spec/dummy/config/environments/development.rb'
-    - 'spec/dummy/config/environments/production.rb'
-    - 'spec/dummy/config/environments/test.rb'
-    - 'spec/dummy/config/initializers/apipie.rb'
-    - 'spec/dummy/config/initializers/backtrace_silencers.rb'
-    - 'spec/dummy/config/initializers/inflections.rb'
-    - 'spec/dummy/config/initializers/mime_types.rb'
-    - 'spec/dummy/config/initializers/secret_token.rb'
-    - 'spec/dummy/config/initializers/session_store.rb'
-    - 'spec/dummy/config/routes.rb'
-    - 'spec/dummy/script/rails'
-    - 'spec/lib/apipie/apipies_controller_spec.rb'
-    - 'spec/lib/apipie/application_spec.rb'
-    - 'spec/lib/apipie/extractor/recorder/middleware_spec.rb'
-    - 'spec/lib/apipie/extractor/writer_spec.rb'
-    - 'spec/lib/apipie/extractor_spec.rb'
-    - 'spec/lib/apipie/file_handler_spec.rb'
-    - 'spec/lib/apipie/generator/swagger/context_spec.rb'
-    - 'spec/lib/apipie/generator/swagger/operation_id_spec.rb'
-    - 'spec/lib/apipie/generator/swagger/param_description/builder_spec.rb'
-    - 'spec/lib/apipie/generator/swagger/param_description/composite_spec.rb'
-    - 'spec/lib/apipie/generator/swagger/param_description/description_spec.rb'
-    - 'spec/lib/apipie/generator/swagger/param_description/in_spec.rb'
-    - 'spec/lib/apipie/generator/swagger/param_description/name_spec.rb'
-    - 'spec/lib/apipie/generator/swagger/param_description/type_spec.rb'
-    - 'spec/lib/apipie/generator/swagger/param_description_spec.rb'
-    - 'spec/lib/apipie/generator/swagger/type_extractor_spec.rb'
-    - 'spec/lib/apipie/generator/swagger/warning_spec.rb'
-    - 'spec/lib/apipie/generator/swagger/warning_writer_spec.rb'
-    - 'spec/lib/apipie/method_description/apis_service_spec.rb'
-    - 'spec/lib/apipie/method_description_spec.rb'
-    - 'spec/lib/apipie/param_description/deprecation_spec.rb'
-    - 'spec/lib/apipie/param_description_spec.rb'
-    - 'spec/lib/apipie/param_group_spec.rb'
-    - 'spec/lib/apipie/resource_description_spec.rb'
-    - 'spec/lib/apipie/validator_spec.rb'
-    - 'spec/lib/rake_spec.rb'
-    - 'spec/lib/swagger/rake_swagger_spec.rb'
-    - 'spec/lib/swagger/swagger_dsl_spec.rb'
-    - 'spec/lib/validators/array_validator_spec.rb'
-    - 'spec/spec_helper.rb'
-    - 'spec/support/custom_bool_validator.rb'
-    - 'spec/support/rake.rb'
-    - 'spec/test_engine/memes_controller_spec.rb'
-
 # Offense count: 34
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: MinBodyLength, AllowConsecutiveConditionals.
@@ -1920,35 +1715,6 @@ Style/IfInsideElse:
     - 'lib/apipie/swagger_generator.rb'
     - 'spec/spec_helper.rb'
 
-# Offense count: 73
-# This cop supports safe autocorrection (--autocorrect).
-Style/IfUnlessModifier:
-  Exclude:
-    - 'app/controllers/apipie/apipies_controller.rb'
-    - 'lib/apipie/application.rb'
-    - 'lib/apipie/dsl_definition.rb'
-    - 'lib/apipie/extractor.rb'
-    - 'lib/apipie/extractor/collector.rb'
-    - 'lib/apipie/extractor/writer.rb'
-    - 'lib/apipie/generator/swagger/param_description/composite.rb'
-    - 'lib/apipie/generator/swagger/param_description/type.rb'
-    - 'lib/apipie/generator/swagger/type_extractor.rb'
-    - 'lib/apipie/generator/swagger/warning.rb'
-    - 'lib/apipie/method_description.rb'
-    - 'lib/apipie/param_description.rb'
-    - 'lib/apipie/resource_description.rb'
-    - 'lib/apipie/routes_formatter.rb'
-    - 'lib/apipie/rspec/response_validation_helper.rb'
-    - 'lib/apipie/see_description.rb'
-    - 'lib/apipie/swagger_generator.rb'
-    - 'lib/apipie/validator.rb'
-    - 'lib/tasks/apipie.rake'
-    - 'spec/dummy/app/controllers/application_controller.rb'
-    - 'spec/dummy/app/controllers/users_controller.rb'
-    - 'spec/dummy/config/initializers/apipie.rb'
-    - 'spec/lib/swagger/swagger_dsl_spec.rb'
-    - 'spec/spec_helper.rb'
-
 # Offense count: 4
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: AllowedMethods.
@@ -1959,20 +1725,6 @@ Style/IfWithBooleanLiteralBranches:
     - 'lib/apipie/validator.rb'
     - 'lib/tasks/apipie.rake'
 
-# Offense count: 13
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: InverseMethods, InverseBlocks.
-Style/InverseMethods:
-  Exclude:
-    - 'lib/apipie/configuration.rb'
-    - 'lib/apipie/extractor/collector.rb'
-    - 'lib/apipie/extractor/writer.rb'
-    - 'lib/apipie/generator/swagger/warning.rb'
-    - 'lib/apipie/method_description.rb'
-    - 'lib/apipie/param_description.rb'
-    - 'lib/apipie/swagger_generator.rb'
-    - 'spec/spec_helper.rb'
-
 # Offense count: 5
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
@@ -2146,16 +1898,6 @@ Style/RedundantConditional:
     - 'lib/apipie/validator.rb'
     - 'lib/tasks/apipie.rake'
 
-# Offense count: 9
-# This cop supports safe autocorrection (--autocorrect).
-Style/RedundantConstantBase:
-  Exclude:
-    - 'lib/tasks/apipie.rake'
-    - 'spec/dummy/config.ru'
-    - 'spec/lib/rake_spec.rb'
-    - 'spec/lib/swagger/rake_swagger_spec.rb'
-    - 'spec/spec_helper.rb'
-
 # Offense count: 5
 # This cop supports unsafe autocorrection (--autocorrect-all).
 Style/RedundantInterpolation:
@@ -2219,21 +1961,6 @@ Style/RedundantStringEscape:
   Exclude:
     - 'spec/dummy/app/controllers/users_controller.rb'
 
-# Offense count: 12
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
-# SupportedStyles: slashes, percent_r, mixed
-Style/RegexpLiteral:
-  Exclude:
-    - 'lib/apipie/extractor.rb'
-    - 'lib/apipie/extractor/collector.rb'
-    - 'lib/apipie/extractor/recorder.rb'
-    - 'lib/apipie/generator/swagger/operation_id.rb'
-    - 'lib/apipie/helpers.rb'
-    - 'lib/apipie/routing.rb'
-    - 'lib/apipie/swagger_generator.rb'
-    - 'lib/tasks/apipie.rake'
-
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.

data/CHANGELOG.md

@@ -4,6 +4,12 @@
 Also deleted the `Gemfile` that was now a broken symlink.
 please use `export BUNDLE_GEMFILE='gemfiles/Gemfile.rails61'; bundle exec rspec` to run the test suite
 
+## [v0.9.4](https://github.com/Apipie/apipie-rails/tree/v0.9.4) (2023-04-11)
+[Full Changelog](https://github.com/Apipie/apipie-rails/compare/v0.9.3...v0.9.4)
+* [Fix] Separate nested resource name [#855](https://github.com/Apipie/apipie-rails/pull/855)[#455](https://github.com/Apipie/apipie-rails/issues/455) (Panos Dalitsouris)
+* [Rubocop] Disable a few Rubocop Rules, run Rubocop with ruby 3.2 [#851](https://github.com/Apipie/apipie-rails/pull/851)[#853](https://github.com/Apipie/apipie-rails/pull/853)[#840](https://github.com/Apipie/apipie-rails/pull/840)[#841](https://github.com/Apipie/apipie-rails/pull/841) (Panos Dalitsouris)
+* [Rubocop] More Rubocop Auto corrections [#858](https://github.com/Apipie/apipie-rails/pull/858)[#849](https://github.com/Apipie/apipie-rails/pull/849)[#850](https://github.com/Apipie/apipie-rails/pull/850)[#844](https://github.com/Apipie/apipie-rails/pull/844)[#846](https://github.com/Apipie/apipie-rails/pull/846)[#834](https://github.com/Apipie/apipie-rails/pull/834)[#847](https://github.com/Apipie/apipie-rails/pull/847) (Rubocop Challenger)
+
 ## [v0.9.3](https://github.com/Apipie/apipie-rails/tree/v0.9.3) (2023-03-08)
 [Full Changelog](https://github.com/Apipie/apipie-rails/compare/v0.9.2...v0.9.3)
 * [Feature] Allow Apipie::ParamDescription to be marked as deprecated [#819](https://github.com/Apipie/apipie-rails/pull/819)[#811](https://github.com/Apipie/apipie-rails/pull/811) (Panos Dalitsouris)

data/app/controllers/apipie/apipies_controller.rb

@@ -155,7 +155,7 @@ module Apipie
     def render_from_cache
       path = Apipie.configuration.doc_base_url.dup
       # some params can contain dot, but only one in row
-      if [:resource, :method, :format, :version].any? { |p| params[p].to_s.gsub(".", "") =~ /\W/ || params[p].to_s =~ /\.\./ }
+      if [:resource, :method, :format, :version].any? { |p| params[p].to_s.gsub(".", "") =~ /\W/ || params[p].to_s.include?('..') }
         head :bad_request and return
       end
 
@@ -171,7 +171,7 @@ module Apipie
       # we sanitize the params before so in ideal case, this condition
       # will be never satisfied. It's here for cases somebody adds new
       # param into the path later and forgets about sanitation.
-      if path =~ /\.\./
+      if path.include?('..')
         head :bad_request and return
       end
 

data/app/helpers/apipie_helper.rb

@@ -1,7 +1,7 @@
 module ApipieHelper
   include ActionView::Helpers::TagHelper
 
-  def heading(title, level=1)
+  def heading(title, level = 1)
     content_tag("h#{level}") do
       title
     end

data/lib/apipie/apipie_module.rb

@@ -13,7 +13,7 @@ module Apipie
     app.to_json(version, resource_name, method_name, lang)
   end
 
-  def self.to_swagger_json(version = nil, resource_name = nil, method_name = nil, lang = nil, clear_warnings=true)
+  def self.to_swagger_json(version = nil, resource_name = nil, method_name = nil, lang = nil, clear_warnings = true)
     version ||= Apipie.configuration.default_version
     app.to_swagger_json(version, resource_name, method_name, lang, clear_warnings)
   end
@@ -24,7 +24,7 @@ module Apipie
     app.json_schema_for_method_response(version, controller_name, method_name, return_code, allow_nulls)
   end
 
-  def self.json_schema_for_self_describing_class(cls, allow_nulls=true)
+  def self.json_schema_for_self_describing_class(cls, allow_nulls = true)
     app.json_schema_for_self_describing_class(cls, allow_nulls)
   end
 

data/lib/apipie/application.rb

@@ -268,7 +268,7 @@ module Apipie
       @swagger_generator.json_schema_for_self_describing_class(cls, allow_nulls)
     end
 
-    def to_swagger_json(version, resource_name, method_name, lang, clear_warnings=false)
+    def to_swagger_json(version, resource_name, method_name, lang, clear_warnings = false)
       return unless valid_search_args?(version, resource_name, method_name)
 
       # if resource_name is blank, take just resources which have some methods because
@@ -375,8 +375,18 @@ module Apipie
         @controller_to_resource_id[klass]
       elsif Apipie.configuration.namespaced_resources? && klass.respond_to?(:controller_path)
         return nil if klass == ActionController::Base
+
+        version_prefix = version_prefix(klass)
         path = klass.controller_path
-        path.gsub(version_prefix(klass), "").gsub("/", "-")
+
+        path =
+          if version_prefix == '/'
+            path
+          else
+            path.gsub(version_prefix, '')
+          end
+
+        path.gsub('/', '-')
       elsif klass.respond_to?(:controller_name)
         return nil if klass == ActionController::Base
         klass.controller_name

data/lib/apipie/dsl_definition.rb

@@ -96,7 +96,7 @@ module Apipie
       #   # load paths from routes and don't provide description
       #   api
       #
-      def api(method, path, desc = nil, options={}) #:doc:
+      def api(method, path, desc = nil, options = {}) #:doc:
         return unless Apipie.active_dsl?
         _apipie_dsl_data[:api] = true
         _apipie_dsl_data[:api_args] << [method, path, desc, options]
@@ -105,7 +105,7 @@ module Apipie
       #   # load paths from routes
       #   api! "short description",
       #
-      def api!(desc = nil, options={}) #:doc:
+      def api!(desc = nil, options = {}) #:doc:
         return unless Apipie.active_dsl?
         _apipie_dsl_data[:api] = true
         _apipie_dsl_data[:api_from_routes] = { :desc => desc, :options =>options }
@@ -218,7 +218,7 @@ module Apipie
       #     puts "hello world"
       #   end
       #
-      def error(code_or_options, desc=nil, options={}) #:doc:
+      def error(code_or_options, desc = nil, options = {}) #:doc:
         return unless Apipie.active_dsl?
         _apipie_dsl_data[:errors] << [code_or_options, desc, options]
       end
@@ -403,7 +403,7 @@ module Apipie
       #     render json: {user: {name: "Alfred"}}
       #   end
       #
-      def returns(pgroup_or_options, desc_or_options=nil, options={}, &block) #:doc:
+      def returns(pgroup_or_options, desc_or_options = nil, options = {}, &block) #:doc:
         return unless Apipie.active_dsl?
 
 

data/lib/apipie/error_description.rb

@@ -10,7 +10,7 @@ module Apipie
                                    options)
     end
 
-    def initialize(code_or_options, desc=nil, options={})
+    def initialize(code_or_options, desc = nil, options = {})
       if code_or_options.is_a? Hash
         code_or_options.symbolize_keys!
         @code = code_or_options[:code]

data/lib/apipie/errors.rb

@@ -60,27 +60,13 @@ module Apipie
 
   class ResponseDoesNotMatchSwaggerSchema < Error
     def initialize(controller_name, method_name, response_code, error_messages, schema, returned_object)
-      @controller_name = controller_name
-      @method_name = method_name
-      @response_code = response_code
-      @error_messages = error_messages
-      @schema = schema
-      @returned_object = returned_object
-    end
-
-    def to_s
-      "Response does not match swagger schema (#{@controller_name}##{@method_name} #{@response_code}): #{@error_messages}\nSchema: #{JSON(@schema)}\nReturned object: #{@returned_object}"
+      super("Response does not match swagger schema (#{controller_name}##{method_name} #{response_code}): #{error_messages}\nSchema: #{JSON(schema)}\nReturned object: #{returned_object}")
     end
   end
 
   class NoDocumentedMethod < Error
     def initialize(controller_name, method_name)
-      @method_name = method_name
-      @controller_name = controller_name
-    end
-
-    def to_s
-      "There is no documented method #{@controller_name}##{@method_name}"
+      super("There is no documented method #{controller_name}##{method_name}")
     end
   end
 end

data/lib/apipie/extractor/collector.rb

@@ -96,7 +96,7 @@ module Apipie
       end
 
       def add_routes_info(desc)
-        api_prefix = Apipie.api_base_url.sub(/\/$/,"")
+        api_prefix = Apipie.api_base_url.sub(%r{/$},"")
         desc[:api] = Apipie::Extractor.apis_from_routes[[desc[:controller].name, desc[:action]]]
         if desc[:api]
           desc[:params].each do |name, param|

data/lib/apipie/extractor/recorder.rb

@@ -9,7 +9,7 @@ module Apipie
 
       def analyse_env(env)
         @verb = env["REQUEST_METHOD"].to_sym
-        @path = env["PATH_INFO"].sub(/^\/*/,"/")
+        @path = env["PATH_INFO"].sub(%r{^/*},"/")
         @query = env["QUERY_STRING"] unless env["QUERY_STRING"].blank?
         @params = Rack::Utils.parse_nested_query(@query)
         @params.merge!(env["action_dispatch.request.request_parameters"] || {})

data/lib/apipie/extractor.rb

@@ -81,7 +81,7 @@ module Apipie
       def apis_from_routes
         return @apis_from_routes if @apis_from_routes
 
-        @api_prefix = Apipie.api_base_url.sub(/\/$/,"")
+        @api_prefix = Apipie.api_base_url.sub(%r{/$},"")
         populate_api_routes
         update_api_descriptions
 

data/lib/apipie/generator/swagger/operation_id.rb

@@ -37,7 +37,7 @@ class Apipie::Generator::Swagger::OperationId
   #
   # @return [String]
   def path
-    @path.gsub(/\//, '_').gsub(/:(\w+)/, '\1').gsub(/_$/, '')
+    @path.gsub(%r{/}, '_').gsub(/:(\w+)/, '\1').gsub(/_$/, '')
   end
 
   # Converts an http method like `GET` to `get` Using lowercase http method,

data/lib/apipie/helpers.rb

@@ -25,10 +25,10 @@ module Apipie
         @url_prefix << request_script_name
         @url_prefix << Apipie.configuration.doc_base_url
       end
-      path = path.sub(/^\//,"")
+      path = path.sub(%r{^/},"")
       ret = "#{@url_prefix}/#{path}"
-      ret.insert(0,"/") unless ret =~ /\A[.\/]/
-      ret.sub!(/\/*\Z/,"")
+      ret.insert(0,"/") unless ret =~ %r{\A[./]}
+      ret.sub!(%r{/*\Z},"")
       ret
     end
 

data/lib/apipie/method_description.rb

@@ -159,7 +159,7 @@ module Apipie
       @formats || @resource._formats
     end
 
-    def to_json(lang=nil)
+    def to_json(lang = nil)
       {
         :doc_url => doc_url,
         :name => @method,