api_me 0.8.3 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a0e54aaed7c4f43cf317932557e98703dd0f92a1
-  data.tar.gz: f8378de47b162e3d4d5af42b5e2b7cff0b4c32c8
+  metadata.gz: 645e13a4bad82a3438471c239b114e274c8359f8
+  data.tar.gz: 4fd73fa2d420709e31ed318f3b8811c67c93f7e6
 SHA512:
-  metadata.gz: 4a18e146f973884145a49abcd430fcc649ef383dec0cc2d5b0b14d7dd55fdc93121d34698c275c01f9b6ac32578904f147d95ea84af17bfadedafe9d187162f1
-  data.tar.gz: 3635a11745a173d844c6fb3703d5acf673b87404713ce0c45be9eaa18b9f3f71ab1382e734ed38bab31af26515c5798e17d2f0d417f9d590a002f6156792a602
+  metadata.gz: 22cb87900699c9c798aba454a68f55dcd089a4eab02a7256bb165ab41690950ec6a426dcbd88b4fea165fa1c228273c3daac6788b494b472d4ad50e988d32405
+  data.tar.gz: bf3d38090a2960accb601856c2f372719fbcd8410087df49f262074496f555d8b85fbe7c1df2b1d983e1e822c6e0f7de159146f24c8103ded53495a91232869e

data/Gemfile

@@ -3,12 +3,9 @@ source 'https://rubygems.org'
 gemspec
 
 group :test do
-  gem 'pry'
-  gem 'activerecord'
-  gem 'activesupport'
-  gem 'actionpack' # action_controller, action_view
-  gem 'combustion', '~> 0.5.2'
-  gem 'rack-test'
-  gem 'pundit'
+  gem 'actionpack'
   gem 'active_model_serializers', '~> 0.10.0'
+  gem 'combustion', '~> 0.5.2'
+  gem 'pry'
+  gem 'rack-test', '~> 0.6.2'
 end

data/Gemfile.lock

@@ -1,119 +1,138 @@
 PATH
   remote: .
   specs:
-    api_me (0.8.3)
+    api_me (0.9.0)
       active_model_serializers (~> 0.10.0)
-      activerecord (>= 3.2.0)
-      activesupport (>= 3.2.0)
+      activerecord (>= 4.1.16)
+      activesupport (>= 4.1.16)
       kaminari (~> 0.16.3)
-      pundit (~> 1.0)
+      pundit (~> 1.1.0)
       search_object (~> 1.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    actionpack (4.1.6)
-      actionview (= 4.1.6)
-      activesupport (= 4.1.6)
-      rack (~> 1.5.2)
+    actionpack (4.2.10)
+      actionview (= 4.2.10)
+      activesupport (= 4.2.10)
+      rack (~> 1.6)
       rack-test (~> 0.6.2)
-    actionview (4.1.6)
-      activesupport (= 4.1.6)
+      rails-dom-testing (~> 1.0, >= 1.0.5)
+      rails-html-sanitizer (~> 1.0, >= 1.0.2)
+    actionview (4.2.10)
+      activesupport (= 4.2.10)
       builder (~> 3.1)
       erubis (~> 2.7.0)
-    active_model_serializers (0.10.2)
+      rails-dom-testing (~> 1.0, >= 1.0.5)
+      rails-html-sanitizer (~> 1.0, >= 1.0.3)
+    active_model_serializers (0.10.7)
       actionpack (>= 4.1, < 6)
       activemodel (>= 4.1, < 6)
-      jsonapi (~> 0.1.1.beta2)
-      railties (>= 4.1, < 6)
-    activemodel (4.1.6)
-      activesupport (= 4.1.6)
+      case_transform (>= 0.2)
+      jsonapi-renderer (>= 0.1.1.beta1, < 0.3)
+    activemodel (4.2.10)
+      activesupport (= 4.2.10)
       builder (~> 3.1)
-    activerecord (4.1.6)
-      activemodel (= 4.1.6)
-      activesupport (= 4.1.6)
-      arel (~> 5.0.0)
-    activesupport (4.1.6)
-      i18n (~> 0.6, >= 0.6.9)
-      json (~> 1.7, >= 1.7.7)
+    activerecord (4.2.10)
+      activemodel (= 4.2.10)
+      activesupport (= 4.2.10)
+      arel (~> 6.0)
+    activesupport (4.2.10)
+      i18n (~> 0.7)
       minitest (~> 5.1)
-      thread_safe (~> 0.1)
+      thread_safe (~> 0.3, >= 0.3.4)
       tzinfo (~> 1.1)
-    arel (5.0.1.20140414130214)
-    ast (2.0.0)
-    astrolabe (1.3.0)
-      parser (>= 2.2.0.pre.3, < 3.0)
-    builder (3.2.2)
-    coderay (1.1.0)
+    arel (6.0.4)
+    ast (2.4.0)
+    builder (3.2.3)
+    case_transform (0.2)
+      activesupport
+    coderay (1.1.2)
     colored (1.2)
-    combustion (0.5.2)
+    combustion (0.5.5)
       activesupport (>= 3.0.0)
       railties (>= 3.0.0)
       thor (>= 0.14.6)
-    diff-lcs (1.2.5)
+    concurrent-ruby (1.0.5)
+    crass (1.0.3)
+    diff-lcs (1.3)
     erubis (2.7.0)
-    i18n (0.6.11)
-    json (1.8.1)
-    jsonapi (0.1.1.beta2)
-      json (~> 1.8)
+    i18n (0.9.5)
+      concurrent-ruby (~> 1.0)
+    jsonapi-renderer (0.2.0)
     kaminari (0.16.3)
       actionpack (>= 3.0.0)
       activesupport (>= 3.0.0)
-    method_source (0.8.2)
-    minitest (5.4.2)
-    parser (2.2.0.pre.8)
-      ast (>= 1.1, < 3.0)
-      slop (~> 3.4, >= 3.4.5)
-    powerpack (0.0.9)
-    pry (0.10.3)
+    loofah (2.2.2)
+      crass (~> 1.0.2)
+      nokogiri (>= 1.5.9)
+    method_source (0.9.0)
+    mini_portile2 (2.3.0)
+    minitest (5.11.3)
+    nokogiri (1.8.2)
+      mini_portile2 (~> 2.3.0)
+    parallel (1.12.1)
+    parser (2.5.0.4)
+      ast (~> 2.4.0)
+    powerpack (0.1.1)
+    pry (0.11.3)
       coderay (~> 1.1.0)
-      method_source (~> 0.8.1)
-      slop (~> 3.4)
-    pundit (1.0.1)
+      method_source (~> 0.9.0)
+    pundit (1.1.0)
       activesupport (>= 3.0.0)
-    rack (1.5.2)
-    rack-test (0.6.2)
+    rack (1.6.9)
+    rack-test (0.6.3)
       rack (>= 1.0)
-    railties (4.1.6)
-      actionpack (= 4.1.6)
-      activesupport (= 4.1.6)
+    rails-deprecated_sanitizer (1.0.3)
+      activesupport (>= 4.2.0.alpha)
+    rails-dom-testing (1.0.9)
+      activesupport (>= 4.2.0, < 5.0)
+      nokogiri (~> 1.6)
+      rails-deprecated_sanitizer (>= 1.0.1)
+    rails-html-sanitizer (1.0.3)
+      loofah (~> 2.0)
+    railties (4.2.10)
+      actionpack (= 4.2.10)
+      activesupport (= 4.2.10)
       rake (>= 0.8.7)
       thor (>= 0.18.1, < 2.0)
-    rainbow (2.0.0)
-    rake (10.3.2)
+    rainbow (3.0.0)
+    rake (12.3.1)
     rake-notes (0.2.0)
       colored
       rake
-    rspec-core (3.1.7)
-      rspec-support (~> 3.1.0)
-    rspec-expectations (3.1.2)
+    rspec-core (3.7.1)
+      rspec-support (~> 3.7.0)
+    rspec-expectations (3.7.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.7.0)
+    rspec-mocks (3.7.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.1.0)
-    rspec-mocks (3.1.3)
-      rspec-support (~> 3.1.0)
-    rspec-rails (3.1.0)
+      rspec-support (~> 3.7.0)
+    rspec-rails (3.7.2)
       actionpack (>= 3.0)
       activesupport (>= 3.0)
       railties (>= 3.0)
-      rspec-core (~> 3.1.0)
-      rspec-expectations (~> 3.1.0)
-      rspec-mocks (~> 3.1.0)
-      rspec-support (~> 3.1.0)
-    rspec-support (3.1.2)
-    rubocop (0.28.0)
-      astrolabe (~> 1.3)
-      parser (>= 2.2.0.pre.7, < 3.0)
-      powerpack (~> 0.0.6)
-      rainbow (>= 1.99.1, < 3.0)
-      ruby-progressbar (~> 1.4)
-    ruby-progressbar (1.7.0)
+      rspec-core (~> 3.7.0)
+      rspec-expectations (~> 3.7.0)
+      rspec-mocks (~> 3.7.0)
+      rspec-support (~> 3.7.0)
+    rspec-support (3.7.1)
+    rubocop (0.54.0)
+      parallel (~> 1.10)
+      parser (>= 2.5)
+      powerpack (~> 0.1)
+      rainbow (>= 2.2.2, < 4.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.0, >= 1.0.1)
+    ruby-progressbar (1.9.0)
     search_object (1.2.0)
-    slop (3.6.0)
-    sqlite3 (1.3.9)
-    thor (0.19.1)
-    thread_safe (0.3.4)
-    tzinfo (1.2.2)
+    sqlite3 (1.3.13)
+    thor (0.20.0)
+    thread_safe (0.3.6)
+    tzinfo (1.2.5)
       thread_safe (~> 0.1)
+    unicode-display_width (1.3.0)
 
 PLATFORMS
   ruby
@@ -121,14 +140,14 @@ PLATFORMS
 DEPENDENCIES
   actionpack
   active_model_serializers (~> 0.10.0)
-  activerecord
-  activesupport
   api_me!
   combustion (~> 0.5.2)
   pry
-  pundit
-  rack-test
+  rack-test (~> 0.6.2)
   rake-notes (>= 0.2.0)
   rspec-rails (~> 3)
-  rubocop (>= 0.27.0)
+  rubocop (~> 0.49)
   sqlite3 (~> 1.3.7)
+
+BUNDLED WITH
+   1.16.1

data/README.md

@@ -121,6 +121,45 @@ return this.store.query('some-model', {
 });
 ````
 
+### Pagination
+
+To enable pagination just pass `page` in your request with `size` and `offset`.
+
+Ember Example
+````js
+return this.store.query('some-model', {
+  filters: {
+    cool_models_only: true
+  },
+  sort:  {
+    criteria: 'createdAt', // Property to sort on.
+    reverse: false, // True reverses the sort.
+  },
+  page:  {
+    size: 50, // Size of a page. Number of results per page.
+    offset: false, /* The page number you want to see.
+                      Imagine 103 records are available.
+                      If the size of 50 is given as a parameter
+                      then valid inputs to offset would be 1, 2, and 3. */
+  }
+});
+````
+
+
+Your response will contain a meta object with the following data:
+```js
+meta: {
+  size: n           // Size input above
+  offset: m         // Offset input above
+  record_count: i   /* The number of records in the page.
+                       In the `offset` example above pages 1 and 2
+                       would have a record_count of 50 while page 3
+                       would have a record count of 3. */
+  total_records: j // Total number of records accessible
+  total_pages: k   // Total number of pages accessible
+}
+```
+
 ### Overrides
 Overriding the default model class, serializer class, filter class, and filter parameter can be done like so:
 

data/Rakefile

@@ -17,7 +17,7 @@ end
 task default: 'reports:all'
 
 namespace :reports do
-  task all: [:fixme_notes, :rubocop, :spec]
+  task all: %i[fixme_notes rubocop spec]
 
   task :rubocop do
     system 'bundle exec rubocop --rails --display-cop-names'

data/api_me.gemspec

@@ -18,9 +18,9 @@ Gem::Specification.new do |s|
   s.test_files    = `git ls-files -- {spec}/*`.split("\n")
   s.require_paths = %w(lib app)
 
-  s.add_runtime_dependency 'activerecord',             '>= 3.2.0'
-  s.add_runtime_dependency 'activesupport',            '>= 3.2.0'
-  s.add_runtime_dependency 'pundit',                   '~> 1.0'
+  s.add_runtime_dependency 'activerecord',             '>= 4.1.16'
+  s.add_runtime_dependency 'activesupport',            '>= 4.1.16'
+  s.add_runtime_dependency 'pundit',                   '~> 1.1.0'
   s.add_runtime_dependency 'active_model_serializers', '~> 0.10.0'
   s.add_runtime_dependency 'search_object',            '~> 1.0'
   s.add_runtime_dependency 'kaminari',                 '~> 0.16.3'
@@ -28,6 +28,6 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'combustion',  '~> 0.5.1'
   s.add_development_dependency 'rspec-rails', '~> 3'
   s.add_development_dependency 'sqlite3',     '~> 1.3.7'
-  s.add_development_dependency 'rubocop', '>= 0.27.0'
+  s.add_development_dependency 'rubocop', '~> 0.49'
   s.add_development_dependency 'rake-notes', '>= 0.2.0'
 end

data/lib/api_me.rb

@@ -18,11 +18,11 @@ module ApiMe
   end
 
   module ClassMethods
-    def model(klass) # rubocop:disable TrivialAccessors
+    def model(klass)
       @model_klass = klass
     end
 
-    def serializer(klass) # rubocop:disable TrivialAccessors
+    def serializer(klass)
       @serializer_klass = klass
     end
 
@@ -68,7 +68,7 @@ module ApiMe
   def index
     @policy_scope = policy_scope(resource_scope)
     @filter_scope = filter_scope(@policy_scope)
-    @sorted_scope = sort_scope(@filter_scope, sort_params)
+    @sorted_scope = sort_scope(@filter_scope)
     @pagination_object = paginate_scope(@sorted_scope, page_params)
 
     render json: @pagination_object.results, root: collection_root_key, each_serializer: serializer_klass, meta: { page: @pagination_object.page_meta }
@@ -162,19 +162,26 @@ module ApiMe
     self.class.filter_klass
   end
 
+  def sort_klass
+    ApiMe::Sorting
+  end
+
   def resource_scope
     model_klass.all
   end
 
   def filter_scope(scope)
     filter_klass.new(
-        scope: scope,
-        filters: filters_hash
+      scope: scope,
+      filters: filters_hash
     ).results
   end
 
-  def sort_scope(scope, params)
-    ApiMe::Sorting.new(scope: scope, sort_params: params).results
+  def sort_scope(scope)
+    sort_klass.new(
+        scope: scope,
+        sort_params: sort_hash
+    ).results
   end
 
   def paginate_scope(scope, params)
@@ -194,6 +201,14 @@ module ApiMe
     params[:filters]
   end
 
+  def sort_hash
+    sort_params
+  end
+
+  def sort_params
+    params[:sort]
+  end
+
   def find_resource
     model_klass.find_by_id!(params[:id])
   end

data/lib/api_me/engine.rb

@@ -1,5 +1,5 @@
 begin
-  require "active_model_serializers"
+  require 'active_model_serializers'
 rescue LoadError
   puts "Could not load 'active_model_serializers'"
   exit

data/lib/api_me/pagination.rb

@@ -16,7 +16,7 @@ module ApiMe
     end
 
     def page_meta
-      return Hash.new unless paging?
+      return {} unless paging?
       {
         size: page_size.nil? ? default_page_size : page_size,
         offset: page_offset,
@@ -29,14 +29,12 @@ module ApiMe
     protected
 
     def page
-      self.scope = scope.page(self.page_offset ? page_offset : 1)
+      self.scope = scope.page(page_offset ? page_offset : 1)
       self
     end
 
     def per
-      if page_size
-        self.scope = scope.per(page_size)
-      end
+      self.scope = scope.per(page_size) if page_size
       self
     end
 
@@ -49,6 +47,5 @@ module ApiMe
     def paging?
       page_size || page_offset
     end
-
   end
 end

data/lib/api_me/sorting.rb

@@ -15,35 +15,34 @@ module ApiMe
     end
 
     def sort_meta
-      return Hash.new unless sorting?
+      return {} unless sorting?
       {
-        criteria: sort_criteria.is_blank? || sort_criteria === "" ? default_sort_criteria : sort_criteria,
+        criteria: sort_criteria.is_blank? || sort_criteria === '' ? default_sort_criteria : sort_criteria,
         reverse: sort_reverse,
         record_count: scope.size,
-        total_records: scope.total_count,
+        total_records: scope.total_count
       }
     end
 
     protected
 
     def sort(criteria = default_sort_criteria)
-      if sort_reverse === "true"
-        self.scope = scope.order(criteria => :desc)
-      else
-        self.scope = scope.order(criteria => :asc)
-      end
+      self.scope = if sort_reverse === 'true'
+                     scope.order(criteria => :desc)
+                   else
+                     scope.order(criteria => :asc)
+                   end
       self
     end
 
     private
 
     def default_sort_criteria
-      sort_criteria = "id"
+      sort_criteria = 'id'
     end
 
     def sorting?
       sort_criteria || sort_reverse
     end
-
   end
 end

data/lib/api_me/version.rb

@@ -1,3 +1,3 @@
 module ApiMe
-  VERSION = '0.8.3'
+  VERSION = '0.9.0'.freeze
 end

data/lib/generators/api_me/controller/controller_generator.rb

@@ -1,7 +1,7 @@
 module ApiMe
   module Generators
     class ControllerGenerator < ::Rails::Generators::NamedBase
-      source_root File.expand_path('../templates', __FILE__)
+      source_root File.expand_path('templates', __dir__)
       check_class_collision suffix: 'Controller'
 
       argument :attributes, type: :array, default: [], banner: 'field field'
@@ -33,7 +33,7 @@ module ApiMe
       end
 
       def attributes_names
-        [:id] + attributes.select { |attr| !attr.reference? }.map { |a| a.name.to_sym }
+        [:id] + attributes.reject(&:reference?).map { |a| a.name.to_sym }
       end
 
       def associations
@@ -41,19 +41,19 @@ module ApiMe
       end
 
       def nonpolymorphic_attribute_names
-        associations.select { |attr| attr.type.in?([:belongs_to, :references]) }
-          .reject { |attr| attr.attr_options.fetch(:polymorphic, false) }
-          .map { |attr| "#{attr.name}_id".to_sym }
+        associations.select { |attr| attr.type.in?(%i[belongs_to references]) }
+                    .reject { |attr| attr.attr_options.fetch(:polymorphic, false) }
+                    .map { |attr| "#{attr.name}_id".to_sym }
       end
 
       def polymorphic_attribute_names
-        associations.select { |attr| attr.type.in?([:belongs_to, :references]) }
-          .select { |attr| attr.attr_options.fetch(:polymorphic, false) }
-          .map { |attr| ["#{attr.name}_id".to_sym, "#{attr.name}_type".to_sym] }.flatten
+        associations.select { |attr| attr.type.in?(%i[belongs_to references]) }
+                    .select { |attr| attr.attr_options.fetch(:polymorphic, false) }
+                    .map { |attr| ["#{attr.name}_id".to_sym, "#{attr.name}_type".to_sym] }.flatten
       end
 
       def association_attribute_names
-        nonpolymorphic_attribute_names + (polymorphic_attribute_names)
+        nonpolymorphic_attribute_names + polymorphic_attribute_names
       end
 
       def strong_parameters

data/lib/generators/api_me/filter/filter_generator.rb

@@ -1,7 +1,7 @@
 module ApiMe
   module Generators
     class FilterGenerator < ::Rails::Generators::NamedBase
-      source_root File.expand_path('../templates', __FILE__)
+      source_root File.expand_path('templates', __dir__)
       check_class_collision suffix: 'Filter'
 
       argument :attributes, type: :array, default: [], banner: 'field field'
@@ -17,7 +17,7 @@ module ApiMe
       end
 
       def attributes_names
-        attributes.select { |attr| !attr.reference? }.map { |a| a.name.to_sym }
+        attributes.reject(&:reference?).map { |a| a.name.to_sym }
       end
 
       def associations
@@ -25,19 +25,19 @@ module ApiMe
       end
 
       def nonpolymorphic_attribute_names
-        associations.select { |attr| attr.type.in?([:belongs_to, :references]) }
-          .reject { |attr| attr.attr_options.fetch(:polymorphic, false) }
-          .map { |attr| "#{attr.name}_id".to_sym }
+        associations.select { |attr| attr.type.in?(%i[belongs_to references]) }
+                    .reject { |attr| attr.attr_options.fetch(:polymorphic, false) }
+                    .map { |attr| "#{attr.name}_id".to_sym }
       end
 
       def polymorphic_attribute_names
-        associations.select { |attr| attr.type.in?([:belongs_to, :references]) }
-          .select { |attr| attr.attr_options.fetch(:polymorphic, false) }
-          .map { |attr| ["#{attr.name}_id".to_sym, "#{attr.name}_type".to_sym] }.flatten
+        associations.select { |attr| attr.type.in?(%i[belongs_to references]) }
+                    .select { |attr| attr.attr_options.fetch(:polymorphic, false) }
+                    .map { |attr| ["#{attr.name}_id".to_sym, "#{attr.name}_type".to_sym] }.flatten
       end
 
       def association_attribute_names
-        nonpolymorphic_attribute_names + (polymorphic_attribute_names)
+        nonpolymorphic_attribute_names + polymorphic_attribute_names
       end
 
       def strong_parameters

data/lib/generators/api_me/policy/policy_generator.rb

@@ -1,7 +1,7 @@
 module ApiMe
   module Generators
     class PolicyGenerator < ::Rails::Generators::NamedBase
-      source_root File.expand_path('../templates', __FILE__)
+      source_root File.expand_path('templates', __dir__)
       check_class_collision suffix: 'Policy'
 
       argument :attributes, type: :array, default: [], banner: 'field field'
@@ -17,7 +17,7 @@ module ApiMe
       end
 
       def attributes_names
-        attributes.select { |attr| !attr.reference? }.map { |a| a.name.to_sym }
+        attributes.reject(&:reference?).map { |a| a.name.to_sym }
       end
 
       def associations
@@ -25,19 +25,19 @@ module ApiMe
       end
 
       def nonpolymorphic_attribute_names
-        associations.select { |attr| attr.type.in?([:belongs_to, :references]) }
-          .reject { |attr| attr.attr_options.fetch(:polymorphic, false) }
-          .map { |attr| "#{attr.name}_id".to_sym }
+        associations.select { |attr| attr.type.in?(%i[belongs_to references]) }
+                    .reject { |attr| attr.attr_options.fetch(:polymorphic, false) }
+                    .map { |attr| "#{attr.name}_id".to_sym }
       end
 
       def polymorphic_attribute_names
-        associations.select { |attr| attr.type.in?([:belongs_to, :references]) }
-          .select { |attr| attr.attr_options.fetch(:polymorphic, false) }
-          .map { |attr| ["#{attr.name}_id".to_sym, "#{attr.name}_type".to_sym] }.flatten
+        associations.select { |attr| attr.type.in?(%i[belongs_to references]) }
+                    .select { |attr| attr.attr_options.fetch(:polymorphic, false) }
+                    .map { |attr| ["#{attr.name}_id".to_sym, "#{attr.name}_type".to_sym] }.flatten
       end
 
       def association_attribute_names
-        nonpolymorphic_attribute_names + (polymorphic_attribute_names)
+        nonpolymorphic_attribute_names + polymorphic_attribute_names
       end
 
       def strong_parameters

data/lib/generators/api_me/resource/resource_generator.rb

@@ -4,7 +4,7 @@ module ApiMe
       def run_generators
         params = @_initializer[0]
         invoke 'model', params
-        invoke 'serializer', params + %w(created_at updated_at)
+        invoke 'serializer', params + %w[created_at updated_at]
         invoke 'api_me:policy', params
         invoke 'api_me:controller', params
       end

data/spec/acceptance/api/v1/posts_spec.rb

@@ -23,7 +23,6 @@ describe 'Posts API' do
     get '/api/v1/posts?page%5Boffset%5D=1'
     json = JSON.parse(last_response.body)
     expect(json['posts'].length).to eq(25)
-
   end
 
   it 'is page offset of 2 working for size of 40 default page size of 25' do
@@ -34,11 +33,10 @@ describe 'Posts API' do
     get '/api/v1/posts?page%5Boffset%5D=2'
     json = JSON.parse(last_response.body)
     expect(json['posts'].length).to eq(15)
-
   end
 
   it 'is page offset of -1 working for size of 40 default page size of 25' do
-    #min page offset is 1, anything less gets converted to 1 and results in page size records
+    # min page offset is 1, anything less gets converted to 1 and results in page size records
     40.times do
       Post.create(name: 'page item')
     end
@@ -46,11 +44,10 @@ describe 'Posts API' do
     get '/api/v1/posts?page%5Boffset%5D=-1'
     json = JSON.parse(last_response.body)
     expect(json['posts'].length).to eq(25)
-
   end
 
   it 'is page offset of 3 working for size of 40 default page size of 25' do
-    #overflow on page offset will result in 0 records
+    # overflow on page offset will result in 0 records
     40.times do
       Post.create(name: 'page item')
     end
@@ -61,7 +58,7 @@ describe 'Posts API' do
   end
 
   it 'is page size of 10 working for default offset of 1' do
-    #overflow on page offset will result in 0 records
+    # overflow on page offset will result in 0 records
     40.times do
       Post.create(name: 'page item')
     end
@@ -69,11 +66,10 @@ describe 'Posts API' do
     get '/api/v1/posts?page%5Bsize%5D=10'
     json = JSON.parse(last_response.body)
     expect(json['posts'].length).to eq(10)
-
   end
 
   it 'is page size working when the value is negative' do
-    #overflow on page offset will result in 0 records
+    # overflow on page offset will result in 0 records
     40.times do
       Post.create(name: 'page item')
     end
@@ -81,11 +77,10 @@ describe 'Posts API' do
     get '/api/v1/posts?page%5Bsize%5D=-10'
     json = JSON.parse(last_response.body)
     expect(json['posts'].length).to eq(25)
-
   end
 
   it 'is page size working when the value is higher than the total record count' do
-    #overflow on page offset will result in 0 records
+    # overflow on page offset will result in 0 records
     40.times do
       Post.create(name: 'page item')
     end
@@ -96,7 +91,7 @@ describe 'Posts API' do
   end
 
   it 'is the result all records when no page paramas are sent' do
-    #overflow on page offset will result in 0 records
+    # overflow on page offset will result in 0 records
     100.times do
       Post.create(name: 'page item')
     end
@@ -104,7 +99,6 @@ describe 'Posts API' do
     get '/api/v1/posts'
     json = JSON.parse(last_response.body)
     expect(json['posts'].length).to eq(100)
-
   end
 
   it 'restricts page_size when max_per_page config is less' do
@@ -129,7 +123,7 @@ describe 'Posts API' do
     filtered_posts = [all_posts[0], all_posts[2]]
 
     get '/api/v1/posts?ids%5B%5D=' + filtered_posts[0].id.to_s +
-      '&ids%5B%5D=' + filtered_posts[1].id.to_s
+        '&ids%5B%5D=' + filtered_posts[1].id.to_s
 
     expect(last_response.status).to eq(200)
     json = JSON.parse(last_response.body)

data/spec/internal/app/models/test_model.rb

@@ -9,8 +9,7 @@ class TestModel < ActiveModelSerializers::Model
     @created ||= false
   end
 
-  def initialize(*_args)
-  end
+  def initialize(*_args); end
 
   def save!(*_args)
     TestModel.create

data/spec/internal/app/policies/user_policy.rb

@@ -1,6 +1,6 @@
 class UserPolicy < ApplicationPolicy
   def permitted_attributes
-    [:id, :username]
+    %i[id username]
   end
 
   class Scope < ApplicationPolicy::Scope

data/spec/internal/db/schema.rb

@@ -1,12 +1,12 @@
 ActiveRecord::Schema.define do
   create_table :users, force: true do |t|
     t.string :username
-    t.timestamps
+    t.timestamps null: false
   end
 
   create_table :posts, force: true do |t|
     t.string :name
     t.belongs_to :user, foreign_key: true
-    t.timestamps
+    t.timestamps null: false
   end
 end

data/spec/spec_helper.rb

@@ -21,5 +21,4 @@ RSpec.configure do |config|
   config.use_transactional_fixtures = true
 
   config.include ApiHelper
-
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: api_me
 version: !ruby/object:Gem::Version
-  version: 0.8.3
+  version: 0.9.0
 platform: ruby
 authors:
 - Sam Clopton
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-28 00:00:00.000000000 Z
+date: 2018-03-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -17,42 +17,42 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: 4.1.16
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: 4.1.16
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: 4.1.16
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.2.0
+        version: 4.1.16
 - !ruby/object:Gem::Dependency
   name: pundit
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 1.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 1.1.0
 - !ruby/object:Gem::Dependency
   name: active_model_serializers
   requirement: !ruby/object:Gem::Requirement
@@ -141,16 +141,16 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.27.0
+        version: '0.49'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.27.0
+        version: '0.49'
 - !ruby/object:Gem::Dependency
   name: rake-notes
   requirement: !ruby/object:Gem::Requirement