api_me 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0658898c8db26ece5dcf4eba4465c41a4c944007
-  data.tar.gz: 1ac19dc633b67d85039621edee0c9afc06e0f76c
+  metadata.gz: d6be2bfc501d6e34780bb7d71cc7f9504110bbe5
+  data.tar.gz: 0cdf554cf51fc1c08cc960b9aa03d9869a631ecc
 SHA512:
-  metadata.gz: 9011c9ca170a159c3802421d85662be738038e32337655ef74a412ddacd48dc12727cff413db45217c8fbb4294493e34ba2728b3d2148a3bfb572fb3f6a66195
-  data.tar.gz: 5bf8be52281acd86adc7a8316893e2a55b543ca6b22d46bc6e79be11ad8a1d5854142a668515963fa93ef037a3074342f65f91ee5aa75f6553b24977d0011453
+  metadata.gz: af00b5703f9677aa28ae0e7ae5422440931e246d90ef0f3b2ea0166d4e85b53e2c259e22568e77fa5c65bac992b2d118bb0742a616dd916f30ab08bb8c9ce5d2
+  data.tar.gz: d46be75bc55cf3ab8fa89f8c33af26c9a139098b680153a62b750a05f15130fe61802cde9955ca8731f0a046d77b548050090ecd5c58936deea169ae0cc432b0

data/README.md

@@ -108,5 +108,8 @@ end
 - [ ]  Add the ability to specify the api controller path (I.E. app/controllers/api/v2)
 - [ ]  Add the ability to inject the resource route into the routes file in the resource generators
 
+## Code Of Conduct
+Wildland Open Source [Code Of Conduct](https://github.com/wildland/code-of-conduct)
+
 ## License
 Copyright (c) 2014, Api Me is developed and maintained by Sam Clopton, and is released under the open MIT Licence.

data/api_me.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |s|
   s.version     = ApiMe::VERSION
   s.authors     = ['Sam Clopton', 'Joe Weakley']
   s.email       = ['samsinite@gmail.com']
-  s.homepage    = 'https://github.com/inigo/api_me'
+  s.homepage    = 'https://github.com/wildland/api_me'
   s.summary     = 'Api Me'
   s.description = "This friendly library gives you helpers and generators to assist building RESTful API's in your Rails app."
   s.license     = 'MIT'

data/lib/api_me.rb

@@ -11,6 +11,7 @@ module ApiMe
 
   included do
     rescue_from Pundit::NotAuthorizedError, with: :user_not_authorized
+    rescue_from ActiveRecord::RecordNotFound, with: :resource_not_found
   end
 
   module ClassMethods
@@ -73,7 +74,7 @@ module ApiMe
   end
 
   def show
-    @object = model_klass.find(params[:id])
+    @object = find_resource
     authorize @object
 
     render json: @object, serializer: serializer_klass
@@ -90,7 +91,7 @@ module ApiMe
   end
 
   def update
-    @object = model_klass.find(params[:id])
+    @object = find_resource
     authorize @object
     @object.update!(object_params)
 
@@ -100,14 +101,14 @@ module ApiMe
   end
 
   def destroy
-    @object = model_klass.find(params[:id])
+    @object = find_resource
     authorize @object
     @object.destroy
 
     render status: 204, nothing: true
   end
 
-  private
+  protected
 
   def object_params
     params.require(params_klass_symbol).permit(*policy(@object || model_klass).permitted_attributes)
@@ -127,6 +128,10 @@ module ApiMe
     render json: payload, status: 403
   end
 
+  def resource_not_found
+    render status: 404, nothing: true
+  end
+
   def model_klass
     self.class.model_klass
   end
@@ -150,4 +155,8 @@ module ApiMe
   def filter_params
     params[:filters]
   end
+
+  def find_resource
+    model_klass.find_by_id!(params[:id])
+  end
 end

data/lib/api_me/version.rb

@@ -1,3 +1,3 @@
 module ApiMe
-  VERSION = '0.4.0'
+  VERSION = '0.4.1'
 end

data/spec/acceptance/api/v1/users_spec.rb

@@ -15,6 +15,14 @@ describe 'Users API' do
     expect(json['users'].length).to eq(users.count)
   end
 
+  it 'returns a 404 for a user that does not exist' do
+    invalid_user_id = User.maximum(:id).to_i + 1
+
+    get '/api/v1/users/' + invalid_user_id.to_s + '/'
+
+    expect(last_response.status).to eq(404)
+  end
+
   it 'sends an individual user' do
     user = User.create(username: 'Test')
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: api_me
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Sam Clopton
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-21 00:00:00.000000000 Z
+date: 2015-07-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -210,7 +210,7 @@ files:
 - spec/internal/log/.gitignore
 - spec/internal/public/favicon.ico
 - spec/spec_helper.rb
-homepage: https://github.com/inigo/api_me
+homepage: https://github.com/wildland/api_me
 licenses:
 - MIT
 metadata: {}
@@ -231,7 +231,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Api Me