api_client 0.5.9 → 0.5.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 43c461e0ff353c1755880974f8704c1bee7176b0
-  data.tar.gz: f271d02470638507b7e5ddcd1b3e1c537d6d19fc
+  metadata.gz: fa72f20faca901deb66fb6f1b73599829a0ef633
+  data.tar.gz: 38f72c8e3f27ec6c708bba8aa6cc22a2729f0e40
 SHA512:
-  metadata.gz: 3dc40c025d6ebfd1e6e7e35be9b36f4a57feb5bbfc8c0c491bc2e73094964d881136cc79bf42dac693a02916fb4e057081bb5618ad490fe1421e193342cccac7
-  data.tar.gz: f5b8195b7f425819af8662333a62534c62251fa023c371499530cd90517cdee74b5b1e178321d1ad66411df5565c4ff446db83d81a727bf0edace6c0baf96d82
+  metadata.gz: dc9414f6a69354c668012ce321773f83d45e845cf109dbe0a3e4b77146ba986bac7b866ba13cd187dc4c3bac3b05d4c4f6dd8a2939562cf31a4a93f1ca13f6de
+  data.tar.gz: e4195081871e961a05ec586042de5b9aad01c0e92143a5abc4b5c5298e8842a2d8759976c96d46c53a21ecebbda92c47031203837b03c7a90ccf7bf36118d532

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+# 0.5.11
+
+ * fix handling errors
+
+# 0.5.10
+
+ * add TooManyRequests error
+
 # 0.5.9
 
  * fix compatibility with ruby 1.8.x

data/lib/api_client/connection/basic.rb

@@ -83,26 +83,28 @@ module ApiClient
       end
 
       def handle_response(request, response)
-        raise ApiClient::Errors::ConnectionFailed.new(request, response) unless response
+        raise ApiClient::Errors::ConnectionFailed.new(nil, request, response) unless response
         case response.status
           when 401
-            raise ApiClient::Errors::Unauthorized.new(request, response)
+            raise ApiClient::Errors::Unauthorized.new(nil, request, response)
           when 403
-            raise ApiClient::Errors::Forbidden.new(request, response)
+            raise ApiClient::Errors::Forbidden.new(nil, request, response)
           when 404
-            raise ApiClient::Errors::NotFound.new(request, response)
+            raise ApiClient::Errors::NotFound.new(nil, request, response)
           when 400
-            raise ApiClient::Errors::BadRequest.new(request, response)
+            raise ApiClient::Errors::BadRequest.new(nil, request, response)
           when 406
-            raise ApiClient::Errors::Unsupported.new(request, response)
+            raise ApiClient::Errors::Unsupported.new(nil, request, response)
           when 409
-            raise ApiClient::Errors::Conflict.new(request, response)
+            raise ApiClient::Errors::Conflict.new(nil, request, response)
           when 422
             raise ApiClient::Errors::UnprocessableEntity.new(response.body, request, response)
+          when 429
+            raise ApiClient::Errors::TooManyRequests.new(response.body, request, response)
           when 300..399
             raise ApiClient::Errors::Redirect.new(response['Location'], request, response)
           when 500..599
-            raise ApiClient::Errors::ServerError.new(request, response)
+            raise ApiClient::Errors::ServerError.new(nil, request, response)
           else
             response
         end

data/lib/api_client/errors.rb

@@ -22,6 +22,7 @@ module ApiClient
     class Conflict < ApiClientError; end
     class ServerError < ApiClientError; end
     class UnprocessableEntity < ApiClientError; end
+    class TooManyRequests < ApiClientError; end
   end
 
 end

data/lib/api_client/version.rb

@@ -1,3 +1,3 @@
 module ApiClient
-  VERSION = "0.5.9"
+  VERSION = "0.5.11"
 end

data/spec/api_client/connection/basic_spec.rb

@@ -89,71 +89,79 @@ describe ApiClient::Connection::Basic do
     it "raises an ApiClient::Errors::ConnectionFailed if there is no response" do
       lambda {
         @instance.send :handle_response, request, nil
-      }.should raise_error(ApiClient::Errors::ConnectionFailed)
+      }.should raise_error(ApiClient::Errors::ConnectionFailed, "ApiClient::Errors::ConnectionFailed")
     end
 
     it "raises an ApiClient::Errors::Unauthorized if status is 401" do
       @response.env[:status] = 401
       lambda {
         @instance.send :handle_response, request, @response
-      }.should raise_error(ApiClient::Errors::Unauthorized)
+      }.should raise_error(ApiClient::Errors::Unauthorized, "ApiClient::Errors::Unauthorized")
     end
 
     it "raises an ApiClient::Errors::Forbidden if status is 403" do
       @response.env[:status] = 403
       lambda {
         @instance.send :handle_response, request, @response
-      }.should raise_error(ApiClient::Errors::Forbidden)
+      }.should raise_error(ApiClient::Errors::Forbidden, "ApiClient::Errors::Forbidden")
     end
 
     it "raises an ApiClient::Errors::NotFound if status is 404" do
       @response.env[:status] = 404
       lambda {
         @instance.send :handle_response, request, @response
-      }.should raise_error(ApiClient::Errors::NotFound)
+      }.should raise_error(ApiClient::Errors::NotFound, "ApiClient::Errors::NotFound")
     end
 
     it "raises an ApiClient::Errors::BadRequest if status is 400" do
       @response.env[:status] = 400
       lambda {
         @instance.send :handle_response, request, @response
-      }.should raise_error(ApiClient::Errors::BadRequest)
+      }.should raise_error(ApiClient::Errors::BadRequest, "ApiClient::Errors::BadRequest")
     end
 
     it "raises an ApiClient::Errors::Unsupported if status is 406" do
       @response.env[:status] = 406
       lambda {
         @instance.send :handle_response, request, @response
-      }.should raise_error(ApiClient::Errors::Unsupported)
+      }.should raise_error(ApiClient::Errors::Unsupported, "ApiClient::Errors::Unsupported")
     end
 
     it "raises an ApiClient::Errors::Conflict if status is 409" do
       @response.env[:status] = 409
       lambda {
         @instance.send :handle_response, request, @response
-      }.should raise_error(ApiClient::Errors::Conflict)
+      }.should raise_error(ApiClient::Errors::Conflict, "ApiClient::Errors::Conflict")
     end
 
     it "raises an ApiClient::Errors::Unsupported if status is 422" do
       @response.env[:status] = 422
       lambda {
         @instance.send :handle_response, request, @response
-      }.should raise_error(ApiClient::Errors::UnprocessableEntity)
+      }.should raise_error(ApiClient::Errors::UnprocessableEntity, @response.body)
+    end
+
+    it "raises an ApiClient::Errors::TooManyRequests if status is 429" do
+      @response.env[:status] = 429
+      lambda {
+        @instance.send :handle_response, request, @response
+      }.should raise_error(ApiClient::Errors::TooManyRequests, @response.body)
     end
 
     it "raises an ApiClient::Errors::Unsupported if status is 300..399" do
+      location = "https://google.com"
       @response.env[:status] = 302
-      @response.env[:response_headers] = { 'Location' => "https://google.com" }
+      @response.env[:response_headers] = { 'Location' => location }
       lambda {
         @instance.send :handle_response, request, @response
-      }.should raise_error(ApiClient::Errors::Redirect)
+      }.should raise_error(ApiClient::Errors::Redirect, location)
     end
 
     it "raises an ApiClient::Errors::ServerError if status is 500..599" do
       @response.env[:status] = 502
       lambda {
         @instance.send :handle_response, request, @response
-      }.should raise_error(ApiClient::Errors::ServerError)
+      }.should raise_error(ApiClient::Errors::ServerError, "ApiClient::Errors::ServerError")
     end
 
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: api_client
 version: !ruby/object:Gem::Version
-  version: 0.5.9
+  version: 0.5.11
 platform: ruby
 authors:
 - Marcin Bunsch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-18 00:00:00.000000000 Z
+date: 2015-05-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: yajl-ruby