api_client 0.5.7 → 0.5.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: afef879f60d75b581ba06820fe2a817926984909
-  data.tar.gz: 3fc80dfc8684c9a7002cb5ef90f309621951c652
+  metadata.gz: 43c461e0ff353c1755880974f8704c1bee7176b0
+  data.tar.gz: f271d02470638507b7e5ddcd1b3e1c537d6d19fc
 SHA512:
-  metadata.gz: 572c68cf1e8c7da1d39afc7c15bce81b72a17f0f9046140492e327aa673f68bee195072d0a335dd3822981bb37dcc7ced9adc8e43fb9de04eb0c6b7b5a2ec3bf
-  data.tar.gz: 77c85f3c1f0c1da5644e61dd1b452caca2335a1ce5bc7093c5d03de7ffc5ca6b2a274f98e2f3c0a5232d3f737d1370bad3b166472dd95e00189f2b40211fc1b5
+  metadata.gz: 3dc40c025d6ebfd1e6e7e35be9b36f4a57feb5bbfc8c0c491bc2e73094964d881136cc79bf42dac693a02916fb4e057081bb5618ad490fe1421e193342cccac7
+  data.tar.gz: f5b8195b7f425819af8662333a62534c62251fa023c371499530cd90517cdee74b5b1e178321d1ad66411df5565c4ff446db83d81a727bf0edace6c0baf96d82

data/.travis.yml

@@ -0,0 +1,7 @@
+language: ruby
+script: bundle exec rspec spec
+rvm:
+  - 1.8.7
+  - 1.9.3
+  - 2.0.0
+  - 2.1.2

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+# 0.5.9
+
+ * fix compatibility with ruby 1.8.x
+
+# 0.5.8
+
+ * fix the problem with strict_attr_reader and Array#flatten
+
 # 0.5.7
 
  * fix compatibility with hashie 2.1.0 and strict_attr_reader

data/Gemfile

@@ -4,9 +4,8 @@ source "http://rubygems.org"
 gemspec
 
 # Testing
-gem "rspec"
 gem "simplecov"
 
 # Soft dependencies
-gem "simple_oauth"
+gem "simple_oauth", '0.2.0'
 gem 'multi_xml'

data/README.md

@@ -1,4 +1,4 @@
-ApiClient
+ApiClient [![Build Status](https://travis-ci.org/futuresimple/api_client.svg?branch=master)](https://travis-ci.org/futuresimple/api_client)
 =========
 
 ApiClient is an experimental builder for HTTP API clients. The goal is to provide a easy to use engine for constructing queries and map the responses to instances of Hashie::Mash subclasses.

data/api_client.gemspec

@@ -7,7 +7,7 @@ Gem::Specification.new do |s|
   s.version     = ApiClient::VERSION
   s.authors     = ["Marcin Bunsch"]
   s.email       = ["marcin@futuresimple.com"]
-  s.homepage    = ""
+  s.homepage    = "https://github.com/futuresimple/api_client"
   s.summary     = %q{API client builder}
   s.description = %q{API client builder}
 
@@ -47,6 +47,8 @@ Gem::Specification.new do |s|
     s.add_dependency(%q<multi_json>, [">= 1.6.1"])
   end
 
+  s.add_development_dependency "rspec", '2.14.1'
+
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }

data/lib/api_client/base.rb

@@ -60,13 +60,19 @@ module ApiClient
     def method_missing(method_name, *args, &blk)
       if respond_to?(method_name) || has_special_ending?(method_name)
         super
-      elsif respond_to?(:strict_attr_reader?) && self.strict_attr_reader?
+      elsif use_strict_reader?(method_name)
         fetch(method_name)
       else
         super
       end
     end
 
+    def use_strict_reader?(method_name)
+      respond_to?(:strict_attr_reader?) &&
+        self.strict_attr_reader? &&
+        method_name != :to_ary
+    end
+
     def has_special_ending?(name)
       name.to_s =~ /[?=]$/
     end

data/lib/api_client/connection/basic.rb

@@ -76,7 +76,7 @@ module ApiClient
 
       def exec_request(method, path, data, headers)
         response = @handler.send(method, path, data, headers)
-        request = {method: method, path: path, data: data}
+        request = { :method => method, :path => path, :data => data}
         handle_response(request, response)
       rescue Faraday::Error::ConnectionFailed => e
         raise ApiClient::Errors::ConnectionFailed.new(e.message, request, response)

data/lib/api_client/errors.rb

@@ -2,7 +2,7 @@ module ApiClient
 
   module Errors
     class ApiClientError < StandardError
-      def initialize(message=nil, request, response)
+      def initialize(message = nil, request = nil, response = nil)
         super(message)
         @request = request
         @response = response

data/lib/api_client/version.rb

@@ -1,3 +1,3 @@
 module ApiClient
-  VERSION = "0.5.7"
+  VERSION = "0.5.9"
 end

data/spec/api_client/base_spec.rb

@@ -23,6 +23,16 @@ describe ApiClient::Base do
   class StrictDescendant < StrictApi
   end
 
+  context "when used in an array" do
+
+    subject { [StrictApi.new] }
+
+    it "does not break Array#flatten" do
+      lambda { subject.flatten }.should_not raise_error
+    end
+
+  end
+
   describe "#inspect" do
 
     it "has a nice inspect" do
@@ -50,7 +60,10 @@ describe ApiClient::Base do
   describe "strict_read" do
     it "fails if the key is missing and strict_read is set" do
       api = StrictApi.new
-      lambda { api.missing }.should raise_error(KeyError)
+      lambda { api.missing }.should raise_error do |error|
+        error_type = error.class.to_s
+        error_type.should match(/KeyError|IndexError/)
+      end
     end
 
     it "doesn't fail if strict_read is not set" do
@@ -77,12 +90,18 @@ describe ApiClient::Base do
 
     it "calling method which asks for missing attribute fails" do
       api = StrictApi.new
-      lambda { api.accessor_of_x }.should raise_error(KeyError)
+      lambda { api.accessor_of_x }.should raise_error do |error|
+        error_type = error.class.to_s
+        error_type.should match(/KeyError|IndexError/)
+      end
     end
 
     it "passes strict api configuration to subclasses" do
       api = StrictDescendant.new
-      lambda { api.missing }.should raise_error(KeyError)
+      lambda { api.missing }.should raise_error do |error|
+        error_type = error.class.to_s
+        error_type.should match(/KeyError|IndexError/)
+      end
     end
   end
 end

data/spec/api_client/connection/request/logger_spec.rb

@@ -13,7 +13,7 @@ describe ApiClient::Connection::Middlewares::Request::Logger do
     }
     app.should_receive(:call).with(env)
     instance.call(env)
-    logger.history.first.should == "GET http://api.twitter.com: 0.0000 seconds"
+    logger.history.first.include?("GET http://api.twitter.com").should be_true
   end
 
 end

metadata

@@ -1,71 +1,85 @@
 --- !ruby/object:Gem::Specification
 name: api_client
 version: !ruby/object:Gem::Version
-  version: 0.5.7
+  version: 0.5.9
 platform: ruby
 authors:
 - Marcin Bunsch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-14 00:00:00.000000000 Z
+date: 2015-02-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: yajl-ruby
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.8.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.8.1
 - !ruby/object:Gem::Dependency
   name: hashie
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.0.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.0.5
 - !ruby/object:Gem::Dependency
   name: multi_json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.6.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.6.1
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 2.14.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 2.14.1
 description: API client builder
 email:
 - marcin@futuresimple.com
@@ -73,8 +87,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE
@@ -130,7 +145,7 @@ files:
 - spec/spec_helper.rb
 - spec/support/fake_logger.rb
 - spec/support/matchers.rb
-homepage: ''
+homepage: https://github.com/futuresimple/api_client
 licenses: []
 metadata: {}
 post_install_message: 
@@ -139,17 +154,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: api_client
-rubygems_version: 2.0.5
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 3
 summary: API client builder