api_client 0.5.5 → 0.5.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e75ec00cdefbe47d4ee0caa12b10c34ab5cba4b0
-  data.tar.gz: afbeaf9ee0f28b3329a6e6fa2f7f0e2be2cce2b0
+  metadata.gz: c2dce33109687e5c643cd183ef8c656d56af40d4
+  data.tar.gz: 97d0acdf47edc3ed2a03a00d3085c9b897687da3
 SHA512:
-  metadata.gz: 52f9614349cba9dd65884cbf39d9d82044da778025da0a96efbe6b4ebf8fc58b0491e76fa571117cc4434de5ce0148c5acb9b71eec5fd30c0fed2607be75e03b
-  data.tar.gz: 7d8fd7a2deab23da2844c5b9bcafa81f0e5af203c0a5e5ef8ff1788ca611ccadb18ca099ea3b133fe50efb5866801d8b797f4908fc1bf397f32618f5549274de
+  metadata.gz: db347b7180f5ec2296438e1be6ae95ee51fff531fd1d3d703948f5880af427ac07e89e682b6519b52f17d7ee9ce39e47a3e89fa50d57cf7b314c2bd05b5b64db
+  data.tar.gz: eb9d837428478b41fefba7725c30bfd4093fcfe98daae2a3f19bd89673429989051dab0e6acc14276acde7bbec87823dea53663223bcfb13535ac316c87b56c0

data/CHANGELOG.md

@@ -0,0 +1,3 @@
+# 0.5.6
+
+ * add strict_attr_reader option to raise `KeyError` on missing key access

data/lib/api_client/base.rb

@@ -56,7 +56,17 @@ module ApiClient
       "#<#{self.class} #{attributes.join(', ')}>"
     end
 
+    private
+    def method_missing(method_name, *args, &blk)
+      if respond_to?(method_name)
+        super
+      else
+        if respond_to?(:strict_attr_reader?) && self.strict_attr_reader?
+          fetch(method_name)
+        else
+          super
+        end
+      end
+    end
   end
-
 end
-

data/lib/api_client/version.rb

@@ -1,3 +1,3 @@
 module ApiClient
-  VERSION = "0.5.5"
+  VERSION = "0.5.6"
 end

data/spec/api_client/base_spec.rb

@@ -10,6 +10,18 @@ describe ApiClient::Base do
     subject.should respond_to("id")
   end
 
+  class StrictApi < ApiClient::Base
+    def accessor_of_x
+      self.x
+    end
+
+    def strict_attr_reader?
+      true
+    end
+  end
+
+  class StrictDescendant < StrictApi
+  end
 
   describe "#inspect" do
 
@@ -35,4 +47,36 @@ describe ApiClient::Base do
 
   end
 
+  describe "strict_read" do
+    it "fails if the key is missing and strict_read is set" do
+      api = StrictApi.new
+      lambda { api.missing }.should raise_error(KeyError)
+    end
+
+    it "doesn't fail if strict_read is not set" do
+      api = ApiClient::Base.new
+      api.missing
+    end
+
+    it "doesn't fail if the key was set after object was created" do
+      api = StrictApi.new
+      api.not_missing = 1
+      api.not_missing.should == 1
+    end
+
+    it "allows to call methods" do
+      api = StrictApi.new(:x => 14)
+      api.accessor_of_x.should == 14
+    end
+
+    it "calling method which asks for missing attribute fails" do
+      api = StrictApi.new
+      lambda { api.accessor_of_x }.should raise_error(KeyError)
+    end
+
+    it "passes strict api configuration to subclasses" do
+      api = StrictDescendant.new
+      lambda { api.missing }.should raise_error(KeyError)
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: api_client
 version: !ruby/object:Gem::Version
-  version: 0.5.5
+  version: 0.5.6
 platform: ruby
 authors:
 - Marcin Bunsch
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-05 00:00:00.000000000 Z
+date: 2014-04-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: yajl-ruby
@@ -75,6 +75,7 @@ extra_rdoc_files: []
 files:
 - .gitignore
 - .rspec
+- CHANGELOG.md
 - Gemfile
 - LICENSE
 - README.md