api2cart-ruby 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f7da9d481a2ca97c77288a08317918fd795b742a
-  data.tar.gz: 93d0a824c3299f4d50a073b3f2583123fad82e97
+  metadata.gz: 8ab8789095578d475cb638aacf6de3673d879716
+  data.tar.gz: 9e86285773bf57ac40fd5976a39bcac6ffb3d5c3
 SHA512:
-  metadata.gz: e634e1f644cfdf641eec2c9d3da682d457bd7c3d6239ac33552eacf2f0e0e628582713e1de5e7083f9969af65bf77d54e9463716e09e40fb562a5d4cde46071f
-  data.tar.gz: f0957f17c4002a871b3db006dfbe79ad12a9d44d5433d080f74662831c36538a154480a2dd9a8b10cefb8e8aee86819271ed921fdf36f07c1237f50ff13cacee
+  metadata.gz: 821124ef0dbbf9b7a18c6576231001f66dc8008ca631792cdaeb7ed230ecc93e5dfa0a111874a17e93565a39da0d76e311e9f5bf55f92227f37df542c03eee17
+  data.tar.gz: d56756525e4a7824f6b1657e2dd980527ea81cd508819dbb20ccc668882dac9b3e30b1487a0ec3c096c95ce6e42d8b20e87015811b135c0df2fffeeb4a29bb01

data/README.md

@@ -32,4 +32,10 @@ Api2cart::Store.new(api_key, store_key, proxy: 'http://anti-throttling-proxy.loc
 # => { 'products_count' => 76 }
 ```
 
+## Contributors
+
+* [Anton Pershakov](https://github.com/main24)
+* [Daniel Vartanov](https://github.com/DanielVartanov)
+* [Tom Procter](https://github.com/TDProcter)
+
 Sponsored by [Veeqo](https://github.com/veeqo)

data/api2cart-ruby.gemspec

@@ -7,7 +7,7 @@ Gem::Specification.new do |spec|
   spec.name          = "api2cart-ruby"
   spec.version       = Api2cart::VERSION
 
-  spec.authors       = ["Tom Procter", "Daniel Vartanov"].sort
+  spec.authors       = ["Tom Procter", "Daniel Vartanov", "Anton Pershakov"].sort
   spec.email         = ["tom@procterweb.co.uk", "dan@vartanov.net"]
 
   spec.summary       = %q{Ruby client for API2Cart}

data/lib/api2cart/client.rb

@@ -4,8 +4,10 @@ require 'active_support/core_ext/object/blank'
 
 module Api2cart
   class Client < Struct.new(:request_url, :proxy_url)
+    READ_TIMEOUT = 2000
+
     def make_request!
-      self.response_body = net_http_class.get_response(request_url).body
+      self.response_body = net_http.get(request_url.request_uri).body
     end
 
     def successful?
@@ -36,10 +38,14 @@ module Api2cart
       @parsed_proxy_url ||= URI.parse proxy_url
     end
 
-    def net_http_class
-      proxy_url.present? ?
-        Net::HTTP::Proxy(parsed_proxy_url.host, parsed_proxy_url.port) :
-        Net::HTTP
+    def net_http
+      if proxy_url.present?
+        Net::HTTP.new request_url.host, request_url.port, parsed_proxy_url.host, parsed_proxy_url.port
+      else
+        Net::HTTP.new request_url.host, request_url.port
+      end.tap do |net_http|
+        net_http.read_timeout = READ_TIMEOUT
+      end
     end
   end
 end

data/lib/api2cart/version.rb

@@ -1,3 +1,3 @@
 module Api2cart
-  VERSION = "1.1.0"
+  VERSION = "1.2.0"
 end

data/spec/api2cart/with_proxy_spec.rb

@@ -12,7 +12,7 @@ describe Api2cart do
     end
 
     it 'extracts hostname and port from proxy URL' do
-      expect(Net::HTTP).to receive(:Proxy).with('anti-throttling-proxy.local', 1080).and_call_original
+      expect(Net::HTTP).to receive(:new).with('api.api2cart.com', 80, 'anti-throttling-proxy.local', 1080).and_call_original
       store_with_proxy.product_count
     end
   end

metadata

@@ -1,15 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: api2cart-ruby
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
+- Anton Pershakov
 - Daniel Vartanov
 - Tom Procter
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-02 00:00:00.000000000 Z
+date: 2015-01-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -171,7 +172,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.2
+rubygems_version: 2.4.4
 signing_key: 
 specification_version: 4
 summary: Ruby client for API2Cart