api-client 1.8.1 → 1.8.2

data/.gitignore

@@ -3,6 +3,7 @@
 .bundle
 .config
 .yardoc
+*.swp
 Gemfile.lock
 InstalledFiles
 _yardoc
@@ -12,4 +13,4 @@ lib/bundler/man
 pkg
 rdoc
 spec/reports
-tmp
+tmp

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## v1.8.2
+
+* Fixed Query String Bug (It was been sent empty)
+
 ## v1.8.1
 
 * Fixed a Bug when response was an Array.

data/README.md

@@ -1,9 +1,30 @@
-# ApiClient - Client to call Api easily.
+# ApiClient
 
 [![Build Status](https://secure.travis-ci.org/zertico/api-client.png?branch=master)](http://travis-ci.org/zertico/api-client) [![Code Climate](https://codeclimate.com/badge.png)](https://codeclimate.com/github/zertico/api-client)
 
+ApiClient handle all the logic necessary to call Some API, catch the response and initialize an object with it for you.
+It is possible to use Typhoeus or the native Ruby Library Net::Http.
+It works very well with rails, so you can exchange your ActiveRecord based models without any concern and your application will make Api calls transparently.
 It supports ruby 1.8.7, 1.9.2, 1.9.3, jruby and ree out of the box.
 
+## Useful Links
+
+### Mailing List
+
+If you have any questions, comments, or concerns, please use the Google Group instead of the Github issue tracker:
+
+[https://groups.google.com/forum/#!forum/zertico-api-client](https://groups.google.com/forum/#!forum/zertico-api-client)
+
+### Documentation
+
+You can find the code documentation for the last version generated by Yard on this link:
+
+[http://rdoc.info/gems/api-client/frames](http://rdoc.info/gems/api-client/frames)
+
+### Changelog
+
+[https://github.com/zertico/api-client/blob/master/CHANGELOG.md](https://github.com/zertico/api-client/blob/master/CHANGELOG.md)
+
 ## Installation
 
 Add this line to your application's Gemfile:

data/examples/controllers/application_controller.rb

@@ -3,16 +3,23 @@ class ApplicationController < ActionController::Base
   respond_to :html
 
   # NotFound errors will be redirected to the action not_found while any other will be redirected to the action generic.
+  rescue_from ApiClient::Exceptions::Unauthorized, :with => :unauthorized_access
   rescue_from ApiClient::Exceptions::NotFound, :with => :not_found
   rescue_from ApiClient::Exceptions::Generic, :with => :generic
 
   # This code is only for example purposes.
   # Any behavior can be executed here. Just write your own.
+  def unauthorized_access
+    redirect_to "http://www.example.com/sign_in?redirect_uri=#{request.url}"
+  end
+
   def not_found
     ApplicationMailer.send_not_found_notice.deliver
+    render :file => "/public/404.html", :status => 404
   end
 
-  def generic
-    ApplicationMailer.send_generic_error.deliver
+  def generic(exception)
+    ApplicationMailer.send_generic_error(exception).deliver
+    render :file => "/public/404.html", :status => 404
   end
-end
+end

data/lib/api-client/base.rb

@@ -15,11 +15,15 @@ module ApiClient
     # @return [Hash] the request response.
     attr_accessor :response
 
+    # @return [Hash] the errors object.
+    attr_reader :errors
+
     # Initialize an object based on a hash of attributes.
     #
     # @param [Hash] attributes object attributes.
     # @return [Base] the object initialized.
     def initialize(attributes = {})
+      @errors = Errors.new(self)
       attributes.each do |name, value|
         send("#{name.to_s}=", value)
       end
@@ -94,19 +98,11 @@ module ApiClient
 
     alias_method :to_hash, :attributes
 
-    # Return the hash of errors if existent, otherwise instantiate a new ApiClient::Errors object with self.
-    #
-    # @return [ApiClient::Errors] the validation errors.
-    def errors
-      @errors ||= Errors.new(self)
-    end
-
     # Set the hash of errors, making keys symbolic.
     #
     # @param [Hash] errors of the object.
     def errors=(errs = {})
-      @errors = Errors.new(self)
-      @errors.add_errors(Hash[errs.map{|(key,value)| [key.to_sym,value]}])
+      errors.add_errors(Hash[errs.map{|(key,value)| [key.to_sym,value]}])
     end
 
     protected

data/lib/api-client/dispatcher/net-http.rb

@@ -10,7 +10,7 @@ module ApiClient::Dispatcher::NetHttp
   # @return [HTTP] the response object.
   def self.get(url, header = {})
     initialize_connection(url)
-    call { @http.get(@uri.path, { 'Content-Type' => 'application/json' }.merge(header)) }
+    call { @http.get(@uri.request_uri, { 'Content-Type' => 'application/json' }.merge(header)) }
   end
 
   # Make a post request and returns it.
@@ -21,7 +21,7 @@ module ApiClient::Dispatcher::NetHttp
   # @return [HTTP] the response object.
   def self.post(url, args, header = {})
     initialize_connection(url)
-    call { @http.post(@uri.path, args.to_json, { 'Content-Type' => 'application/json' }.merge(header)) }
+    call { @http.post(@uri.request_uri, args.to_json, { 'Content-Type' => 'application/json' }.merge(header)) }
   end
 
   # Make a put request and returns it.
@@ -32,7 +32,7 @@ module ApiClient::Dispatcher::NetHttp
   # @return [HTTP] the response object.
   def self.put(url, args, header = {})
     initialize_connection(url)
-    call { @http.put(@uri.path, args.to_json, { 'Content-Type' => 'application/json' }.merge(header)) }
+    call { @http.put(@uri.request_uri, args.to_json, { 'Content-Type' => 'application/json' }.merge(header)) }
   end
 
   # Make a patch request and returns it.
@@ -43,7 +43,7 @@ module ApiClient::Dispatcher::NetHttp
   # @return [HTTP] the response object.
   def self.patch(url, args, header = {})
     initialize_connection(url)
-    call { @http.patch(@uri.path, args.to_json, { 'Content-Type' => 'application/json' }.merge(header)) }
+    call { @http.patch(@uri.request_uri, args.to_json, { 'Content-Type' => 'application/json' }.merge(header)) }
   end
 
   # Make a delete request and returns it.
@@ -53,15 +53,14 @@ module ApiClient::Dispatcher::NetHttp
   # @return [HTTP] the response object.
   def self.delete(url, header = {})
     initialize_connection(url)
-    call { @http.delete(@uri.path, header) }
+    call { @http.delete(@uri.request_uri, header) }
   end
 
   protected
 
   def self.initialize_connection(url = '')
     @uri = URI(url)
-    @uri.path = "/" if @uri.path.blank?
-    @http = Net::HTTP.new(@uri.host, @uri.port)
+    @http = Net::HTTP.start(@uri.host, @uri.port)
   end
 
   def self.call

data/lib/api-client/parser.rb

@@ -1,3 +1,5 @@
+require 'json'
+
 # ApiClient::Parser provides a method to parse the request response.
 module ApiClient::Parser
   # Parse the JSON response.
@@ -7,8 +9,8 @@ module ApiClient::Parser
   def self.response(response)
     raise_exception(response.code)
     begin
-      object = JSON.parse(response.body)
-    rescue JSON::ParserError, TypeError
+      object = ::JSON.parse(response.body)
+    rescue ::JSON::ParserError, TypeError
       object = {}
     end
     object

data/lib/api-client/version.rb

@@ -1,5 +1,5 @@
 # High Level Namespace of the library ApiClient.
 module ApiClient
   # Version of the library.
-  VERSION = "1.8.1"
+  VERSION = "1.8.2"
 end

data/spec/api-client/base_spec.rb

@@ -14,6 +14,10 @@ describe ApiClient::Base do
       it "should set #b" do
         @user.b.should == "b"
       end
+
+      it "should initialize errors" do
+        @user.errors.should be_an_instance_of(ApiClient::Errors)
+      end
     end
   end
 
@@ -69,28 +73,6 @@ describe ApiClient::Base do
     end
   end
 
-  describe "#errors" do
-    context "when @errors is not nil" do
-      before :each do
-        @user = User.new(:errors => {:a => :invalid})
-      end
-
-      it "should return the errors" do
-        @user.errors.messages.should == {:a => ['is invalid']}
-      end
-    end
-
-    context "when @errors is nil" do
-      before :each do
-        @user = User.new
-      end
-
-      it "should instantiate a new instance of ApiClient::Errors" do
-        @user.errors.should be_an_instance_of(ApiClient::Errors)
-      end
-    end
-  end
-
   describe "#errors=" do
     before :each do
       @user = User.new(:errors => { "a" => "message", "b" => "message" })

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: api-client
 version: !ruby/object:Gem::Version
-  version: 1.8.1
+  version: 1.8.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-02 00:00:00.000000000 Z
+date: 2012-10-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -165,18 +165,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 1498468142604583220
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 1498468142604583220
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24