api-auth 1.3.1 → 1.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8df4c4b6537d3646e5159fb10b1ff7839455cd96
-  data.tar.gz: c50289d2bca57c241f41bbdbf5c9a268505c18ab
+  metadata.gz: 2cd28f63f509490e9930a666f6825bbfd58b2bb7
+  data.tar.gz: 0c5c85110090293af02dd2c2d2ded29ebf2c1589
 SHA512:
-  metadata.gz: 2d11fd71f2ec739b442c1e87c350cc4ec09dd5f1c5acff642abed86a5162654da541eb73d6a3f2146cea3dd07b265741e778e5cdf48da472e00b5404fa1ef07e
-  data.tar.gz: 27cc78257708f8f96f95cf4ef1ceb3070c37b30330a1ba8c22278c0891601166345d3a803add2762f9b8bb6dee2d46aa7bdf87f923c4a59943fba3ddb9c95694
+  metadata.gz: 7bdd120e4c0e769a1ac1e67051f5e69675204e4f511eaece5cb0f967604cf2c2fbea3f44d80b7f8b947fa82e7888b0938e98517be0a3267fab11064de1f782c1
+  data.tar.gz: f12c425faa929ed3aa9ca0fabbcd44d89e4fdd42f65a974df2a35c112a9503b5279a9965c30a6c679d5973a6e43fd47e7717ea66c803733241c1baa29f50f408

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 1.3.2 (2015-08-28)
+- Fixed a bug where some client adapters didn't treat an empty path as
+  "/" in the canonical string (#75 managr)
+
 # 1.3.1 (2015-03-13)
 - Fixed a bug where Faraday requests with no parameters were not signed
   correctly (#65 nathanhoel)

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    api-auth (1.3.1)
+    api-auth (1.3.2)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -120,6 +120,15 @@ single configuration line:
 
 This will automatically sign all outgoing ActiveResource requests from your app.
 
+### Active Rest Client
+
+ApiAuth also works with [ActiveRestClient](https://github.com/whichdigital/active-rest-client) in a very similar way.
+Simply add this configuration to your ActiveRestClient initializer in your app and it will automatically sign all outgoing requests.
+
+``` ruby
+ActiveRestClient::Base.api_auth_credentials(@access_id, @secret_key)
+```
+
 ## Server
 
 ApiAuth provides some built in methods to help you generate API keys for your

data/VERSION

@@ -1 +1 @@
-1.3.1
+1.3.2

data/gemfiles/rails_23.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    api-auth (1.3.1)
+    api-auth (1.3.2)
 
 GEM
   remote: https://rubygems.org/

data/gemfiles/rails_30.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    api-auth (1.3.1)
+    api-auth (1.3.2)
 
 GEM
   remote: https://rubygems.org/

data/gemfiles/rails_31.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    api-auth (1.3.1)
+    api-auth (1.3.2)
 
 GEM
   remote: https://rubygems.org/

data/gemfiles/rails_32.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    api-auth (1.3.1)
+    api-auth (1.3.2)
 
 GEM
   remote: https://rubygems.org/

data/gemfiles/rails_4.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    api-auth (1.3.1)
+    api-auth (1.3.2)
 
 GEM
   remote: https://rubygems.org/

data/gemfiles/rails_41.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    api-auth (1.3.1)
+    api-auth (1.3.2)
 
 GEM
   remote: https://rubygems.org/

data/lib/api_auth/headers.rb

@@ -55,7 +55,7 @@ module ApiAuth
     def canonical_string
       [ @request.content_type,
         @request.content_md5,
-        @request.request_uri.gsub(/https?:\/\/[^(,|\?|\/)]*/,''), # remove host
+        parse_uri(@request.request_uri), 
         @request.timestamp
       ].join(",")
     end
@@ -90,6 +90,12 @@ module ApiAuth
       @request.set_auth_header header
     end
 
-  end
+    private
 
+    def parse_uri(uri)
+      uri_without_host = uri.gsub(/https?:\/\/[^(,|\?|\/)]*/, '')
+      return '/' if uri_without_host.empty?
+      uri_without_host
+    end
+  end
 end

data/spec/headers_spec.rb

@@ -1,6 +1,6 @@
 require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 
-describe "ApiAuth::Headers" do
+describe ApiAuth::Headers do
 
   CANONICAL_STRING = "text/plain,e59ff97941044f85df5297e1c302d260,/resource.xml?foo=bar&bar=foo,Mon, 23 Jan 1984 03:29:56 GMT"
 
@@ -300,4 +300,40 @@ describe "ApiAuth::Headers" do
      end
    end
 
+  describe '#canonical_string' do
+    let(:request) { RestClient::Request.new(:url => uri, :method => :get) }
+    subject { described_class.new(request) }
+
+    context 'empty uri' do
+      let(:uri) { ''.freeze }
+
+      it 'adds / to canonical string' do
+        subject.canonical_string.should eq(',,/,')
+      end
+    end
+
+    context 'uri with just host without /' do
+      let(:uri) { 'http://google.com'.freeze }
+
+      it 'return / as canonical string path' do
+        subject.canonical_string.should eq(',,/,')
+      end
+
+      it 'does not change request url (by removing host)' do
+        request.url.should eq(uri)
+      end
+    end
+
+    context 'uri with host and /' do
+      let(:uri) { 'http://google.com/'.freeze }
+
+      it 'return / as canonical string path' do
+        subject.canonical_string.should eq(',,/,')
+      end
+
+      it 'does not change request url (by removing host)' do
+        request.url.should eq(uri)
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: api-auth
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 1.3.2
 platform: ruby
 authors:
 - Mauricio Gomes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-13 00:00:00.000000000 Z
+date: 2015-08-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: appraisal
@@ -251,7 +251,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: Simple HMAC authentication for your APIs
@@ -264,3 +264,4 @@ test_files:
 - spec/railtie_spec.rb
 - spec/spec_helper.rb
 - spec/test_helper.rb
+has_rdoc: