api-auth 1.3.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ee9363c952d199ecc16cd1f3395e5ac5bb6637b5
-  data.tar.gz: 13ebba43bab52e75146b91ff0d81a3e876a8ac1b
+  metadata.gz: 8df4c4b6537d3646e5159fb10b1ff7839455cd96
+  data.tar.gz: c50289d2bca57c241f41bbdbf5c9a268505c18ab
 SHA512:
-  metadata.gz: fbd418e5584e7b84feb9070efac57c2a4215c011065884ef60e9d2a276f93d2c40b59f4c2eca22e1313aefaa6929726af3517d7f92353212c544f01e58c02770
-  data.tar.gz: 3052ae92cca8d52d3d40f53ba030266e0273b72679cf568e4ccbdb447efed94020b1b2d33f7a3426a54e825d6c32c4f4c6657af216debaaad18491ce0ccc6955
+  metadata.gz: 2d11fd71f2ec739b442c1e87c350cc4ec09dd5f1c5acff642abed86a5162654da541eb73d6a3f2146cea3dd07b265741e778e5cdf48da472e00b5404fa1ef07e
+  data.tar.gz: 27cc78257708f8f96f95cf4ef1ceb3070c37b30330a1ba8c22278c0891601166345d3a803add2762f9b8bb6dee2d46aa7bdf87f923c4a59943fba3ddb9c95694

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 1.3.1 (2015-03-13)
+- Fixed a bug where Faraday requests with no parameters were not signed
+  correctly (#65 nathanhoel)
+
 # 1.3.0 (2015-03-12)
 - Add a Faraday Request Driver (#64 nathanhoel)
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    api-auth (1.3.0)
+    api-auth (1.3.1)
 
 GEM
   remote: https://rubygems.org/

data/VERSION

@@ -1 +1 @@
-1.3.0
+1.3.1

data/gemfiles/rails_23.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    api-auth (1.3.0)
+    api-auth (1.3.1)
 
 GEM
   remote: https://rubygems.org/

data/gemfiles/rails_30.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    api-auth (1.3.0)
+    api-auth (1.3.1)
 
 GEM
   remote: https://rubygems.org/

data/gemfiles/rails_31.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    api-auth (1.3.0)
+    api-auth (1.3.1)
 
 GEM
   remote: https://rubygems.org/

data/gemfiles/rails_32.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    api-auth (1.3.0)
+    api-auth (1.3.1)
 
 GEM
   remote: https://rubygems.org/

data/gemfiles/rails_4.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    api-auth (1.3.0)
+    api-auth (1.3.1)
 
 GEM
   remote: https://rubygems.org/

data/gemfiles/rails_41.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    api-auth (1.3.0)
+    api-auth (1.3.1)
 
 GEM
   remote: https://rubygems.org/

data/lib/api_auth/request_drivers/faraday.rb

@@ -56,7 +56,9 @@ module ApiAuth
       end
 
       def request_uri
-        uri = URI::HTTP.new(nil, nil, nil, nil, nil, @request.path, nil, @request.params.to_query, nil)
+        query_string = @request.params.to_query
+        query_string = nil if query_string.empty?
+        uri = URI::HTTP.new(nil, nil, nil, nil, nil, @request.path, nil, query_string, nil)
         uri.to_s
       end
 

data/spec/api_auth_spec.rb

@@ -570,6 +570,7 @@ describe "ApiAuth" do
       before(:each) do
         stubs = Faraday::Adapter::Test::Stubs.new do |stub|
           stub.put('/resource.xml?foo=bar&bar=foo') { [200, {}, ''] }
+          stub.put('/resource.xml') { [200, {}, ''] }
         end
 
         @faraday_conn = Faraday.new do |builder|
@@ -625,7 +626,7 @@ describe "ApiAuth" do
         @signed_request.headers['Authorization'].should == "APIAuth 1044:#{hmac(@secret_key, @request)}"
       end
 
-      it "should authenticate a valid request" do
+      it "should authenticate a valid request with parameters" do
         ApiAuth.authentic?(@signed_request, @secret_key).should be_true
       end
 
@@ -660,6 +661,26 @@ describe "ApiAuth" do
       it "should retrieve the access_id" do
         ApiAuth.access_id(@signed_request).should == "1044"
       end
+
+      describe 'request_uri' do
+        context 'with parameters' do
+          it "should return urls with a query string" do
+            req = ::ApiAuth::RequestDrivers::FaradayRequest.new(@request)
+            req.request_uri.should == '/resource.xml?bar=foo&foo=bar'
+          end
+        end
+
+        context 'without parameters' do
+          it "should return urls with no query string" do
+            @faraday_conn.put '/resource.xml' do |request|
+              request.headers.merge!({'content-type' => 'text/plain',
+                                       'DATE' => Time.now.utc.httpdate})
+              req = ::ApiAuth::RequestDrivers::FaradayRequest.new(request)
+              req.request_uri.should == '/resource.xml'
+            end
+          end
+        end
+      end
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: api-auth
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Mauricio Gomes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-12 00:00:00.000000000 Z
+date: 2015-03-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: appraisal