apadmi_grout 2.2.3 → 2.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 454ad88ccf8626779e456e3960bf0cb518befae8383418865dceffd8116e4bad
-  data.tar.gz: 2e17f78ac813ccb6d7d6571b38c34e98f2584456626e4bd953ebf5346050b379
+  metadata.gz: 8a044d2b76db5a199809db40b238d152df0b91b85f0092730177b60a104b5f9d
+  data.tar.gz: 9d46bc9e4c75765bd2fa056494af0cd42cfa72e623d331cac330da97388121cc
 SHA512:
-  metadata.gz: 5d1babf7b932f6c92637c9fe22e2ec9814630043356c3fa36092551b7a181440bd23d539329fe053de27260da2664c2b7ba0db00cc73ee3ffa585584c210a770
-  data.tar.gz: b2d9904a1de99ed5bbbe8e401447a98f58b4514616853296828d17f7c743ffafa8a129858bd3bf3fbd90ea5e8701856771f2a45492ada3d6afe34bc651013f13
+  metadata.gz: bb6d2a7ca64f3a9127ea8f625d1010e89e1febf0b25c787eaecacbe064e27da85ae82e587ed993c357fee1587e67c59cc41897712b4dc536e6b7ce9d6fb32dc9
+  data.tar.gz: 674d00cfa25d7fce59f316dea0fd63ab2aef0b21ca31d4ed583c132cc679dda8ec3421e6b9339a47c60d4b12ea3a614f614a36f3e73581d570e2f015dad6a95c

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Core Changelog
 
+## [2.3.1] - 2023-04-05
+* Makes loading pull request information more robust for situations where a ticket has no PRs.
+
+## [2.3.0] - 2023-04-03
+* No changes, version bump to keep in sync with fastlane plugin.
+
 ## [2.2.3] - 2023-01-26
 * Filter tickets with id 0 from changelog since these are almost always just placeholders.
 

data/lib/apadmi/grout/service/board_service/jira_board_service.rb

@@ -137,9 +137,12 @@ module Apadmi
         query_string = "issueId=#{issue.raw_object.id}&applicationType=bitbucket&dataType=pullrequest"
         response = @network_service.do_get("/rest/dev-status/latest/issue/details?#{query_string}")
 
-        return [] if JSON.parse(response.body)["detail"].empty?
+        parsed_detail = JSON.parse(response.body)["detail"]
 
-        JSON.parse(response.body)["detail"][0]["pullRequests"].map do |pr|
+        return [] if parsed_detail.empty?
+        return [] unless parsed_detail[0].key?("pullRequests")
+
+        parsed_detail[0]["pullRequests"].map do |pr|
           PullRequest.new(pr["id"], pr["name"], pr["status"].to_s == "MERGED", pr["status"].to_s == "DECLINED")
         end
       end

data/lib/apadmi/grout/utils/command_parsing_utils.rb

@@ -0,0 +1,24 @@
+# frozen_string_literal: true
+
+module AndroidBuildType
+  AAB = "aab"
+  APK = "apk"
+end
+
+module Apadmi
+  module Grout
+    # Generic Command parsing Utils
+    class CommandParsingUtils
+      def self.determining_build_type(command)
+        raise "Command can't be blank" if command.blank?
+
+        split = command.split(":", -1).last
+
+        return AndroidBuildType::APK if split.starts_with?("assemble")
+        return AndroidBuildType::AAB if split.starts_with?("bundle")
+
+        raise "Could not determine if #{command} generates an apk or aab"
+      end
+    end
+  end
+end

data/lib/apadmi/grout/version.rb

@@ -2,6 +2,6 @@
 
 module Apadmi
   module Grout
-    VERSION = "2.2.3"
+    VERSION = "2.3.1"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: apadmi_grout
 version: !ruby/object:Gem::Version
-  version: 2.2.3
+  version: 2.3.1
 platform: ruby
 authors:
 - Apadmi
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2023-01-26 00:00:00.000000000 Z
+date: 2023-04-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -83,6 +83,7 @@ files:
 - lib/apadmi/grout/service/board_service/ado_board_service.rb
 - lib/apadmi/grout/service/board_service/board_service.rb
 - lib/apadmi/grout/service/board_service/jira_board_service.rb
+- lib/apadmi/grout/utils/command_parsing_utils.rb
 - lib/apadmi/grout/utils/filename_utils.rb
 - lib/apadmi/grout/utils/git_utils.rb
 - lib/apadmi/grout/utils/logger.rb