apache_secure_download 0.2.0 → 0.2.1

data/ChangeLog

@@ -1,5 +1,9 @@
 = Revision history for apache_secure_download
 
+== 0.2.1 [2011-11-08]
+
+* Fixed case with missing parameter
+
 == 0.2.0 [2011-11-08]
 
 * Changed to use one query parameter only (Not backwards compatible!)

data/README

@@ -2,7 +2,7 @@
 
 == VERSION
 
-This documentation refers to apache_secure_download version 0.2.0
+This documentation refers to apache_secure_download version 0.2.1
 
 
 == DESCRIPTION

data/lib/apache/secure_download/version.rb

@@ -6,7 +6,7 @@ module Apache
 
       MAJOR = 0
       MINOR = 2
-      TINY  = 0
+      TINY  = 1
 
       class << self
 

data/lib/apache/secure_download.rb

@@ -53,7 +53,7 @@ module Apache
     # If either condition doesn't hold true, access to the requested resource
     # is denied!
     def check_access(request)
-      timestamp, token = Util.split(request.param(Util::TOKEN_KEY))
+      timestamp, token = Util.split(request.param(Util::TOKEN_KEY) || '')
 
       # Remove timestamp and token from query args
       request.args &&= Util.real_query(request.args)

data/spec/apache/secure_download_spec.rb

@@ -78,6 +78,11 @@ describe Apache::SecureDownload do
       @handler = @class.new(@secret)
     end
 
+    it "should be forbidden without _asd parameter" do
+      mock_request(false)
+      @handler.check_access(@request).should == Apache::FORBIDDEN
+    end
+
     shared_examples "normally" do
 
       it_should_be_allowed "with correct secret"
@@ -237,11 +242,15 @@ describe Apache::SecureDownload do
 
     end
 
-    def mock_request
-      _asd = "#{'%010x' % @timestamp}#{@token}"
+    def mock_request(have_asd = true)
+      if have_asd
+        _asd = "#{'%010x' % @timestamp}#{@token}"
 
-      args = "_asd=#{_asd}"
-      args = "#{@args}&#{args}" if @args
+        args = "_asd=#{_asd}"
+        args = "#{@args}&#{args}" if @args
+      else
+        args = "#{@args}"
+      end
 
       clean_args = @class::Util.real_query(args)
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: apache_secure_download
 version: !ruby/object:Gem::Version 
-  hash: 23
+  hash: 21
   prerelease: 
   segments: 
   - 0
   - 2
-  - 0
-  version: 0.2.0
+  - 1
+  version: 0.2.1
 platform: ruby
 authors: 
 - Jens Wille
@@ -47,7 +47,7 @@ licenses: []
 post_install_message: 
 rdoc_options: 
 - --title
-- apache_secure_download Application documentation (v0.2.0)
+- apache_secure_download Application documentation (v0.2.1)
 - --line-numbers
 - --main
 - README