anycable 0.6.1 → 0.6.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cff0f2d872c485fc15f3046b2fdacbb9cfce2d3e7e312b8f0461dc20f2e52a41
-  data.tar.gz: 586fe6c97d6063512020bde66aaf3a0d8c2dc4a33ca508beb67295a18f121618
+  metadata.gz: 982192dbe84e0576b13033aadf3ead0238e28bf4c30b6dec2d08228cd2093f3c
+  data.tar.gz: 9af924544238340e0c5b171a738b9bec99ebe25c13cc398d279318f6c9cbef12
 SHA512:
-  metadata.gz: f055860a0a5a10eb3954bc6dd5088e66cc948eefe3b853a6fee63ea9ed5e7fafa2827e4fda6f67eeca3efe6efccc2d69eb59f6e8ee11d969be4ef027e73727a8
-  data.tar.gz: c53d21ea1beb3443451839ceb69e318c840b04564e35379adebd65ccfc4f708666c8c78514a805f16e564508aa190ad81a27329334826016f2bc08bc5aa16fde
+  metadata.gz: ba03a684ddce90df929c469deb4b219a494578ab9c203321e9c9f900810f98132eb74d8fc16aa1b79c6042c28bd5b3da2ac83d39bd4e25944127191dc4b2f8b7
+  data.tar.gz: 77a874ad448dff0cca9d8ada4259c8c48ab4fdb87d1df1f3c6bee1dab50f23335f1fc390ee60fb96483a89cc0071700945bdffa73f908745987de2c2e7877c91

data/CHANGELOG.md

@@ -2,6 +2,53 @@
 
 ## master
 
+## 0.6.3 (2019-03-26)
+
+- Relax `redis` gem version requirement. ([@palkan][])
+
+Use the same restriction as Action Cable does (`>= 3`).
+
+## 0.6.2 (2019-03-15)
+
+- Add GRPC service method name and message content to exception notifications ([@sponomarev][])
+
+`Anycable.capture_exception` allows accessing GRPC service method name and message content
+on which an exception was captured. It can be used for exceptions grouping in your tracker and
+providing additional data to investigate a root of a problem.
+
+Example:
+
+```ruby
+AnyCable.capture_exception do |ex, method, message|
+  Honeybadger.notify(ex, component: "any_cable", action: method, params: message)
+end
+```
+
+Usage of a handler proc with just a single argument is preserved for the sake of compatibility.
+
+- Add deprecation warning to default host usage ([@sponomarev][])
+
+Exposing AnyCable publicly is considered to be harmful and planned to be changed
+in future versions.
+
+- Allow running the server as a detachable daemon ([@sponomarev][])
+
+Server is fully managed by the binary itself.
+
+```
+# Start anycable daemon
+$ bundle exec anycabled start
+
+# Pass cli options to anycable through daemon. Separate daemon options and anycable options with `--`
+$ bundle exec anycabled start -- --rpc-host 127.0.0.1:31337
+
+# Stop anycable daemon
+$ bundle exec anycabled stop
+
+# See more anycable daemon options
+$ bundle exec anycabled
+```
+
 ## 0.6.1 (2019-01-05)
 
 - [Fix #63](https://github.com/anycable/anycable-rails/issues/63) Load `anyway_config` after application boot to make sure that all frameworks dependent functionality is loaded. ([@palkan][])
@@ -116,7 +163,7 @@ Minor fixes.
 
 - [#28](https://github.com/anycable/anycable/issues/28) Support arbitrary headers. ([@palkan][])
 
-Previously we hardcoded only "Cookie" header. Now we add all passed headers by WebSocket server to request env. 
+Previously we hardcoded only "Cookie" header. Now we add all passed headers by WebSocket server to request env.
 
 - [#27](https://github.com/anycable/anycable/issues/27) Add `error_msg` to RPC responses. ([@palkan][])
 
@@ -130,7 +177,7 @@ We provide `error_msg` only when request status is `ERROR`.
 
 - [#25](https://github.com/anycable/anycable/issues/25) Improve logging and exceptions handling. ([@palkan][])
 
-Default logger logs to STDOUT with `info` level by default but can be configured to log to file with 
+Default logger logs to STDOUT with `info` level by default but can be configured to log to file with
 any severity.
 
 GRPC logging is turned off by default (can be turned on through `log_grpc` configuration parameter).

data/bin/anycable

@@ -1,6 +1,6 @@
 #!/usr/bin/env ruby
 
-require_relative "../lib/anycable/cli"
+require "anycable/cli"
 
 begin
   cli = AnyCable::CLI.new

data/bin/anycabled

@@ -0,0 +1,30 @@
+#!/usr/bin/env ruby
+
+require "anycable/cli"
+
+begin
+  require "daemons"
+rescue LoadError
+  raise <<~MSG
+    You need to add gem 'daemons' to your Gemfile if you want to use `anycabled`:
+
+      # Gemfile
+      gem "daemons", "~> 1.3", require: false
+  MSG
+end
+
+options = {
+  dir: "tmp/pids",
+  log_output: false
+}
+
+# Preserve current directory. We need it inside the server.
+current_dir = Dir.pwd
+
+# Clean ARGV from daemon command and args
+_, _, args = Daemons::Controller.split_argv(ARGV)
+
+Daemons.run_proc("anycable", options) do
+  Dir.chdir current_dir
+  AnyCable::CLI.new.run(args)
+end

data/lib/anycable/broadcast_adapters/redis.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-gem "redis", ">= 4.0"
+gem "redis", ">= 3"
 
 require "redis"
 require "json"

data/lib/anycable/cli.rb

@@ -23,7 +23,7 @@ module AnyCable
     attr_reader :server, :health_server
 
     # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
-    def run(args)
+    def run(args = {})
       @at_stop = []
 
       extra_options = parse_cli_options!(args)

data/lib/anycable/config.rb

@@ -8,10 +8,12 @@ module AnyCable
   class Config < Anyway::Config
     config_name :anycable
 
+    DefaultHostWrapper = Class.new(String)
+
     attr_config(
       ### gRPC options
-      rpc_host: "[::]:50051",
-      # For defaults see https://github.com/grpc/grpc/blob/master/src/ruby/lib/grpc/generic/rpc_server.rb#L162-L170
+      rpc_host: DefaultHostWrapper.new("[::]:50051"),
+      # For defaults see https://github.com/grpc/grpc/blob/51f0d35509bcdaba572d422c4f856208162022de/src/ruby/lib/grpc/generic/rpc_server.rb#L186-L216
       rpc_pool_size: GRPC::RpcServer::DEFAULT_POOL_SIZE,
       rpc_max_waiting_requests: GRPC::RpcServer::DEFAULT_MAX_WAITING_REQUESTS,
       rpc_poll_period: GRPC::RpcServer::DEFAULT_POLL_PERIOD,

data/lib/anycable/exceptions_handling.rb

@@ -4,15 +4,15 @@ module AnyCable
   module ExceptionsHandling # :nodoc:
     class << self
       def add_handler(block)
-        handlers << block
+        handlers << procify(block)
       end
 
       alias << add_handler
 
-      def notify(exp)
+      def notify(exp, method_name, message)
         handlers.each do |handler|
           begin
-            handler.call(exp)
+            handler.call(exp, method_name, message)
           rescue StandardError => exp
             AnyCable.logger.error "!!! EXCEPTION HANDLER THREW AN ERROR !!!"
             AnyCable.logger.error exp
@@ -23,6 +23,12 @@ module AnyCable
 
       private
 
+      def procify(block)
+        return block unless block.lambda?
+
+        proc { |*args| block.call(*args.take(block.arity)) }
+      end
+
       def handlers
         @handlers ||= []
       end

data/lib/anycable/rpc_handler.rb

@@ -4,15 +4,12 @@ require "anycable/socket"
 require "anycable/rpc/rpc_pb"
 require "anycable/rpc/rpc_services_pb"
 
-require "anycable/handler/capture_exceptions"
-
 # rubocop:disable Metrics/AbcSize
 # rubocop:disable Metrics/MethodLength
+# rubocop:disable Metrics/ClassLength
 module AnyCable
   # RPC service handler
   class RPCHandler < AnyCable::RPC::Service
-    prepend AnyCable::Handler::CaptureExceptions
-
     # Handle connection request from WebSocket server
     def connect(request, _unused_call)
       logger.debug("RPC Connect: #{request.inspect}")
@@ -32,6 +29,13 @@ module AnyCable
           transmissions: socket.transmissions
         )
       end
+    rescue StandardError => exp
+      notify_exception(exp, :connect, request)
+
+      AnyCable::ConnectionResponse.new(
+        status: AnyCable::Status::ERROR,
+        error_msg: exp.message
+      )
     end
 
     def disconnect(request, _unused_call)
@@ -50,6 +54,13 @@ module AnyCable
       else
         AnyCable::DisconnectResponse.new(status: AnyCable::Status::FAILURE)
       end
+    rescue StandardError => exp
+      notify_exception(exp, :disconnect, request)
+
+      AnyCable::DisconnectResponse.new(
+        status: AnyCable::Status::ERROR,
+        error_msg: exp.message
+      )
     end
 
     def command(message, _unused_call)
@@ -75,6 +86,13 @@ module AnyCable
         streams: socket.streams,
         transmissions: socket.transmissions
       )
+    rescue StandardError => exp
+      notify_exception(exp, :command, message)
+
+      AnyCable::CommandResponse.new(
+        status: AnyCable::Status::ERROR,
+        error_msg: exp.message
+      )
     end
 
     private
@@ -114,7 +132,12 @@ module AnyCable
     def factory
       AnyCable.connection_factory
     end
+
+    def notify_exception(exp, method_name, message)
+      AnyCable::ExceptionsHandling.notify(exp, method_name.to_s, message.to_h)
+    end
   end
 end
 # rubocop:enable Metrics/AbcSize
 # rubocop:enable Metrics/MethodLength
+# rubocop:enable Metrics/ClassLength

data/lib/anycable/server.rb

@@ -12,8 +12,8 @@ module AnyCable
   #
   # Basic example:
   #
-  #   # create new server listening on [::]:50051 (default host)
-  #   server = AnyCable::Server.new(host: "[::]:50051")
+  #   # create new server listening on the loopback interface with 50051 port
+  #   server = AnyCable::Server.new(host: "127.0.0.1:50051")
   #
   #   # run gRPC server in bakground
   #   server.start
@@ -25,7 +25,7 @@ module AnyCable
       # rubocop:disable Metrics/AbcSize, Metrics/MethodLength
       def start(**options)
         warn <<~DEPRECATION
-          Using AnyCable::Server.start is deprecated!
+          DEPRECATION WARNING: Using AnyCable::Server.start is deprecated!
           Please, use anycable CLI instead.
 
           See https://docs.anycable.io/#upgrade_to_0_6_0
@@ -63,11 +63,9 @@ module AnyCable
       # rubocop:enable Metrics/AbcSize, Metrics/MethodLength
     end
 
-    DEFAULT_HOST = "0.0.0.0:50051"
-
     attr_reader :grpc_server, :host
 
-    def initialize(host: DEFAULT_HOST, logger: AnyCable.logger, **options)
+    def initialize(host:, logger: AnyCable.logger, **options)
       @logger = logger
       @host = host
       @grpc_server = build_server(options)
@@ -80,6 +78,8 @@ module AnyCable
 
       raise "Cannot re-start stopped server" if stopped?
 
+      check_default_host
+
       logger.info "RPC server is starting..."
 
       @start_thread = Thread.new { grpc_server.run }
@@ -132,5 +132,21 @@ module AnyCable
       )
       health_checker
     end
+
+    def check_default_host
+      return unless host.is_a?(Anycable::Config::DefaultHostWrapper)
+
+      warn <<~DEPRECATION
+        DEPRECATION WARNING: You're using default rpc_host configuration which starts AnyCable RPC
+        server on all available interfaces including external IPv4 and IPv6.
+        This is about to be changed to loopback interface only in future versions.
+
+        Please, consider switching to the loopback interface or set "[::]:50051"
+        explicitly in your configuration, if you want to continue with the current
+        behavior and supress this message.
+
+        See https://docs.anycable.io/#/configuration
+      DEPRECATION
+    end
   end
 end

data/lib/anycable/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AnyCable
-  VERSION = "0.6.1"
+  VERSION = "0.6.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: anycable
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.6.3
 platform: ruby
 authors:
 - palkan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-06 00:00:00.000000000 Z
+date: 2019-03-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: anyway_config
@@ -114,14 +114,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.60.0
+        version: 0.65.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.60.0
+        version: 0.65.0
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -155,70 +155,23 @@ email:
 - dementiev.vm@gmail.com
 executables:
 - anycable
+- anycabled
 extensions: []
 extra_rdoc_files: []
 files:
-- ".github/ISSUE_TEMPLATE.md"
-- ".github/PULL_REQUEST_TEMPLATE.md"
-- ".gitignore"
-- ".hound.yml"
-- ".rubocop.yml"
-- ".travis.yml"
 - CHANGELOG.md
-- Gemfile
 - MIT-LICENSE
-- Makefile
-- PITCHME.md
-- PITCHME.yaml
 - README.md
-- Rakefile
-- anycable.gemspec
-- assets/Memory3.png
-- assets/Memory5.png
-- assets/RTT3.png
-- assets/RTT5.png
-- assets/Scheme1.png
-- assets/Scheme2.png
-- assets/cpu_chart.gif
-- assets/cpu_chart2.gif
-- assets/evlms.png
-- benchmarks/.gitignore
-- benchmarks/2017-02-12.md
-- benchmarks/2018-03-04.md
-- benchmarks/2018-05-27-rpc-bench.md
-- benchmarks/2018-10-27.md
-- benchmarks/HowTo.md
-- benchmarks/ansible.cfg
-- benchmarks/assets/2018-10-27-action-cable-rss.png
-- benchmarks/assets/2018-10-27-action-cable-rtt.png
-- benchmarks/assets/2018-10-27-anycable-rss.png
-- benchmarks/assets/2018-10-27-anycable-rtt.png
-- benchmarks/assets/2018-10-27-async-rss.png
-- benchmarks/assets/2018-10-27-async-rtt.png
-- benchmarks/assets/2018-10-27-falcon-cable-rss.png
-- benchmarks/assets/2018-10-27-falcon-cable-rtt.png
-- benchmarks/assets/2018-10-27-iodine-cable-rss.png
-- benchmarks/assets/2018-10-27-iodine-cable-rtt.png
-- benchmarks/assets/2018-10-27-plezi-rss.png
-- benchmarks/assets/2018-10-27-plezi-rtt.png
-- benchmarks/bench.png
-- benchmarks/benchmark.yml
-- benchmarks/hosts
-- benchmarks/rtt_plot.py
-- benchmarks/rtt_plot_test.py
-- benchmarks/servers.yml
 - bin/anycable
+- bin/anycabled
 - bin/console
 - bin/setup
-- circle.yml
-- etc/bug_report_template.rb
 - lib/anycable.rb
 - lib/anycable/broadcast_adapters.rb
 - lib/anycable/broadcast_adapters/redis.rb
 - lib/anycable/cli.rb
 - lib/anycable/config.rb
 - lib/anycable/exceptions_handling.rb
-- lib/anycable/handler/capture_exceptions.rb
 - lib/anycable/health_server.rb
 - lib/anycable/middleware.rb
 - lib/anycable/middleware_chain.rb
@@ -228,7 +181,6 @@ files:
 - lib/anycable/server.rb
 - lib/anycable/socket.rb
 - lib/anycable/version.rb
-- protos/rpc.proto
 homepage: http://github.com/anycable/anycable
 licenses:
 - MIT
@@ -248,8 +200,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.2
 signing_key: 
 specification_version: 4
 summary: AnyCable is a polyglot replacement for ActionCable-compatible servers