anycable-rails 1.0.0.rc1 → 1.0.0.rc2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 36b6e47a498bfc2d1156e4635a5c30f60258c925142c59ad837c1b6708f1ff73
-  data.tar.gz: f27c94856df0db9d178537e8ac75598f8a355b338e725a80a5cb06a6e0ac610c
+  metadata.gz: e0de4d95da59574a14f3f56219154cf3e12513a74e677520acf0cffbbf566e49
+  data.tar.gz: c6a4e9b87c3c59aac495663f8acc9f3150a8de5f43d5ab55d19c265039ba2af1
 SHA512:
-  metadata.gz: 28b72e3f6a9950d3a95eb8d4f1c6a59f24a704ff63ac50384ffb2d22aa97c9f6b6e1f0c882a89cc6a0fd9ac22ea553a381514d56885f6f1cce41e7146153ab24
-  data.tar.gz: ac7c402d2b57a332ced9372a4546709d6b41a0fb082c823d292b87c8b11e4bf741047cbc10258f68acd228712f0ca974b6723246bd3ddc689920f656b1488974
+  metadata.gz: 93f85efbfa20cffe71b3b52115b98321158577a36439b9875e6bbfb18ecee32c44fd31376a05f8883b8eff7d8b06b4d2d5abf762f86f6765248e3051869f3b17
+  data.tar.gz: 2ca2cd646321b0ed567af383847e4ae5f5cab116be0a7c410ea18d91f43378c024c47e3002c0aa70ddd0970a4e2bad50fd173c0b1fdf9088f229bad3ea53a05d

data/CHANGELOG.md

@@ -1,5 +1,18 @@
 # Change log
 
+## master
+
+## 1.0.0.rc2 (2020-06-16)
+
+- Fix connection identifiers deserialization regression. ([@palkan][])
+
+Using non-strings or non-GlobalId-encoded objects was broken.
+
+- Improve `anycable:setup` generator. ([@palkan][])
+
+Update Docker snippet, do not enable persistent sessions automatically,
+fix setting `config.action_cable.url` in environment configuration.
+
 ## 1.0.0.rc1 (2020-06-10)
 
 - Add `state_attr_accessor` for channels. ([@palkan][])

data/lib/anycable/rails.rb

@@ -35,7 +35,7 @@ module AnyCable
       # If the resulting object is a Hash, make it indifferent
       def deserialize(str, json: false)
         str.yield_self do |val|
-          next unless val.is_a?(String)
+          next val unless val.is_a?(String)
 
           gval = GlobalID::Locator.locate(val)
           return gval if gval

data/lib/anycable/rails/actioncable/connection/persistent_session.rb

@@ -21,7 +21,7 @@ module ActionCable
       end
 
       def commit_session!
-        return unless request_loaded? && request.session.loaded?
+        return unless request_loaded? && request.session.respond_to?(:loaded?) && request.session.loaded?
 
         socket.session = request.session.to_json
       end

data/lib/anycable/rails/version.rb

@@ -2,6 +2,6 @@
 
 module AnyCable
   module Rails
-    VERSION = "1.0.0.rc1"
+    VERSION = "1.0.0.rc2"
   end
 end

data/lib/generators/anycable/setup/setup_generator.rb

@@ -49,14 +49,18 @@ module AnyCableRailsGenerators
       environment(nil, env: :development) do
         <<~SNIPPET
           # Specify AnyCable WebSocket server URL to use by JS client
-          config.action_cable.url = ENV.fetch("CABLE_URL", "ws://localhost:8080/cable") if AnyCable::Rails.enabled?
+          config.after_initialize do
+            config.action_cable.url = ActionCable.server.config.url = ENV.fetch("CABLE_URL", "ws://localhost:8080/cable") if AnyCable::Rails.enabled?
+          end
         SNIPPET
       end
 
       environment(nil, env: :production) do
         <<~SNIPPET
           # Specify AnyCable WebSocket server URL to use by JS client
-          config.action_cable.url = ENV.fetch("CABLE_URL") if AnyCable::Rails.enabled?
+          config.after_initialize do
+            config.action_cable.url = ActionCable.server.config.url = ENV.fetch("CABLE_URL") if AnyCable::Rails.enabled?
+          end
         SNIPPET
       end
 
@@ -111,6 +115,12 @@ module AnyCableRailsGenerators
       say_status :info, "✅ config/initializers/anycable.rb with Devise configuration has been added"
     end
 
+    def stimulus_reflex
+      return unless stimulus_reflex?
+
+      say_status :help, "⚠️  Please, check out the documentation on using AnyCable with Stimulus Reflex: https://docs.anycable.io/v1/#/ruby/stimulus_reflex"
+    end
+
     def rubocop_compatibility
       return unless rubocop?
 
@@ -155,14 +165,16 @@ module AnyCableRailsGenerators
       say <<~YML
         ─────────────────────────────────────────
         ws:
-          image: anycable/anycable-go:1.0.0.preview1
+          image: anycable/anycable-go:1.0
           ports:
             - '8080:8080'
           environment:
+            ANYCABLE_HOST: "0.0.0.0"
             ANYCABLE_REDIS_URL: redis://redis:6379/0
             ANYCABLE_RPC_HOST: anycable:50051
+            ANYCABLE_DEBUG: 1
           depends_on:
-            - anycable-rpc
+            - anycable
             - redis
 
         anycable:

data/lib/generators/anycable/setup/templates/config/anycable.yml.tt

@@ -12,8 +12,8 @@
 default: &default
   # Turn on/off access logs ("Started..." and "Finished...")
   access_logs_disabled: false
-  # Persist "dirty" session between RPC calls (might be required for StimulusReflex apps)
-  persistent_session_enabled: <%= stimulus_reflex? %>
+  # Persist "dirty" session between RPC calls (might be required for apps using stimulus_reflex <3.0)
+  # persistent_session_enabled: true
   # This is the host and the port to run AnyCable RPC server on.
   # You must configure your WebSocket server to connect to it, e.g.:
   #   $ anycable-go --rpc-host="<rpc hostname>:50051"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: anycable-rails
 version: !ruby/object:Gem::Version
-  version: 1.0.0.rc1
+  version: 1.0.0.rc2
 platform: ruby
 authors:
 - palkan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-06-10 00:00:00.000000000 Z
+date: 2020-06-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: anycable